From 1b7cb4179dcb3edd0b2e9e86403f0b40270c145e Mon Sep 17 00:00:00 2001 From: The412Banner <205237651+The412Banner@users.noreply.github.com> Date: Sat, 10 Oct 2026 14:03:04 -0400 Subject: [PATCH] Windows components: leave out WebView2, which only Microsoft's installer can lay out (#532) Its files sit in a container no extractor opens and may not be hosted, so a recording cannot source them; installing it means running the installer in the prefix, which no runtime here does. With it gone the waiting section is empty. --- .../java/com/droiddeck/launcher/session/WinComponents.kt | 6 ++++-- .../droiddeck/launcher/session/WinComponentsSupportTest.kt | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt b/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt index 9151c95263..baaae5b75e 100644 --- a/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt +++ b/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt @@ -120,9 +120,11 @@ object WinComponents { /** * Catalog entries nothing here can use: the IE8 security update patches a browser no prefix - * has, and the OpenAL setup program is a twin of oalinst_dll, which copies the same DLLs. + * has; the OpenAL setup program is a twin of oalinst_dll, which copies the same DLLs; and + * WebView2 can only be installed by running Microsoft's installer in the prefix (its files + * sit in a container nothing opens and may not be hosted), which no runtime here does. */ - private val POINTLESS = setOf("ie8_kb2936068", "oalinst") + private val POINTLESS = setOf("ie8_kb2936068", "oalinst", "webview2") private fun protonProvides(name: String): Boolean = name in PROTON_PROVIDES || name in POINTLESS || name.startsWith("mono-") diff --git a/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt b/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt index 9ec5f12d82..d086ea6000 100644 --- a/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt +++ b/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt @@ -97,5 +97,6 @@ class WinComponentsSupportTest { assertEquals(Support.UNSUPPORTED, support(component("VulkanRT", step("install_exe", "url" to "$base/VulkanRT.exe")))) assertEquals(Support.UNSUPPORTED, support(component("ie8_kb2936068", step("install_exe", "url" to "$base/ie8_kb2936068.exe")))) assertEquals(Support.UNSUPPORTED, support(component("oalinst", step("install_exe", "url" to "$base/oalinst.exe")))) + assertEquals(Support.UNSUPPORTED, support(component("webview2", step("install_exe", "url" to "$base/webview2.exe")))) } }