mirror of
https://github.com/Droid-Deck/DroidDeck.git
synced 2026-11-19 04:46:08 +00:00
fix: file manager copy/move keeps symlinks (#1027)
This commit is contained in:
1 parent
3149567328
commit
25938cc249
3 files changed
+115
-4
No files matched your search
@@ -0,0 +1,85 @@
|
||||
package com.droiddeck.launcher.files
|
||||
|
||||
import java.io.File
|
||||
import java.nio.file.Files
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Assume.assumeTrue
|
||||
import org.junit.Rule
|
||||
import org.junit.Test
|
||||
import org.junit.rules.TemporaryFolder
|
||||
import org.junit.runner.RunWith
|
||||
import org.robolectric.RobolectricTestRunner
|
||||
|
||||
@RunWith(RobolectricTestRunner::class)
|
||||
class FileOpsLinksTest {
|
||||
@get:Rule val tmp = TemporaryFolder()
|
||||
|
||||
private fun link(at: File, target: String): Boolean =
|
||||
runCatching { Files.createSymbolicLink(at.toPath(), File(target).toPath()) }.isSuccess
|
||||
|
||||
@Test fun aMovedFolderKeepsItsLinks() {
|
||||
val src = tmp.newFolder("game")
|
||||
File(src, "data.bin").writeText("x")
|
||||
assumeTrue("symlinks unavailable here", link(File(src, "lib.so"), "data.bin"))
|
||||
val dst = File(tmp.root, "other/game")
|
||||
File(dst, "keep").mkdirs()
|
||||
assertTrue(FileOps.moveWithProgress(src, dst, null))
|
||||
assertFalse(src.exists())
|
||||
assertTrue(Files.isSymbolicLink(File(dst, "lib.so").toPath()))
|
||||
assertEquals("data.bin", Files.readSymbolicLink(File(dst, "lib.so").toPath()).toString())
|
||||
}
|
||||
|
||||
@Test fun aCopiedLinkPointsWhereTheOriginalDoes() {
|
||||
val src = tmp.newFolder("a")
|
||||
assumeTrue("symlinks unavailable here", link(File(src, "l"), "/nowhere/target"))
|
||||
val dst = File(tmp.root, "b")
|
||||
assertTrue(FileOps.copyWithProgress(src, dst, null))
|
||||
assertTrue(Files.isSymbolicLink(File(src, "l").toPath()))
|
||||
assertTrue(Files.isSymbolicLink(File(dst, "l").toPath()))
|
||||
}
|
||||
|
||||
@Test fun copyingALinkPreservesAnUnrelatedStagingName() {
|
||||
val src = File(tmp.root, "source")
|
||||
assumeTrue("symlinks unavailable here", link(src, "missing-target"))
|
||||
val dst = File(tmp.root, "dest")
|
||||
dst.writeText("old destination")
|
||||
val sibling = File(tmp.root, ".dest.link-tmp")
|
||||
sibling.writeText("unrelated user data")
|
||||
|
||||
assertTrue(FileOps.copyWithProgress(src, dst, null))
|
||||
assertEquals("unrelated user data", sibling.readText())
|
||||
assertEquals("missing-target", Files.readSymbolicLink(dst.toPath()).toString())
|
||||
assertEquals(setOf("source", "dest", ".dest.link-tmp"), tmp.root.list()!!.toSet())
|
||||
}
|
||||
|
||||
@Test fun anUnrelatedStagingDirectoryDoesNotPreventCopyingALink() {
|
||||
val src = File(tmp.root, "source")
|
||||
assumeTrue("symlinks unavailable here", link(src, "missing-target"))
|
||||
val sibling = tmp.newFolder(".dest.link-tmp")
|
||||
File(sibling, "keep").writeText("unrelated user data")
|
||||
|
||||
assertTrue(FileOps.copyWithProgress(src, File(tmp.root, "dest"), null))
|
||||
assertEquals("unrelated user data", File(sibling, "keep").readText())
|
||||
}
|
||||
|
||||
@Test fun aLongDestinationNameDoesNotOverflowTheStagingName() {
|
||||
val src = File(tmp.root, "source")
|
||||
assumeTrue("symlinks unavailable here", link(src, "missing-target"))
|
||||
val dst = File(tmp.root, "d".repeat(240))
|
||||
assertTrue(FileOps.copyWithProgress(src, dst, null))
|
||||
assertEquals("missing-target", Files.readSymbolicLink(dst.toPath()).toString())
|
||||
}
|
||||
|
||||
@Test fun aLinkThatCannotReplaceTheDestinationLeavesItAlone() {
|
||||
val src = tmp.newFolder("c")
|
||||
assumeTrue("symlinks unavailable here", link(File(src, "l"), "x"))
|
||||
val dst = File(tmp.root, "d")
|
||||
File(dst, "l").mkdirs()
|
||||
File(dst, "l/keep.txt").writeText("kept")
|
||||
assertFalse(FileOps.copyWithProgress(File(src, "l"), File(dst, "l"), null))
|
||||
assertEquals("kept", File(dst, "l/keep.txt").readText())
|
||||
assertFalse(File(dst, ".l.link-tmp").exists())
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user