fix: an unproven update-channel guess no longer moves stable users to Nightly (#1067)

This commit is contained in:
Kurt Himebauch authored and GitHub committed 2026-10-27 22:27:20 -04:00
commit 3716c8acdf
2 files changed
+90 -11

No files matched your search

@@ -8,6 +8,7 @@ import com.droiddeck.launcher.update.AppUpdates.Offer
import com.droiddeck.launcher.update.AppUpdates.PreviewChange
import com.droiddeck.launcher.update.AppUpdates.PreviewHistoryKind
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertNull
import org.json.JSONArray
@@ -285,4 +286,69 @@ class AppUpdatesTest {
} catch (_: IOException) {
}
}
@Test fun anOlderStableIsGuessedStableAndSaved() {
val g = AppUpdates.guessFollow(catalog, me("eeeeeee999", version = "0.1.9"))
assertEquals(AppUpdates.Channel.STABLE, g.follow.channel)
assertTrue(g.certain)
}
@Test fun anOlderBuildInPreviewHistoryKeepsStableAsAnUncertainGuess() {
val withHistory = AppUpdates.Catalog(stable, release("1111111"), emptyList(), 0L, recentPreview)
val g = AppUpdates.guessFollow(withHistory, me("2".repeat(40), version = "0.1.0"))
assertEquals(Channel.STABLE, g.follow.channel)
assertFalse(g.certain)
}
@Test fun anOlderCataloguedBuildDoesNotPersistAGuessAndExplicitChoicesStillWin() {
val context = org.robolectric.RuntimeEnvironment.getApplication()
val preferences = context.getSharedPreferences("app_updates", android.content.Context.MODE_PRIVATE)
preferences.edit().clear().commit()
try {
val installed = me("2".repeat(40), version = "0.1.0")
val newerStable = release("0".repeat(40), version = "9999.0.0")
val currentPreview = release(installed.commit)
val newerCatalog = AppUpdates.Catalog(newerStable, currentPreview, emptyList(), 0L)
assertEquals(Channel.STABLE, AppUpdates.follow(context, newerCatalog, installed).channel)
assertNull(preferences.getString("channel", null))
assertEquals(Channel.STABLE, AppUpdates.follow(context, null, installed).channel)
assertNull(preferences.getString("channel", null))
for (choice in listOf(Follow(Channel.STABLE), Follow(Channel.NIGHTLY), Follow(Channel.TEST, 93))) {
AppUpdates.setFollow(context, choice)
val actual = AppUpdates.follow(context, newerCatalog, installed)
assertEquals(choice.channel, actual.channel)
assertEquals(choice.pr, actual.pr)
}
} finally {
preferences.edit().clear().commit()
}
}
@Test fun runningTheCatalogStableIsCertainStable() {
val g = AppUpdates.guessFollow(catalog, me(stable.commit))
assertEquals(AppUpdates.Channel.STABLE, g.follow.channel)
assertTrue(g.certain)
}
@Test fun aPublishedPreviewPastStableIsGuessedNightlyWithoutSaving() {
val withHistory = AppUpdates.Catalog(stable, release("1111111"), emptyList(), 0L, recentPreview)
val g = AppUpdates.guessFollow(withHistory, me("2".repeat(40), version = "0.3.0"))
assertEquals(AppUpdates.Channel.NIGHTLY, g.follow.channel)
assertFalse(g.certain)
}
@Test fun anUncataloguedNewerBuildStaysStableForNow() {
val g = AppUpdates.guessFollow(catalog, me("9".repeat(40), version = "0.3.0"))
assertEquals(AppUpdates.Channel.STABLE, g.follow.channel)
assertFalse(g.certain)
val offline = AppUpdates.guessFollow(null, me("9".repeat(40), version = "0.3.0"))
assertEquals(AppUpdates.Channel.STABLE, offline.follow.channel)
assertFalse(offline.certain)
}
@Test fun aPullRequestBuildIsCertainTest() {
val g = AppUpdates.guessFollow(catalog, me("ccccccc2222222222222222222222222222222", pr = 93))
assertEquals(AppUpdates.Channel.TEST, g.follow.channel)
assertTrue(g.certain)
}
}