From 37535a3d388bffecd1602f393532c52e4565d998 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Resul=20=C3=96v=C3=BCr?= <92828257+ovurrsl@users.noreply.github.com> Date: Thu, 22 Oct 2026 06:52:35 +0300 Subject: [PATCH] fix: a full disk no longer crashes the app during cover art fetches (#1030) --- .../main/java/com/droiddeck/launcher/frontend/AddedGameArt.kt | 4 ++-- app/src/main/java/com/droiddeck/launcher/frontend/CoverArt.kt | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/droiddeck/launcher/frontend/AddedGameArt.kt b/app/src/main/java/com/droiddeck/launcher/frontend/AddedGameArt.kt index b3bdeb9684..62d04d2477 100644 --- a/app/src/main/java/com/droiddeck/launcher/frontend/AddedGameArt.kt +++ b/app/src/main/java/com/droiddeck/launcher/frontend/AddedGameArt.kt @@ -323,8 +323,8 @@ object AddedGameArt { if (dst.isFile) continue val bytes = get("$CDN$id/$remote") ?: steamAssetUrl(id, remote)?.let { get(it) } ?: continue val tmp = File(cache, "$localName.tmp") - tmp.writeBytes(bytes) - if (tmp.renameTo(dst)) { got = true; File(cache, "$localName.src").writeText(STEAM) } + if (runCatching { tmp.writeBytes(bytes) }.isFailure) { tmp.delete(); continue } + if (tmp.renameTo(dst)) { got = true; runCatching { File(cache, "$localName.src").writeText(STEAM) } } } return got } diff --git a/app/src/main/java/com/droiddeck/launcher/frontend/CoverArt.kt b/app/src/main/java/com/droiddeck/launcher/frontend/CoverArt.kt index 5f30796e4c..db982a0f12 100644 --- a/app/src/main/java/com/droiddeck/launcher/frontend/CoverArt.kt +++ b/app/src/main/java/com/droiddeck/launcher/frontend/CoverArt.kt @@ -63,7 +63,8 @@ object CoverArt { missFile(context, rom).delete() found = true } else { - missFile(context, rom).apply { parentFile?.mkdirs(); writeText(url ?: "") } + runCatching { missFile(context, rom).apply { parentFile?.mkdirs(); writeText(url ?: "") } } + .onFailure { Log.w(TAG, "${rom.name}: miss marker not written: $it") } } } return found