From 3ea35abe83c168a902463d847953061fa9b9d973 Mon Sep 17 00:00:00 2001 From: The412Banner <205237651+The412Banner@users.noreply.github.com> Date: Sat, 10 Oct 2026 14:54:28 -0400 Subject: [PATCH] Windows components: a recommended component is listed once, not again under All (#537) The full list left out only the 'installed for this game' rows, never the recommendations, so every recommended component appeared twice (DirectX 9 on Final Fantasy Resonance, both rows switched on). --- .../java/com/droiddeck/launcher/ui/WinComponentsEditor.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/droiddeck/launcher/ui/WinComponentsEditor.kt b/app/src/main/java/com/droiddeck/launcher/ui/WinComponentsEditor.kt index 25e9539277..1a838e8e79 100644 --- a/app/src/main/java/com/droiddeck/launcher/ui/WinComponentsEditor.kt +++ b/app/src/main/java/com/droiddeck/launcher/ui/WinComponentsEditor.kt @@ -163,11 +163,12 @@ internal fun WinComponentsDialog( val extra = (installed + picks).filter { all?.containsKey(it) != true } // What is turned on for this game gets its own section under the recommendations, which stay // where they are; the rest of the list is everything else, so a component turned off goes back - // to its place in the alphabet. + // to its place in the alphabet. A component is listed once: the recommendations are left out + // of the full list too. val recSet = recIds.map { installable(it.componentName, all.orEmpty()) }.toSet() val active = picks.filter { it !in recSet && (all?.containsKey(it) == true || it in installed) }.distinct() .sortedBy { WinComponentNames.of(it).lowercase() } - val list = (ready + extra).distinct().filter { it !in active }.sortedBy { WinComponentNames.of(it).lowercase() } + val list = (ready + extra).distinct().filter { it !in active && it !in recSet }.sortedBy { WinComponentNames.of(it).lowercase() } val waiting = all.orEmpty().values.filter { WinComponents.support(it, all.orEmpty()) == Support.NEEDS_INSTALLER } .map { it.name }.sortedBy { WinComponentNames.of(it).lowercase() } val hasRec = all != null && recIds.any { supportOf(installable(it.componentName, all)) == Support.READY }