Add controller and desktop quality-of-life options (#194)

This commit is contained in:
Kurt Himebauch authored and GitHub committed 2026-10-04 00:56:09 -04:00
1 parent 336b8851f7
commit 6f1fb462ed
22 files changed
+536 -19

No files matched your search

@@ -0,0 +1,60 @@
#!/usr/bin/env python3
"""Expose the selected secondary library in PCManFM's Places sidebar."""
import os
from pathlib import Path
import sys
import tempfile
LIBRARY = Path("/mnt/droiddeck-sd")
URI = "file:///mnt/droiddeck-sd"
def bookmarks_file(home, config):
# libfm-qt reads GTK3 bookmarks first, falling back to the legacy file when empty.
current = config / "gtk-3.0/bookmarks"
legacy = home / ".gtk-bookmarks"
if current.is_file() and current.read_text(errors="surrogateescape").strip():
return current
return legacy if legacy.is_file() else current
def update_bookmark(path, label):
original = path.read_text(errors="surrogateescape") if path.is_file() else ""
lines = [line for line in original.splitlines(keepends=True)
if line.strip().split(" ", 1)[0] != URI]
content = "".join(lines)
if label is not None:
label = " ".join(label.split()) or "Secondary library"
if content and not content.endswith("\n"):
content += "\n"
content += URI + " " + label + "\n"
if content == original:
return
path.parent.mkdir(parents=True, exist_ok=True)
temporary = None
try:
with tempfile.NamedTemporaryFile(mode="w", encoding="utf-8", errors="surrogateescape",
dir=path.parent, delete=False) as stream:
temporary = stream.name
stream.write(content)
os.replace(temporary, path)
finally:
if temporary and os.path.exists(temporary):
os.unlink(temporary)
def main():
home = Path.home()
config = Path(os.environ.get("XDG_CONFIG_HOME") or home / ".config")
label = os.environ.get("BL_LIBRARY_LABEL")
# An unbound mount-point directory may remain from a previous session.
available = bool(label) and (LIBRARY / "steamapps").is_dir()
update_bookmark(bookmarks_file(home, config), label if available else None)
if __name__ == "__main__":
try:
main()
except OSError as error:
print("== desktop library bookmark: " + str(error), file=sys.stderr)
@@ -92,6 +92,9 @@ export XDG_DATA_HOME=${XDG_DATA_HOME:-$HOME/.local/share}
export XDG_CONFIG_HOME=${XDG_CONFIG_HOME:-$HOME/.config}
export XDG_CACHE_HOME=${XDG_CACHE_HOME:-$HOME/.cache}
mkdir -p "$XDG_DATA_HOME" "$XDG_CONFIG_HOME" "$XDG_CACHE_HOME"
if [ "$mode" = lxqt ] || [ "$mode" = desktop ]; then
/usr/local/bin/bannerlator-desktop-bookmarks || true
fi
# Flatpak (the store's apps): its sandboxes through the app instead of bubblewrap, which needs the
# user namespaces Android keeps from apps, and its apps' menu entries and icons on the desktop.
export FLATPAK_BWRAP=/usr/local/bin/bannerlator-bwrap
+69
View File
@@ -0,0 +1,69 @@
import os
from pathlib import Path
import runpy
import tempfile
import unittest
from unittest.mock import patch
HELPER = Path(__file__).resolve().parents[1] / "linuxfs/overlay/usr/local/bin/bannerlator-desktop-bookmarks"
MODULE = runpy.run_path(str(HELPER))
class DesktopBookmarksTest(unittest.TestCase):
def setUp(self):
temporary = tempfile.TemporaryDirectory()
self.addCleanup(temporary.cleanup)
self.home = Path(temporary.name)
self.config = self.home / ".config"
self.bookmarks = self.config / "gtk-3.0/bookmarks"
def test_add_and_update_preserve_user_bookmarks_without_duplicates(self):
self.bookmarks.parent.mkdir(parents=True)
self.bookmarks.write_text("file:///root/Documents My Documents\nfile:///root/Downloads Downloads")
MODULE["update_bookmark"](self.bookmarks, "SD Card")
expected = "file:///root/Documents My Documents\nfile:///root/Downloads Downloads\nfile:///mnt/droiddeck-sd SD Card\n"
self.assertEqual(self.bookmarks.read_text(), expected)
before = self.bookmarks.stat().st_mtime_ns
MODULE["update_bookmark"](self.bookmarks, "SD Card")
self.assertEqual(self.bookmarks.stat().st_mtime_ns, before)
MODULE["update_bookmark"](self.bookmarks, "Games\nfile:///unexpected Injected")
self.assertEqual(len(self.bookmarks.read_text().splitlines()), 3)
self.assertIn("file:///mnt/droiddeck-sd Games file:///unexpected Injected\n", self.bookmarks.read_text())
def test_removing_unavailable_library_keeps_personal_bookmarks(self):
MODULE["update_bookmark"](self.bookmarks, "SD Card")
with self.bookmarks.open("a") as stream:
stream.write("file:///root/Documents My Documents\n")
MODULE["update_bookmark"](self.bookmarks, None)
self.assertEqual(self.bookmarks.read_text(), "file:///root/Documents My Documents\n")
absent = self.home / "missing/bookmarks"
MODULE["update_bookmark"](absent, None)
self.assertFalse(absent.exists())
def test_file_selection_matches_libfm_legacy_fallback(self):
legacy = self.home / ".gtk-bookmarks"
legacy.write_text("file:///root/Documents My Documents\n")
self.assertEqual(MODULE["bookmarks_file"](self.home, self.config), legacy)
self.bookmarks.parent.mkdir(parents=True)
self.bookmarks.touch()
self.assertEqual(MODULE["bookmarks_file"](self.home, self.config), legacy)
self.bookmarks.write_text("file:///root/Downloads Downloads\n")
self.assertEqual(MODULE["bookmarks_file"](self.home, self.config), self.bookmarks)
def test_main_requires_selected_library_and_usable_bind(self):
library = self.home / "library"
library.mkdir()
with patch.object(Path, "home", return_value=self.home), patch.dict(os.environ, {"XDG_CONFIG_HOME": str(self.config), "BL_LIBRARY_LABEL": "SD Card"}), patch.dict(MODULE["main"].__globals__, {"LIBRARY": library}):
MODULE["main"]()
self.assertFalse(self.bookmarks.exists())
(library / "steamapps").mkdir()
MODULE["main"]()
self.assertEqual(self.bookmarks.read_text(), "file:///mnt/droiddeck-sd SD Card\n")
del os.environ["BL_LIBRARY_LABEL"]
MODULE["main"]()
self.assertEqual(self.bookmarks.read_text(), "")
if __name__ == "__main__":
unittest.main()