feat: downloads resume where they stopped, and fall back to another source (#623)

This commit is contained in:
kingokksa authored and GitHub committed 2026-10-16 13:45:35 -04:00
1 parent 5e57d78b5d
commit 7c90879b39
53 files changed
+784 -221

No files matched your search

@@ -4,6 +4,7 @@ import java.io.File
import java.net.ServerSocket
import java.net.Socket
import java.nio.file.Files
import java.security.MessageDigest
import java.util.concurrent.CopyOnWriteArrayList
import org.junit.After
import org.junit.Assert.assertArrayEquals
@@ -26,6 +27,8 @@ class DownloaderResumeTest {
private lateinit var dir: File
private lateinit var thread: Thread
@Volatile private var misbehave = false
@Volatile private var etag: String? = "\"v1\""
@Volatile private var corrupt = false
@Before fun setUp() {
dir = Files.createTempDirectory("downloader-resume").toFile()
@@ -50,6 +53,7 @@ class DownloaderResumeTest {
private fun handle(socket: Socket) = socket.use {
val input = it.getInputStream().bufferedReader(Charsets.ISO_8859_1)
val path = input.readLine() ?: return@use
var range: String? = null
while (true) {
val line = input.readLine() ?: break
@@ -58,24 +62,26 @@ class DownloaderResumeTest {
}
requests.add(range)
val out = it.getOutputStream()
val validator = etag?.let { tag -> "ETag: $tag\r\n" } ?: ""
val content = if (corrupt && "/corrupt" in path) ByteArray(data.size) else data
val from = range?.removePrefix("bytes=")?.substringBefore('-')?.toIntOrNull()
if (misbehave) {
// answers a Range request with a 206 that starts at 0, and serves plain requests whole
val start = if (from == null) "200 OK" else "206 Partial Content"
val extra = if (from == null) "" else "Content-Range: bytes 0-${data.size - 1}/${data.size}\r\n"
out.write("HTTP/1.1 $start\r\n${extra}Content-Length: ${data.size}\r\nConnection: close\r\n\r\n".toByteArray())
out.write(data)
out.write("HTTP/1.1 $start\r\n${extra}${validator}Content-Length: ${data.size}\r\nConnection: close\r\n\r\n".toByteArray())
out.write(content)
out.flush()
} else if (from == null) {
out.write("HTTP/1.1 200 OK\r\nContent-Length: ${data.size}\r\nConnection: close\r\n\r\n".toByteArray())
out.write(data, 0, cutAt)
out.write("HTTP/1.1 200 OK\r\n${validator}Content-Length: ${data.size}\r\nConnection: close\r\n\r\n".toByteArray())
out.write(content, 0, cutAt)
out.flush()
// hang up with most of the promised body still unsent
} else {
val rest = data.size - from
out.write(("HTTP/1.1 206 Partial Content\r\nContent-Range: bytes $from-${data.size - 1}/${data.size}\r\n" +
"Content-Length: $rest\r\nConnection: close\r\n\r\n").toByteArray())
out.write(data, from, rest)
"${validator}Content-Length: $rest\r\nConnection: close\r\n\r\n").toByteArray())
out.write(content, from, rest)
out.flush()
}
}
@@ -108,4 +114,57 @@ class DownloaderResumeTest {
assertArrayEquals("the file must not be the kept bytes plus a misplaced body", data, target.readBytes())
assertEquals(listOf<String?>(null, "bytes=$kept-", null), requests.toList())
}
@Test fun legacyPartialWithoutValidatorRestartsAtZero() {
val url = "http://127.0.0.1:${server.localPort}/runtime.tar.zst"
val target = File(dir, "runtime.tar.zst")
target.writeBytes(ByteArray(cutAt) { 9 })
misbehave = true
assertTrue(Downloader.downloadFile(url, target, true, null))
assertArrayEquals(data, target.readBytes())
assertEquals(listOf<String?>(null), requests.toList())
}
@Test fun missingStrongETagPreventsUnsafeResume() {
val url = "http://127.0.0.1:${server.localPort}/runtime.tar.zst"
val target = File(dir, "runtime.tar.zst")
etag = null
assertFalse(Downloader.downloadFile(url, target, true, null))
misbehave = true
assertTrue(Downloader.downloadFile(url, target, true, null))
assertArrayEquals(data, target.readBytes())
assertEquals(listOf<String?>(null, null), requests.toList())
}
@Test fun switchingCandidateDoesNotAppendToDifferentSource() {
val first = "http://127.0.0.1:${server.localPort}/first"
val second = "http://127.0.0.1:${server.localPort}/second"
val target = File(dir, "runtime.tar.zst")
val sha256 = MessageDigest.getInstance("SHA-256").digest(data).joinToString("") { "%02x".format(it.toInt() and 0xff) }
assertFalse(Downloader.downloadFile(first, target, true, sha256, null))
misbehave = true
assertTrue(Downloader.downloadFile(second, target, true, sha256, null))
assertArrayEquals(data, target.readBytes())
assertEquals(listOf<String?>(null, null), requests.toList())
}
@Test fun corruptCandidateFallsBackAfterChecksumMismatch() {
val first = "http://127.0.0.1:${server.localPort}/corrupt"
val second = "http://127.0.0.1:${server.localPort}/clean"
val target = File(dir, "runtime.tar.zst")
val sha256 = MessageDigest.getInstance("SHA-256").digest(data).joinToString("") { "%02x".format(it.toInt() and 0xff) }
misbehave = true
corrupt = true
assertTrue(Downloader.downloadCandidates(first, listOf(first, second), target, true, sha256, null))
assertArrayEquals(data, target.readBytes())
assertEquals(listOf<String?>(null, null), requests.toList())
}
@Test fun executableMetadataIsAlwaysDirect() {
val url = "https://api.github.com/repos/GloriousEggroll/proton-ge-custom/releases"
assertEquals(listOf(url), DownloadSource.candidates(url))
val catalog = "https://raw.githubusercontent.com/Droid-Deck/DroidDeck-CI/main/catalog.json"
assertEquals(listOf(catalog), DownloadSource.candidates(catalog))
}
}