mirror of
https://github.com/Droid-Deck/DroidDeck.git
synced 2026-11-19 12:56:06 +00:00
feat(rockstar): broaden launcher protocol compatibility (#2547)
This commit is contained in:
1 parent
f33181e430
commit
83de0e7f8c
20 files changed
+1368
-90
No files matched your search
@@ -1,4 +1,5 @@
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
import tempfile
|
||||
import time
|
||||
@@ -9,6 +10,112 @@ from test_store_launch import store
|
||||
|
||||
|
||||
class RockstarLaunch(unittest.TestCase):
|
||||
def test_service_directory_cannot_export_sessions_outside_the_prefix(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
folder, sidecar, prefix, _, _ = self.setup_game(root)
|
||||
outside = Path(root) / 'outside'
|
||||
outside.mkdir()
|
||||
target = prefix / 'pfx' / store.ROCKSTAR_FOLDER
|
||||
target.parent.mkdir(parents=True)
|
||||
target.symlink_to(outside, target_is_directory=True)
|
||||
sentinel = outside / 'launch.json'
|
||||
sentinel.write_text('keep')
|
||||
with patch.object(store, 'ask') as ask:
|
||||
self.assertEqual('invalid-service-path', store.prepare_rockstar(folder, sidecar, prefix, 'channel'))
|
||||
ask.assert_not_called()
|
||||
self.assertEqual('keep', sentinel.read_text())
|
||||
|
||||
def test_sdk_registration_does_not_use_an_untrusted_display_name_as_a_key(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
folder, _, prefix, _, _ = self.setup_game(root)
|
||||
with patch.object(store, 'wait_for_server', return_value=True):
|
||||
self.assertTrue(store.rockstar_registry(folder, None, prefix, '', sdk_arch='x64'))
|
||||
text = (prefix / 'pfx/system.reg').read_text()
|
||||
self.assertIn(r'[Software\\Rockstar Games\\Rockstar Games Social Club]', text)
|
||||
self.assertNotIn('Grand Theft Auto', text)
|
||||
|
||||
def test_root_metadata_is_found_after_many_assets(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
folder = Path(root)
|
||||
for index in range(300):
|
||||
(folder / ('asset-%s.dat' % index)).write_bytes(b'asset')
|
||||
(folder / 'title.rgl').write_bytes(b'RGLM' + bytes(108))
|
||||
self.assertTrue(store.rockstar_sdk(folder, {'id': 'future_title', 'exe': 'Game.exe'}))
|
||||
(folder / 'title.rgl').unlink()
|
||||
(folder / 'Title.RGL').write_bytes(b'RGLM' + bytes(108))
|
||||
self.assertTrue(store.rockstar_sdk(folder, {'id': 'future_title', 'exe': 'Game.exe'}))
|
||||
|
||||
def test_sdk_titles_receive_only_their_short_lived_game_session(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
def change(values):
|
||||
folder, sidecar, _, _, answer = values
|
||||
sidecar['id'] = 'future_title'
|
||||
(folder / 'socialclub.dll').write_bytes(b'game-runtime')
|
||||
answer['session'] = {'accountId': '123', 'identity': 'player@example.invalid', 'ticket': 'game-session',
|
||||
'ScAuthToken': 'never-export-refresh-token'}
|
||||
result, path, _ = self.prepare(root, change)
|
||||
self.assertEqual('ready', result)
|
||||
data = json.loads(path.read_text())
|
||||
self.assertEqual({'accountId', 'identity', 'ticket'}, set(data['session']))
|
||||
self.assertNotIn('pipe', data)
|
||||
self.assertNotIn('material', data)
|
||||
self.assertNotIn('never-export-refresh-token', path.read_text())
|
||||
self.assertEqual(0o600, path.stat().st_mode & 0o777)
|
||||
|
||||
def test_invalid_sdk_sessions_cannot_reuse_an_old_handoff(self):
|
||||
for session in (None, {'accountId': '0', 'identity': 'player', 'ticket': 'session'},
|
||||
{'accountId': '123', 'identity': 'player', 'ticket': 'bad\0session'}):
|
||||
with self.subTest(session=session), tempfile.TemporaryDirectory() as root:
|
||||
def change(values):
|
||||
folder, sidecar, _, _, answer = values
|
||||
sidecar['id'] = 'future_title'
|
||||
(folder / 'socialclub.dll').write_bytes(b'game-runtime')
|
||||
answer['session'] = session
|
||||
result, path, _ = self.prepare(root, change)
|
||||
self.assertEqual('invalid-sdk-session', result)
|
||||
self.assertFalse(path.exists())
|
||||
|
||||
def test_sdk_detection_does_not_follow_external_metadata(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
folder = Path(root) / 'game'
|
||||
folder.mkdir()
|
||||
metadata = Path(root) / 'outside.rgl'
|
||||
metadata.write_bytes(b'RGLM' + bytes(108))
|
||||
(folder / 'title.rgl').symlink_to(metadata)
|
||||
self.assertFalse(store.rockstar_sdk(folder, {'id': 'future_title', 'exe': 'Game.exe'}))
|
||||
|
||||
def test_sdk_installer_cannot_escape_its_architecture_folder(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
folder = Path(root) / 'game'
|
||||
installer = folder / 'Installers/Social-Club-Setup.exe'
|
||||
installer.parent.mkdir(parents=True)
|
||||
installer.write_bytes(b'installer')
|
||||
listing = type('Listing', (), {'returncode': 0, 'stdout': b'Path = x64/../../outside.dll\nSize = 1\n'})()
|
||||
with patch.object(store.shutil, 'which', return_value='/bin/7z'), patch.object(store.subprocess, 'run', return_value=listing):
|
||||
with self.assertRaises(ValueError):
|
||||
store.rockstar_runtime(folder, folder / 'Game.exe', str(Path(root) / 'prefix'), 'x64')
|
||||
self.assertFalse((Path(root) / 'outside.dll').exists())
|
||||
|
||||
def test_other_titles_can_launch_without_the_classic_pipe_service(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
folder = Path(root)
|
||||
sidecar = {'store': 'rockstar', 'id': 'rdr2', 'exe': 'RDR2.exe'}
|
||||
with patch.object(store, 'find_store_game', return_value=(folder, sidecar)), \
|
||||
patch.object(store, 'prepare_rockstar') as prepare, \
|
||||
patch.object(store, 'ask') as ask, patch.dict(os.environ, {}, clear=True):
|
||||
self.assertEqual(store.STORE_GAME, store.main([str(folder / 'RDR2.exe')]))
|
||||
prepare.assert_not_called()
|
||||
ask.assert_not_called()
|
||||
|
||||
def test_classic_authentication_failure_still_stops_launch(self):
|
||||
with tempfile.TemporaryDirectory() as root:
|
||||
folder = Path(root)
|
||||
sidecar = {'store': 'rockstar', 'id': 'gtavc', 'exe': 'gta-vc.exe'}
|
||||
with patch.object(store, 'find_store_game', return_value=(folder, sidecar)), \
|
||||
patch.object(store, 'prepare_rockstar', return_value='session-not-owned'), \
|
||||
patch.dict(os.environ, {}, clear=True):
|
||||
self.assertEqual(store.RAN_FAILED, store.main([str(folder / 'gta-vc.exe')]))
|
||||
|
||||
def setup_game(self, root):
|
||||
folder = Path(root) / 'game'
|
||||
folder.mkdir()
|
||||
|
||||
Reference in new issue
Block a user