diff --git a/tools/linuxfs/overlay/usr/local/bin/steam-compatibility b/tools/linuxfs/overlay/usr/local/bin/steam-compatibility index 242d217234..67a33b424c 100755 --- a/tools/linuxfs/overlay/usr/local/bin/steam-compatibility +++ b/tools/linuxfs/overlay/usr/local/bin/steam-compatibility @@ -243,6 +243,13 @@ bl_vacdiag() { """ BL_DIRECTAUDIO_SETUP = """ +bl_is_steam_installscript_target() { + local target=${1:-} + local steam_root=${STEAM_COMPAT_CLIENT_INSTALL_PATH:-${XDG_DATA_HOME:-$HOME/.local/share}/Steam} + local helper="$steam_root/legacycompat/iscriptevaluator.exe" + [ -f "$helper" ] && [[ -n "$target" && "$target" -ef "$helper" ]] +} + bl_directaudio() { case "${verb:-}" in run|waitforexitandrun|runinprefix) ;; @@ -251,6 +258,10 @@ bl_directaudio() { base=$1 [ -n "${BL_DIRECTAUDIO:-}" ] || return 0 [ -d "$BL_DIRECTAUDIO" ] || return 0 + if bl_is_steam_installscript_target "${2:-}"; then + echo "droiddeck-proton: DirectAudio skipped for Steam's install-script evaluator" >&2 + return 0 + fi version=$("$base/files/bin-arm64/wine" --version 2>/dev/null) major=${version#wine-} major=${major%%.*} @@ -338,7 +349,7 @@ for name in %s; do done if [ -n "$depot" ]; then bl_components "$depot" - bl_directaudio "$depot" + bl_directaudio "$depot" "$@" bl_game_cpus bl_idtech3 "$@" bl_vacdiag "$@" @@ -393,7 +404,7 @@ if [ -n "${PROOT_FP_KEY:-}" ] && [ -f "$audit" ]; then esac fi bl_components "$here" -bl_directaudio "$here" +bl_directaudio "$here" "$@" bl_game_cpus bl_idtech3 "$@" bl_vacdiag "$@" diff --git a/tools/tests/test_game_environment.py b/tools/tests/test_game_environment.py index 9c8a98c202..6757d46d6f 100644 --- a/tools/tests/test_game_environment.py +++ b/tools/tests/test_game_environment.py @@ -434,6 +434,8 @@ class GameEnvironmentTest(unittest.TestCase): self.assertEqual(changes, {"42": COMPAT["TOOL"]}) def test_both_proton_wrappers_call_environment_launcher(self): + self.assertIn('bl_directaudio "$depot" "$@"', COMPAT["LAUNCHER_SH"]) + self.assertIn('bl_directaudio "$here" "$@"', COMPAT["EXTRA_WRAPPER_SH"] % "proton") for script in (COMPAT["LAUNCHER_SH"], COMPAT["EXTRA_WRAPPER_SH"] % "proton"): subprocess.run(["bash", "-n"], input=script, text=True, check=True) self.assertIn('bl_run ${BL_TASKSET:-} /usr/local/bin/droiddeck-game-env', script) @@ -849,12 +851,15 @@ class DirectAudioPrefixTest(unittest.TestCase): (self.windows / folder).mkdir(parents=True) self.reg = self.compat / "pfx/user.reg" - def run_setup(self, verb="waitforexitandrun"): - script = COMPAT["BL_DIRECTAUDIO_SETUP"] + '\nverb=$2\nbl_directaudio "$1"\necho "WINEDLLPATH=$WINEDLLPATH"\necho "WINE_AUDIO_DRIVER=${WINE_AUDIO_DRIVER:-}"\n' - env = dict(os.environ, BL_DIRECTAUDIO=str(self.sets), STEAM_COMPAT_DATA_PATH=str(self.compat)) + def run_setup(self, verb="waitforexitandrun", target="game.exe", cwd=None): + script = COMPAT["BL_DIRECTAUDIO_SETUP"] + '\nverb=$2\nbl_directaudio "$1" "$3"\necho "WINEDLLPATH=$WINEDLLPATH"\necho "WINE_AUDIO_DRIVER=${WINE_AUDIO_DRIVER:-}"\n' + steam = self.compat.parent / "Steam" + env = dict(os.environ, BL_DIRECTAUDIO=str(self.sets), STEAM_COMPAT_DATA_PATH=str(self.compat), + STEAM_COMPAT_CLIENT_INSTALL_PATH=str(steam)) env.pop("WINEDLLPATH", None) env.pop("WINE_AUDIO_DRIVER", None) - return subprocess.run(["bash", "-c", script, "bash", str(self.tool), verb], env=env, capture_output=True, text=True, check=True) + return subprocess.run(["bash", "-c", script, "bash", str(self.tool), verb, target], cwd=cwd, env=env, + capture_output=True, text=True, check=True) def audio_values(self): found, current = [], None @@ -869,6 +874,35 @@ class DirectAudioPrefixTest(unittest.TestCase): path = self.windows / folder / "winedirectaudio.drv" return os.readlink(path) if path.is_symlink() else None + def test_steam_installscript_evaluator_does_not_change_prefix_audio(self): + legacycompat = self.compat.parent / "Steam/legacycompat" + legacycompat.mkdir(parents=True) + (legacycompat / "iscriptevaluator.exe").write_bytes(b"Steam install-script evaluator") + self.reg.write_text("WINE REGISTRY Version 2\n\n#arch=win64\n") + + result = self.run_setup(target="iscriptevaluator.exe", cwd=legacycompat) + + self.assertIn("DirectAudio skipped for Steam's install-script evaluator", result.stderr) + self.assertIn("WINEDLLPATH=\n", result.stdout) + self.assertIn("WINE_AUDIO_DRIVER=\n", result.stdout) + self.assertEqual(self.reg.read_text(), "WINE REGISTRY Version 2\n\n#arch=win64\n") + self.assertIsNone(self.link("system32")) + self.assertIsNone(self.link("syswow64")) + + def test_same_basename_outside_steam_legacycompat_keeps_normal_setup(self): + legacycompat = self.compat.parent / "Steam/legacycompat" + legacycompat.mkdir(parents=True) + (legacycompat / "iscriptevaluator.exe").write_bytes(b"Steam install-script evaluator") + other = self.compat.parent / "other" + other.mkdir() + (other / "iscriptevaluator.exe").write_bytes(b"unrelated executable") + self.reg.write_text("WINE REGISTRY Version 2\n\n#arch=win64\n") + + result = self.run_setup(target="iscriptevaluator.exe", cwd=other) + + self.assertIn("DirectAudio selected", result.stderr) + self.assertEqual(self.link("system32"), str(self.audio / "lib/wine/aarch64-windows/winedirectaudio.drv")) + self.assertEqual(self.audio_values(), [("[Software\\\\Wine\\\\Drivers]", '"Audio"="directaudio,pulse"')]) def test_non_launch_verbs_preserve_audio_configuration(self): for verb in ("getcompatpath", "getnativepath", "destroyprefix"): with self.subTest(verb=verb):