mirror of
https://github.com/Droid-Deck/DroidDeck.git
synced 2026-11-19 04:46:08 +00:00
fix: keep select mapping and panel input ownership consistent
Keep Select-as-Steam in the existing one-time profile migration and remove the obsolete bridge flag. Raw SELECT state stays stable across router attachment changes, while explicit native, disabled and local profile bindings remain authoritative. Let the panel close its shared DeckControls source. Detached sticks, D-pads and face buttons release only their own controls, preserving other trackpad contacts and clicks. Add seven regressions. All 2,246 JVM tests pass; the debug APK build, session assets and runtime inputs validate. Thor validation remains pending.
This commit is contained in:
1 parent
1dae4bf8ee
commit
884671a065
7 files changed
+250
-15
No files matched your search
@@ -95,6 +95,10 @@ trackpads and grips; it does not create another emulated controller.
|
||||
|
||||
The old touch-only mapping and Select-as-Steam settings migrate once into Game's
|
||||
primary-screen and physical bindings respectively. Their redundant UI is removed.
|
||||
`PadBridge` retains raw SELECT state; only the profile maps it to GUIDE. The old
|
||||
flag is read for migration, not applied again during event handling, so explicit
|
||||
native/disabled/local bindings and profile resets remain authoritative. Attaching
|
||||
or removing a router cannot change which raw button a SELECT release clears.
|
||||
Invalid stored entries fall back to defaults. The global settings reset clears
|
||||
both profile and surface settings without reimporting the old mappings.
|
||||
|
||||
|
||||
@@ -96,6 +96,29 @@ device. Retained-state initialization runs when sources attach; ordinary input
|
||||
keeps its existing synchronous routing and native identity path. The VR command
|
||||
uses the existing chord handler for its release, retaining the 120 ms pulse.
|
||||
|
||||
### SELECT and panel ownership follow-up
|
||||
|
||||
The next review covered SELECT-to-GUIDE routing and child-view ownership. The
|
||||
existing one-time Select-as-Steam migration is exercised through real controller
|
||||
key events, including simultaneous physical GUIDE ownership. Explicit native,
|
||||
disabled and local SELECT assignments, and resetting the Game profile, remain
|
||||
authoritative. Removing the obsolete bridge flag keeps raw SELECT state stable
|
||||
when a router is attached or removed while the button is held.
|
||||
|
||||
Panel regressions use an attached Android view hierarchy and a two-finger
|
||||
trackpad contact. Switching the other stick to a trackpad, or removing the D-pad
|
||||
or face buttons, must release only that child's controls and preserve the other
|
||||
trackpad's contact, coordinates and click. Whole-panel removal still releases
|
||||
the shared source. These three panel scenarios and the retained SELECT scenario
|
||||
failed before the fixes; all seven new tests pass after them.
|
||||
|
||||
The complete JVM run passes **2,246 tests across 336 suites, zero failures/errors/
|
||||
skips**. The debug APK build, session-asset check and runtime-input verification
|
||||
pass with the same local build settings. APK SHA-256:
|
||||
`0d85b4003cd6b31084e50d603e8b00f239775c9c97f3ec17327264db5dd50612`.
|
||||
These changes have host coverage only; Thor validation and new latency
|
||||
measurements remain pending.
|
||||
|
||||
## Manual AYN Thor results
|
||||
|
||||
The user performed the following checks in the installed candidate. The desktop
|
||||
|
||||
Reference in new issue
Block a user