From 9a6d770c1d55cf25abe6abe72d58ad84f6f99f40 Mon Sep 17 00:00:00 2001 From: Kurt Himebauch <136133082+xXJSONDeruloXx@users.noreply.github.com> Date: Wed, 11 Nov 2026 19:32:10 +0000 Subject: [PATCH] ci: install Node for the Python tests on either runner and update the job-dependency test --- .github/workflows/build.yml | 3 +++ tools/tests/test_ci_checks.py | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 93b7bf0e45..730cc2dfba 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -840,6 +840,9 @@ jobs: env: XBOX_SOURCE_TREE: ${{ needs.source.outputs.tree-sha }} run: test "$(git rev-parse 'HEAD^{tree}')" = "$XBOX_SOURCE_TREE" + - uses: actions/setup-node@v4 + with: + node-version: '20' - name: Install Python test dependencies timeout-minutes: 7 run: bash tools/ci/install-ubuntu-packages.sh python3-yaml gcc-aarch64-linux-gnu libc6-dev-arm64-cross qemu-user libvulkan-dev mesa-vulkan-drivers diff --git a/tools/tests/test_ci_checks.py b/tools/tests/test_ci_checks.py index 125dba0398..d6482e8491 100644 --- a/tools/tests/test_ci_checks.py +++ b/tools/tests/test_ci_checks.py @@ -48,8 +48,11 @@ class CiChecksTest(unittest.TestCase): def test_independent_jobs_wait_only_for_the_pinned_source(self): jobs = yaml.safe_load((ROOT / '.github/workflows/build.yml').read_text())['jobs'] - for name in ('xbox', 'python-tests', 'components-runner'): + for name in ('xbox', 'python-runner', 'components-runner'): self.assertEqual(jobs[name]['needs'], 'source') + self.assertEqual(set(jobs['python-tests']['needs']), {'source', 'python-runner'}) + node = [step for step in jobs['python-tests']['steps'] if step.get('uses', '').startswith('actions/setup-node@')] + self.assertEqual(len(node), 1) self.assertEqual(set(jobs['components']['needs']), {'source', 'components-runner'}) self.assertEqual(jobs['build-runner']['needs'], ['components']) self.assertEqual(set(jobs['build']['needs']), {'source', 'components', 'xbox', 'build-runner'})