From a80300c3571f5c2ae2794129b5096e213701e023 Mon Sep 17 00:00:00 2001 From: XxJSONDeruloxX Date: Wed, 14 Oct 2026 22:14:19 -0400 Subject: [PATCH] test: report sustained Quest XR telemetry --- docs/development/quest-openxr.md | 12 +++++++ tools/test_quest_xr.py | 42 ++++++++++++++++++++++++- tools/tests/test_quest_xr_validation.py | 39 ++++++++++++++++++++++- 3 files changed, 91 insertions(+), 2 deletions(-) diff --git a/docs/development/quest-openxr.md b/docs/development/quest-openxr.md index 3d9f5cd41e..440f03586c 100644 --- a/docs/development/quest-openxr.md +++ b/docs/development/quest-openxr.md @@ -309,6 +309,18 @@ bundled into the user-facing runtime. A valid already-signaled SYNC_FD value of ## Remaining stages +### Sustained validation telemetry + +`tools/test_quest_xr.py --metrics` records public battery, thermal-service and +package-memory dumps before and after the measured frame window. Unavailable +metrics remain explicitly unavailable; no privilege escalation or alternate +private-file access is attempted. Reports now distinguish observed XR submits, +guest GPU presentations, owned-image uploads and rejected-frame rates from the +runtime's nominal refresh rate, and record the focused/tracked sample fraction. +A run that loses focused 6DoF tracking at the end no longer passes merely because +one earlier sample was tracked. These reporting paths have host tests; no new +Quest performance or thermal result is claimed while the headset is disconnected. + ### Touch input profile Fresh XR controller activation now selects SteamVR's built-in `oculus_touch` diff --git a/tools/test_quest_xr.py b/tools/test_quest_xr.py index 54efb97e58..359b932d72 100644 --- a/tools/test_quest_xr.py +++ b/tools/test_quest_xr.py @@ -15,6 +15,8 @@ def validate_samples(samples, require_controllers=False, guest=False, steamvr=Fa return 'Fewer than 72 additional stereo frames were submitted' if not any(sample['sessionState'] == 5 and sample['headFlags'] & 15 == 15 for sample in samples): return 'No focused session with tracked 6DoF position and orientation' + if samples[-1]['sessionState'] != 5 or samples[-1]['headFlags'] & 15 != 15: + return 'Session did not remain focused with tracked 6DoF through the final sample' if require_controllers and not any(all(sample['controllersActive']) for sample in samples): return 'Both controllers did not become active' if steamvr and samples[-1].get('uploadedFrames', 0) - samples[0].get('uploadedFrames', 0) < 72: @@ -31,6 +33,39 @@ def validate_samples(samples, require_controllers=False, guest=False, steamvr=Fa return None +def summarize_samples(samples): + result = {'sampleCount': len(samples), 'focusedTrackedFraction': None, 'observedSeconds': None, 'ratesHz': {}} + if not samples: + return result + result['focusedTrackedFraction'] = sum(sample.get('sessionState') == 5 and sample.get('headFlags', 0) & 15 == 15 + for sample in samples) / len(samples) + if len(samples) < 2 or '_hostMonotonicSeconds' not in samples[0] or '_hostMonotonicSeconds' not in samples[-1]: + return result + duration = samples[-1]['_hostMonotonicSeconds'] - samples[0]['_hostMonotonicSeconds'] + if duration <= 0: + return result + result['observedSeconds'] = duration + for counter in ('rendered', 'guestFrames', 'receivedFrames', 'rejectedFrames', 'uploadedFrames'): + if counter in samples[0] and counter in samples[-1]: + delta = samples[-1][counter] - samples[0][counter] + result['ratesHz'][counter] = delta / duration if delta >= 0 else None + period = samples[-1].get('periodNs', 0) + result['runtimeRefreshHz'] = 1000000000 / period if period > 0 else None + return result + + +def collect_device_metrics(adb, package): + result = {} + for name, command in [('battery', ('shell', 'dumpsys', 'battery')), + ('thermal', ('shell', 'dumpsys', 'thermalservice')), + ('memory', ('shell', 'dumpsys', 'meminfo', package))]: + try: + result[name] = {'available': True, 'text': adb(*command)} + except (subprocess.CalledProcessError, subprocess.TimeoutExpired) as error: + result[name] = {'available': False, 'error': type(error).__name__} + return result + + def main(): parser = argparse.ArgumentParser(description='Validate immersive DroidDeck XR on a connected Quest') parser.add_argument('--adb', default=os.environ.get('ADB', 'adb')) @@ -42,6 +77,7 @@ def main(): parser.add_argument('--guest', action='store_true') parser.add_argument('--keep-awake', action='store_true') parser.add_argument('--steamvr', action='store_true') + parser.add_argument('--metrics', action='store_true', help='Record public battery, thermal and package memory dumps before/after testing') args = parser.parse_args() if args.seconds < 5 or args.seconds > 600: parser.error('--seconds must be between 5 and 600') @@ -72,6 +108,7 @@ def main(): launch += ['--ez', 'start_steamvr', 'true'] samples = [] failure = None + metrics = {'before': collect_device_metrics(adb, package)} if args.metrics else None try: adb('shell', 'am', 'broadcast', '-a', 'com.oculus.vrpowermanager.prox_close') adb(*launch) @@ -81,6 +118,7 @@ def main(): adb('shell', 'am', 'broadcast', '-a', 'com.oculus.vrpowermanager.prox_close') try: sample = json.loads(adb('shell', 'cat', health_path)) + sample['_hostMonotonicSeconds'] = time.monotonic() samples.append(sample) if sample.get('error'): failure = sample['error'] @@ -100,8 +138,10 @@ def main(): except (subprocess.CalledProcessError, subprocess.TimeoutExpired) as error: log = str(error) (args.output / 'logcat.txt').write_text(log, encoding='utf-8') + if metrics is not None: + metrics['after'] = collect_device_metrics(adb, package) failure = failure or validate_samples(samples, args.require_controllers, args.guest, args.steamvr, args.surface) - report = {'ok': failure is None, 'error': failure, 'samples': samples} + report = {'ok': failure is None, 'error': failure, 'samples': samples, 'summary': summarize_samples(samples), 'deviceMetrics': metrics} (args.output / 'report.json').write_text(json.dumps(report, indent=2), encoding='utf-8') print(json.dumps({'ok': report['ok'], 'error': failure, 'samples': len(samples), 'last': samples[-1] if samples else None}, indent=2)) diff --git a/tools/tests/test_quest_xr_validation.py b/tools/tests/test_quest_xr_validation.py index 140d988b2c..ed91f950d1 100644 --- a/tools/tests/test_quest_xr_validation.py +++ b/tools/tests/test_quest_xr_validation.py @@ -3,7 +3,8 @@ import unittest from pathlib import Path sys.path.insert(0, str(Path(__file__).resolve().parents[1])) -from test_quest_xr import validate_samples +from test_quest_xr import collect_device_metrics, summarize_samples, validate_samples +import subprocess class QuestXrValidationTest(unittest.TestCase): @@ -27,6 +28,42 @@ class QuestXrValidationTest(unittest.TestCase): def test_optional_controllers_cannot_be_claimed_as_tested(self): self.assertIn('controllers', validate_samples(self.samples(), require_controllers=True)) + def test_one_early_tracked_sample_cannot_hide_final_tracking_loss(self): + samples = self.samples() + samples[-1]['headFlags'] = 7 + self.assertIn('final sample', validate_samples(samples)) + samples[-1]['headFlags'] = 15 + samples[-1]['sessionState'] = 4 + self.assertIn('final sample', validate_samples(samples)) + + def test_measured_rates_are_separate_from_runtime_refresh(self): + samples = self.samples('frames') + samples[0]['_hostMonotonicSeconds'] = 10 + samples[-1]['_hostMonotonicSeconds'] = 12 + samples[-1]['periodNs'] = 8333333 + summary = summarize_samples(samples) + self.assertEqual(summary['observedSeconds'], 2) + self.assertEqual(summary['ratesHz']['uploadedFrames'], 72) + self.assertAlmostEqual(summary['runtimeRefreshHz'], 120, places=3) + self.assertEqual(summary['focusedTrackedFraction'], 1) + samples[-1]['uploadedFrames'] = -1 + self.assertIsNone(summarize_samples(samples)['ratesHz']['uploadedFrames']) + self.assertIsNone(summarize_samples(self.samples())['observedSeconds']) + self.assertIsNone(summarize_samples([])['focusedTrackedFraction']) + + def test_metrics_failures_stay_unavailable_without_privileged_fallback(self): + commands = [] + def adb(*command): + commands.append(command) + if command[-1] == 'battery': + return 'temperature: 310' + raise subprocess.CalledProcessError(1, command, stderr='Permission denied') + metrics = collect_device_metrics(adb, 'com.droiddeck.launcher') + self.assertEqual(len(commands), 3) + self.assertTrue(metrics['battery']['available']) + self.assertFalse(metrics['thermal']['available']) + self.assertFalse(metrics['memory']['available']) + def test_steamvr_requires_owned_images_and_source_frame_ids(self): samples = self.samples('frames') self.assertIsNone(validate_samples(samples, guest=True, steamvr=True))