fix: preserve the runtime PATH when overriding guest binaries

This commit is contained in:
qinsiyuan committed 2026-10-30 18:35:06 +08:00
1 parent f69e2d0171
commit ab43524bbc
5 files changed
+34 -3

No files matched your search

@@ -181,6 +181,32 @@ class AgentSecurityTest {
assertEquals(listOf("TEST=old", "STICKY=1"), AgentEnv.beginSession(context))
}
@Test fun binaryOverridesPreserveTheRuntimeSearchPathForOneSession() {
AgentAccess.setCommandsEnabled(context, true)
File(AgentEnv.inbox(context).apply { mkdirs() }, "gamescope").writeText("test binary")
AgentEnv.override(context, "gamescope")
val path = AgentEnv.beginSession(context).single { it.startsWith("PATH=") }.substringAfter('=')
assertEquals("/opt/droiddeck-agent/bin:" + LinuxRuntime.GUEST_PATH, path)
assertTrue(path.split(':').contains("/usr/games"))
assertTrue(path.split(':').contains("/usr/sbin"))
AgentEnv.endSession(context)
assertTrue(AgentEnv.beginSession(context).none { it.startsWith("PATH=") })
}
@Test fun binaryOverridesKeepExplicitPathsAndPendingPathPrecedence() {
AgentAccess.setCommandsEnabled(context, true)
AgentEnv.set(context, listOf("PATH=/custom/persistent"), true)
AgentEnv.set(context, listOf("PATH=/custom/next:/usr/games"), false)
File(AgentEnv.inbox(context).apply { mkdirs() }, "gamescope").writeText("test binary")
AgentEnv.override(context, "gamescope")
assertEquals("PATH=/opt/droiddeck-agent/bin:/custom/next:/usr/games", AgentEnv.beginSession(context).last())
AgentEnv.endSession(context)
assertEquals(listOf("PATH=/custom/persistent"), AgentEnv.beginSession(context))
}
@Test fun fastPathLibraryIsValidatedAndSelectedForOneSession() {
AgentAccess.setCommandsEnabled(context, true)
val source = File(AgentEnv.inbox(context).apply { mkdirs() }, "libblfastpath.so")