fix(library): only list the Collections source when it has something to show

This commit is contained in:
FX192 committed 2026-11-18 18:43:26 +03:00
1 parent 75c19cae68
commit b74d005e7f
2 files changed
+7 -7

No files matched your search

@@ -282,7 +282,7 @@ internal fun LibraryPage(s: FrontEndState, a: FrontEndActions, selected: String,
val gameJoltSignedIn = owned.containsKey(Store.GAMEJOLT)
val sources = librarySources(
all, SessionPrefs.storesTabOrder(ctx),
listOfNotNull(Store.ITCH.id.takeIf { itchSignedIn && !soundMode }, Store.GAMEJOLT.id.takeIf { gameJoltSignedIn && !soundMode }, Library.SOURCE_COLLECTION.takeIf { soundMode }).toSet(),
listOfNotNull(Store.ITCH.id.takeIf { itchSignedIn && !soundMode }, Store.GAMEJOLT.id.takeIf { gameJoltSignedIn && !soundMode }).toSet(),
favorites, concealed, LibraryDisplay.hidden && !soundMode,
)
val source = LibraryView.source.takeIf { it == LIBRARY_ALL || it in sources } ?: LIBRARY_ALL
@@ -44,11 +44,11 @@ class SoundtrackCollectionsTest {
@Test fun emptyFavoritesCanBeLeftOutOfTheLibraryList() {
val context = androidx.test.core.app.ApplicationProvider.getApplicationContext<android.content.Context>()
SoundtrackCollections.load(context)
SoundtrackCollections.create(context, "Chill", emptyList())
val ids = { skip: Boolean -> SoundtrackCollections.games(context, "Favorites", skip).map { it.appId } }
assertTrue(SoundtrackCollections.FAVORITES_ID in ids(false))
assertFalse(SoundtrackCollections.FAVORITES_ID in ids(true))
SoundtrackCollections.add(context, SoundtrackCollections.FAVORITES_ID, listOf(ref("a")))
assertTrue(SoundtrackCollections.FAVORITES_ID in ids(true))
val custom = SoundtrackCollections.create(context, "Chill", emptyList())!!
val favorites = SoundtrackCollections.FAVORITES_ID
assertEquals(listOf(custom), SoundtrackCollections.games(context, "Favorites", skipEmptyFavorites = true).map { it.appId })
assertEquals(listOf(favorites, custom), SoundtrackCollections.games(context, "Favorites").map { it.appId })
SoundtrackCollections.add(context, favorites, listOf(ref("a")))
assertEquals(listOf(favorites, custom), SoundtrackCollections.games(context, "Favorites", skipEmptyFavorites = true).map { it.appId })
}
}