mirror of
https://github.com/Droid-Deck/DroidDeck.git
synced 2026-11-19 12:56:06 +00:00
Stores: seal sign-in files with an Android Keystore key
credentials.json for GOG, Epic and Amazon is an AES-256-GCM envelope
({"v":1,"alg":"AES/GCM","iv","ct"}) under a non-exportable AndroidKeyStore
key (StrongBox if present, else TEE, no user authentication). StoreAccounts
stays the one layer every reader and writer uses.
A plain file from an earlier build is sealed at start, verified, then
replaced. Without a Keystore the file stays plain (logged once, retried next
start); a file that no longer opens is deleted and the store reads as signed
out.
This commit is contained in:
1 parent
38e3fa2a33
commit
c248d3e1c4
6 files changed
+326
-8
No files matched your search
@@ -189,5 +189,29 @@ Store log lines (the engines' included) go through `StoresState.logLine`, which
|
||||
(`StoreLogFiles`: one file a day, seven days kept, ~2 MB each before it rolls to `.1`). Nothing
|
||||
shows them in the app; the session's Share logs zip carries them under `stores/`.
|
||||
|
||||
Credentials live in `filesDir/stores/<store>/credentials.json` only (`StoreAccounts`); store URLs
|
||||
are logged through `StoreLog.redactUrl`, which drops the query string where the signed tokens live.
|
||||
Store URLs are logged through `StoreLog.redactUrl`, which drops the query string where the signed
|
||||
tokens live.
|
||||
|
||||
## Security
|
||||
|
||||
- **Sign-ins:** `filesDir/stores/<store>/credentials.json` only, read and written through
|
||||
`StoreAccounts` alone (`GogAuth`, `EpicCredentialStore`, `AmazonCredentialStore`, cloud saves
|
||||
all call it). The file is an envelope `{"v":1,"alg":"AES/GCM","iv":...,"ct":...}` (base64):
|
||||
AES-256-GCM (`CredentialCipher`) under a key generated in the AndroidKeyStore (alias
|
||||
`droiddeck-store-credentials`; encrypt/decrypt, GCM, no padding, not exportable, no user
|
||||
authentication so background downloads and launch-time exchange codes work with the screen off;
|
||||
StrongBox where present, else the TEE). Written through a temp file and a rename, mode 600.
|
||||
- **Earlier plain files:** sealed at app start (`StoreAccounts.encryptAll`, and on any read),
|
||||
verified by opening the result, the plain file replaced; the log says
|
||||
`stores: credentials encrypted <store>`. A plain `.tmp` left by an older build is deleted.
|
||||
- **No Keystore** (some ROMs): the file stays plain, the log says
|
||||
`stores: keystore unavailable, credentials stay plain (<exception class>)` once, and the next
|
||||
start tries again.
|
||||
- **A file that no longer opens** (key invalidated: data cleared, a backup restored on another
|
||||
device, tampering): deleted, and the store reads as signed out, so its sign-in card shows.
|
||||
- **The Linux session:** the app's files directory is bound into every session, so the guest can
|
||||
see `credentials.json` - as the envelope only; the key never leaves the Keystore. Nothing in the
|
||||
guest reads the files: `droiddeck-store-launch` asks the app over `<session>/stores/req|resp`
|
||||
for an Epic exchange code, which the app writes beside the game's launcher; the launcher reads
|
||||
it into a variable and deletes it before the game starts (single use, expires in minutes).
|
||||
Steam's own client files are outside this.
|
||||
@@ -7,6 +7,22 @@ the timeline, then lessons and backlog. Companion to the README (what the app *d
|
||||
|
||||
---
|
||||
|
||||
## 2026-10-09 - `feat/store-credentials-keystore`: store sign-ins sealed with the Android Keystore
|
||||
|
||||
- **What:** `filesDir/stores/<store>/credentials.json` (GOG, Epic, Amazon: tokens, ids, names,
|
||||
expiry) is now an AES-256-GCM envelope (`{"v":1,"alg":"AES/GCM","iv","ct"}`) under a
|
||||
non-exportable AndroidKeyStore key (StrongBox if present, else TEE; no user authentication).
|
||||
`StoreAccounts` is the one layer; `CredentialCipher` holds the envelope and the key.
|
||||
- **Upgrade:** a plain file is sealed at the first start (verified, then replaced); users stay
|
||||
signed in. Log: `stores: credentials encrypted <store>`.
|
||||
- **Fallbacks:** no Keystore - stays plain, logged once, retried next start; a file that will not
|
||||
open - deleted, signed out (sign-in card), never a crash.
|
||||
- **Session:** the guest sees the envelope only; it never read the files (the Epic code comes over
|
||||
the request channel, written beside the launcher and deleted by it).
|
||||
- **Tests:** `StoreAccountsCipherTest` (round trip, sealed on disk, migration of all three stores,
|
||||
tampered file, lost key, garbage, no-Keystore fallback then sealed next start, sign-out). Not yet
|
||||
on a device.
|
||||
|
||||
## 2026-10-08 - `feat/private-logs`: every log in app-private storage, shared as one scrubbed zip
|
||||
|
||||
- **Where logs live:** `files/logs/` (`LinuxRuntime.logDir`), nothing under `Download/DroidDeck`
|
||||
|
||||
Reference in new issue
Block a user