From ca6c409436d04b8e845df0ed796dc36000c7c607 Mon Sep 17 00:00:00 2001 From: MaxsTechReview Date: Sat, 7 Nov 2026 08:25:08 -0500 Subject: [PATCH] fix(drivers): built-in Auto picks match the published table on Adreno 6xx and 8xx (#2151) --- .../main/java/com/droiddeck/launcher/gpu/AutoPicks.kt | 7 +++---- .../java/com/droiddeck/launcher/gpu/AutoPicksTest.kt | 2 +- .../java/com/droiddeck/launcher/gpu/DriverPairsTest.kt | 10 +++++----- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/app/src/main/java/com/droiddeck/launcher/gpu/AutoPicks.kt b/app/src/main/java/com/droiddeck/launcher/gpu/AutoPicks.kt index 6216ccf7d3..f48e788bba 100644 --- a/app/src/main/java/com/droiddeck/launcher/gpu/AutoPicks.kt +++ b/app/src/main/java/com/droiddeck/launcher/gpu/AutoPicks.kt @@ -27,12 +27,11 @@ object AutoPicks { } val BUILT_IN = listOf( - Rule(setOf(Family.A8XX), models = setOf(840), prefer = listOf(NEWEST_DD_TURNIP, DriverPairs.WN_BALANCED)), - Rule(setOf(Family.A8XX), prefer = listOf(DriverPairs.WN_BALANCED)), + Rule(setOf(Family.A8XX), prefer = listOf(NEWEST_DD_TURNIP, DriverPairs.WN_BALANCED)), Rule(setOf(Family.A7XX_LOW), prefer = listOf(NEWEST_DD_TURNIP, DriverPairs.BANNER_710)), - Rule(setOf(Family.A7XX), oneUi8Gen2 = true, prefer = listOf(DriverPairs.BANNER_ONEUI)), + Rule(setOf(Family.A7XX), oneUi8Gen2 = true, prefer = listOf(NEWEST_DD_TURNIP, DriverPairs.BANNER_ONEUI)), Rule(setOf(Family.A7XX), prefer = listOf(NEWEST_DD_TURNIP, DriverPairs.BANNER)), - Rule(setOf(Family.A6XX), prefer = listOf(DriverPairs.BANNER)), + Rule(setOf(Family.A6XX), prefer = listOf(NEWEST_DD_TURNIP, DriverPairs.BANNER)), Rule(setOf(Family.ADRENO_UNKNOWN), minSdk = 36, prefer = listOf(DriverPairs.WN_BALANCED)), Rule(setOf(Family.ADRENO_UNKNOWN), prefer = listOf(DriverPairs.BANNER)), ) diff --git a/app/src/test/java/com/droiddeck/launcher/gpu/AutoPicksTest.kt b/app/src/test/java/com/droiddeck/launcher/gpu/AutoPicksTest.kt index 83f32a36eb..2f5c427679 100644 --- a/app/src/test/java/com/droiddeck/launcher/gpu/AutoPicksTest.kt +++ b/app/src/test/java/com/droiddeck/launcher/gpu/AutoPicksTest.kt @@ -56,7 +56,7 @@ class AutoPicksTest { } @Test fun aGpuTheManifestDoesNotCoverUsesTheBuiltInTable() { - assertEquals(DriverPairs.WN_BALANCED, DriverPairs.recommendedKey(gpu(830), pairs, AutoPicks.parse(manifest)!!)) + assertEquals(DriverPairs.ddTurnip("DD-Turnip-v0.3.0"), DriverPairs.recommendedKey(gpu(830), pairs, AutoPicks.parse(manifest)!!)) } @Test fun anotherSchemaOrNoUsableRulesIsIgnored() { diff --git a/app/src/test/java/com/droiddeck/launcher/gpu/DriverPairsTest.kt b/app/src/test/java/com/droiddeck/launcher/gpu/DriverPairsTest.kt index d1c048b61b..b234260030 100644 --- a/app/src/test/java/com/droiddeck/launcher/gpu/DriverPairsTest.kt +++ b/app/src/test/java/com/droiddeck/launcher/gpu/DriverPairsTest.kt @@ -116,7 +116,7 @@ class DriverPairsTest { } @Test - fun adreno840GetsTheNewestOfficialDdTurnip() { + fun everyAdrenoGenerationGetsTheNewestOfficialDdTurnip() { fun bundle(tag: String) = TurnipReleases.Asset("DroidDeck", tag, "$tag.zip", "https://example/$tag", 6_000_000, false, "Android + Linux", "0".repeat(64), DriverPairs.ddTurnip(tag), bundle = true) val pairs = DriverPairs.from(TurnipReleases.Check( @@ -126,12 +126,12 @@ class DriverPairsTest { emptyList(), emptyList(), 0L, )) assertEquals(DriverPairs.ddTurnip("DD-Turnip-v1.0.0"), DriverPairs.recommendedKey(gpu(840), pairs)) - assertEquals("other 8xx keep WinNative", DriverPairs.WN_BALANCED, DriverPairs.recommendedKey(gpu(830), pairs)) - assertEquals(DriverPairs.WN_BALANCED, DriverPairs.recommendedKey(gpu(825), pairs)) + assertEquals(DriverPairs.ddTurnip("DD-Turnip-v1.0.0"), DriverPairs.recommendedKey(gpu(830), pairs)) + assertEquals(DriverPairs.ddTurnip("DD-Turnip-v1.0.0"), DriverPairs.recommendedKey(gpu(825), pairs)) assertEquals(DriverPairs.ddTurnip("DD-Turnip-v1.0.0"), DriverPairs.recommendedKey(gpu(740), pairs)) assertEquals(DriverPairs.ddTurnip("DD-Turnip-v1.0.0"), DriverPairs.recommendedKey(gpu(722), pairs)) - assertEquals(DriverPairs.BANNER_ONEUI, DriverPairs.recommendedKey(gpu(740, oneUi = true), pairs)) - assertEquals(DriverPairs.BANNER, DriverPairs.recommendedKey(gpu(650), pairs)) + assertEquals(DriverPairs.ddTurnip("DD-Turnip-v1.0.0"), DriverPairs.recommendedKey(gpu(740, oneUi = true), pairs)) + assertEquals(DriverPairs.ddTurnip("DD-Turnip-v1.0.0"), DriverPairs.recommendedKey(gpu(650), pairs)) } @Test