mirror of
https://github.com/Droid-Deck/DroidDeck.git
synced 2026-11-22 14:26:00 +00:00
fix(proot): a call the filesystem does not implement no longer switches the fast path off (#2509)
Android's FUSE daemon has no symlink or link, so those calls on a storage card return ENOSYS. The fast path read any ENOSYS from its trampoline as a seccomp trap and stopped for the whole process. It now asks again with the same call number and invalid arguments: a trap answers ENOSYS again, anything else means the call reached the kernel and only that call is repeated. Folders opened for a refused call are still closed.
This commit is contained in:
1 parent
b303423001
commit
cd05c96d10
3 files changed
+51
-3
No files matched your search
@@ -162,6 +162,11 @@ Prototype (inert unless `PROOT_FASTPATH` is set; see `docs/development/proot-per
|
||||
`ENOSYS`, because its arguments are host paths; the fast path then stops for that process and
|
||||
repeats the call through a plain `svc`, which the guest's filter traps with the guest path.
|
||||
`bench/guest-trap.c` installs a tagged `openat` trap and checks its handler answers the call.
|
||||
The kernel and filesystems also return `ENOSYS` themselves: Android's FUSE daemon has no
|
||||
`symlink`, so `symlinkat` on a storage card fails with it. The fast path therefore asks again
|
||||
with the same call number and invalid arguments. A trap answers `ENOSYS` again and the fast path
|
||||
stops for the process; any other error means the call reached the kernel, so only that one call
|
||||
is repeated through a plain `svc` and the fast path stays on.
|
||||
|
||||
Old kernel fixes:
|
||||
|
||||
|
||||
Reference in new issue
Block a user