From cd1caf523d7aa24d0146b860608772249dfc9223 Mon Sep 17 00:00:00 2001 From: Kurt Himebauch <136133082+xXJSONDeruloXx@users.noreply.github.com> Date: Wed, 28 Oct 2026 13:10:08 -0400 Subject: [PATCH] Default to Native background behavior and automatic PiP (#1727) --- .../com/droiddeck/launcher/session/SessionPrefs.kt | 5 +++-- .../launcher/session/SessionBackgroundPrefsTest.kt | 13 +++++++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/droiddeck/launcher/session/SessionPrefs.kt b/app/src/main/java/com/droiddeck/launcher/session/SessionPrefs.kt index a98dabcead..ed55f0019b 100644 --- a/app/src/main/java/com/droiddeck/launcher/session/SessionPrefs.kt +++ b/app/src/main/java/com/droiddeck/launcher/session/SessionPrefs.kt @@ -1195,7 +1195,7 @@ object SessionPrefs { resolutionChosen(context, SessionService.MODE_DESKTOP)) SessionService.MODE_DESKTOP else prefMode(mode) - fun pipAutoEnter(context: Context): Boolean = prefs(context).getBoolean("pipAutoEnter", false) + fun pipAutoEnter(context: Context): Boolean = prefs(context).getBoolean("pipAutoEnter", true) fun setPipAutoEnter(context: Context, enabled: Boolean) { prefs(context).edit().putBoolean("pipAutoEnter", enabled).apply() @@ -1238,7 +1238,8 @@ object SessionPrefs { } fun suspendPolicy(context: Context, mode: String): String = - prefs(context).getString("suspendPolicy.${prefMode(mode)}", SUSPEND_MANUAL) + prefs(context).getString("suspendPolicy.${prefMode(mode)}", + if (mode == SessionService.MODE_STEAM) SUSPEND_NATIVE else SUSPEND_MANUAL) ?.let { if (it == LEGACY_SUSPEND_DOWNLOADS) SUSPEND_AUTO else it } ?.takeIf { it in setOf(SUSPEND_AUTO, SUSPEND_NATIVE, SUSPEND_MANUAL, SUSPEND_NEVER) } ?.let { if (mode != SessionService.MODE_STEAM && it == SUSPEND_NATIVE) SUSPEND_AUTO else it } diff --git a/app/src/test/java/com/droiddeck/launcher/session/SessionBackgroundPrefsTest.kt b/app/src/test/java/com/droiddeck/launcher/session/SessionBackgroundPrefsTest.kt index 0daf6f99b7..f7ba39b65f 100644 --- a/app/src/test/java/com/droiddeck/launcher/session/SessionBackgroundPrefsTest.kt +++ b/app/src/test/java/com/droiddeck/launcher/session/SessionBackgroundPrefsTest.kt @@ -18,8 +18,9 @@ class SessionBackgroundPrefsTest { context.getSharedPreferences("session", Context.MODE_PRIVATE).edit().clear().commit() } - @Test fun nativeIsOptInAndDoesNotChangeDesktopOrExistingPolicies() { - assertEquals(SessionPrefs.SUSPEND_MANUAL, SessionPrefs.suspendPolicy(context, "steam")) + @Test fun nativeIsTheSteamDefaultWithoutChangingOtherModesOrSavedPolicies() { + assertEquals(SessionPrefs.SUSPEND_NATIVE, SessionPrefs.suspendPolicy(context, "steam")) + assertEquals(SessionPrefs.SUSPEND_MANUAL, SessionPrefs.suspendPolicy(context, SessionService.MODE_RUN)) for (policy in listOf(SessionPrefs.SUSPEND_AUTO, SessionPrefs.SUSPEND_MANUAL, SessionPrefs.SUSPEND_NEVER, SessionPrefs.SUSPEND_NATIVE)) { SessionPrefs.setSuspendPolicy(context, "steam", policy) @@ -28,6 +29,14 @@ class SessionBackgroundPrefsTest { } } + @Test fun automaticPipDefaultsOnAndHonorsSavedChoices() { + assertEquals(true, SessionPrefs.pipAutoEnter(context)) + SessionPrefs.setPipAutoEnter(context, false) + assertEquals(false, SessionPrefs.pipAutoEnter(context)) + SessionPrefs.setPipAutoEnter(context, true) + assertEquals(true, SessionPrefs.pipAutoEnter(context)) + } + @Test fun directGamesUseAutoWithoutOverwritingSteamsNativeChoice() { SessionPrefs.setSuspendPolicy(context, SessionService.MODE_STEAM, SessionPrefs.SUSPEND_NATIVE) assertEquals(SessionPrefs.SUSPEND_AUTO, SessionPrefs.suspendPolicy(context, SessionService.MODE_RUN))