feat(input): pass held Back through as Steam QAM

This commit is contained in:
Kurt Himebauch committed 2026-10-26 12:49:51 -04:00
1 parent 53d643dd00
commit dde1a55d00
8 files changed
+285 -3

No files matched your search

@@ -0,0 +1,90 @@
package com.droiddeck.launcher.input
import android.view.KeyEvent
import org.junit.Assert.*
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [34], manifest = Config.NONE)
class BackQamInputTest {
private val changes = mutableListOf<Boolean>()
private val input = BackQamInput(changes::add)
@Test fun aHoldAndItsRepeatsProduceOnePressAndOneRelease() {
assertTrue(send(KeyEvent.ACTION_DOWN))
for (repeat in 1..10) assertTrue(send(KeyEvent.ACTION_DOWN, repeat = repeat))
assertEquals(listOf(true), changes)
assertTrue(send(KeyEvent.ACTION_UP))
assertEquals(listOf(true, false), changes)
}
@Test fun otherButtonsAndSelectPassThroughWhileBackIsHeld() {
send(KeyEvent.ACTION_DOWN)
for (code in listOf(KeyEvent.KEYCODE_BUTTON_X, KeyEvent.KEYCODE_BUTTON_SELECT)) {
for (action in listOf(KeyEvent.ACTION_DOWN, KeyEvent.ACTION_UP)) {
assertFalse(input.onKeyEvent(KeyEvent(action, code), true))
}
}
assertEquals(listOf(true), changes)
send(KeyEvent.ACTION_UP)
assertEquals(listOf(true, false), changes)
}
@Test fun disabledRoutingPreservesBackNavigation() {
assertFalse(send(KeyEvent.ACTION_DOWN, enabled = false))
assertFalse(send(KeyEvent.ACTION_UP, enabled = false))
assertTrue(changes.isEmpty())
}
@Test fun losingFocusReleasesQamAndConsumesTheLateRelease() {
send(KeyEvent.ACTION_DOWN)
input.cancel()
input.cancel()
assertTrue(send(KeyEvent.ACTION_DOWN, repeat = 1, enabled = false))
assertTrue(send(KeyEvent.ACTION_UP, enabled = false))
assertEquals(listOf(true, false), changes)
assertFalse(send(KeyEvent.ACTION_UP, enabled = false))
}
@Test fun openingAnOverlayReleasesQamBeforeRoutingItsNextKey() {
send(KeyEvent.ACTION_DOWN)
assertFalse(input.onKeyEvent(KeyEvent(KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_BUTTON_B), false))
assertTrue(send(KeyEvent.ACTION_UP, enabled = false))
assertEquals(listOf(true, false), changes)
}
@Test fun repeatsAfterCancellationCannotReassertQam() {
send(KeyEvent.ACTION_DOWN)
input.cancel()
assertTrue(send(KeyEvent.ACTION_DOWN, repeat = 1))
assertEquals(listOf(true, false), changes)
assertTrue(send(KeyEvent.ACTION_DOWN))
assertTrue(send(KeyEvent.ACTION_UP))
assertEquals(listOf(true, false, true, false), changes)
}
@Test fun cancelledReleaseStillReleasesQam() {
send(KeyEvent.ACTION_DOWN)
assertTrue(input.onKeyEvent(KeyEvent(0, 100, KeyEvent.ACTION_UP, KeyEvent.KEYCODE_BACK,
0, 0, 4, 0, KeyEvent.FLAG_CANCELED), true))
assertEquals(listOf(true, false), changes)
}
@Test fun removingOneDeviceDoesNotReleaseAnotherDevicesHold() {
send(KeyEvent.ACTION_DOWN, device = 4)
send(KeyEvent.ACTION_DOWN, device = 5)
input.onDeviceRemoved(4)
assertTrue(changes.last())
send(KeyEvent.ACTION_UP, device = 5)
assertFalse(changes.last())
send(KeyEvent.ACTION_DOWN, device = 4)
input.onDeviceRemoved(4)
assertFalse(changes.last())
}
private fun send(action: Int, repeat: Int = 0, device: Int = 4, enabled: Boolean = true) =
input.onKeyEvent(KeyEvent(0, 100, action, KeyEvent.KEYCODE_BACK, repeat, 0, device, 0), enabled)
}
@@ -0,0 +1,115 @@
package com.droiddeck.launcher.input
import android.os.Handler
import com.droiddeck.launcher.session.SessionState
import java.nio.file.Files
import java.time.Duration
import org.junit.After
import org.junit.Assert.*
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.Shadows.shadowOf
import org.robolectric.annotation.Config
import org.robolectric.util.ReflectionHelpers
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [34], manifest = Config.NONE, instrumentedPackages = ["com.droiddeck.launcher.input.FakeInputWriter"],
shadows = [JoyConPadTest.RecordingWriter::class])
class PadBridgeQamTest {
private val directory = Files.createTempDirectory("qam-pad").toFile()
private lateinit var bridge: PadBridge
@Before fun start() {
JoyConPadTest.RecordingWriter.pads.clear()
ReflectionHelpers.setStaticField(FakeInputWriter::class.java, "padType", FakeInputWriter.PAD_TYPE_DECK)
SessionState.deckPad = true
bridge = PadBridge(directory)
assertTrue(bridge.start())
}
@After fun stop() {
bridge.stop()
SessionState.deckPad = false
directory.deleteRecursively()
}
@Test fun onlyNativeQamControllersAcceptAHeldBack() {
for (type in listOf(-1, FakeInputWriter.PAD_TYPE_DECK, FakeInputWriter.PAD_TYPE_STEAM,
FakeInputWriter.PAD_TYPE_XBOX, FakeInputWriter.PAD_TYPE_DS4, FakeInputWriter.PAD_TYPE_DUALSENSE)) {
ReflectionHelpers.setStaticField(FakeInputWriter::class.java, "padType", type)
val supported = type <= FakeInputWriter.PAD_TYPE_STEAM
assertEquals(supported, bridge.canHoldQam())
bridge.setBackQamPressed(true)
bridge.applyExternal({}, false)
assertEquals(supported, pad().isDown(PadState.QAM))
bridge.setBackQamPressed(false)
}
SessionState.deckPad = false
assertFalse(bridge.canHoldQam())
}
@Test fun qamAndOtherButtonsShareAReportUntilBackIsReleased() {
bridge.setBackQamPressed(true)
advanceTime()
bridge.applyExternal({ it.press(PadState.X, true); it.press(PadState.SELECT, true) }, true)
assertTrue(pad().isDown(PadState.QAM))
assertTrue(pad().isDown(PadState.X))
assertTrue(pad().isDown(PadState.SELECT))
bridge.setBackQamPressed(false)
assertFalse(pad().isDown(PadState.QAM))
assertTrue(pad().isDown(PadState.X))
assertTrue(pad().isDown(PadState.SELECT))
}
@Test fun touchQamAndBackHaveIndependentReleases() {
bridge.setBackQamPressed(true)
bridge.setSystemButtons(false, true)
bridge.setBackQamPressed(false)
assertTrue(pad().isDown(PadState.QAM))
bridge.setBackQamPressed(true)
bridge.setSystemButtons(false, false)
assertTrue(pad().isDown(PadState.QAM))
bridge.setBackQamPressed(false)
assertFalse(pad().isDown(PadState.QAM))
}
@Test fun aTimedQamTapCannotReleaseAHeldBack() {
bridge.triggerQam()
bridge.setBackQamPressed(true)
advanceTime()
assertTrue(pad().isDown(PadState.QAM))
bridge.setBackQamPressed(false)
assertFalse(pad().isDown(PadState.QAM))
}
@Test fun releasingAllOrStoppingClearsTheHold() {
bridge.setBackQamPressed(true)
bridge.releaseAll()
assertFalse(pad().isDown(PadState.QAM))
bridge.setBackQamPressed(true)
bridge.stop()
bridge.start()
bridge.applyExternal({}, false)
assertFalse(pad().isDown(PadState.QAM))
}
@Test fun disablingTheBuiltinPadClearsAndRejectsTheHold() {
bridge.setBackQamPressed(true)
bridge.setBuiltinPad(false)
assertFalse(bridge.canHoldQam())
assertFalse(pad().isDown(PadState.QAM))
bridge.setBackQamPressed(true)
bridge.setBuiltinPad(true)
bridge.applyExternal({}, false)
assertFalse(pad().isDown(PadState.QAM))
}
private fun pad() = requireNotNull(JoyConPadTest.RecordingWriter.pads[0])
private fun advanceTime() {
val handler = ReflectionHelpers.getStaticField<Handler>(PadBridge::class.java, "chordHandler")
shadowOf(handler.looper).idleFor(Duration.ofSeconds(2))
}
}