From e25fa5429bbf67f1a26806d339e37328c973db11 Mon Sep 17 00:00:00 2001 From: The412Banner <205237651+The412Banner@users.noreply.github.com> Date: Sat, 10 Oct 2026 13:32:12 -0400 Subject: [PATCH] Windows components: leave out the OpenAL setup program, a twin of the DLL copy that installs here (#528) --- .../java/com/droiddeck/launcher/session/WinComponents.kt | 7 +++++-- .../droiddeck/launcher/session/WinComponentsSupportTest.kt | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt b/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt index 18385c8d40..9151c95263 100644 --- a/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt +++ b/app/src/main/java/com/droiddeck/launcher/session/WinComponents.kt @@ -118,8 +118,11 @@ object WinComponents { (step.action == "install_msi" || listOf(step.str("file_name"), step.str("url").substringBefore('?')) .any { it.endsWith(".msi", ignoreCase = true) || it.endsWith(".exe", ignoreCase = true) }) - /** Catalog entries nothing here can use: the IE8 security update patches a browser no prefix has. */ - private val POINTLESS = setOf("ie8_kb2936068") + /** + * Catalog entries nothing here can use: the IE8 security update patches a browser no prefix + * has, and the OpenAL setup program is a twin of oalinst_dll, which copies the same DLLs. + */ + private val POINTLESS = setOf("ie8_kb2936068", "oalinst") private fun protonProvides(name: String): Boolean = name in PROTON_PROVIDES || name in POINTLESS || name.startsWith("mono-") diff --git a/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt b/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt index 945d7a40ee..9ec5f12d82 100644 --- a/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt +++ b/app/src/test/java/com/droiddeck/launcher/session/WinComponentsSupportTest.kt @@ -96,5 +96,6 @@ class WinComponentsSupportTest { assertEquals(Support.UNSUPPORTED, support(component("powershell", step("copy_file", "file_name" to "profile.ps1", "dest" to "win64")))) assertEquals(Support.UNSUPPORTED, support(component("VulkanRT", step("install_exe", "url" to "$base/VulkanRT.exe")))) assertEquals(Support.UNSUPPORTED, support(component("ie8_kb2936068", step("install_exe", "url" to "$base/ie8_kb2936068.exe")))) + assertEquals(Support.UNSUPPORTED, support(component("oalinst", step("install_exe", "url" to "$base/oalinst.exe")))) } }