From e31a6eef1838aa83c2e29d86991c967b78870e82 Mon Sep 17 00:00:00 2001 From: openMali Date: Sun, 1 Nov 2026 17:24:06 +0800 Subject: [PATCH] local: hide unreadable Mali HUD GPU metrics --- app/build.gradle | 2 +- .../com/droiddeck/launcher/hud/DroidDeckHudView.kt | 11 +++++++---- .../java/com/droiddeck/launcher/hud/MangoReadings.kt | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 1f4d02ca91..a4b037b5cb 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -134,7 +134,7 @@ android { applicationId "com.droiddeck.launcher" minSdkVersion 26 targetSdkVersion 28 - versionCode 20 + versionCode 21 versionName "0.6.7-dnsfix" buildConfigField "String", "BUILD_LABEL", "\"${escapedBuildLabel}\"" buildConfigField "String", "SOURCE_COMMIT", "\"${sourceCommit}\"" diff --git a/app/src/main/java/com/droiddeck/launcher/hud/DroidDeckHudView.kt b/app/src/main/java/com/droiddeck/launcher/hud/DroidDeckHudView.kt index a60846ad7a..eec9142481 100644 --- a/app/src/main/java/com/droiddeck/launcher/hud/DroidDeckHudView.kt +++ b/app/src/main/java/com/droiddeck/launcher/hud/DroidDeckHudView.kt @@ -741,6 +741,9 @@ class DroidDeckHudView(context: Context) : View(context) { contentW = max(contentW, pad + w + pad) } + private fun hasGpuStats(s: HudMetrics.Snapshot): Boolean = + s.gpuPercent != null || s.gpuTempC != null || s.gpuClockMhz != null + private fun buildFull(s: HudMetrics.Snapshot) { val rowPx = sp(12f); val unitPx = rowPx * 0.62f val pad = sp(10f); val lineGap = sp(4f); val lvGap = sp(8f) @@ -752,7 +755,7 @@ class DroidDeckHudView(context: Context) : View(context) { rows.add(HudRow(Span("DISP", colDisp, rowPx), listOf(Span(displayServer, colValue, rowPx)))) if (hdrState != DroidDeckHudHdr.NONE) rows.add(HudRow(Span("HDR", colHdr, rowPx), hdrValue(rowPx))) - if (showGPU) { + if (showGPU && hasGpuStats(s)) { val v = ArrayList() v += numUnit(s.gpuPercent?.toString(), "%", rowPx, unitPx) if (showGpuTemp) tempSpans(s.gpuTempC, HudMetrics.TempSensor.GPU, rowPx, unitPx) @@ -846,7 +849,7 @@ class DroidDeckHudView(context: Context) : View(context) { "${fmt1(fpsAvg)} avg · ${lowText(lows.low1Fps) ?: "—"} 1%", false)) if (showFPS) tiles.add(Tile("FRAME", colDim, numUnit(fmt1(1000f / max(fpsNow, 1f)), "ms", valPx, unitPx), "${fmt1(graphMinMs)} – ${fmt1(graphMaxMs)}", false)) - if (showGPU) tiles.add(Tile("GPU", colGpu, numUnit(s.gpuPercent?.toString(), "%", valPx, unitPx), + if (showGPU && hasGpuStats(s)) tiles.add(Tile("GPU", colGpu, numUnit(s.gpuPercent?.toString(), "%", valPx, unitPx), if (showGpuTemp && s.gpuTempC != null) HudMetrics.formatTemp(s.gpuTempC.toFloat(), tempDisplay, false) else s.gpuClockMhz?.let { "${it}MHz" }, false)) if (showCPU) tiles.add(Tile("CPU", colCpu, numUnit(s.cpuPercent?.toString(), "%", valPx, unitPx), @@ -938,7 +941,7 @@ class DroidDeckHudView(context: Context) : View(context) { val gpuName = if (showGpuModel && gpuNameText().isNotBlank()) gpuModelSpans(stkPx, colDim, compact = true) else null run { val l = ArrayList() - if (showGPU) { l += Span("GPU ${s.gpuPercent ?: "—"}%", colGpu, stkPx) } + if (showGPU && s.gpuPercent != null) { l += Span("GPU ${s.gpuPercent}%", colGpu, stkPx) } if (showCPU) { if (l.isNotEmpty()) l += Span(" · ", colDim, stkPx); l += Span("CPU ${s.cpuPercent ?: "—"}%", colCpu, stkPx) } if (l.isNotEmpty()) stack.add(l) } @@ -1133,7 +1136,7 @@ class DroidDeckHudView(context: Context) : View(context) { val left = ArrayList() if (showGpuModel && gpuNameText().isNotBlank()) left.add(HudRow(Span("GPU", colGpu, rowPx), gpuModelSpans(rowPx, colValue))) - if (showGPU) { + if (showGPU && hasGpuStats(s)) { val v = ArrayList() v += numUnit(s.gpuPercent?.toString(), "%", rowPx, unitPx) if (showGpuTemp) tempSpans(s.gpuTempC, HudMetrics.TempSensor.GPU, rowPx, unitPx) diff --git a/app/src/main/java/com/droiddeck/launcher/hud/MangoReadings.kt b/app/src/main/java/com/droiddeck/launcher/hud/MangoReadings.kt index 828bcc0f5a..a91cff5c33 100644 --- a/app/src/main/java/com/droiddeck/launcher/hud/MangoReadings.kt +++ b/app/src/main/java/com/droiddeck/launcher/hud/MangoReadings.kt @@ -103,7 +103,7 @@ internal class MangoReadings(private val sessionDir: File, private val rootDir: } /** The KGSL total DroidDeck shares with the session (GpuMemComponent). */ - fun vramBytes(): Long? = fresh(File(rootDir, VRAM_FILE), VRAM_FRESH_MS)?.let(::readLong) + fun vramBytes(): Long? = fresh(File(rootDir, VRAM_FILE), VRAM_FRESH_MS)?.let(::readLong)?.takeIf { it > 0 } /** BAT* under the session's power_supply (BatteryComponent): no watts while charging, full or unknown. */ fun battery(): Battery? {