From 2b272c81c130a0bee37c6abdb065917bfa50e0e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leon=20B=C3=B6ttger?= Date: Tue, 9 Sep 2025 11:14:29 +0200 Subject: [PATCH] Refactoring --- NearbyShare/Util/Helpers.swift | 6 +++--- NearbyShare/Util/SaveFilesManager.swift | 2 +- QuickDrop/AppDelegate.swift | 4 ++-- QuickDrop/Plus/PlusView.swift | 6 +++--- QuickDrop/Settings.swift | 4 ++-- QuickDrop/View/TutorialView.swift | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/NearbyShare/Util/Helpers.swift b/NearbyShare/Util/Helpers.swift index cf03be9..13c426a 100644 --- a/NearbyShare/Util/Helpers.swift +++ b/NearbyShare/Util/Helpers.swift @@ -110,11 +110,11 @@ extension String { } -public func isPlusVersion() -> Bool { +public func fullVersion() -> Bool { #if os(macOS) // Enable full functionality if app distributed directly - return DistributionDetector.isDirectDistributionEnabled || Settings.shared.isPlusVersion + return Settings.shared.gotPlus || DistributionDetector.isDirectDistributionEnabled #else // iOS return true @@ -123,5 +123,5 @@ public func isPlusVersion() -> Bool { public func isFileTransferRestricted() -> Bool { - (!isPlusVersion() && Settings.shared.incomingTransmissionCount > 1) + (!fullVersion() && Settings.shared.incomingTransmissionCount > 1) } diff --git a/NearbyShare/Util/SaveFilesManager.swift b/NearbyShare/Util/SaveFilesManager.swift index e51ce44..4996581 100644 --- a/NearbyShare/Util/SaveFilesManager.swift +++ b/NearbyShare/Util/SaveFilesManager.swift @@ -59,7 +59,7 @@ public class SaveFilesManager { public func movePendingFilesToTarget() { - if isPlusVersion() { + if fullVersion() { do { let fileManager = FileManager.default let files = try fileManager.contentsOfDirectory(at: tempDirectory, includingPropertiesForKeys: nil) diff --git a/QuickDrop/AppDelegate.swift b/QuickDrop/AppDelegate.swift index 0f419bc..cc6a786 100644 --- a/QuickDrop/AppDelegate.swift +++ b/QuickDrop/AppDelegate.swift @@ -84,9 +84,9 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele // user installed the app before the IAP was implemented, grant the plus version if !Settings.shared.isEligibleForIap { log("[AppDelegate] Granting QuickDrop+ for old user") - Settings.shared.isPlusVersion = true + Settings.shared.gotPlus = true } else { - if !isPlusVersion() { + if !fullVersion() { log("[AppDelegate] New user - QuickDrop+ not available") } else { diff --git a/QuickDrop/Plus/PlusView.swift b/QuickDrop/Plus/PlusView.swift index 81acbed..78dbedb 100644 --- a/QuickDrop/Plus/PlusView.swift +++ b/QuickDrop/Plus/PlusView.swift @@ -115,7 +115,7 @@ struct PlusView: View { if success { log("[LUI] Restored purchases successfully") withAnimation { - settings.isPlusVersion = true + settings.gotPlus = true } boughtSuccessAlert = true } else { @@ -146,7 +146,7 @@ struct PlusView: View { if success { withAnimation { - settings.isPlusVersion = true + settings.gotPlus = true } boughtSuccessAlert = true @@ -193,7 +193,7 @@ struct PlusView: View { case .success(_): withAnimation { - settings.isPlusVersion = true + settings.gotPlus = true boughtSuccessAlert = true warning = false } diff --git a/QuickDrop/Settings.swift b/QuickDrop/Settings.swift index 91683bf..8d23d68 100644 --- a/QuickDrop/Settings.swift +++ b/QuickDrop/Settings.swift @@ -16,8 +16,8 @@ class Settings: ObservableObject { // MARK: - Published UserDefaults Backed Properties - @Published var isPlusVersion = UserDefaults.standard.bool(forKey: UserDefaultsKeys.plusVersion.rawValue) - { didSet { UserDefaults.standard.set(isPlusVersion, forKey: UserDefaultsKeys.plusVersion.rawValue) }} + @Published var gotPlus = UserDefaults.standard.bool(forKey: UserDefaultsKeys.plusVersion.rawValue) + { didSet { UserDefaults.standard.set(gotPlus, forKey: UserDefaultsKeys.plusVersion.rawValue) }} @Published var automaticallyAcceptFiles: Bool = UserDefaults.standard.bool(forKey: UserDefaultsKeys.automaticallyAcceptFiles.rawValue) diff --git a/QuickDrop/View/TutorialView.swift b/QuickDrop/View/TutorialView.swift index 87dff6b..54a2a2a 100644 --- a/QuickDrop/View/TutorialView.swift +++ b/QuickDrop/View/TutorialView.swift @@ -40,7 +40,7 @@ struct TutorialView: View { } .buttonStyle(.plain) - if !settings.isPlusVersion { + if !settings.gotPlus { Button { openPlus() } label: {