mirror of
https://github.com/Corfirean/coa-server-manager.git
synced 2026-11-22 03:25:56 +00:00
- Enforce fail-closed backend resolution in LocalBackend::info (unknown ruleset = error). - Implement strict three-space isolation (Wildcard != CoA != Reborn) across canonical store, host mappings, and collections. - Isolate collection namespaces (wildcard:appearance, wildcard:vanity) and reject cross-ruleset collections in claim and import. - Enforce Control Protocol v2 ruleset verification on TransferOffer, TransferCommit, and Claimed response. - Route Direct Ingress and Relay Link dynamically according to realm world port (8085 for CoA, 8086 for Wildcard). - Add runtime session attack rejection test suite (cross-ruleset session offers, checkpoints, owner acks, server IDs). - Verify end-to-end Wildcard session lifecycle and documentation updates.
13 KiB
13 KiB
Multi-Ruleset Realms & Portable Characters: Architectural Audit
This audit evaluates the architecture to support three independent, strictly isolated gameplay rulesets:
- Conquest of Azeroth (
coa) - Wildcard (
wildcard) - Warcraft Reborn (
reborn)
Date: October 2026
Status: Updated for MR2 Gate (Wildcard Vertical Slice Completed)
1. Executive Summary: Baseline vs Implemented vs Planned
1.1 Baseline Discovered Before Implementation (v0.7.0 Master)
realms::ModedefinedCoa,Wildcard, andRebornfor local realm profiles and database switching (acore_characters,acore_characters_wildcard,acore_characters_reborn).- The Portable Characters and Public Realm Registry subsystems were designed almost entirely around
coa, with experimental/preliminary partial awareness ofwildcard, and an explicit blocking error forreborn(ruleset_of: "Portable characters are not supported on Warcraft Reborn realms yet"). - SQLite
charactertable hadCHECK (ruleset IN ('coa', 'wildcard')), which hard-failed on anyrebornrow. - SQLite
collectiontable was keyed by(profile_id, kind)withoutruleset, causing cross-ruleset collision. Request::TransferOffer,PortableSessionStarted,PortableCheckpoint,OwnerAck,CollectionObserved,CollectionState, andCollectionAcklacked explicit protocol-levelrulesetfields or version negotiation.- Collection validation used unsafe prefix checks (
kind.starts_with(ruleset)), permitting prefix confusion attacks. Ruleset::schema(kind)contained a fallback_ => "acore_characters", routing unknown database kinds to CoA.
1.2 Implemented in MR1, MR1.1, and MR2
- Authoritative Ruleset Enum:
Ruleset(Coa,Wildcard,Reborn) unified acrosscoa-core,coa-registry-proto,coa-control-proto, and frontend models. - Transactional SQLite Migration 009: Migrates released v0.7.x databases by recreating both
collection(composite keyprofile_id, ruleset, kind) andcharacter(CHECK constraint allowing'coa', 'wildcard', 'reborn') with FK toggles ensuring zero child row loss. - Fail-Closed Realm Backend: Removed unsafe
unwrap_or(Ruleset::Coa)inLocalBackend::info(). Unreadable, unknown, or broken realms fail closed immediately with error rather than falling back to CoA. - Control Protocol 2 & Strict Envelopes:
CONTROL_PROTOCOL_VERSION = 2.Request::TransferOfferrequires explicitruleset: String.Response::Claimedreturns explicitruleset: String.- Claiming and commit verify that the claimed envelope ruleset matches the decoded payload ruleset and matches target realm ruleset.
HostTransferstoresrulesetin SQLite;transfer_commitverifies that canonical JSON hash and ruleset match the offer and destination realm before writing to disk.
- Session Protocol 3 & Ruleset Enforcement:
SESSION_PROTOCOL_VERSION = 3andCOLLECTION_PROTOCOL_VERSION = 2.SessionOffer,PortableSessionStarted,PortableCheckpoint, andOwnerAckrequire explicitruleset.- Any mismatch between character ruleset, offer ruleset, session ruleset, or checkpoint ruleset rejects immediately with zero DB mutation and zero canonical revision advance.
- Wildcard Collections Isolation:
wildcard:appearanceandwildcard:vanityisolated fromcoa:appearanceandcoa:vanity.- Cross-ruleset collection merges strictly rejected by
carried_kind_for(kind, ruleset).
- Database Routing & Three-Space Isolation:
- Canonical SQL routes through
Db::query()andrealm_schematoacore_characters_wildcardandacore_world_wildcard. - Multiple characters sharing local GUIDs on distinct server IDs (
srv-1:coa,srv-1:wildcard,srv-1:reborn) coexist with zero collision in character mappings and item mappings. - Mutating Wildcard character state, revisions, or collections leaves CoA and Reborn states 100% byte-for-byte untouched.
- Canonical SQL routes through
- Direct & Relay Routing for Wildcard:
world_port_for_modedynamically determines active world port (8085 for primary CoA, 8086 for secondary Wildcard in simultaneous mode).- Direct Ingress proxy and Relay link dynamically route to the correct realm world port.
- Direct Ingress Auth rewrite replaces internal realm list address with external mapped Wildcard port (e.g. 48086) and never advertises CoA port 8085.
1.3 Still Planned (Subsequent Milestones)
- MR3 (Warcraft Reborn Vertical Slice): Unlocking
ruleset_offor Reborn, import/export adapters, and live verification. - MR4 (Multi-Realm Publication UI & Registry): Simultaneous publication of multiple RealmIds from a single Manager host under distinct identities and keypairs.
2. Inventory of Current Subsystem Locations & Representation
2.1 Realm Profiles & Databases (crates/coa-core/src/realms.rs, db.rs)
| Ruleset / Mode | Realm ID | Character Database | World Database | Auth Database | Configuration Profile |
|---|---|---|---|---|---|
| CoA | 1 |
acore_characters |
acore_world |
acore_auth |
Settings/realm-profiles/coa.json |
| Wildcard | 2 |
acore_characters_wildcard |
acore_world_wildcard |
acore_auth |
Settings/realm-profiles/wildcard.json |
| Warcraft Reborn | 3 |
acore_characters_reborn |
acore_world_reborn |
acore_auth |
Settings/realm-profiles/reborn.json |
- Simultaneous Startup Policy:
- CoA + Wildcard simultaneous is supported via
secondary_world_portandsecondary_ra_port(CoA on primary world port 8085, Wildcard on secondary e.g. 8086). - Warcraft Reborn simultaneous startup is strictly unsupported (
s.simultaneous && s.active == Mode::RebornreturnsError::Invalid("Simultaneous startup supports CoA and Wildcard only.")).
- CoA + Wildcard simultaneous is supported via
- Worldserver Capability Detection:
- Executable inspected directly (
Core/worldserver.exeon Windows repack,Core/worldserveron Linux Docker). - Wildcard detected by byte pattern:
b"Wildcard synergy settings". - Reborn detected by byte pattern:
b"Warcraft Reborn class spells are unavailable".
- Executable inspected directly (
2.2 Ruleset Enumeration & Protocols
crates/coa-core/src/realms.rs:enum Mode { Coa, Wildcard, Reborn }crates/coa-core/src/portable/model.rs:enum Ruleset { Coa, Wildcard }(LacksReborn)crates/coa-registry-proto/src/caps.rs:enum Ruleset { Coa, Wildcard }(LacksReborn)services/coa-registry/src/pg.rs:ruleset: match ruleset.as_str() { "coa" => Ruleset::Coa, "wildcard" => Ruleset::Wildcard }(LacksReborn)src/lib/browse.ts:export type Ruleset = "coa" | "wildcard";(Lacksreborn)
2.3 Public Registry Model & Publication
crates/coa-core/src/realm_registry/settings.rs:RegistrySettings.realmsis aBTreeMap<String, PublishConfig>.src/screens/PublishCard.tsx: UseslocalId = 'srv-' + serverId.- Host vs Published Realm Identity Issue:
One installation (
InstallMeta.id) hosting multiple rulesets currently shareslocalId = srv-<id>. If the host switches active realm from CoA to Wildcard, or publishes both under simultaneous mode,srv-<id>cannot represent both published realms distinctly. Each published realm must possess its own distinct local realm identity (srv-<id>-<ruleset>orsrv-<id>:<ruleset>), uniqueRealmId(UUIDv7), and independent Ed25519 signing key inKeyStore.
2.4 Canonical Portable Storage (crates/coa-core/src/portable/store.rs)
- SQLite schema (
%LOCALAPPDATA%\CoAServerManager\portable\portable.db):character:ruleset TEXT NOT NULL CHECK (ruleset IN ('coa', 'wildcard'))-> Must be updated to allow'reborn'.collection:PRIMARY KEY (profile_id, kind)-> Unpartitioned by ruleset! Must become(profile_id, ruleset, kind).character_server_mapping:PRIMARY KEY (character_id, server_id), UNIQUE (server_id, local_guid).item_mapping:PRIMARY KEY (character_id, server_id, portable_item_id).pet_mapping:PRIMARY KEY (character_id, server_id, portable_pet_id).owner_session:character_id,server_id,c0_revision,b0_hash.host_session:character_id,server_id,local_guid.
2.5 Remote Transfer & Control Protocol (crates/coa-control-proto/src/app.rs)
Request::TransferOffer:{ transfer_id, character_id, canonical_revision, content_hash, total_size, collections }-> Missingruleset. An offer must bindruleset: Rulesetso the host can reject before chunk transport or preflight if target realm mismatch occurs.Request::TransferCommit: Currently relies on cached transfer metadata.Response::TransferCommitted: Returns session parameters.
2.6 Runtime Sessions & Checkpoints (crates/coa-core/src/portable/session/protocol.rs)
PortableSessionStarted:{ protocol_version, session_id, character_id, server_id, base_canonical_revision, baseline_generation, b0, content_hash, progression }-> Missingruleset.PortableCheckpoint:{ protocol_version, session_id, character_id, server_id, base_canonical_revision, sequence, final_checkpoint, realm_snapshot, content_hash, pin }-> Missingruleset.OwnerAck:{ protocol_version, session_id, sequence, outcome, canonical_revision, canonical_hash, owned_items, owned_pets, canonical, next_session, pin }-> Must verify ruleset match in owner session state before applying 3-way merge.
2.7 Direct & Relay Routing
- Direct Ingress Proxy (
crates/coa-core/src/control/direct_ingress.rs): Listens on direct auth and world ports, interceptsCMD_REALM_LISTfrom the Auth server, and rewrites the realm entry address to the public direct world IP and port. When multiple realms are active (simultaneous CoA + Wildcard), each published realm must target its respective local world port (ports.worldvss.secondary_world_port). - Relay Hub & Allocations (
services/coa-relay/,crates/coa-core/src/control/relay_link.rs): Relay allocation requests are authenticated by Ed25519 realm key. Allocations bind a short-lived token to an isolated auth/world stream pair.
3. Strict Isolation Invariants
The fundamental architectural invariant is:
\text{portable\_character.ruleset} == \text{target\_realm.ruleset}
On mismatch:
- Zero DB Mutation: No rows written to
acore_characters*,item_instance, or modules. - Zero Session Creation: No
host_sessionorowner_sessionrecord opened or armed. - Zero Mapping Creation: No entry in
character_server_mapping,item_mapping, or pet mapping. - Zero Collection Merge: No union into collections of a different ruleset.
- Zero Canonical Revision Change: Canonical revision remains unchanged; reject with explicit mismatch error.
- No Implicit Conversion: Never attempt conversion, level projection across rulesets, or guessing missing rulesets.
4. Execution Plan & Phasing
- Authoritative RulesetId Abstraction (Section 3):
- Normalize
RulesetId/ unified enum acrosscoa-core,coa-registry-proto,coa-control-proto, and TypeScript models. - Values:
coa,wildcard,reborn.
- Normalize
- Partitioning Collections & Canonical Storage (Sections 8, 11):
- Add SQLite migration
009_multiruleset_collections.sqlpartitioning collections by(profile_id, ruleset, kind)and expandingcharactertable ruleset constraint to allow'reborn'. - Update
StoreAPIs to acceptruleset: Ruleseton character operations and collection operations.
- Add SQLite migration
- Registry & Multi-Realm Publication on One Host (Sections 5, 6, 26):
- Partition published realm keys:
srv-<serverId>:<ruleset>. - Each published realm receives its own
RealmId, Ed25519 key, heartbeat, status, and capabilities. - Registry PostgreSQL migration for
rebornruleset check.
- Partition published realm keys:
- Remote Transfer Envelope & Session Binding (Sections 14, 22):
- Add
rulesettoTransferOffer,PortableSessionStarted,PortableCheckpoint. - Enforce 4-way equality: envelope ruleset == payload ruleset == published realm ruleset == host target DB ruleset.
- Add
- Wildcard Vertical Slice (Section 15):
- End-to-end testing of Wildcard claiming, transfer, session, checkpoint, and collection partitioning.
- Verify negative cross-ruleset attack scenarios.
- Warcraft Reborn Audit & Vertical Slice (Sections 18, 19):
- Complete
docs/REBORN_PORTABLE_AUDIT.md. - Wire Reborn adapter into the unified engine and verify vertical slice.
- Complete
- UI Multi-Ruleset Filtering (Sections 7, 27):
- Server browser ruleset tabs/filters (
All,Conquest of Azeroth,Wildcard,Warcraft Reborn). - Portable character picker filtered by target realm ruleset.
- Server browser ruleset tabs/filters (
- Regression & Cross-Ruleset Attack Test Suite (Section 29):
- Comprehensive unit and integration attack tests ensuring strict isolation.