From 297426c595b7b681d537d92bc39f2e4b593e9853 Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Fri, 6 Nov 2026 22:21:51 -0800 Subject: [PATCH 01/19] Export: color profile text states which formats are tagged and that CMYK PDF is DeviceCMYK The export tool and command descriptions, docs/mcp.md and the file-format table said PDF is always sRGB, that sRGB JPG is untagged and that every exported file is tagged with its profile. RGB PDF is sRGB and PDF with cmyk is DeviceCMYK; JPG embeds an ICC profile for sRGB and Display P3; WebP embeds one for Display P3 only. The JPG quality (1 to 100, default 90) now has one row in the format table. --- crates/engine/src/cmd/file.rs | 2 +- crates/mcp/src/tools.rs | 2 +- docs/file-format-parity.md | 7 +++---- docs/mcp.md | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/crates/engine/src/cmd/file.rs b/crates/engine/src/cmd/file.rs index 0ed12b8d3..e52960d43 100644 --- a/crates/engine/src/cmd/file.rs +++ b/crates/engine/src/cmd/file.rs @@ -120,7 +120,7 @@ pub fn specs() -> Vec { spec!( "file.export", "Export", - "{ids? (default selection, else the page), format? (png|jpg|svg|pdf|webp|xml (an Android Vector Drawable, with `warnings` for what it changed or left out), or fig: the whole file as .fig, experimental, with `warnings` for what was left out; other apps may not open every file; or penpot: the whole file as a Penpot 2.x archive, with warnings for unsupported content), scale? (default 1) | size? (2x|512w|512h or {by: scale|width|height, value}: a scale, or a width or height in pixels), path? (else returns base64 `data`), bleed? (PDF: points, or with a unit: \"3mm\", \"0.125in\", \"9pt\"), cropMarks?, bleedMarks?, cmyk? (PDF print options), contentsOnly? (default true; false also draws the layers that show in their area), includeBoundingBox? (true: only the layers' own boxes, cutting off shadows and outside strokes), svgOutlineText? (default true), svgSimplifyStroke? (default true), svgIdAttribute? (SVG ids, XML android:name), vdCompat? (XML: bestEffort (default: approximate with a warning)|exact (leave out what can't be exact, with a warning)|ignore (no warnings)), colorProfile? (PNG, JPG and WebP: sameAsFile (default: the document's profile)|srgb|displayP3; colors convert, out-of-gamut ones clip; SVG, PDF and XML are always sRGB), quality? (JPG: 1-100, default 90)}", + "{ids? (default selection, else the page), format? (png|jpg|svg|pdf|webp|xml (an Android Vector Drawable, with `warnings` for what it changed or left out), or fig: the whole file as .fig, experimental, with `warnings` for what was left out; other apps may not open every file; or penpot: the whole file as a Penpot 2.x archive, with warnings for unsupported content), scale? (default 1) | size? (2x|512w|512h or {by: scale|width|height, value}: a scale, or a width or height in pixels), path? (else returns base64 `data`), bleed? (PDF: points, or with a unit: \"3mm\", \"0.125in\", \"9pt\"), cropMarks?, bleedMarks?, cmyk? (PDF print options), contentsOnly? (default true; false also draws the layers that show in their area), includeBoundingBox? (true: only the layers' own boxes, cutting off shadows and outside strokes), svgOutlineText? (default true), svgSimplifyStroke? (default true), svgIdAttribute? (SVG ids, XML android:name), vdCompat? (XML: bestEffort (default: approximate with a warning)|exact (leave out what can't be exact, with a warning)|ignore (no warnings)), colorProfile? (PNG, JPG and WebP: sameAsFile (default: the document's profile)|srgb|displayP3; colors convert, out-of-gamut ones clip; SVG, XML and RGB PDF output are always sRGB; PDF with cmyk is DeviceCMYK), quality? (JPG: 1-100, default 90)}", false, export ), diff --git a/crates/mcp/src/tools.rs b/crates/mcp/src/tools.rs index 9e901f5bb..5d4296f01 100644 --- a/crates/mcp/src/tools.rs +++ b/crates/mcp/src/tools.rs @@ -280,7 +280,7 @@ fn tools() -> Vec { "svgIdAttribute": boolean("SVG: layer names as unique `id` attributes (default false)"), "svgSimplifyStroke": boolean("SVG: strokes as `stroke` attributes where exact (default true); false writes outlines"), "vdCompat": {"type": "string", "enum": ["bestEffort", "exact", "ignore"], "description": "XML: what a Vector Drawable can't draw exactly is approximated with a warning (bestEffort, default), left out with a warning (exact), or written as far as it maps without warnings (ignore: overlapping layer opacity dropped, even-odd fills kept as fillType=evenOdd, diamond gradients left out)"}, - "colorProfile": {"type": "string", "enum": ["sameAsFile", "srgb", "displayP3"], "description": "PNG, JPG and WebP: the color profile of the file (default sameAsFile: the document's); colors are converted and out-of-gamut ones clip. SVG, PDF and XML are always sRGB"}, + "colorProfile": {"type": "string", "enum": ["sameAsFile", "srgb", "displayP3"], "description": "PNG, JPG and WebP: the color profile of the file (default sameAsFile: the document's); colors are converted and out-of-gamut ones clip. SVG, XML and RGB PDF output are always sRGB; PDF with cmyk is DeviceCMYK"}, "quality": {"type": "integer", "minimum": 1, "maximum": 100, "description": "JPG: the encoder's quality, 1 (smallest file) to 100; default 90"}, }), &[], diff --git a/docs/file-format-parity.md b/docs/file-format-parity.md index bce90b008..335115ad1 100644 --- a/docs/file-format-parity.md +++ b/docs/file-format-parity.md @@ -54,12 +54,11 @@ export limit, not a native document nesting limit. | Format | Figma | FigCraft | Notes | Hours | |---|---|---|---|---| | PNG | yes, scales/suffixes | yes | export settings per layer, presets (`2x`, `512w`, `512h`), preview, "Export N layers"; ignore overlapping layers (on by default; off: every layer showing in the area) and include bounding box (the layer's own box; the Export section offers it for text layers, and `file.export` and `export.update` take it for any layer); slashes in layer names export into folders. The exported area is what the layer paints: shadows towards their offset, outside and centre strokes, unclipped children, a mask group's mask, nothing for hidden layers; slices export everything under them, except that with ignore overlapping layers on a slice inside a frame or group exports only that frame or group; sides round up to whole pixels | — | -| JPG | yes | yes | white where transparent; quality 1 to 100 (`quality` on `file.export`, export settings and MCP `export`; default 90; the Export panel has no control for it yet); the file's colour profile embedded as ICC (APP2), sRGB too | — | +| JPG | yes | yes | white where transparent; quality 1 to 100 (`quality` on `file.export`, export settings and MCP `export`; default 90; the Export panel has no control for it yet); a color profile per setting as for PNG (`colorProfile`), the file tagged with an ICC profile (APP2) for sRGB and for Display P3 | — | | PNG | yes, scales/suffixes | yes | export settings per layer, presets (`2x`, `512w`, `512h`), preview, "Export N layers"; ignore overlapping layers (on by default; off: every layer showing in the area) and include bounding box (the layer's own box; the Export section offers it for text layers, and `file.export` and `export.update` take it for any layer); slashes in layer names export into folders. The exported area is what the layer paints: shadows towards their offset, outside and centre strokes, unclipped children, a mask group's mask, nothing for hidden layers; slices export everything under them, except that with ignore overlapping layers on a slice inside a frame or group exports only that frame or group; sides round up to whole pixels; a color profile per setting (Same as file, the default, sRGB or Display P3: `colorProfile`), the pixels converted and the file tagged (`sRGB` chunk, or ICC and `cICP`) | — | -| JPG | yes | yes | white where transparent; fixed quality (90); a color profile per setting as for PNG (sRGB untagged, Display P3 with its ICC profile) | — | | SVG | yes (outline text option, ids) | yes | alpha/luminance masks kept; noise, texture, progressive and background blur, glass embedded as images; outline text (off: `` with one `` per line, one style per layer), unique id attributes from layer names, explicit depth-limit refusal, nested frames clipped by their parent's clip (#327), simplified strokes (stroke attributes for centred strokes and for inside and outside strokes on boxes and ellipses) | — | | PDF | yes | yes | one page per frame, real selectable text in subset fonts, links, vectors and gradients as vectors, effects as images; bleed, crop/bleed marks, page boxes, naive CMYK; checked by rendering the PDF back against PNG exports; explicit depth-limit refusal; RGB is always sRGB (no color profile setting and no output intent) | CMYK output intent 2–4 | -| WebP | — | yes (ours) | a color profile per setting as for JPG | — | +| WebP | — | yes (ours) | a color profile per setting as for PNG; sRGB files untagged, Display P3 files with the generated ICC profile | — | | Android Vector Drawable (XML) | — | yes (ours) | an `.xml` drawable resource (`file.export {format: "xml"}`, export settings, File ▸ Export…, the CLI and MCP), pretty-printed, sized in dp with the viewport in layer units, for AndroidX (VectorDrawableCompat: gradients and even-odd need API 24 without it). Shapes, booleans and text as path data with transforms baked in; solid fills and linear, radial and sweep gradients (`aapt:attr`, exact for any handles: radial and sweep in a `` that maps the unit circle); centred strokes as stroke attributes where Android draws them the same (uniform scale, one cap, no dashes or variable width), other strokes as filled outlines; clipping frames and masks as `` with ``; `android:name` from layer names with the id attribute option. What the format can't hold goes by the compatibility mode (`vdCompat`): best effort (default) applies layer opacity to each shape, rewrites even-odd fills and clip outlines as non-zero, draws diamond gradients as radial and alpha masks as outline clips, each with a warning; exact leaves out what it can't draw exactly, with a warning; ignore writes what maps without warnings: layer opacity over overlapping shapes is dropped (drawn opaque), even-odd fills keep `fillType="evenOdd"`, even-odd clip outlines clip as non-zero, diamond gradients are left out and alpha masks clip to their outline. Effects, image and pattern fills and blend modes are always left out (warned except in ignore); an export that draws nothing writes one empty path (Android refuses a drawable without a path), with a warning. Checked by parsing the XML, against FigCraft's renderer (gradients pixel by pixel), with `aapt2 compile` and `link`, and by rendering samples (linear, skewed radial and sweep gradients, a sweep with mirrored handles, even-odd booleans, centred and inside strokes, rotated text, a clipping frame, an alpha mask, a translucent group, each compatibility mode) with Android 13's (API 33) VectorDrawable on an emulator, next to FigCraft's PNG export: they match, including where the sweep starts and which way it turns, except what the compatibility mode and its warnings say (best effort: overlapping shapes in a translucent group look denser; exact and ignore leave out or draw opaque what they list). Not checked on API 21–23 (VectorDrawableCompat) | — | | Copy as CSS / SVG / PNG / text / link | yes | yes | Copy as PNG: the whole selection at 2x | — | | Dev Mode code (CSS, iOS SwiftUI, Android Compose) | yes | yes, plus HTML, React, Vue, Leptos, ArkUI and Flutter | see [dev-mode-parity](dev-mode-parity.md) | — | @@ -193,7 +192,7 @@ source paint coordinates. | 2026-11-04 | minor | JPG export: `quality` (1 to 100, default 90) on `file.export`, `export.add` / `export.update` and MCP `export`, kept in the export setting; an sRGB file's JPGs embed the sRGB ICC profile, as Display P3 files' JPGs already embedded theirs, since an untagged JPG is only assumed to be sRGB (#2004). | | 2026-11-04 | minor | `.fig` and `.jam` import, #1910: an elbowed connector saved with its path keeps it. FigJam stores `connectorControlPoints`, one per run between the first and the last, each a point on its run (in the connector's parent's coordinates) with the run's axis; the first run leaves the start's side and the last arrives at the end's. They become the `ConnectorPath::Runs` a board connector reshaped by hand has (`figcraft_doc::route_along`), so a connector drawn around a layer in FigJam stays around it instead of being routed through it. Points that don't make such a path (off both axes, two runs in a row the same way, a first or last run sideways to its side or going back into its object, more runs than a hand could make) leave the connector to the router as before, and only connectors routed here count in the "follow FigCraft's own routing" note. A curved connector's `connectorBezierControlPoints` are still not read. Tests: `tail_tests::an_elbow_connector_saved_with_its_path_keeps_it`, `tail_tests::an_elbow_whose_saved_path_doesnt_fit_its_sides_is_routed_here`. | | 2026-11-01 | patch | `.fig` and `.jam` import: a connector without a saved snapshot (elbowed and curved ones are routed here) took no stroke, so it was invisible (#1807); its line's paint, weight, cap and dashes now come from the file's generated line record, as a saved snapshot's do, and the connector's own values, when it has any, win. Test: `fig::connector_label_tests::a_routed_connector_takes_its_line_style_from_the_generated_record`. Numbers unchanged | -| 2026-10-31 | minor | Export settings: each PNG, JPG and WebP setting has a color profile, Same as file (the default; the document's profile when it exports), sRGB or Display P3, in its advanced settings and as `colorProfile` on `export.add`, `export.update`, `file.export`, `file.exportLayers` and MCP `export`. The pixels convert to the chosen profile (out-of-gamut colors clip) and the file is tagged as before: sRGB PNG with an `sRGB` chunk, Display P3 with the generated ICC profile (and `cICP` in PNG); sRGB JPG and WebP stay untagged. A setting keeps its choice when its format changes; settings saved without one read as Same as file. SVG, PDF and XML show no choice and stay sRGB (PDF has no output intent yet). Numbers unchanged | +| 2026-10-31 | minor | Export settings: each PNG, JPG and WebP setting has a color profile, Same as file (the default; the document's profile when it exports), sRGB or Display P3, in its advanced settings and as `colorProfile` on `export.add`, `export.update`, `file.export`, `file.exportLayers` and MCP `export`. The pixels convert to the chosen profile (out-of-gamut colors clip) and the file is tagged as before: sRGB PNG with an `sRGB` chunk, Display P3 with the generated ICC profile (and `cICP` in PNG); sRGB JPG embeds the sRGB ICC profile (#2004) and sRGB WebP stays untagged. A setting keeps its choice when its format changes; settings saved without one read as Same as file. SVG, PDF and XML show no choice and stay sRGB (PDF has no output intent yet). Numbers unchanged | | 2026-10-31 | patch | M4: Dash and Custom strokes have a Dash cap (None, Round, Square) in the advanced stroke settings and `node.set {dashCap}`, on both ends of every dash on the canvas and in PNG, PDF and SVG. Unset, dashes keep taking the end point caps, so older files look the same; the saved file writes it only when set. Numbers unchanged | | 2026-10-30 | minor | `.fig` import: a connector's label without a saved snapshot was skipped; now the connector imports as a frame holding its line and the label, as a connector with a saved snapshot does, the label centred on the line's middle by length (in a 200-wide box, laid out again with the fonts at hand), in the connector's fill paints or black. Its background isn't known without the snapshot and is left out. Not checked on real files. Test: `fig::tests::tail::a_labelled_connector_without_a_snapshot_keeps_its_label` | | 2026-10-30 | minor | Pasted content row: an image the clipboard doesn't carry keeps its name and shows a placeholder that reads as missing; the paste names those layers in its message and opens the import report with its notes (#1646). Numbers unchanged | diff --git a/docs/mcp.md b/docs/mcp.md index aebcbf46d..11945a76c 100644 --- a/docs/mcp.md +++ b/docs/mcp.md @@ -255,7 +255,7 @@ Or in a project's `.mcp.json`: profile into the file's space: an embedded ICC profile (PNG, JPG, WebP, TIFF; RGB or grey), a PNG's `sRGB` / `gAMA` / `cHRM` chunks, else sRGB (also for CMYK or damaged profiles); `image.place` reports the profile's name as `imageProfile` (`null`: none usable, taken as sRGB). PNG exports are tagged (`sRGB` chunk, or a Display P3 ICC profile plus - `cICP`), Display P3 JPG and WebP embed the ICC profile, and SVG and PDF export Display P3 files + `cICP`), JPG embeds the ICC profile for sRGB and for Display P3, WebP embeds it for Display P3 only (sRGB WebP is untagged), and SVG and PDF export Display P3 files converted to sRGB (out-of-gamut colours clip). The app's canvas shows sRGB (P3 colours outside sRGB clip on screen): `view.proofSrgb {on?}` (View ▸ Soft-proof sRGB) stripes those pixels so `screenshot {window: true}` shows where they are (after the next canvas render), and the colour picker says Outside @@ -380,7 +380,7 @@ a later step can use `{"$step": 0, "field": "ids/0"}` to target the first match. | `inspect_document {depth, allPages, fields?, outline?}` | The document as JSON (its `id`, layer tree, styles, selection, history); `fields` selects layer properties, `outline: true` gives a compact tree (below). The tools that act on a document also take `document` (see Naming the document below). | | `get_node {id, depth, fields?, outline?}` | One layer as JSON; takes the same `fields` and `outline` options; `pluginData` (`{key: value}`, values as strings) when the layer or page has layer data written with `set_properties {props: {pluginData}}`. | | `select {ids}` | Replace the selection (`[]` deselects). | -| `export {ids, format, scale \| size, path?, bleed?, cropMarks?, bleedMarks?, cmyk?, contentsOnly?, includeBoundingBox?, svgOutlineText?, svgIdAttribute?, svgSimplifyStroke?, vdCompat?, colorProfile?, quality?}` | png, jpg, svg, webp, pdf, xml (an Android Vector Drawable: `svgIdAttribute` writes `android:name`, `vdCompat` is `bestEffort` (default: approximated with a warning), `exact` (left out with a warning) or `ignore` (no warnings: overlapping layer opacity dropped, even-odd fills kept as `fillType="evenOdd"`, diamond gradients left out), and the result lists `warnings` for what was changed or left out), or `fig`: the whole file as `.fig`, experimental (see Exporting `.fig` files below); `size` is `2x`, `512w` or `512h`; `quality` is the JPG quality, 1 to 100 (default 90). The image covers what the layers paint (shadows towards their offset, strokes, unclipped children, a mask group's mask; hidden layers take no room; a slice is its area with everything under it, or only the frame or group it sits in while `contentsOnly` is on); `contentsOnly: false` also draws every other layer showing in that area, `includeBoundingBox` exports the layers' own boxes; SVG: `svgOutlineText: false` keeps ``, `svgIdAttribute` writes unique ids from layer names, `svgSimplifyStroke: false` writes every stroke as an outline; png, jpg and webp: `colorProfile` is `sameAsFile` (default: the document's profile), `srgb` or `displayP3`, the pixels converted (out-of-gamut colors clip) and the file tagged for it (SVG, PDF and XML are always sRGB). The same options go in export settings (`export.add` / `export.update`). PDF: frames one page each (sized in points), anything else together on one page; print options: `bleed` (points or a length like `"3mm"`, `"0.125in"`), crop and bleed marks, CMYK colour (see Exports below), also taken by `file.export`, `file.exportLayers`, `file.exportFramesPdf` and stored per export setting by `export.add` / `export.update`; `run_command` `file.exportFramesPdf {page?, path?}` writes every top-level frame of a page. Without `path`, images come back as MCP image content, SVG as text, XML as text followed by `{format, bytes, warnings}`. Layers' own export settings: `run_command` with `export.add` / `export.update {index, size?, suffix?, format?}` / `export.remove` and `file.exportLayers {ids?, dir?, assets?}` (every layer once per setting, named `.`, a slash in a layer name making a folder; `assets: true` exports the Inspect tab's assets instead: icons as SVG, images as PNG). | +| `export {ids, format, scale \| size, path?, bleed?, cropMarks?, bleedMarks?, cmyk?, contentsOnly?, includeBoundingBox?, svgOutlineText?, svgIdAttribute?, svgSimplifyStroke?, vdCompat?, colorProfile?, quality?}` | png, jpg, svg, webp, pdf, xml (an Android Vector Drawable: `svgIdAttribute` writes `android:name`, `vdCompat` is `bestEffort` (default: approximated with a warning), `exact` (left out with a warning) or `ignore` (no warnings: overlapping layer opacity dropped, even-odd fills kept as `fillType="evenOdd"`, diamond gradients left out), and the result lists `warnings` for what was changed or left out), or `fig`: the whole file as `.fig`, experimental (see Exporting `.fig` files below); `size` is `2x`, `512w` or `512h`; `quality` is the JPG quality, 1 to 100 (default 90). The image covers what the layers paint (shadows towards their offset, strokes, unclipped children, a mask group's mask; hidden layers take no room; a slice is its area with everything under it, or only the frame or group it sits in while `contentsOnly` is on); `contentsOnly: false` also draws every other layer showing in that area, `includeBoundingBox` exports the layers' own boxes; SVG: `svgOutlineText: false` keeps ``, `svgIdAttribute` writes unique ids from layer names, `svgSimplifyStroke: false` writes every stroke as an outline; png, jpg and webp: `colorProfile` is `sameAsFile` (default: the document's profile), `srgb` or `displayP3`, the pixels converted (out-of-gamut colors clip) and the file tagged for it (PNG: `sRGB` chunk, or ICC and `cICP` for Display P3; JPG: ICC profile; WebP: ICC profile for Display P3, none for sRGB) (SVG, XML and RGB PDF output are always sRGB; PDF with `cmyk` is DeviceCMYK). The same options go in export settings (`export.add` / `export.update`). PDF: frames one page each (sized in points), anything else together on one page; print options: `bleed` (points or a length like `"3mm"`, `"0.125in"`), crop and bleed marks, CMYK colour (see Exports below), also taken by `file.export`, `file.exportLayers`, `file.exportFramesPdf` and stored per export setting by `export.add` / `export.update`; `run_command` `file.exportFramesPdf {page?, path?}` writes every top-level frame of a page. Without `path`, images come back as MCP image content, SVG as text, XML as text followed by `{format, bytes, warnings}`. Layers' own export settings: `run_command` with `export.add` / `export.update {index, size?, suffix?, format?}` / `export.remove` and `file.exportLayers {ids?, dir?, assets?}` (every layer once per setting, named `.`, a slash in a layer name making a folder; `assets: true` exports the Inspect tab's assets instead: icons as SVG, images as PNG). | | `screenshot {ids?, scale?, maxSize?, window?}` | PNG of the page (with background) or of layers, scaled to fit `maxSize` (default 1600). `window: true` captures the app window in front when attached, a window id (see Windows below) that window. | | `open_file {path, variables?, reload?}` / `save_file {path?}` | Open `.figcraft`, `.json` (FigCraft JSON or REST API file JSON with its variables, see below), `.fig` or FigJam `.jam` (best effort, see below), `.sketch` (Sketch 48 and newer, best effort), `.svg` (see Importing SVG below) or an image; save as `.figcraft`. `open_file` returns `opened` (for a file opened anew, a `summary` of `name`, `pages`, `layers` and `images`, and `warnings` or `repairs`; a file that was already open gives its `index`, with `stale: true` when the file changed on disk since that tab read or saved it; `reload: true` reads it again into the tab, refused while the tab has unsaved changes) and the document's `document` outline. | | `undo` / `redo` | Step through history. | From 12ade9c78c62783dfe539bbbfb62c1fbae03d9ab Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Fri, 6 Nov 2026 23:31:02 -0800 Subject: [PATCH 02/19] Docs: the 2026-10-31 export entry keeps the JPG tagging it had on that date --- docs/file-format-parity.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/file-format-parity.md b/docs/file-format-parity.md index 335115ad1..0d51910f0 100644 --- a/docs/file-format-parity.md +++ b/docs/file-format-parity.md @@ -192,7 +192,7 @@ source paint coordinates. | 2026-11-04 | minor | JPG export: `quality` (1 to 100, default 90) on `file.export`, `export.add` / `export.update` and MCP `export`, kept in the export setting; an sRGB file's JPGs embed the sRGB ICC profile, as Display P3 files' JPGs already embedded theirs, since an untagged JPG is only assumed to be sRGB (#2004). | | 2026-11-04 | minor | `.fig` and `.jam` import, #1910: an elbowed connector saved with its path keeps it. FigJam stores `connectorControlPoints`, one per run between the first and the last, each a point on its run (in the connector's parent's coordinates) with the run's axis; the first run leaves the start's side and the last arrives at the end's. They become the `ConnectorPath::Runs` a board connector reshaped by hand has (`figcraft_doc::route_along`), so a connector drawn around a layer in FigJam stays around it instead of being routed through it. Points that don't make such a path (off both axes, two runs in a row the same way, a first or last run sideways to its side or going back into its object, more runs than a hand could make) leave the connector to the router as before, and only connectors routed here count in the "follow FigCraft's own routing" note. A curved connector's `connectorBezierControlPoints` are still not read. Tests: `tail_tests::an_elbow_connector_saved_with_its_path_keeps_it`, `tail_tests::an_elbow_whose_saved_path_doesnt_fit_its_sides_is_routed_here`. | | 2026-11-01 | patch | `.fig` and `.jam` import: a connector without a saved snapshot (elbowed and curved ones are routed here) took no stroke, so it was invisible (#1807); its line's paint, weight, cap and dashes now come from the file's generated line record, as a saved snapshot's do, and the connector's own values, when it has any, win. Test: `fig::connector_label_tests::a_routed_connector_takes_its_line_style_from_the_generated_record`. Numbers unchanged | -| 2026-10-31 | minor | Export settings: each PNG, JPG and WebP setting has a color profile, Same as file (the default; the document's profile when it exports), sRGB or Display P3, in its advanced settings and as `colorProfile` on `export.add`, `export.update`, `file.export`, `file.exportLayers` and MCP `export`. The pixels convert to the chosen profile (out-of-gamut colors clip) and the file is tagged as before: sRGB PNG with an `sRGB` chunk, Display P3 with the generated ICC profile (and `cICP` in PNG); sRGB JPG embeds the sRGB ICC profile (#2004) and sRGB WebP stays untagged. A setting keeps its choice when its format changes; settings saved without one read as Same as file. SVG, PDF and XML show no choice and stay sRGB (PDF has no output intent yet). Numbers unchanged | +| 2026-10-31 | minor | Export settings: each PNG, JPG and WebP setting has a color profile, Same as file (the default; the document's profile when it exports), sRGB or Display P3, in its advanced settings and as `colorProfile` on `export.add`, `export.update`, `file.export`, `file.exportLayers` and MCP `export`. The pixels convert to the chosen profile (out-of-gamut colors clip) and the file is tagged as before: sRGB PNG with an `sRGB` chunk, Display P3 with the generated ICC profile (and `cICP` in PNG); sRGB JPG and WebP stay untagged (builds before 2026-11-04; from that date sRGB JPGs embed the sRGB ICC profile, see the 2026-11-04 JPG export entry). A setting keeps its choice when its format changes; settings saved without one read as Same as file. SVG, PDF and XML show no choice and stay sRGB (PDF has no output intent yet). Numbers unchanged | | 2026-10-31 | patch | M4: Dash and Custom strokes have a Dash cap (None, Round, Square) in the advanced stroke settings and `node.set {dashCap}`, on both ends of every dash on the canvas and in PNG, PDF and SVG. Unset, dashes keep taking the end point caps, so older files look the same; the saved file writes it only when set. Numbers unchanged | | 2026-10-30 | minor | `.fig` import: a connector's label without a saved snapshot was skipped; now the connector imports as a frame holding its line and the label, as a connector with a saved snapshot does, the label centred on the line's middle by length (in a 200-wide box, laid out again with the fonts at hand), in the connector's fill paints or black. Its background isn't known without the snapshot and is left out. Not checked on real files. Test: `fig::tests::tail::a_labelled_connector_without_a_snapshot_keeps_its_label` | | 2026-10-30 | minor | Pasted content row: an image the clipboard doesn't carry keeps its name and shows a placeholder that reads as missing; the paste names those layers in its message and opens the import report with its notes (#1646). Numbers unchanged | From fbd313f4e7b9157c60f30f9e010e284df82cc5a2 Mon Sep 17 00:00:00 2001 From: Davit Matchakhelidze Date: Sat, 7 Nov 2026 12:50:18 +0400 Subject: [PATCH 03/19] i18n(ka): Georgian for 126 new strings --- crates/ui-egui/locales/ka.toml | 126 +++++++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+) diff --git a/crates/ui-egui/locales/ka.toml b/crates/ui-egui/locales/ka.toml index 2af58f385..8a4a70475 100644 --- a/crates/ui-egui/locales/ka.toml +++ b/crates/ui-egui/locales/ka.toml @@ -111,6 +111,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Along the top" = "ზედა კიდის გასწვრივ" "Alpha" = "ალფა" "Alphabetical" = "ანბანის მიხედვით" +"Alt+double-click an edge of an auto layout child" = "Alt+ორმაგი დაწკაპუნება ავტოგანლაგების შვილობილი ელემენტის კიდეზე" "Alt+drag" = "Alt+გადათრევა" "An analytics screen on a grid: figures, charts drawn from vectors and a table" = "ანალიტიკა ბადეზე: ციფრები, დიაგრამები და ცხრილი" "An earlier vote" = "ადრინდელი კენჭისყრა" @@ -124,6 +125,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Another server, or one that needs its key. The usual server is set in Preferences." = "სხვა სერვერი ან სერვერი, რომელსაც გასაღები სჭირდება. ჩვეულებრივი სერვერი პარამეტრებში ირჩევა." "Any status" = "ნებისმიერი სტატუსი" "Anyone on your network with this code can edit the file, while this app stays open." = "თქვენს ქსელში ნებისმიერს, ვისაც ეს კოდი აქვს, შეუძლია ფაილის რედაქტირება, სანამ ეს აპი ღიაა." +"Anyone on your network with this code can look at the file, not change it, while this app stays open." = "თქვენს ქსელში ნებისმიერს, ვისაც ეს კოდი აქვს, შეუძლია ფაილის ნახვა, მაგრამ არა შეცვლა, სანამ ეს აპი ღიაა." "Anyone with the edit link can change the file; the view link only lets people look. The links carry their secrets: share them like passwords. `figcraft-server links` makes more and revokes them." = "რედაქტირების ბმულის მქონე ნებისმიერს შეუძლია ფაილის შეცვლა; ნახვის ბმული მხოლოდ დათვალიერების საშუალებას იძლევა. ბმულები საიდუმლო გასაღებებს შეიცავს: გააზიარეთ ისინი პაროლების მსგავსად. `figcraft-server links` ქმნის ახალ ბმულებს და აუქმებს მათ." "Anyone with this code can edit the file." = "ნებისმიერს, ვისაც ეს კოდი აქვს, შეუძლია ფაილის რედაქტირება." "Anyone with this code can look at the file, not change it." = "ნებისმიერს, ვისაც ეს კოდი აქვს, შეუძლია ფაილის ნახვა, მაგრამ არა შეცვლა." @@ -158,6 +160,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Auto layout" = "ავტოგანლაგება" "Auto rows" = "ავტომატური სტრიქონები" "Auto width" = "ავტომატური სიგანე" +"Auto: by the first letter with a direction" = "ავტომატური: მიმართულების მქონე პირველი ასოს მიხედვით" "Back to the FigCraft server" = "FigCraft-ის სერვერზე დაბრუნება" "Back to the font's value" = "შრიფტის მნიშვნელობაზე დაბრუნება" "Back" = "უკან" @@ -330,6 +333,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Copied as PNG" = "დაკოპირდა როგორც PNG" "Copied as SVG" = "დაკოპირდა როგორც SVG" "Copied as text" = "დაკოპირდა როგორც ტექსტი" +"Copied comments for AI" = "კომენტარები დაკოპირდა AI-სთვის" "Copied {value}" = "დაკოპირდა: {value}" "Copy" = "კოპირება" "Copy as" = "კოპირება როგორც" @@ -337,6 +341,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Copy as PNG" = "კოპირება როგორც PNG" "Copy as SVG" = "კოპირება როგორც SVG" "Copy code" = "კოდის კოპირება" +"Copy for AI" = "კოპირება AI-სთვის" "Copy link" = "ბმულის კოპირება" "Copy the {label}" = "კოპირება: {label}" "Copy {value}" = "კოპირება: {value}" @@ -364,8 +369,10 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Created" = "შექმნილია" "Crop" = "ჩამოჭრა" "Crop marks" = "ჭრის ნიშნები" +"Ctrl+Alt+← ↑ → ↓" = "Ctrl+Alt+← ↑ → ↓" "Ctrl+arrows" = "Ctrl+ისრები" "Ctrl+click" = "Ctrl+დაწკაპუნება" +"Ctrl+click a padding field" = "Ctrl+დაწკაპუნება შიდა დაშორების ველზე" "Ctrl+scroll" = "Ctrl+გადახვევა" "Current name" = "მიმდინარე სახელი" "Current version" = "მიმდინარე ვერსია" @@ -385,6 +392,47 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Decoration style" = "გაფორმების სტილი" "Decoration" = "გაფორმება" "Deep select" = "ღრმა მონიშვნა" +"Delete {n} variables" = { one = "ცვლადის წაშლა: {n}", other = "ცვლადის წაშლა: {n}" } +"Disconnected. Reconnecting…" = "კავშირი გაწყდა. ხელახლა დაკავშირება…" +"Disconnected. Your edits stay here and sync when the connection returns. Reconnecting…" = "კავშირი გაწყდა. თქვენი ცვლილებები აქ რჩება და სინქრონიზდება, როცა კავშირი აღდგება. ხელახლა დაკავშირება…" +"Dismiss" = "უგულებელყოფა" +"Double-click an edge of an auto layout frame" = "ორმაგი დაწკაპუნება ავტოგანლაგების ჩარჩოს კიდეზე" +"Edit padding on all sides" = "შიდა დაშორების რედაქტირება ყველა მხარეს" +"Enter / Shift+Enter" = "Enter / Shift+Enter" +"Expand the interface" = "ინტერფეისის გაშლა" +"Hide UI" = "ინტერფეისის დამალვა" +"Left to right" = "მარცხნიდან მარჯვნივ" +"Move out of any group" = "ჯგუფიდან გამოტანა" +"Move to group {group}" = "ჯგუფში გადატანა: {group}" +"Move up or down while dragging its label" = "ზემოთ ან ქვემოთ გადაადგილება მისი იარლიყის გადათრევისას" +"Not connected: {reason}. Your work is still in this tab." = "კავშირი არ არის: {reason}. თქვენი ნამუშევარი ისევ ამ ჩანართშია." +"Nothing to pick: the page is empty" = "ასარჩევი არაფერია: გვერდი ცარიელია" +"Pick select: Tab and Shift+Tab move between layers, Enter goes into one, Shift+Enter out, Space selects, Escape cancels" = "შრის არჩევა: Tab და Shift+Tab შრეებს შორის გადაადგილდება, Enter შრეში შედის, Shift+Enter გამოდის, Space მონიშნავს, Escape გააუქმებს" +"Pick select: into a layer, out to its parent" = "შრის არჩევა: შრეში შესვლა, მშობელზე გასვლა" +"Pick select: next or previous layer" = "შრის არჩევა: შემდეგი ან წინა შრე" +"Pick select: select the picked layer" = "შრის არჩევა: არჩეული შრის მონიშვნა" +"Remove all auto layout" = "ყველა ავტოგანლაგების მოხსნა" +"Retry now" = "ახლავე ხელახლა ცდა" +"Right to left" = "მარჯვნიდან მარცხნივ" +"Rotate a degree (Shift: 15)" = "ერთი გრადუსით შემობრუნება (Shift: 15)" +"Same as file ({profile})" = "როგორც ფაილში ({profile})" +"Save a copy…" = "ასლის შენახვა…" +"Scope: all supported properties" = "არე: ყველა მხარდაჭერილი თვისება" +"Scope: hidden from pickers" = "არე: ამომრჩევებში დამალული" +"Scope: only {scope}" = "არე: მხოლოდ {scope}" +"Scrub a field faster (2x) or slower (1/2, 1/4)" = "ველის მნიშვნელობის გადათრევით ცვლა უფრო სწრაფად (2x) ან ნელა (1/2, 1/4)" +"Scrubbing at 1/2" = "გადათრევით ცვლა: 1/2" +"Scrubbing at 1/4" = "გადათრევით ცვლა: 1/4" +"Scrubbing at 1x" = "გადათრევით ცვლა: 1x" +"Scrubbing at 2x" = "გადათრევით ცვლა: 2x" +"Selection box: switch to pick select" = "მონიშვნის ჩარჩო: შრის არჩევაზე გადართვა" +"Set fill container" = "ზომა: კონტეინერის შევსება" +"Set hug contents" = "ზომა: შიგთავსზე მორგება" +"Show and move the placement crosshair (its tool chosen, nothing selected)" = "განთავსების ჯვრის ჩვენება და გადაადგილება (არჩეული ხელსაწყოთი, როცა არაფერია მონიშნული)" +"Space" = "Space" +"Tab or Ctrl+Space again" = "Tab ან ხელახლა Ctrl+Space" +"Text direction" = "ტექსტის მიმართულება" +"The bars are hidden. {shortcut} shows them again" = "ზოლები დამალულია. {shortcut} ისევ აჩვენებს მათ" "Wrap style" = "გადატანის სტილი" "Balance" = "დაბალანსებული" "Pretty" = "მოწესრიგებული" @@ -890,6 +938,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "No color styles" = "ფერის სტილები არ არის" "No colour variables fit here." = "აქ არცერთი ფერის ცვლადი არ ერგება." "No colour variables yet. Create them in Local variables." = "ფერის ცვლადები ჯერ არ არის. შექმენით ისინი ლოკალურ ცვლადებში." +"No comments to copy" = "დასაკოპირებელი კომენტარები არ არის" "No comments yet" = "კომენტარები ჯერ არ არის" "No compatibility warnings reported" = "თავსებადობის გაფრთხილებები არ დაფიქსირებულა" "No components yet. Select layers and press {keys}." = "კომპონენტები ჯერ არ არის. მონიშნეთ შრეები და დააჭირეთ {keys}." @@ -1804,6 +1853,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "{name} is forgotten on this computer; the file stays on {server}" = "{name} დავიწყებულია ამ კომპიუტერზე; ფაილი {server}-ზე რჩება" "{name} is on the server." = "{name} სერვერზეა." "{name} is spotlighting" = "ყურადღება {name}-ზეა" +"{name}, disconnected from its live session" = "{name}, ცოცხალ სესიასთან კავშირი გაწყვეტილია" "{name}\nClick to apply to the selection" = "{name}\nდაწკაპეთ მონიშნულზე გამოსაყენებლად" "{name}\nDrag onto the canvas, or click to place in the middle of the view.\nHold Alt (Option) while dropping onto an instance to swap it." = "{name}\nგადაათრიეთ ტილოზე ან დაწკაპეთ ხედის შუაში განსათავსებლად.\nინსტანსის ჩასანაცვლებლად მასზე ჩაგდებისას დააჭირეთ Alt-ს (Option)." "{name} (from {library})" = "{name} ({library}-იდან)" @@ -1876,10 +1926,14 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "←" = "←" "→, Space or N" = "→, Space ან N" "↵" = "↵" +"↵ / ⇧↵" = "↵ / ⇧↵" "⇥ / ⇧⇥" = "⇥ / ⇧⇥" +"⇥ or ⌥ Space again" = "⇥ ან ხელახლა ⌥ Space" "⌘ arrows" = "⌘ ისრები" "⌘ click" = "⌘ დაწკაპუნება" +"⌘ click a padding field" = "⌘ დაწკაპუნება შიდა დაშორების ველზე" "⌘ scroll" = "⌘ გადახვევა" +"⌥ double-click an edge of an auto layout child" = "⌥ ორმაგი დაწკაპუნება ავტოგანლაგების შვილობილი ელემენტის კიდეზე" "⌥ drag" = "⌥ გადათრევა" "Android Vector Drawable" = "Android Vector Drawable" "Best effort" = "მაქსიმალური მიახლოება" @@ -1908,6 +1962,67 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Update check is not supported in the web browser." = "ვებბრაუზერში განახლებების შემოწმება მხარდაჭერილი არ არის." "instance swap properties whose default component was past the layer limit were skipped" = "ინსტანსის ჩანაცვლების თვისებები, რომელთა ნაგულისხმევი კომპონენტი შრეების ზღვარს მიღმა იყო, გამოტოვებულია" "instances whose component was past the layer limit were imported as frames" = "ინსტანსები, რომელთა კომპონენტი შრეების ზღვარს მიღმა იყო, ჩარჩოებად იმპორტირდა" +"1 year" = "1 წელი" +"30 days" = "30 დღე" +"90 days" = "90 დღე" +"Allow and download" = "დაშვება და ჩამოტვირთვა" +"Allow downloading fonts?" = "დაიშვას შრიფტების ჩამოტვირთვა?" +"Board grid" = "დაფის ბადე" +"Changed {date}" = "შეცვლილია: {date}" +"Copy browser link" = "ბრაუზერის ბმულის კოპირება" +"Couldn't reach {server} for its team list." = "{server}-იდან გუნდის სიის მიღება ვერ მოხერხდა." +"Calculated from other variables; it follows them" = "გამოითვლება სხვა ცვლადებიდან და მათ მიჰყვება" +"Crop image" = "გამოსახულების ჩამოჭრა" +"Detach calculation" = "გამოთვლის გამოყოფა" +"Download" = "ჩამოტვირთვა" +"Downloading… {percent}%" = "ჩამოტვირთვა… {percent}%" +"Drop to use this image" = "ჩააგდეთ ამ გამოსახულების გამოსაყენებლად" +"Everyone who reaches this server can open these files while they are shared." = "ამ სერვერთან წვდომის მქონე ყველას შეუძლია ამ ფაილების გახსნა, სანამ ისინი გაზიარებულია." +"FigCraft stopped because of an internal error." = "FigCraft-ის მუშაობა შიდა შეცდომის გამო შეწყდა." +"Free fonts come from Google Fonts and Noto, through jsDelivr and GitHub. Each file is checked against the font index before it is installed into the font folder the Craft apps share. Nothing is downloaded until you allow it." = "უფასო შრიფტები Google Fonts-იდან და Noto-დან მოდის, jsDelivr-ისა და GitHub-ის გავლით. თითოეული ფაილი შრიფტების ინდექსთან მოწმდება, სანამ Craft-აპების საერთო შრიფტების საქაღალდეში დაინსტალირდება. სანამ არ დაუშვებთ, არაფერი ჩამოიტვირთება." +"Graph paper" = "მილიმეტრიანი ქაღალდი" +"Joining live session…" = "ცოცხალ სესიასთან შეერთება…" +"Link copied: it opens the file in FigCraft" = "ბმული დაკოპირდა: ის ფაილს FigCraft-ში ხსნის" +"Link copied: it opens the file in the browser" = "ბმული დაკოპირდა: ის ფაილს ბრაუზერში ხსნის" +"Nobody shares a file there now." = "იქ ახლა არავინ აზიარებს ფაილს." +"Past 30 days" = "ბოლო 30 დღე" +"Past 90 days" = "ბოლო 90 დღე" +"Past year" = "ბოლო წელი" +"Shared by your team on {server}" = "თქვენი გუნდის მიერ {server}-ზე გაზიარებული" +"Not now" = "ახლა არა" +"Nothing counted yet" = "ჯერ არაფერი დათვლილა" +"Reload the page to get back the unsaved files the browser had room for." = "განაახლეთ გვერდი, რომ დაიბრუნოთ ის შეუნახავი ფაილები, რომლებიც ბრაუზერში დაეტია." +"Reload the page to get your unsaved files back." = "განაახლეთ გვერდი, რომ შეუნახავი ფაილები დაიბრუნოთ." +"Reload the page to start again." = "თავიდან დასაწყებად განაახლეთ გვერდი." +"Reset grid" = "ბადის ჩამოყრა" +"This server doesn't count insertions" = "ეს სერვერი ჩასმებს არ ითვლის" +"This server doesn't count styles and variables" = "ეს სერვერი სტილებსა და ცვლადებს არ ითვლის" +"Upload from computer" = "კომპიუტერიდან ატვირთვა" +"Strong line every" = "მუქი ხაზის ბიჯი" +"This link opens your mail app to write a message:" = "ეს ბმული წერილის დასაწერად თქვენს საფოსტო აპს ხსნის:" +"This server doesn't count detached instances" = "ეს სერვერი გამოყოფილ ინსტანსებს არ ითვლის" +"Your unsaved files were too large for the browser to keep." = "თქვენი შეუნახავი ფაილები ბრაუზერისთვის შესანახად ზედმეტად დიდი იყო." +"connector labels without a saved snapshot are centred on the line, without their background" = "შენახული სნეპშოტის გარეშე შემაერთებლის იარლიყები ხაზზე ცენტრდება, ფონის გარეშე" +"elbowed and curved connectors without a saved path follow FigCraft's own routing" = "შენახული ტრაექტორიის გარეშე კუთხოვანი და მრუდი შემაერთებლები FigCraft-ის საკუთარ მარშრუტს მიჰყვება" +"invalid vector region fill paint list; layer fill used" = "ვექტორული არის შევსების საღებავების სია არასწორია; გამოყენებულია შრის შევსება" +"invalid vector region paints were skipped" = "ვექტორული არის არასწორი საღებავები გამოტოვებულია" +"linked vector region fill styles keep resolved appearance; live style links were left out" = "ვექტორული არის მიბმული შევსების სტილები გამოთვლილ იერსახეს ინარჩუნებს; სტილების ცოცხალი კავშირები არ გადმოვიდა" +"note or shape generated child has invalid bounds; child skipped" = "შენიშვნის ან ფიგურის გენერირებულ შვილობილ ელემენტს არასწორი საზღვრები აქვს; ელემენტი გამოტოვებულია" +"note or shape generated child is missing its style or bounds; child skipped" = "შენიშვნის ან ფიგურის გენერირებულ შვილობილ ელემენტს სტილი ან საზღვრები აკლია; ელემენტი გამოტოვებულია" +"note or shape generated children exceed the layer or nesting limit; remaining children skipped" = "შენიშვნის ან ფიგურის გენერირებული შვილობილი ელემენტები შრეების ან ჩადგმის ლიმიტს აჭარბებს; დანარჩენი ელემენტები გამოტოვებულია" +"note or shape generated layout is missing or unsupported; using its outer frame" = "შენიშვნის ან ფიგურის გენერირებული განლაგება აკლია ან მხარდაუჭერელია; გამოიყენება მისი გარე ჩარჩო" +"shape generated outline is missing or damaged; using its rectangle" = "ფიგურის გენერირებული კონტური აკლია ან დაზიანებულია; გამოიყენება მისი მართკუთხედი" +"variable-bound vector region paints keep resolved appearance; live bindings were left out" = "ცვლადებზე მიბმული ვექტორული არის საღებავები გამოთვლილ იერსახეს ინარჩუნებს; ცოცხალი მიბმები არ გადმოვიდა" +"vector region paint data exceeded import limits and was skipped" = "ვექტორული არის საღებავის მონაცემებმა იმპორტის ლიმიტებს გადააჭარბა და გამოტოვებულია" +"vector region references a missing fill style; layer fill used" = "ვექტორული არე მიუთითებს შევსების არარსებულ სტილზე; გამოყენებულია შრის შევსება" +"{count} in it now · Changed {date}" = "ახლა მასშია: {count} · შეცვლილია: {date}" +"{insertions} · {detachments}" = "{insertions} · {detachments}" +"{period}: {counts}" = "{period}: {counts}" +"{used} · {detached}" = "{used} · {detached}" +"{used} · {inserted}" = "{used} · {inserted}" +"{n} detached" = { one = "გამოყოფილი: {n}", other = "გამოყოფილი: {n}" } +"{n} inserted" = { one = "ჩასმული: {n}", other = "ჩასმული: {n}" } +"⌥⌘ ← ↑ → ↓" = "⌥⌘ ← ↑ → ↓" [commands] "align.bottom" = "ქვემოთ სწორება" @@ -2003,6 +2118,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "comment.next" = "შემდეგი კომენტარი" "comment.open" = "კომენტარის გახსნა" "comment.people" = "კომენტარებში მონაწილე ადამიანები" +"comment.prompt" = "კომენტარების კოპირება AI-სთვის" "comment.react" = "კომენტარზე რეაგირება" "comment.reply" = "კომენტარზე პასუხი" "comment.resolve" = "კომენტარის გადაწყვეტა" @@ -2081,6 +2197,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "file.exportFramesPdf" = "ჩარჩოების PDF-ად ექსპორტირება" "file.exportLayers" = "შრეების ექსპორტირება" "file.exportSvg" = "მონიშნულის SVG-ად ექსპორტირება" +"file.fontReport" = "დოკუმენტის შრიფტების ინსპექტირება" "file.import" = "იმპორტი" "file.moveTab" = "ჩანართის გადატანა" "file.new" = "ახალი დიზაინის ფაილი" @@ -2533,6 +2650,15 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "file.markSaved" = "შენახულად მარკირება" "text.fit" = "ტექსტის ჩატევა თავის საზღვრებში" "data.fill" = "ასლების მონაცემებით შევსება" +"board.grid" = "დაფის ბადე" +"font.download" = "შრიფტის ჩამოტვირთვა" +"font.downloads" = "შრიფტების ჩამოტვირთვები" +"image.crop" = "გამოსახულების ჩამოჭრა" +"library.check" = "გუნდის ბიბლიოთეკების განახლებების შემოწმება" +"board.reshape" = "შემაერთებლის ფორმის შეცვლა" +"image.replace" = "გამოსახულების ჩანაცვლება" +"variable.extendCollection" = "კოლექციის გაფართოება" +"widget.hover" = "ვიჯეტზე მაჩვენებლის მიტანა" [menu] "bool.exclude" = "გამორიცხვა" From b33da8a7b0f3dd92d0a2a88ec22ab72f9d028a1d Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Sat, 7 Nov 2026 11:52:52 -0500 Subject: [PATCH 04/19] Ellipse: an unsliced ellipse edits as four anchor points, not six (#2080) A whole ellipse and each ring contour are built as four cubics through the extremes instead of a tolerance-subdivided arc. Sliced ellipses are unchanged. Co-Authored-By: Claude Fable 5.1 --- crates/geom/src/lib.rs | 23 ++++++++++++++++----- crates/geom/src/tests.rs | 43 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 60 insertions(+), 6 deletions(-) diff --git a/crates/geom/src/lib.rs b/crates/geom/src/lib.rs index a775a4170..f290882d8 100644 --- a/crates/geom/src/lib.rs +++ b/crates/geom/src/lib.rs @@ -472,15 +472,28 @@ pub fn ellipse(width: f64, height: f64, start: f64, sweep: f64, inner: f64) -> B let mut path = BezPath::new(); // A whole turn as an arc with these radii: kurbo's `Ellipse` recovers its radii from an // affine map, which overflows to infinity for radii near f64's limit (and infinite cubics). - let whole = |rx: f64, ry: f64| kurbo::Arc::new(c, (rx, ry), 0.0, TAU, 0.0); + // Four cubics through the right, bottom, left and top extremes (clockwise from 3 o'clock), + // the same four anchors an ellipse has when edited as a vector; an arc subdivided by + // tolerance would give five or six. + let whole = |rx: f64, ry: f64| { + const K: f64 = 0.552_284_749_830_793_4; + let (kx, ky) = (rx * K, ry * K); + let mut p = BezPath::new(); + p.move_to(c + Vec2::new(rx, 0.0)); + p.curve_to(c + Vec2::new(rx, ky), c + Vec2::new(kx, ry), c + Vec2::new(0.0, ry)); + p.curve_to(c + Vec2::new(-kx, ry), c + Vec2::new(-rx, ky), c + Vec2::new(-rx, 0.0)); + p.curve_to(c + Vec2::new(-rx, -ky), c + Vec2::new(-kx, -ry), c + Vec2::new(0.0, -ry)); + p.curve_to(c + Vec2::new(kx, -ry), c + Vec2::new(rx, -ky), c + Vec2::new(rx, 0.0)); + p + }; if full && inner <= 0.0 { - return whole(rx, ry).to_path(tol); + return whole(rx, ry); } if full { // A ring: outer clockwise, inner counter-clockwise. - path.extend(whole(rx, ry).path_elements(tol)); - let inner_path = whole(rx * inner, ry * inner).to_path(tol); - path.extend(inner_path.reverse_subpaths()); + path.extend(whole(rx, ry).elements().iter().copied()); + let inner_path = whole(rx * inner, ry * inner); + path.extend(inner_path.reverse_subpaths().elements().iter().copied()); return path; } let outer = kurbo::Arc::new(c, (rx, ry), start, sweep, 0.0); diff --git a/crates/geom/src/tests.rs b/crates/geom/src/tests.rs index 459b2b101..909a3c475 100644 --- a/crates/geom/src/tests.rs +++ b/crates/geom/src/tests.rs @@ -263,7 +263,7 @@ fn smoothed_polygon_smooths_every_corner() { #[test] fn ellipse_ring_area() { let full = area(&ellipse(100.0, 100.0, 0.0, TAU, 0.0)); - assert!((full - PI * 2500.0).abs() < 2.0); + assert!((full - PI * 2500.0).abs() < 5.0, "{full}"); let ring = ellipse(100.0, 100.0, 0.0, TAU, 0.5); // Winding area of a ring with a reversed inner contour: outer - inner. let a = ring.area().abs(); @@ -321,6 +321,47 @@ fn reverse_subpaths_preserves_open_and_closed() { assert!(matches!(r.elements().last(), Some(kurbo::PathEl::ClosePath)), "{:?}", r.elements()); } +fn cubics(path: &BezPath) -> Vec { + path.segments() + .filter_map(|s| match s { + kurbo::PathSeg::Cubic(c) => Some(c), + _ => None, + }) + .collect() +} + +#[test] +fn a_whole_ellipse_is_four_cubics_through_the_extremes() { + for (w, h) in [(100.0, 100.0), (200.0, 60.0), (3.0, 900.0)] { + let segs = cubics(&ellipse(w, h, 0.0, TAU, 0.0)); + assert_eq!(segs.len(), 4, "{w}x{h}"); + let (rx, ry) = (w / 2.0, h / 2.0); + let want = [Point::new(rx, h), Point::new(0.0, ry), Point::new(rx, 0.0), Point::new(w, ry)]; + for (i, s) in segs.iter().enumerate() { + assert!((s.p3 - want[i]).hypot() < 1e-9, "{w}x{h}: anchor {i} is {:?}", s.p3); + // Handle length is 0.5523 of the radius along the tangent. + let k = 0.552_284_749_830_793_4; + let (r_along, r_across) = if i % 2 == 0 { (ry, rx) } else { (rx, ry) }; + let _ = r_across; + assert!(((s.p1 - s.p0).hypot() - k * r_along).abs() < 1e-9, "{w}x{h}: handle {i}"); + } + } +} + +#[test] +fn a_whole_ring_is_four_cubics_per_contour() { + let segs = cubics(&ellipse(100.0, 100.0, 0.0, TAU, 0.5)); + assert_eq!(segs.len(), 8); +} + +#[test] +fn a_sliced_ellipse_still_builds_its_arc() { + let pie = ellipse(100.0, 100.0, 0.0, PI, 0.0); + assert!(!cubics(&pie).is_empty()); + assert!(matches!(pie.elements().last(), Some(kurbo::PathEl::ClosePath))); + assert!((area(&pie) - PI * 1250.0).abs() < 2.0); +} + #[test] fn a_huge_ellipse_arc_is_a_few_cubics() { let big = ellipse(1e300, 1e300, 0.3, 2.0, 0.5); From 4118be890c2e15c9183293104a8a7e20e77e25b7 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Sat, 7 Nov 2026 12:42:44 -0500 Subject: [PATCH 05/19] Ellipse: the four-cubic contour is closed, and the band test allows apex antialiasing (#2080) The band test compared row 10, the ellipse top, where the cubic now ends exactly at its level extreme; 8 pixels antialias slightly differently between a short band and the whole view. The row mean limit now grows by 0.05 per such pixel; whole-row artifacts still fail. Co-Authored-By: Claude Fable 5.1 --- crates/geom/src/lib.rs | 1 + crates/render/src/band_tests.rs | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/geom/src/lib.rs b/crates/geom/src/lib.rs index f290882d8..41669488f 100644 --- a/crates/geom/src/lib.rs +++ b/crates/geom/src/lib.rs @@ -484,6 +484,7 @@ pub fn ellipse(width: f64, height: f64, start: f64, sweep: f64, inner: f64) -> B p.curve_to(c + Vec2::new(-kx, ry), c + Vec2::new(-rx, ky), c + Vec2::new(-rx, 0.0)); p.curve_to(c + Vec2::new(-rx, -ky), c + Vec2::new(-kx, -ry), c + Vec2::new(0.0, -ry)); p.curve_to(c + Vec2::new(kx, -ry), c + Vec2::new(rx, -ky), c + Vec2::new(rx, 0.0)); + p.close_path(); p }; if full && inner <= 0.0 { diff --git a/crates/render/src/band_tests.rs b/crates/render/src/band_tests.rs index b9a7bfbcc..e01fad5d7 100644 --- a/crates/render/src/band_tests.rs +++ b/crates/render/src/band_tests.rs @@ -83,7 +83,8 @@ fn bands_match_one_piece_rendering() { assert_eq!((banded.width(), banded.height()), (one.width(), one.height())); for (y, (mean, off)) in row_diffs(&one, &banded).into_iter().enumerate() { assert!( - mean < 0.25 && off * 20 <= v.width as usize, + // Each pixel antialiased differently (the level top of an ellipse, where a cubic ends at its extreme) may add up to 0.05 to the row's mean. + mean < 0.25 + 0.05 * off as f64 && off * 20 <= v.width as usize, "scale {scale}, {bands} bands: row {y} differs ({off} pixels, {mean:.2} on average)" ); } From 0774e44fa8c4218821a300e341237cfcb071f822 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Sat, 7 Nov 2026 13:41:25 -0500 Subject: [PATCH 06/19] Render band test: only small antialiasing differences are forgiven, a real band artifact still fails (#2080) Pixels whose largest channel differs by 24 or less are noise and left out of the row mean, which keeps its original 0.25 limit; the differing-pixel limit is unchanged. A unit test shows a 44-pixel row off by 60 still fails. Co-Authored-By: Claude Fable 5.1 --- crates/render/src/band_tests.rs | 68 ++++++++++++++++++++++++--------- 1 file changed, 51 insertions(+), 17 deletions(-) diff --git a/crates/render/src/band_tests.rs b/crates/render/src/band_tests.rs index e01fad5d7..4ea9fb1f6 100644 --- a/crates/render/src/band_tests.rs +++ b/crates/render/src/band_tests.rs @@ -56,20 +56,58 @@ fn view(scale: f64) -> View { View { origin: (-10.0, -10.0), scale, width: (440.0 * scale) as u32, height: (240.0 * scale) as u32 } } -/// Per row: the mean channel difference and how many pixels differ by more than 2. A band artifact -/// differs along a whole row; edge antialiasing may differ in a few pixels per edge (a curve -/// clipped at a band's edge rasterises a hair differently, most where it runs nearly level). +/// A pixel whose largest channel differs by at most this much between two renders is edge +/// antialiasing noise (a curve clipped at a band's edge rasterises a hair differently, most where +/// it runs level, as at the top of an ellipse), not a band artifact. +const NOISE: u8 = 24; + +/// One row of two renders: the mean channel difference over the pixels that are not noise (see +/// `NOISE`), and how many pixels differ by more than 2 at all. A band artifact differs along a +/// whole row, by more than noise. +fn row_stats(x: &[u8], y: &[u8]) -> (f64, usize) { + let mut sum = 0.0; + let mut off = 0; + for (p, q) in x.chunks(4).zip(y.chunks(4)) { + let worst = p.iter().zip(q).map(|(c, d)| c.abs_diff(*d)).max().unwrap_or(0); + if worst > 2 { + off += 1; + } + if worst > NOISE { + sum += p.iter().zip(q).map(|(c, d)| f64::from(c.abs_diff(*d))).sum::(); + } + } + (sum / x.len().max(1) as f64, off) +} + fn row_diffs(a: &Pixmap, b: &Pixmap) -> Vec<(f64, usize)> { let row = a.width() as usize * 4; - a.data() - .chunks(row) - .zip(b.data().chunks(row)) - .map(|(x, y)| { - let sum: f64 = x.iter().zip(y).map(|(p, q)| f64::from(p.abs_diff(*q))).sum(); - let off = x.chunks(4).zip(y.chunks(4)).filter(|(p, q)| p.iter().zip(*q).any(|(c, d)| c.abs_diff(*d) > 2)).count(); - (sum / row as f64, off) - }) - .collect() + a.data().chunks(row).zip(b.data().chunks(row)).map(|(x, y)| row_stats(x, y)).collect() +} + +/// Whether a row passes: the original mean limit over non-noise pixels, and at most a twentieth +/// of the row differing at all. +fn row_ok(mean: f64, off: usize, width: usize) -> bool { + mean < 0.25 && off * 20 <= width +} + +#[test] +fn a_real_band_artifact_fails_but_edge_noise_passes() { + let width = 880; // scale 2 + let flat = vec![100u8; width * 4]; + // 44 pixels differing by 60 per channel: under the old mean allowance, but a real artifact. + let mut artifact = flat.clone(); + for px in artifact.chunks_mut(4).take(44) { + px.iter_mut().for_each(|c| *c += 60); + } + let (mean, off) = row_stats(&flat, &artifact); + assert!(!row_ok(mean, off, width), "{mean} {off}"); + // 8 pixels differing by 16 (the ellipse top's antialiasing): forgiven. + let mut noise = flat.clone(); + for px in noise.chunks_mut(4).take(8) { + px.iter_mut().for_each(|c| *c += 16); + } + let (mean, off) = row_stats(&flat, &noise); + assert!(row_ok(mean, off, width), "{mean} {off}"); } #[test] @@ -82,11 +120,7 @@ fn bands_match_one_piece_rendering() { let banded = render_bands(&d, p, &v, &Options::default(), bands).unwrap(); assert_eq!((banded.width(), banded.height()), (one.width(), one.height())); for (y, (mean, off)) in row_diffs(&one, &banded).into_iter().enumerate() { - assert!( - // Each pixel antialiased differently (the level top of an ellipse, where a cubic ends at its extreme) may add up to 0.05 to the row's mean. - mean < 0.25 + 0.05 * off as f64 && off * 20 <= v.width as usize, - "scale {scale}, {bands} bands: row {y} differs ({off} pixels, {mean:.2} on average)" - ); + assert!(row_ok(mean, off, v.width as usize), "scale {scale}, {bands} bands: row {y} differs ({off} pixels, {mean:.2} on average)"); } } } From 97f086e091d712548a3415bceb344284b62302b8 Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Sat, 7 Nov 2026 16:36:59 -0800 Subject: [PATCH 07/19] Docs: the Display P3 export sentence names RGB PDF and says CMYK PDF ends as DeviceCMYK The colour profile paragraph in docs/mcp.md said SVG and PDF export Display P3 files converted to sRGB, without the RGB qualifier the export tool text now carries. It now says SVG and RGB PDF convert to sRGB, and PDF with `cmyk` converts to sRGB the same way and then to DeviceCMYK. The comment above the export match in file.rs says the same. --- crates/engine/src/cmd/file.rs | 3 ++- docs/mcp.md | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/engine/src/cmd/file.rs b/crates/engine/src/cmd/file.rs index e52960d43..ca83292ec 100644 --- a/crates/engine/src/cmd/file.rs +++ b/crates/engine/src/cmd/file.rs @@ -372,7 +372,8 @@ pub fn export_file(doc: &Document, ids: &[NodeId], setting: &ExportSetting, scal && !setting.include_bounding_box && !ids.iter().any(|i| doc.node(*i).is_some_and(|n| matches!(n.kind, NodeKind::Slice))); match setting.format { - // SVG and PDF colours are sRGB: a Display P3 file exports converted (out-of-gamut colours clip). + // SVG and RGB PDF colors are sRGB: a Display P3 file exports converted (out-of-gamut colours clip). + // PDF with `cmyk` converts from those sRGB colors to DeviceCMYK. ExportFormat::Svg => { let opts = figcraft_svg::SvgOptions { include_ids: setting.svg_id_attribute, diff --git a/docs/mcp.md b/docs/mcp.md index 11945a76c..5b4efa3f7 100644 --- a/docs/mcp.md +++ b/docs/mcp.md @@ -255,8 +255,8 @@ Or in a project's `.mcp.json`: profile into the file's space: an embedded ICC profile (PNG, JPG, WebP, TIFF; RGB or grey), a PNG's `sRGB` / `gAMA` / `cHRM` chunks, else sRGB (also for CMYK or damaged profiles); `image.place` reports the profile's name as `imageProfile` (`null`: none usable, taken as sRGB). PNG exports are tagged (`sRGB` chunk, or a Display P3 ICC profile plus - `cICP`), JPG embeds the ICC profile for sRGB and for Display P3, WebP embeds it for Display P3 only (sRGB WebP is untagged), and SVG and PDF export Display P3 files - converted to sRGB (out-of-gamut colours clip). The app's canvas shows sRGB (P3 colours outside sRGB clip on screen): + `cICP`), JPG embeds the ICC profile for sRGB and for Display P3, WebP embeds it for Display P3 only (sRGB WebP is untagged), and SVG and RGB PDF export Display P3 files + converted to sRGB (out-of-gamut colours clip). PDF with `cmyk` converts them to sRGB the same way and then to DeviceCMYK. The app's canvas shows sRGB (P3 colours outside sRGB clip on screen): `view.proofSrgb {on?}` (View ▸ Soft-proof sRGB) stripes those pixels so `screenshot {window: true}` shows where they are (after the next canvas render), and the colour picker says Outside sRGB for such a colour. From 0c1fb11c4800d98090c00b4e531cec81e12507b0 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Sat, 7 Nov 2026 19:37:16 -0500 Subject: [PATCH 08/19] Render band test: the comments say what row_stats divides by and what the artifact case measures (#2080) row_stats sums the differences of the pixels above noise and divides by the whole row's channel count; the doc now says so. The artifact case changes only the colour channels, so its mean is 2.25, which the earlier allowance let through, and its comment now says it fails on the mean while its count stays within a twentieth of the row. Co-Authored-By: Claude Opus 5.5 Model-Effort: Opus 5.5 drove and wrote at high; no brief --- crates/render/src/band_tests.rs | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/crates/render/src/band_tests.rs b/crates/render/src/band_tests.rs index 4ea9fb1f6..9fcf29f20 100644 --- a/crates/render/src/band_tests.rs +++ b/crates/render/src/band_tests.rs @@ -61,9 +61,10 @@ fn view(scale: f64) -> View { /// it runs level, as at the top of an ellipse), not a band artifact. const NOISE: u8 = 24; -/// One row of two renders: the mean channel difference over the pixels that are not noise (see -/// `NOISE`), and how many pixels differ by more than 2 at all. A band artifact differs along a -/// whole row, by more than noise. +/// One row of two renders: the channel differences of the pixels above noise (see `NOISE`) summed +/// and divided by the whole row's channel count, so noise pixels add nothing but still count in +/// the denominator; and how many pixels differ by more than 2 at all. A band artifact differs along +/// a whole row, by more than noise. fn row_stats(x: &[u8], y: &[u8]) -> (f64, usize) { let mut sum = 0.0; let mut off = 0; @@ -84,8 +85,8 @@ fn row_diffs(a: &Pixmap, b: &Pixmap) -> Vec<(f64, usize)> { a.data().chunks(row).zip(b.data().chunks(row)).map(|(x, y)| row_stats(x, y)).collect() } -/// Whether a row passes: the original mean limit over non-noise pixels, and at most a twentieth -/// of the row differing at all. +/// Whether a row passes: the original 0.25 limit on the mean from `row_stats`, and at most a +/// twentieth of the row differing at all. fn row_ok(mean: f64, off: usize, width: usize) -> bool { mean < 0.25 && off * 20 <= width } @@ -94,10 +95,13 @@ fn row_ok(mean: f64, off: usize, width: usize) -> bool { fn a_real_band_artifact_fails_but_edge_noise_passes() { let width = 880; // scale 2 let flat = vec![100u8; width * 4]; - // 44 pixels differing by 60 per channel: under the old mean allowance, but a real artifact. + // 44 pixels whose colour channels differ by 60 (alpha unchanged): the mean is + // 44 * 3 * 60 / (880 * 4) = 2.25, which the earlier `0.25 + 0.05 * off` allowance (2.45 here) + // let through; the count, 44, is within a twentieth of the row. A real artifact, so it fails + // on the mean now. let mut artifact = flat.clone(); for px in artifact.chunks_mut(4).take(44) { - px.iter_mut().for_each(|c| *c += 60); + px.iter_mut().take(3).for_each(|c| *c += 60); } let (mean, off) = row_stats(&flat, &artifact); assert!(!row_ok(mean, off, width), "{mean} {off}"); From 9c2c2cb74eb3a960dc3f36ab55bd7e603a1e2601 Mon Sep 17 00:00:00 2001 From: Davit Matchakhelidze Date: Mon, 9 Nov 2026 00:59:12 +0400 Subject: [PATCH 09/19] i18n(ka): place the new rows next to their English keys (review) --- crates/ui-egui/locales/ka.toml | 228 ++++++++++++++++----------------- 1 file changed, 114 insertions(+), 114 deletions(-) diff --git a/crates/ui-egui/locales/ka.toml b/crates/ui-egui/locales/ka.toml index 8a4a70475..80b99a957 100644 --- a/crates/ui-egui/locales/ka.toml +++ b/crates/ui-egui/locales/ka.toml @@ -16,7 +16,10 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "({n} warnings: some entries were skipped)" = { one = "(გაფრთხილება: {n}; ზოგი ჩანაწერი გამოტოვებულია)", other = "(გაფრთხილება: {n}; ზოგი ჩანაწერი გამოტოვებულია)" } "+ Create variable" = "+ ცვლადის შექმნა" ".fig (experimental)" = ".fig (ექსპერიმენტული)" +"1 year" = "1 წელი" "1…9, 0" = "1…9, 0" +"30 days" = "30 დღე" +"90 days" = "90 დღე" "@{login}: {prs} PRs, {commits} commits, +{added} / −{deleted} lines (Δ {delta}), +{bin_added} / −{bin_deleted} binary assets, {first} – {last}" = "@{login}: PR: {prs}, კომიტი: {commits}, +{added} / −{deleted} სტრიქონი (Δ {delta}), +{bin_added} / −{bin_deleted} ბინარული რესურსი, {first} – {last}" "A collection of this file with these modes and variables: override their values per mode and add variables of its own" = "ამ ფაილის კოლექცია ამ რეჟიმებითა და ცვლადებით: შეცვალეთ მათი მნიშვნელობები თითოეული რეჟიმისთვის და დაამატეთ საკუთარი ცვლადები" "A .figcraft file with this name already exists. Choose its full name to confirm replacement." = "ამ სახელით .figcraft ფაილი უკვე არსებობს. ჩანაცვლების დასადასტურებლად აირჩიეთ მისი სრული სახელი." @@ -105,13 +108,14 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "All supported properties" = "ყველა მხარდაჭერილი თვისება" "All the fonts this file uses are installed" = "ამ ფაილის ყველა შრიფტი დაინსტალირებულია" "All variables" = "ყველა ცვლადი" +"Allow and download" = "დაშვება და ჩამოტვირთვა" +"Allow downloading fonts?" = "დაიშვას შრიფტების ჩამოტვირთვა?" "Along the bottom" = "ქვედა კიდის გასწვრივ" "Along the left" = "მარცხენა კიდის გასწვრივ" "Along the right" = "მარჯვენა კიდის გასწვრივ" "Along the top" = "ზედა კიდის გასწვრივ" "Alpha" = "ალფა" "Alphabetical" = "ანბანის მიხედვით" -"Alt+double-click an edge of an auto layout child" = "Alt+ორმაგი დაწკაპუნება ავტოგანლაგების შვილობილი ელემენტის კიდეზე" "Alt+drag" = "Alt+გადათრევა" "An analytics screen on a grid: figures, charts drawn from vectors and a table" = "ანალიტიკა ბადეზე: ციფრები, დიაგრამები და ცხრილი" "An earlier vote" = "ადრინდელი კენჭისყრა" @@ -160,7 +164,6 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Auto layout" = "ავტოგანლაგება" "Auto rows" = "ავტომატური სტრიქონები" "Auto width" = "ავტომატური სიგანე" -"Auto: by the first letter with a direction" = "ავტომატური: მიმართულების მქონე პირველი ასოს მიხედვით" "Back to the FigCraft server" = "FigCraft-ის სერვერზე დაბრუნება" "Back to the font's value" = "შრიფტის მნიშვნელობაზე დაბრუნება" "Back" = "უკან" @@ -189,6 +192,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Blend mode" = "შერევის რეჟიმი" "Blue" = "ლურჯი" "Blur" = "გაბუნდოვნება" +"Board grid" = "დაფის ბადე" "Boolean" = "ლოგიკური" "Boolean groups" = "ლოგიკური ოპერაციების ჯგუფები" "Both directions" = "ორივე მიმართულება" @@ -220,6 +224,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Bulleted list" = "ბურთულებიანი სია" "C or Shift+C" = "C ან Shift+C" "C or ⇧C" = "C ან ⇧C" +"Changed {date}" = "შეცვლილია: {date}" "CMYK colour" = "CMYK ფერი" "Can view" = "შეუძლია ნახვა" "Can comment" = "შეუძლია კომენტარი" @@ -237,6 +242,8 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Connector" = "შემაერთებელი" "Convert to frame" = "ჩარჩოდ გარდაქმნა" "Convert to section" = "სექციად გარდაქმნა" +"Copy browser link" = "ბრაუზერის ბმულის კოპირება" +"Couldn't reach {server} for its team list." = "{server}-იდან გუნდის სიის მიღება ვერ მოხერხდა." "CSS custom properties…" = "CSS-ის მორგებული თვისებები…" "Can edit" = "შეუძლია რედაქტირება" "Can't read this library: {e}" = "ამ ბიბლიოთეკის წაკითხვა ვერ მოხერხდა: {e}" @@ -341,7 +348,6 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Copy as PNG" = "კოპირება როგორც PNG" "Copy as SVG" = "კოპირება როგორც SVG" "Copy code" = "კოდის კოპირება" -"Copy for AI" = "კოპირება AI-სთვის" "Copy link" = "ბმულის კოპირება" "Copy the {label}" = "კოპირება: {label}" "Copy {value}" = "კოპირება: {value}" @@ -368,11 +374,12 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Create style from the selected text" = "სტილის შექმნა მონიშნული ტექსტიდან" "Created" = "შექმნილია" "Crop" = "ჩამოჭრა" +"Crop image" = "გამოსახულების ჩამოჭრა" "Crop marks" = "ჭრის ნიშნები" -"Ctrl+Alt+← ↑ → ↓" = "Ctrl+Alt+← ↑ → ↓" "Ctrl+arrows" = "Ctrl+ისრები" "Ctrl+click" = "Ctrl+დაწკაპუნება" "Ctrl+click a padding field" = "Ctrl+დაწკაპუნება შიდა დაშორების ველზე" +"⌘ click a padding field" = "⌘ დაწკაპუნება შიდა დაშორების ველზე" "Ctrl+scroll" = "Ctrl+გადახვევა" "Current name" = "მიმდინარე სახელი" "Current version" = "მიმდინარე ვერსია" @@ -392,53 +399,40 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Decoration style" = "გაფორმების სტილი" "Decoration" = "გაფორმება" "Deep select" = "ღრმა მონიშვნა" +"Scrub a field faster (2x) or slower (1/2, 1/4)" = "ველის მნიშვნელობის გადათრევით ცვლა უფრო სწრაფად (2x) ან ნელა (1/2, 1/4)" +"Move up or down while dragging its label" = "ზემოთ ან ქვემოთ გადაადგილება მისი იარლიყის გადათრევისას" +"Scrubbing at 2x" = "გადათრევით ცვლა: 2x" +"Scrubbing at 1x" = "გადათრევით ცვლა: 1x" +"Scrubbing at 1/2" = "გადათრევით ცვლა: 1/2" +"Scrubbing at 1/4" = "გადათრევით ცვლა: 1/4" "Delete {n} variables" = { one = "ცვლადის წაშლა: {n}", other = "ცვლადის წაშლა: {n}" } -"Disconnected. Reconnecting…" = "კავშირი გაწყდა. ხელახლა დაკავშირება…" -"Disconnected. Your edits stay here and sync when the connection returns. Reconnecting…" = "კავშირი გაწყდა. თქვენი ცვლილებები აქ რჩება და სინქრონიზდება, როცა კავშირი აღდგება. ხელახლა დაკავშირება…" -"Dismiss" = "უგულებელყოფა" -"Double-click an edge of an auto layout frame" = "ორმაგი დაწკაპუნება ავტოგანლაგების ჩარჩოს კიდეზე" -"Edit padding on all sides" = "შიდა დაშორების რედაქტირება ყველა მხარეს" -"Enter / Shift+Enter" = "Enter / Shift+Enter" -"Expand the interface" = "ინტერფეისის გაშლა" -"Hide UI" = "ინტერფეისის დამალვა" -"Left to right" = "მარცხნიდან მარჯვნივ" "Move out of any group" = "ჯგუფიდან გამოტანა" "Move to group {group}" = "ჯგუფში გადატანა: {group}" -"Move up or down while dragging its label" = "ზემოთ ან ქვემოთ გადაადგილება მისი იარლიყის გადათრევისას" -"Not connected: {reason}. Your work is still in this tab." = "კავშირი არ არის: {reason}. თქვენი ნამუშევარი ისევ ამ ჩანართშია." -"Nothing to pick: the page is empty" = "ასარჩევი არაფერია: გვერდი ცარიელია" -"Pick select: Tab and Shift+Tab move between layers, Enter goes into one, Shift+Enter out, Space selects, Escape cancels" = "შრის არჩევა: Tab და Shift+Tab შრეებს შორის გადაადგილდება, Enter შრეში შედის, Shift+Enter გამოდის, Space მონიშნავს, Escape გააუქმებს" -"Pick select: into a layer, out to its parent" = "შრის არჩევა: შრეში შესვლა, მშობელზე გასვლა" -"Pick select: next or previous layer" = "შრის არჩევა: შემდეგი ან წინა შრე" -"Pick select: select the picked layer" = "შრის არჩევა: არჩეული შრის მონიშვნა" -"Remove all auto layout" = "ყველა ავტოგანლაგების მოხსნა" -"Retry now" = "ახლავე ხელახლა ცდა" -"Right to left" = "მარჯვნიდან მარცხნივ" -"Rotate a degree (Shift: 15)" = "ერთი გრადუსით შემობრუნება (Shift: 15)" -"Same as file ({profile})" = "როგორც ფაილში ({profile})" -"Save a copy…" = "ასლის შენახვა…" "Scope: all supported properties" = "არე: ყველა მხარდაჭერილი თვისება" "Scope: hidden from pickers" = "არე: ამომრჩევებში დამალული" "Scope: only {scope}" = "არე: მხოლოდ {scope}" -"Scrub a field faster (2x) or slower (1/2, 1/4)" = "ველის მნიშვნელობის გადათრევით ცვლა უფრო სწრაფად (2x) ან ნელა (1/2, 1/4)" -"Scrubbing at 1/2" = "გადათრევით ცვლა: 1/2" -"Scrubbing at 1/4" = "გადათრევით ცვლა: 1/4" -"Scrubbing at 1x" = "გადათრევით ცვლა: 1x" -"Scrubbing at 2x" = "გადათრევით ცვლა: 2x" -"Selection box: switch to pick select" = "მონიშვნის ჩარჩო: შრის არჩევაზე გადართვა" -"Set fill container" = "ზომა: კონტეინერის შევსება" -"Set hug contents" = "ზომა: შიგთავსზე მორგება" -"Show and move the placement crosshair (its tool chosen, nothing selected)" = "განთავსების ჯვრის ჩვენება და გადაადგილება (არჩეული ხელსაწყოთი, როცა არაფერია მონიშნული)" -"Space" = "Space" -"Tab or Ctrl+Space again" = "Tab ან ხელახლა Ctrl+Space" -"Text direction" = "ტექსტის მიმართულება" -"The bars are hidden. {shortcut} shows them again" = "ზოლები დამალულია. {shortcut} ისევ აჩვენებს მათ" +"Disconnected. Reconnecting…" = "კავშირი გაწყდა. ხელახლა დაკავშირება…" +"Disconnected. Your edits stay here and sync when the connection returns. Reconnecting…" = "კავშირი გაწყდა. თქვენი ცვლილებები აქ რჩება და სინქრონიზდება, როცა კავშირი აღდგება. ხელახლა დაკავშირება…" +"Dismiss" = "უგულებელყოფა" +"Not connected: {reason}. Your work is still in this tab." = "კავშირი არ არის: {reason}. თქვენი ნამუშევარი ისევ ამ ჩანართშია." +"Retry now" = "ახლავე ხელახლა ცდა" +"Save a copy…" = "ასლის შენახვა…" "Wrap style" = "გადატანის სტილი" +"Text direction" = "ტექსტის მიმართულება" +"Auto: by the first letter with a direction" = "ავტომატური: მიმართულების მქონე პირველი ასოს მიხედვით" +"Left to right" = "მარცხნიდან მარჯვნივ" +"Right to left" = "მარჯვნიდან მარცხნივ" "Balance" = "დაბალანსებული" "Pretty" = "მოწესრიგებული" "Auto: as many words as fit on each line" = "ავტომატური: თითო სტრიქონში იმდენი სიტყვა, რამდენიც ეტევა" "Balance: every line close to the same length" = "დაბალანსებული: ყველა სტრიქონი დაახლოებით ერთი სიგრძისაა" "Pretty: full lines, no one word alone on the last" = "მოწესრიგებული: სავსე სტრიქონები, ბოლო სტრიქონზე ერთი სიტყვა მარტო არ რჩება" +"Set hug contents" = "ზომა: შიგთავსზე მორგება" +"Set fill container" = "ზომა: კონტეინერის შევსება" +"Double-click an edge of an auto layout frame" = "ორმაგი დაწკაპუნება ავტოგანლაგების ჩარჩოს კიდეზე" +"{name}, disconnected from its live session" = "{name}, ცოცხალ სესიასთან კავშირი გაწყვეტილია" +"⌥ double-click an edge of an auto layout child" = "⌥ ორმაგი დაწკაპუნება ავტოგანლაგების შვილობილი ელემენტის კიდეზე" +"Alt+double-click an edge of an auto layout child" = "Alt+ორმაგი დაწკაპუნება ავტოგანლაგების შვილობილი ელემენტის კიდეზე" "Default" = "ნაგულისხმევი" "Default content" = "ნაგულისხმევი შიგთავსი" "Default value (the top-left variant)" = "ნაგულისხმევი მნიშვნელობა (ზედა მარცხენა ვარიანტი)" @@ -468,6 +462,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Desktop" = "დესკტოპი" "Destination" = "დანიშნულება" "Detach alias" = "ალიასის გამოყოფა" +"Detach calculation" = "გამოთვლის გამოყოფა" "Detach instance" = "ინსტანსის გამოყოფა" "Detach property" = "თვისების გამოყოფა" "Detach style" = "სტილის გამოყოფა" @@ -499,6 +494,8 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Dots" = "წერტილები" "Dotted" = "პუნქტირი" "Down" = "ქვემოთ" +"Download" = "ჩამოტვირთვა" +"Downloading… {percent}%" = "ჩამოტვირთვა… {percent}%" "Drafts" = "მონახაზები" "Drag the stroke to add a width point" = "გადაათრიეთ კონტური სიგანის წერტილის დასამატებლად" "Draw" = "ხატვა" @@ -508,6 +505,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Drop to import" = "ჩააგდეთ იმპორტისთვის" "Drop to open" = "ჩააგდეთ გასახსნელად" "Drop shadow" = "ჩრდილი" +"Drop to use this image" = "ჩააგდეთ ამ გამოსახულების გამოსაყენებლად" "Dual-licensed MIT OR Apache-2.0. Made by the ArtCraft team and community." = "ორმაგი ლიცენზია: MIT OR Apache-2.0. შექმნილია ArtCraft-ის გუნდისა და საზოგადოების მიერ." "Duo" = "დუო" "Duplicate" = "დუბლირება" @@ -521,6 +519,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Edit dev resource" = "დეველოპერის რესურსის რედაქტირება" "Edit link" = "რედაქტირების ბმული" "Edit link copied" = "რედაქტირების ბმული დაკოპირდა" +"Edit padding on all sides" = "შიდა დაშორების რედაქტირება ყველა მხარეს" "Edit style" = "სტილის რედაქტირება" "Edit variable" = "ცვლადის რედაქტირება" "Edit with the builder" = "კონსტრუქტორით რედაქტირება" @@ -548,6 +547,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Essential" = "ძირითადი" "Every conflict has a choice." = "ყველა კონფლიქტს არჩევანი აქვს." "Every top-level frame already starts a flow" = "ყველა ზედა დონის ჩარჩო უკვე იწყებს ნაკადს" +"Everyone who reaches this server can open these files while they are shared." = "ამ სერვერთან წვდომის მქონე ყველას შეუძლია ამ ფაილების გახსნა, სანამ ისინი გაზიარებულია." "Exact opacity (4 then 5: 45%)" = "ზუსტი გაუმჭვირვალობა (4, შემდეგ 5: 45%)" "Exclude" = "გამორიცხვა" "Excluded" = "გამორიცხული" @@ -556,6 +556,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Exclusion" = "გამორიცხვა" "Exit focus view (Esc)" = "ფოკუსის ხედიდან გასვლა (Esc)" "Expand" = "გაშლა" +"Expand the interface" = "ინტერფეისის გაშლა" "Export" = "ექსპორტირება" "Export all" = "ყველაფრის ექსპორტირება" "Export frames and layers as PNG, JPG, SVG or PDF" = "ჩარჩოები და შრეები PNG, JPG, SVG ან PDF ფორმატში" @@ -582,6 +583,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Fetching from the server…" = "სერვერიდან მიღება…" "FigCraft couldn't open its window: {error}" = "FigCraft-მა ფანჯრის გახსნა ვერ შეძლო: {error}" "FigCraft doesn't support every feature of these files yet. The notes list what was left out or changed in the imported copy; the original file is unchanged." = "FigCraft ჯერ ამ ფაილების ყველა შესაძლებლობას არ უჭერს მხარს. შენიშვნებში ჩამოთვლილია, რა გამოტოვდა ან შეიცვალა იმპორტირებულ ასლში; ორიგინალი ფაილი უცვლელია." +"FigCraft stopped because of an internal error." = "FigCraft-ის მუშაობა შიდა შეცდომის გამო შეწყდა." "File" = "ფაილი" "File name" = "ფაილის სახელი" "File not found" = "ფაილი ვერ მოიძებნა" @@ -638,6 +640,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Frame selection" = "მონიშნულის ჩარჩოში მოქცევა" "Frame tools" = "ჩარჩოს ხელსაწყოები" "Frames" = "ჩარჩოები" +"Free fonts come from Google Fonts and Noto, through jsDelivr and GitHub. Each file is checked against the font index before it is installed into the font folder the Craft apps share. Nothing is downloaded until you allow it." = "უფასო შრიფტები Google Fonts-იდან და Noto-დან მოდის, jsDelivr-ისა და GitHub-ის გავლით. თითოეული ფაილი შრიფტების ინდექსთან მოწმდება, სანამ Craft-აპების საერთო შრიფტების საქაღალდეში დაინსტალირდება. სანამ არ დაუშვებთ, არაფერი ჩამოიტვირთება." "From the library \"{name}\": read-only" = "ბიბლიოთეკიდან „{name}“: მხოლოდ წასაკითხად" "From {name}" = "წყარო: {name}" "From {server}" = "წყარო: {server}" @@ -653,6 +656,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Go to {name}" = "{name}-ზე გადასვლა" "Grab bag" = "სხვადასხვა" "Gradient" = "გრადიენტი" +"Graph paper" = "მილიმეტრიანი ქაღალდი" "Gray" = "ნაცრისფერი" "Green" = "მწვანე" "Greyscale components and two example screens to sketch a flow with" = "ნაცრისფერი კომპონენტები ნაკადის ჩანახატისთვის" @@ -675,6 +679,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Help page" = "დახმარების გვერდი" "Here: {names}" = "აქ: {names}" "Hidden" = "დამალული" +"Hide UI" = "ინტერფეისის დამალვა" "Hide contents" = "შიგთავსის დამალვა" "Hide from publishing" = "გამოქვეყნებისას დამალვა" "Hide section contents" = "სექციის შიგთავსის დამალვა" @@ -766,6 +771,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Join with a code" = "კოდით შეერთება" "Joined" = "შეერთებულია" "Joined {file}" = "შეერთებულია: {file}" +"Joining live session…" = "ცოცხალ სესიასთან შეერთება…" "Joining…" = "შეერთება…" "Join|stroke" = "შეერთება" "Jul" = "ივლ" @@ -827,6 +833,8 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Lines deleted" = "წაშლილი სტრიქონები" "Link" = "ბმული" "Link copied" = "ბმული დაკოპირდა" +"Link copied: it opens the file in FigCraft" = "ბმული დაკოპირდა: ის ფაილს FigCraft-ში ხსნის" +"Link copied: it opens the file in the browser" = "ბმული დაკოპირდა: ის ფაილს ბრაუზერში ხსნის" "Link docs, code or tickets for developers." = "მიაბით დოკუმენტაცია, კოდი ან ტიკეტები დეველოპერებისთვის." "Link frames on the Prototype tab, then present the flow" = "დააკავშირეთ ჩარჩოები და წარადგინეთ ნაკადი" "Link this component to its code component: instances then show your real snippet with their values." = "დააკავშირეთ ეს კომპონენტი მის კოდის კომპონენტთან: ინსტანსები მაშინ თქვენს რეალურ ფრაგმენტს აჩვენებს მათი მნიშვნელობებით." @@ -849,10 +857,15 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Make a component" = "შექმენით კომპონენტი" "Make slot" = "სლოტად გადაქცევა" "New collection" = "ახალი კოლექცია" +"Nobody shares a file there now." = "იქ ახლა არავინ აზიარებს ფაილს." +"Past 30 days" = "ბოლო 30 დღე" +"Past 90 days" = "ბოლო 90 დღე" +"Past year" = "ბოლო წელი" "Pasted design layers" = "ჩასმული დიზაინის ფენები" "Pasted design layers; the clipboard didn't carry the images of: {layers}" = "დიზაინის ფენები ჩაისვა; ბუფერში არ იყო შემდეგის სურათები: {layers}" "Remove these results from the file" = "ამ შედეგების ფაილიდან წაშლა" "Scroll wheel zoom" = "მასშტაბირება გადახვევის ბორბლით" +"Shared by your team on {server}" = "თქვენი გუნდის მიერ {server}-ზე გაზიარებული" "Slot name" = "სლოტის სახელი" "Mar" = "მარ" "Margin" = "ველი" @@ -987,15 +1000,18 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Not bound" = "მიბმული არ არის" "Not in a live session" = "ცოცხალ სესიაში არ ხართ" "Not in this font" = "ამ შრიფტში არ არის" +"Not now" = "ახლა არა" "Not properties, kept as written: {names}" = "არ არის თვისებები, დარჩა დაწერილი სახით: {names}" "Not read yet" = "ჯერ არ არის წაკითხული" "Check for updates" = "განახლებების შემოწმება" "Not checked yet" = "ჯერ არ არის შემოწმებული" "Someone who left" = "ვინც წავიდა" "Take the results off the board; they stay in the file" = "შედეგების დაფიდან მოხსნა; ფაილში დარჩება" +"Upload from computer" = "კომპიუტერიდან ატვირთვა" "This file uses team libraries on servers you haven't used here. They aren't contacted until you check them." = "ეს ფაილი იყენებს გუნდის ბიბლიოთეკებს სერვერებზე, რომლებიც აქ არ გამოგიყენებიათ. მათ არ დავუკავშირდებით, სანამ არ შეამოწმებთ." "Not shared" = "არ არის გაზიარებული" "Note {n}" = "შენიშვნა {n}" +"Nothing counted yet" = "ჯერ არაფერი დათვლილა" "Nothing changed since this version." = "ამ ვერსიის შემდეგ არაფერი შეცვლილა." "Nothing changed since this was marked ready for dev." = "მას შემდეგ, რაც მზად დეველოპერისთვის მოინიშნა, არაფერი შეცვლილა." "Nothing here yet. Set a frame's status to list it." = "აქ ჯერ არაფერია. ჩარჩოს სიაში გამოსაჩენად მიანიჭეთ სტატუსი." @@ -1004,6 +1020,9 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Nov" = "ნოე" "Now" = "ახლა" "Nudge (Shift: big nudge)" = "მცირედ გადაწევა (Shift: დიდი ბიჯით)" +"Rotate a degree (Shift: 15)" = "ერთი გრადუსით შემობრუნება (Shift: 15)" +"⌥⌘ ← ↑ → ↓" = "⌥⌘ ← ↑ → ↓" +"Ctrl+Alt+← ↑ → ↓" = "Ctrl+Alt+← ↑ → ↓" "Nudge amount" = "მცირედ გადაწევის ბიჯი" "Number" = "რიცხვი" "Number ↑" = "რიცხვი ↑" @@ -1080,6 +1099,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Pages: {pages}" = "გვერდი: {pages}" "Paint bucket" = "საღებავის ვედრო" "Pan the canvas" = "ტილოს გადაადგილება" +"Show and move the placement crosshair (its tool chosen, nothing selected)" = "განთავსების ჯვრის ჩვენება და გადაადგილება (არჩეული ხელსაწყოთი, როცა არაფერია მონიშნული)" "Pan with nothing selected (Shift: farther)" = "გადაადგილება, როცა არაფერია მონიშნული (Shift: უფრო შორს)" "Panels" = "პანელები" "Paper" = "ქაღალდი" @@ -1189,9 +1209,13 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Regular expression" = "რეგულარული გამოსახულება" "Relative to" = "მიმართ" "Relative to your system's display scaling (100% is the system's own size). Document zoom is separate." = "სისტემის ეკრანის მასშტაბირებასთან მიმართებით (100% სისტემის საკუთარი ზომაა). დოკუმენტის მასშტაბი ცალკე რეგულირდება." +"Reload the page to get back the unsaved files the browser had room for." = "განაახლეთ გვერდი, რომ დაიბრუნოთ ის შეუნახავი ფაილები, რომლებიც ბრაუზერში დაეტია." +"Reload the page to get your unsaved files back." = "განაახლეთ გვერდი, რომ შეუნახავი ფაილები დაიბრუნოთ." +"Reload the page to start again." = "თავიდან დასაწყებად განაახლეთ გვერდი." "Remove" = "წაშლა" "Remove all" = "ყველას წაშლა" "Remove annotation" = "ანოტაციის წაშლა" +"Remove all auto layout" = "ყველა ავტოგანლაგების მოხსნა" "Remove auto layout" = "ავტოგანლაგების მოხსნა" "Remove column" = "სვეტის წაშლა" "Remove dev resource" = "დეველოპერის რესურსის წაშლა" @@ -1243,6 +1267,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Reset adjustments" = "კორექციების ჩამოყრა" "Reset all changes" = "ყველა ცვლილების ჩამოყრა" "Reset all overrides on this layer" = "ამ შრის ყველა გადაფარვის ჩამოყრა" +"Reset grid" = "ბადის ჩამოყრა" "Reset overrides" = "გადაფარვების ჩამოყრა" "Reset slot" = "სლოტის ჩამოყრა" "Reset this override" = "ამ გადაფარვის ჩამოყრა" @@ -1297,6 +1322,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "See all templates" = "ყველა შაბლონის ნახვა" "Select layers and they space themselves as their content changes" = "შრეები შიგთავსის ცვლილებისას თავად დაშორდება" "SHA-256: {sha}…" = "SHA-256: {sha}…" +"Same as file ({profile})" = "როგორც ფაილში ({profile})" "Same as layer" = "შრის მსგავსად" "Saturation" = "გაჯერება" "Save" = "შენახვა" @@ -1322,6 +1348,8 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Search files and templates" = "ფაილებისა და შაბლონების ძიება" "Search results" = "ძიების შედეგები" "Search fonts" = "შრიფტების ძიება" +"This server doesn't count insertions" = "ეს სერვერი ჩასმებს არ ითვლის" +"This server doesn't count styles and variables" = "ეს სერვერი სტილებსა და ცვლადებს არ ითვლის" "Use fonts installed on this computer…" = "ამ კომპიუტერზე დაყენებული შრიფტების გამოყენება…" "Search layers" = "შრეების ძიება" "Search shortcuts" = "მალსახმობების ძიება" @@ -1381,6 +1409,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Show device frame" = "მოწყობილობის კორპუსის ჩვენება" "Show dimensions on objects" = "ზომების ჩვენება ობიექტებზე" "Show hotspot hints" = "აქტიური არეების მინიშნებების ჩვენება" +"The bars are hidden. {shortcut} shows them again" = "ზოლები დამალულია. {shortcut} ისევ აჩვენებს მათ" "Show in Explorer" = "Explorer-ში ჩვენება" "Show in Finder" = "Finder-ში ჩვენება" "Show in folder" = "საქაღალდეში ჩვენება" @@ -1484,6 +1513,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Stroke style" = "კონტურის სტილი" "Stroke weight" = "კონტურის სისქე" "Strokes" = "კონტურები" +"Strong line every" = "მუქი ხაზის ბიჯი" "Style" = "სტილი" "Styles" = "სტილები" "Stylistic set 1" = "სტილისტური ნაკრები 1" @@ -1707,6 +1737,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Your copy stays open; the file stays on the server" = "თქვენი ასლი ღია რჩება; ფაილი სერვერზე რჩება" "Your name" = "თქვენი სახელი" "Your system asks for reduced motion: animations stay off." = "თქვენი სისტემა ითხოვს მოძრაობის შემცირებას: ანიმაციები გამორთული რჩება." +"Your unsaved files were too large for the browser to keep." = "თქვენი შეუნახავი ფაილები ბრაუზერისთვის შესანახად ზედმეტად დიდი იყო." "Z" = "Z" "Z to A" = "ჰ-დან ა-მდე" "Zoom" = "მასშტაბი" @@ -1740,6 +1771,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "connector label was skipped: text style data is missing" = "შემაერთებლის იარლიყი გამოტოვებულია: ტექსტის სტილის მონაცემები აკლია" "connector label was skipped: text transform is invalid" = "შემაერთებლის იარლიყი გამოტოვებულია: ტექსტის გარდაქმნა არასწორია" "connector labels were skipped" = "შემაერთებლების იარლიყები გამოტოვებულია" +"connector labels without a saved snapshot are centred on the line, without their background" = "შენახული სნეპშოტის გარეშე შემაერთებლის იარლიყები ხაზზე ცენტრდება, ფონის გარეშე" "connector layers import as static frame/vector snapshots with labels when present; live endpoint bindings are not retained" = "შემაერთებლის შრეები იმპორტირდება ჩარჩოს ან ვექტორის სტატიკური სნეპშოტების სახით, იარლიყებით (თუ არის); ბოლოების ცოცხალი მიბმები არ ნარჩუნდება" "connector snapshot vector data is missing; connector was left empty" = "შემაერთებლის სნეპშოტის ვექტორული მონაცემები აკლია; შემაერთებელი ცარიელი დარჩა" "connectors whose ends can't be placed are empty" = "შემაერთებლები, რომელთა ბოლოების განთავსება ვერ ხერხდება, ცარიელია" @@ -1751,6 +1783,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "duplicate grid track sizing entries use equal tracks" = "ბადის ტრეკის ზომის დუბლირებული ჩანაწერებისას ტრეკები თანაბარია" "e.g. count + 1" = "მაგ. count + 1" "e.g. count >= 3 and not done" = "მაგ. count >= 3 and not done" +"elbowed and curved connectors without a saved path follow FigCraft's own routing" = "შენახული ტრაექტორიის გარეშე კუთხოვანი და მრუდი შემაერთებლები FigCraft-ის საკუთარ მარშრუტს მიჰყვება" "entries without a node type were skipped" = "კვანძის ტიპის გარეშე ჩანაწერები გამოტოვებულია" "figcraft:// links from a browser, chat or email open this app and join the session." = "ბრაუზერიდან, ჩატიდან ან ელფოსტიდან figcraft:// ბმულები ხსნის ამ აპს და უერთდება სესიას." "from {server}" = "წყარო: {server}" @@ -1772,12 +1805,15 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "invalid internal .fig text path data was ignored" = ".fig-ის შიდა ტექსტის ტრაექტორიის არასწორი მონაცემები იგნორირებულია" "invalid or oversized vector networks import as outlines" = "არასწორი ან ზედმეტად დიდი ვექტორული ქსელები კონტურებად იმპორტირდება" "invalid or oversized vector path data was skipped" = "ვექტორული ტრაექტორიის არასწორი ან ზედმეტად დიდი მონაცემები გამოტოვებულია" +"invalid vector region fill paint list; layer fill used" = "ვექტორული არის შევსების საღებავების სია არასწორია; გამოყენებულია შრის შევსება" +"invalid vector region paints were skipped" = "ვექტორული არის არასწორი საღებავები გამოტოვებულია" "just now" = "ახლახან" "key triggers without a supported key were skipped" = "მხარდაჭერილი კლავიშის გარეშე კლავიშის გამშვებები გამოტოვებულია" "key up triggers import as key presses" = "კლავიშის აშვების გამშვებები კლავიშის დაჭერებად იმპორტირდება" "layers without a position were placed at their parent's origin" = "პოზიციის გარეშე შრეები მშობლის საწყის წერტილში განთავსდა" "layers without a type were skipped" = "ტიპის გარეშე შრეები გამოტოვებულია" "legacy image filter container is unsupported; filter conversion was skipped" = "გამოსახულების ფილტრების ძველი კონტეინერი მხარდაუჭერელია; ფილტრების გარდაქმნა გამოტოვებულია" +"linked vector region fill styles keep resolved appearance; live style links were left out" = "ვექტორული არის მიბმული შევსების სტილები გამოთვლილ იერსახეს ინარჩუნებს; სტილების ცოცხალი კავშირები არ გადმოვიდა" "links to shared styles that aren't in the file kept the layers' own values" = "ფაილში არარსებულ საერთო სტილებზე ბმულებმა შეინარჩუნეს ფენების საკუთარი მნიშვნელობები" "locked" = "ჩაკეტილი" "malformed image filters container was skipped" = "გამოსახულების ფილტრების დაზიანებული კონტეინერი გამოტოვებულია" @@ -1786,6 +1822,10 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "no bleed" = "ჭრისპირა არის გარეშე" "nobody else here yet" = "აქ ჯერ სხვა არავინაა" "non-default slot settings are not represented and were skipped" = "სლოტის არანაგულისხმევი პარამეტრები არ არის წარმოდგენილი და გამოტოვებულია" +"note or shape generated child has invalid bounds; child skipped" = "შენიშვნის ან ფიგურის გენერირებულ შვილობილ ელემენტს არასწორი საზღვრები აქვს; ელემენტი გამოტოვებულია" +"note or shape generated child is missing its style or bounds; child skipped" = "შენიშვნის ან ფიგურის გენერირებულ შვილობილ ელემენტს სტილი ან საზღვრები აკლია; ელემენტი გამოტოვებულია" +"note or shape generated children exceed the layer or nesting limit; remaining children skipped" = "შენიშვნის ან ფიგურის გენერირებული შვილობილი ელემენტები შრეების ან ჩადგმის ლიმიტს აჭარბებს; დანარჩენი ელემენტები გამოტოვებულია" +"note or shape generated layout is missing or unsupported; using its outer frame" = "შენიშვნის ან ფიგურის გენერირებული განლაგება აკლია ან მხარდაუჭერელია; გამოიყენება მისი გარე ჩარჩო" "now" = "ახლა" "offer files to save if it asks to (you choose where each one goes)" = "შესანახად ფაილების შეთავაზება, თუ ამას ითხოვს (თითოეულის ადგილს თქვენ ირჩევთ)" "only in a text style or variable" = "მხოლოდ ტექსტის სტილში ან ცვლადში" @@ -1809,6 +1849,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "set-variable actions with values that don't fit the variable were skipped" = "ცვლადის დაყენების მოქმედებები, რომელთა მნიშვნელობა ცვლადს არ შეესაბამება, გამოტოვებულია" "set-variable actions without a value were skipped" = "მნიშვნელობის გარეშე ცვლადის დაყენების მოქმედებები გამოტოვებულია" "set-variable-mode actions on collections or modes that aren't in the variables JSON were skipped" = "ცვლადის რეჟიმის დაყენების მოქმედებები იმ კოლექციებზე ან რეჟიმებზე, რომლებიც ცვლადების JSON-ში არ არის, გამოტოვებულია" +"shape generated outline is missing or damaged; using its rectangle" = "ფიგურის გენერირებული კონტური აკლია ან დაზიანებულია; გამოიყენება მისი მართკუთხედი" "slot content assignment target is missing or is not slot content" = "სლოტის შიგთავსის მინიჭების სამიზნე აკლია ან სლოტის შიგთავსი არ არის" "slot content assignment uses the empty GUID sentinel and was skipped" = "სლოტის შიგთავსის მინიჭება ცარიელ GUID მარკერს იყენებს და გამოტოვებულია" "slot layers without a matching slot property were imported as frames" = "სლოტის შრეები, რომლებსაც შესაბამისი სლოტის თვისება არ აქვს, ჩარჩოებად იმპორტირდა" @@ -1834,10 +1875,13 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "variable modes of collections that aren't in the file were skipped" = "იმ კოლექციების ცვლადის რეჟიმები, რომლებიც ფაილში არ არის, გამოტოვებულია" "variable modes of collections that aren't in the variables JSON were skipped" = "იმ კოლექციების ცვლადის რეჟიმები, რომლებიც ცვლადების JSON-ში არ არის, გამოტოვებულია" "variable values that don't match their type (or composed colours) were skipped" = "ცვლადის მნიშვნელობები, რომლებიც თავიანთ ტიპს არ შეესაბამება (ან შედგენილი ფერები), გამოტოვებულია" +"variable-bound vector region paints keep resolved appearance; live bindings were left out" = "ცვლადებზე მიბმული ვექტორული არის საღებავები გამოთვლილ იერსახეს ინარჩუნებს; ცოცხალი მიბმები არ გადმოვიდა" "variables of unknown types were skipped" = "უცნობი ტიპის ცვლადები გამოტოვებულია" "variables whose collection isn't in the variables JSON were skipped" = "ცვლადები, რომელთა კოლექცია ცვლადების JSON-ში არ არის, გამოტოვებულია" "variables without readable values were skipped" = "წაკითხვადი მნიშვნელობების გარეშე ცვლადები გამოტოვებულია" "vector points with unknown stroke joins use the layer join" = "უცნობი კონტურის შეერთების მქონე ვექტორული წერტილები შრის შეერთებას იყენებს" +"vector region paint data exceeded import limits and was skipped" = "ვექტორული არის საღებავის მონაცემებმა იმპორტის ლიმიტებს გადააჭარბა და გამოტოვებულია" +"vector region references a missing fill style; layer fill used" = "ვექტორული არე მიუთითებს შევსების არარსებულ სტილზე; გამოყენებულია შრის შევსება" "vectors without geometry are empty" = "გეომეტრიის გარეშე ვექტორები ცარიელია" "vectors without geometry are empty (export the file JSON with geometry=paths)" = "გეომეტრიის გარეშე ვექტორები ცარიელია (ფაილის JSON-ის ექსპორტი გააკეთეთ geometry=paths პარამეტრით)" "very long text was cut to 1,048,576 characters" = "ძალიან გრძელი ტექსტი 1 048 576 სიმბოლომდე შემოკლდა" @@ -1845,6 +1889,8 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "video actions are not supported and were skipped" = "ვიდეოს მოქმედებები მხარდაუჭერელია და გამოტოვებულია" "video triggers are not supported and were skipped" = "ვიდეოს გამშვებები მხარდაუჭერელია და გამოტოვებულია" "yesterday" = "გუშინ" +"{count} in it now · Changed {date}" = "ახლა მასშია: {count} · შეცვლილია: {date}" +"{insertions} · {detachments}" = "{insertions} · {detachments}" "{instances} in {files}" = "{instances} — {files}" "{language}: draft translation, waiting for a native speaker's review." = "{language}: თარგმანის მონახაზი, ელოდება მშობლიური ენის მცოდნის განხილვას." "{length} bleed" = "ჭრისპირა არე: {length}" @@ -1853,7 +1899,6 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "{name} is forgotten on this computer; the file stays on {server}" = "{name} დავიწყებულია ამ კომპიუტერზე; ფაილი {server}-ზე რჩება" "{name} is on the server." = "{name} სერვერზეა." "{name} is spotlighting" = "ყურადღება {name}-ზეა" -"{name}, disconnected from its live session" = "{name}, ცოცხალ სესიასთან კავშირი გაწყვეტილია" "{name}\nClick to apply to the selection" = "{name}\nდაწკაპეთ მონიშნულზე გამოსაყენებლად" "{name}\nDrag onto the canvas, or click to place in the middle of the view.\nHold Alt (Option) while dropping onto an instance to swap it." = "{name}\nგადაათრიეთ ტილოზე ან დაწკაპეთ ხედის შუაში განსათავსებლად.\nინსტანსის ჩასანაცვლებლად მასზე ჩაგდებისას დააჭირეთ Alt-ს (Option)." "{name} (from {library})" = "{name} ({library}-იდან)" @@ -1881,8 +1926,10 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "{n} components and styles have newer versions" = { one = "ახალი ვერსია აქვს კომპონენტს ან სტილს: {n}", other = "ახალი ვერსია აქვს კომპონენტს ან სტილს: {n}" } "{n} conflicts to resolve" = { one = "გადასაწყვეტი კონფლიქტი: {n}", other = "გადასაწყვეტი კონფლიქტი: {n}" } "{n} days ago" = { one = "{n} დღის წინ", other = "{n} დღის წინ" } +"{n} detached" = { one = "გამოყოფილი: {n}", other = "გამოყოფილი: {n}" } "{n} files" = { one = "ფაილი: {n}", other = "ფაილი: {n}" } "{n} hours ago" = { one = "{n} საათის წინ", other = "{n} საათის წინ" } +"{n} inserted" = { one = "ჩასმული: {n}", other = "ჩასმული: {n}" } "{n} instances" = { one = "ინსტანსი: {n}", other = "ინსტანსი: {n}" } "{n} layers" = { one = "შრე: {n}", other = "შრე: {n}" } "{n} layers as one file" = { one = "შრე: {n}, ერთ ფაილად", other = "შრე: {n}, ერთ ფაილად" } @@ -1913,12 +1960,15 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "{n}w" = "{n} კვ" "{page}, nothing selected" = "{page}, არაფერია მონიშნული" "{percent}%" = "{percent}%" +"{period}: {counts}" = "{period}: {counts}" "{profile} (current)" = "{profile} (მიმდინარე)" "{property} is its value; {property ? \"a\" : \"b\"} picks a string. Other {…} stays as written." = "{property} მისი მნიშვნელობაა; {property ? \"a\" : \"b\"} ირჩევს სტრიქონს. ნებისმიერი სხვა {…} რჩება დაწერილი სახით." "{server} can't say what became of your files (it is older than this app)." = "{server} ვერ გეტყვით, რა მოუვიდა თქვენს ფაილებს (ის ამ აპზე ძველია)." "{server} · No longer on the server" = "{server} · სერვერზე აღარ არის" "{server} · {shared} · Opened {date}" = "{server} · {shared} · გაიხსნა {date}" "{tool} hold {key}" = "{tool} დააჭირეთ {key}" +"{used} · {detached}" = "{used} · {detached}" +"{used} · {inserted}" = "{used} · {inserted}" "{value} isn't a colour" = "{value} ფერი არ არის" "{when} · edited" = "{when} · რედაქტირებულია" "← ↑ → ↓" = "← ↑ → ↓" @@ -1926,23 +1976,32 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "←" = "←" "→, Space or N" = "→, Space ან N" "↵" = "↵" -"↵ / ⇧↵" = "↵ / ⇧↵" "⇥ / ⇧⇥" = "⇥ / ⇧⇥" -"⇥ or ⌥ Space again" = "⇥ ან ხელახლა ⌥ Space" "⌘ arrows" = "⌘ ისრები" "⌘ click" = "⌘ დაწკაპუნება" -"⌘ click a padding field" = "⌘ დაწკაპუნება შიდა დაშორების ველზე" "⌘ scroll" = "⌘ გადახვევა" -"⌥ double-click an edge of an auto layout child" = "⌥ ორმაგი დაწკაპუნება ავტოგანლაგების შვილობილი ელემენტის კიდეზე" "⌥ drag" = "⌥ გადათრევა" +"Selection box: switch to pick select" = "მონიშვნის ჩარჩო: შრის არჩევაზე გადართვა" +"Pick select: next or previous layer" = "შრის არჩევა: შემდეგი ან წინა შრე" +"Pick select: into a layer, out to its parent" = "შრის არჩევა: შრეში შესვლა, მშობელზე გასვლა" +"Pick select: select the picked layer" = "შრის არჩევა: არჩეული შრის მონიშვნა" +"⇥ or ⌥ Space again" = "⇥ ან ხელახლა ⌥ Space" +"Tab or Ctrl+Space again" = "Tab ან ხელახლა Ctrl+Space" +"↵ / ⇧↵" = "↵ / ⇧↵" +"Enter / Shift+Enter" = "Enter / Shift+Enter" +"Space" = "Space" +"Nothing to pick: the page is empty" = "ასარჩევი არაფერია: გვერდი ცარიელია" +"Pick select: Tab and Shift+Tab move between layers, Enter goes into one, Shift+Enter out, Space selects, Escape cancels" = "შრის არჩევა: Tab და Shift+Tab შრეებს შორის გადაადგილდება, Enter შრეში შედის, Shift+Enter გამოდის, Space მონიშნავს, Escape გააუქმებს" "Android Vector Drawable" = "Android Vector Drawable" "Best effort" = "მაქსიმალური მიახლოება" "Check for Updates" = "განახლებების შემოწმება" "Check for updates…" = "განახლებების შემოწმება…" "Compatibility" = "თავსებადობა" "Dart constants for Flutter…" = "Dart-ის კონსტანტები Flutter-ისთვის…" +"Calculated from other variables; it follows them" = "გამოითვლება სხვა ცვლადებიდან და მათ მიჰყვება" "Copy effect" = "ეფექტის კოპირება" "Copy fill" = "შევსების კოპირება" +"Copy for AI" = "კოპირება AI-სთვის" "Copy stroke" = "კონტურის კოპირება" "Couldn't download {name}" = "{name} ვერ ჩამოიტვირთა" "Don't show this again" = "აღარ აჩვენო" @@ -1959,70 +2018,11 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Set corner smoothing to 60%" = "კუთხეების დარბილების 60%-ზე დაყენება" "Text on a path" = "ტექსტი ტრაექტორიაზე" "This link opens a website outside the prototype:" = "ეს ბმული პროტოტიპის გარეთ ვებსაიტს ხსნის:" +"This link opens your mail app to write a message:" = "ეს ბმული წერილის დასაწერად თქვენს საფოსტო აპს ხსნის:" +"This server doesn't count detached instances" = "ეს სერვერი გამოყოფილ ინსტანსებს არ ითვლის" "Update check is not supported in the web browser." = "ვებბრაუზერში განახლებების შემოწმება მხარდაჭერილი არ არის." "instance swap properties whose default component was past the layer limit were skipped" = "ინსტანსის ჩანაცვლების თვისებები, რომელთა ნაგულისხმევი კომპონენტი შრეების ზღვარს მიღმა იყო, გამოტოვებულია" "instances whose component was past the layer limit were imported as frames" = "ინსტანსები, რომელთა კომპონენტი შრეების ზღვარს მიღმა იყო, ჩარჩოებად იმპორტირდა" -"1 year" = "1 წელი" -"30 days" = "30 დღე" -"90 days" = "90 დღე" -"Allow and download" = "დაშვება და ჩამოტვირთვა" -"Allow downloading fonts?" = "დაიშვას შრიფტების ჩამოტვირთვა?" -"Board grid" = "დაფის ბადე" -"Changed {date}" = "შეცვლილია: {date}" -"Copy browser link" = "ბრაუზერის ბმულის კოპირება" -"Couldn't reach {server} for its team list." = "{server}-იდან გუნდის სიის მიღება ვერ მოხერხდა." -"Calculated from other variables; it follows them" = "გამოითვლება სხვა ცვლადებიდან და მათ მიჰყვება" -"Crop image" = "გამოსახულების ჩამოჭრა" -"Detach calculation" = "გამოთვლის გამოყოფა" -"Download" = "ჩამოტვირთვა" -"Downloading… {percent}%" = "ჩამოტვირთვა… {percent}%" -"Drop to use this image" = "ჩააგდეთ ამ გამოსახულების გამოსაყენებლად" -"Everyone who reaches this server can open these files while they are shared." = "ამ სერვერთან წვდომის მქონე ყველას შეუძლია ამ ფაილების გახსნა, სანამ ისინი გაზიარებულია." -"FigCraft stopped because of an internal error." = "FigCraft-ის მუშაობა შიდა შეცდომის გამო შეწყდა." -"Free fonts come from Google Fonts and Noto, through jsDelivr and GitHub. Each file is checked against the font index before it is installed into the font folder the Craft apps share. Nothing is downloaded until you allow it." = "უფასო შრიფტები Google Fonts-იდან და Noto-დან მოდის, jsDelivr-ისა და GitHub-ის გავლით. თითოეული ფაილი შრიფტების ინდექსთან მოწმდება, სანამ Craft-აპების საერთო შრიფტების საქაღალდეში დაინსტალირდება. სანამ არ დაუშვებთ, არაფერი ჩამოიტვირთება." -"Graph paper" = "მილიმეტრიანი ქაღალდი" -"Joining live session…" = "ცოცხალ სესიასთან შეერთება…" -"Link copied: it opens the file in FigCraft" = "ბმული დაკოპირდა: ის ფაილს FigCraft-ში ხსნის" -"Link copied: it opens the file in the browser" = "ბმული დაკოპირდა: ის ფაილს ბრაუზერში ხსნის" -"Nobody shares a file there now." = "იქ ახლა არავინ აზიარებს ფაილს." -"Past 30 days" = "ბოლო 30 დღე" -"Past 90 days" = "ბოლო 90 დღე" -"Past year" = "ბოლო წელი" -"Shared by your team on {server}" = "თქვენი გუნდის მიერ {server}-ზე გაზიარებული" -"Not now" = "ახლა არა" -"Nothing counted yet" = "ჯერ არაფერი დათვლილა" -"Reload the page to get back the unsaved files the browser had room for." = "განაახლეთ გვერდი, რომ დაიბრუნოთ ის შეუნახავი ფაილები, რომლებიც ბრაუზერში დაეტია." -"Reload the page to get your unsaved files back." = "განაახლეთ გვერდი, რომ შეუნახავი ფაილები დაიბრუნოთ." -"Reload the page to start again." = "თავიდან დასაწყებად განაახლეთ გვერდი." -"Reset grid" = "ბადის ჩამოყრა" -"This server doesn't count insertions" = "ეს სერვერი ჩასმებს არ ითვლის" -"This server doesn't count styles and variables" = "ეს სერვერი სტილებსა და ცვლადებს არ ითვლის" -"Upload from computer" = "კომპიუტერიდან ატვირთვა" -"Strong line every" = "მუქი ხაზის ბიჯი" -"This link opens your mail app to write a message:" = "ეს ბმული წერილის დასაწერად თქვენს საფოსტო აპს ხსნის:" -"This server doesn't count detached instances" = "ეს სერვერი გამოყოფილ ინსტანსებს არ ითვლის" -"Your unsaved files were too large for the browser to keep." = "თქვენი შეუნახავი ფაილები ბრაუზერისთვის შესანახად ზედმეტად დიდი იყო." -"connector labels without a saved snapshot are centred on the line, without their background" = "შენახული სნეპშოტის გარეშე შემაერთებლის იარლიყები ხაზზე ცენტრდება, ფონის გარეშე" -"elbowed and curved connectors without a saved path follow FigCraft's own routing" = "შენახული ტრაექტორიის გარეშე კუთხოვანი და მრუდი შემაერთებლები FigCraft-ის საკუთარ მარშრუტს მიჰყვება" -"invalid vector region fill paint list; layer fill used" = "ვექტორული არის შევსების საღებავების სია არასწორია; გამოყენებულია შრის შევსება" -"invalid vector region paints were skipped" = "ვექტორული არის არასწორი საღებავები გამოტოვებულია" -"linked vector region fill styles keep resolved appearance; live style links were left out" = "ვექტორული არის მიბმული შევსების სტილები გამოთვლილ იერსახეს ინარჩუნებს; სტილების ცოცხალი კავშირები არ გადმოვიდა" -"note or shape generated child has invalid bounds; child skipped" = "შენიშვნის ან ფიგურის გენერირებულ შვილობილ ელემენტს არასწორი საზღვრები აქვს; ელემენტი გამოტოვებულია" -"note or shape generated child is missing its style or bounds; child skipped" = "შენიშვნის ან ფიგურის გენერირებულ შვილობილ ელემენტს სტილი ან საზღვრები აკლია; ელემენტი გამოტოვებულია" -"note or shape generated children exceed the layer or nesting limit; remaining children skipped" = "შენიშვნის ან ფიგურის გენერირებული შვილობილი ელემენტები შრეების ან ჩადგმის ლიმიტს აჭარბებს; დანარჩენი ელემენტები გამოტოვებულია" -"note or shape generated layout is missing or unsupported; using its outer frame" = "შენიშვნის ან ფიგურის გენერირებული განლაგება აკლია ან მხარდაუჭერელია; გამოიყენება მისი გარე ჩარჩო" -"shape generated outline is missing or damaged; using its rectangle" = "ფიგურის გენერირებული კონტური აკლია ან დაზიანებულია; გამოიყენება მისი მართკუთხედი" -"variable-bound vector region paints keep resolved appearance; live bindings were left out" = "ცვლადებზე მიბმული ვექტორული არის საღებავები გამოთვლილ იერსახეს ინარჩუნებს; ცოცხალი მიბმები არ გადმოვიდა" -"vector region paint data exceeded import limits and was skipped" = "ვექტორული არის საღებავის მონაცემებმა იმპორტის ლიმიტებს გადააჭარბა და გამოტოვებულია" -"vector region references a missing fill style; layer fill used" = "ვექტორული არე მიუთითებს შევსების არარსებულ სტილზე; გამოყენებულია შრის შევსება" -"{count} in it now · Changed {date}" = "ახლა მასშია: {count} · შეცვლილია: {date}" -"{insertions} · {detachments}" = "{insertions} · {detachments}" -"{period}: {counts}" = "{period}: {counts}" -"{used} · {detached}" = "{used} · {detached}" -"{used} · {inserted}" = "{used} · {inserted}" -"{n} detached" = { one = "გამოყოფილი: {n}", other = "გამოყოფილი: {n}" } -"{n} inserted" = { one = "ჩასმული: {n}", other = "ჩასმული: {n}" } -"⌥⌘ ← ↑ → ↓" = "⌥⌘ ← ↑ → ↓" [commands] "align.bottom" = "ქვემოთ სწორება" @@ -2053,10 +2053,12 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "arrange.tidy" = "მოწესრიგება" "board.addConnected" = "დაკავშირებული ფიგურის დამატება" "board.connector" = "შემაერთებელი" +"board.grid" = "დაფის ბადე" "board.ink" = "მარკერის შტრიხი" "board.label" = "შემაერთებლის წარწერა" "board.nextSticky" = "შემდეგი სტიკერი" "board.reattach" = "შემაერთებლის ხელახლა მიმაგრება" +"board.reshape" = "შემაერთებლის ფორმის შეცვლა" "board.setColor" = "დაფის ფერი" "board.setStyle" = "დაფის სტილი" "board.shape" = "ფიგურა ტექსტით" @@ -2218,6 +2220,8 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "fill.pattern" = "პატერნით შევსება" "fill.remove" = "შევსების წაშლა" "fill.set" = "შევსების დაყენება" +"font.download" = "შრიფტის ჩამოტვირთვა" +"font.downloads" = "შრიფტების ჩამოტვირთვები" "frame.create" = "ჩარჩოს შექმნა" "frame.presets" = "ჩარჩოს პრესეტების სია" "frame.swapOrientation" = "ორიენტაციის შეცვლა" @@ -2234,9 +2238,11 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "help.page" = "დახმარების გვერდი" "help.shortcuts" = "კლავიატურის მალსახმობები" "image.adjust" = "გამოსახულების კორექცია" +"image.crop" = "გამოსახულების ჩამოჭრა" "image.deletePreset" = "გამოსახულების პრესეტის წაშლა" "image.place" = "გამოსახულების განთავსება" "image.presets" = "გამოსახულების პრესეტები" +"image.replace" = "გამოსახულების ჩანაცვლება" "image.savePreset" = "გამოსახულების პრესეტის შენახვა" "inspect.assets" = "რესურსების ინსპექტირება" "inspect.code" = "შრის კოდი" @@ -2263,6 +2269,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "library.aliasVariable" = "ბიბლიოთეკის ცვლადის ალიასი" "library.applyStyle" = "ბიბლიოთეკის სტილის გამოყენება" "library.bindVariable" = "ბიბლიოთეკის ცვლადის მიბმა" +"library.check" = "გუნდის ბიბლიოთეკების განახლებების შემოწმება" "library.extendCollection" = "ბიბლიოთეკის კოლექციის გაფართოება" "library.import" = "ბიბლიოთეკის კომპონენტის იმპორტი" "library.importVariable" = "ბიბლიოთეკის ცვლადის იმპორტი" @@ -2524,6 +2531,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "variable.deleteCollection" = "კოლექციის წაშლა" "variable.duplicate" = "ცვლადის დუბლირება" "variable.export" = "ცვლადების ექსპორტირება" +"variable.extendCollection" = "კოლექციის გაფართოება" "variable.import" = "ცვლადების იმპორტი" "variable.list" = "ცვლადების სია" "variable.moveMode" = "რეჟიმის გადატანა" @@ -2633,6 +2641,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "view.zoomOut" = "დაპატარავება" "view.zoomSelection" = "მონიშნულის მასშტაბირება" "widget.click" = "ვიჯეტზე დაწკაპუნება" +"widget.hover" = "ვიჯეტზე მაჩვენებლის მიტანა" "widget.insert" = "ვიჯეტის ჩასმა" "widget.list" = "ვიჯეტების სია" "widget.menu" = "ვიჯეტის მენიუ" @@ -2650,15 +2659,6 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "file.markSaved" = "შენახულად მარკირება" "text.fit" = "ტექსტის ჩატევა თავის საზღვრებში" "data.fill" = "ასლების მონაცემებით შევსება" -"board.grid" = "დაფის ბადე" -"font.download" = "შრიფტის ჩამოტვირთვა" -"font.downloads" = "შრიფტების ჩამოტვირთვები" -"image.crop" = "გამოსახულების ჩამოჭრა" -"library.check" = "გუნდის ბიბლიოთეკების განახლებების შემოწმება" -"board.reshape" = "შემაერთებლის ფორმის შეცვლა" -"image.replace" = "გამოსახულების ჩანაცვლება" -"variable.extendCollection" = "კოლექციის გაფართოება" -"widget.hover" = "ვიჯეტზე მაჩვენებლის მიტანა" [menu] "bool.exclude" = "გამორიცხვა" From 5c50025270fac9ec187db56416f965eaa8fdc5ea Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Mon, 9 Nov 2026 08:37:11 -0500 Subject: [PATCH 10/19] M7: a connection dropped on a sibling variant creates Change to (#2158) A connection dragged from a variant (or a layer in it) onto a sibling variant of its set now creates Change to that variant (On click, Instant) and outlines the sibling while dragging, as measured in Figma. The set background and the variant itself add nothing; a frame outside the set still gets Navigate to. Co-Authored-By: Claude Sonnet 5.5 Model-Effort: Opus 5.5 drove and briefed; Sonnet 5.5 measured in Figma and wrote at medium --- crates/ui-egui/src/canvas/proto_canvas.rs | 56 +++++++- crates/ui-egui/src/lib.rs | 2 + .../src/proto_variant_connect_tests.rs | 126 ++++++++++++++++++ docs/prototyping-parity.md | 4 +- 4 files changed, 180 insertions(+), 8 deletions(-) create mode 100644 crates/ui-egui/src/proto_variant_connect_tests.rs diff --git a/crates/ui-egui/src/canvas/proto_canvas.rs b/crates/ui-egui/src/canvas/proto_canvas.rs index 1178ed6b2..b6955e956 100644 --- a/crates/ui-egui/src/canvas/proto_canvas.rs +++ b/crates/ui-egui/src/canvas/proto_canvas.rs @@ -119,7 +119,7 @@ fn segment_distance(a: Pos2, b: Pos2, q: Pos2) -> f32 { } /// Handle centres of the selected layers (right edge, vertically centred). -fn handles(app: &FigApp, doc: &Document, sel: &[NodeId]) -> Vec<(NodeId, Pos2)> { +pub(crate) fn handles(app: &FigApp, doc: &Document, sel: &[NodeId]) -> Vec<(NodeId, Pos2)> { sel.iter() .take(32) .filter(|i| doc.node(**i).is_some_and(|n| !n.is_page())) @@ -135,6 +135,46 @@ fn frame_at(app: &FigApp, doc: &Document, page: NodeId, p: Pos2) -> Option NodeId { + match self { + Target::Navigate(n) | Target::ChangeTo(n) => n, + } + } +} + +/// The variant (a child of a component set) the layer is, or sits inside. +fn variant_of(doc: &Document, source: NodeId) -> Option { + let is_set = |i: NodeId| doc.node(i).is_some_and(|n| matches!(n.kind, figcraft_doc::NodeKind::ComponentSet { .. })); + std::iter::once(source).chain(doc.ancestors(source)).find(|v| doc.node(*v).and_then(|n| n.parent).is_some_and(is_set)) +} + +/// What a connection dragged from `source` and released at screen point `p` targets: a sibling +/// variant of the source's own variant (Change to), else a frame other than the source's own +/// (Navigate to). +fn target_at(app: &FigApp, doc: &Document, page: NodeId, source: NodeId, p: Pos2) -> Option { + if let Some(v) = variant_of(doc, source) + && let Some(set) = doc.node(v).and_then(|n| n.parent) + && doc.node(set).is_some_and(|n| matches!(n.kind, figcraft_doc::NodeKind::ComponentSet { .. })) + { + let pt = app.to_page(p); + let siblings = doc.node(set).map(|n| n.children.clone()).unwrap_or_default(); + if let Some(w) = siblings.into_iter().rev().find(|w| doc.world_bounds(*w).is_some_and(|b| b.contains(pt))) { + return (w != v).then_some(Target::ChangeTo(w)); + } + } + frame_at(app, doc, page, p).filter(|f| doc.top_level_frame(source) != Some(*f)).map(Target::Navigate) +} + fn arrow(painter: &egui::Painter, pts: &[Pos2; 4], col: Color32) { let tip = pts[3]; let dir = (pts[3] - bezier(pts, 0.9)).normalized(); @@ -200,9 +240,8 @@ pub fn draw(app: &FigApp, painter: &egui::Painter) { } match dragging { Some(d) => { - if let Some(f) = frame_at(app, doc, page, d.pos) - && doc.top_level_frame(d.source) != Some(f) - && let Some(r) = screen_rect(app, doc, f) + if let Some(t) = target_at(app, doc, page, d.source, d.pos) + && let Some(r) = screen_rect(app, doc, t.node()) { painter.rect_stroke(r, CornerRadius::ZERO, Stroke::new(2.0, crate::theme::canvas_accent(painter.ctx())), StrokeKind::Outside); } @@ -259,9 +298,12 @@ pub fn input(app: &mut FigApp, ui: &egui::Ui, resp: &egui::Response) -> bool { ctx.request_repaint(); if released || !down { ctx.data_mut(|m| m.remove::(drag_id())); - if let Some(dest) = frame_at(app, &doc, page, d.pos) - && doc.top_level_frame(d.source) != Some(dest) - && let Some(r) = app.run("proto.interaction.add", json!({"ids": [d.source], "dest": dest})) + let params = target_at(app, &doc, page, d.source, d.pos).map(|t| match t { + Target::Navigate(dest) => json!({"ids": [d.source], "dest": dest}), + Target::ChangeTo(dest) => json!({"ids": [d.source], "action": {"type": "changeTo", "dest": dest}}), + }); + if let Some(params) = params + && let Some(r) = app.run("proto.interaction.add", params) { let k = r.get("index").and_then(Value::as_u64).unwrap_or(0) as usize; crate::proto_panel::open_editor(&ctx, Some((d.source, k))); diff --git a/crates/ui-egui/src/lib.rs b/crates/ui-egui/src/lib.rs index 60c68f526..a9e620a7f 100644 --- a/crates/ui-egui/src/lib.rs +++ b/crates/ui-egui/src/lib.rs @@ -233,6 +233,8 @@ mod proto_reorder_tests; #[cfg(test)] mod proto_responsive_tests; #[cfg(test)] +mod proto_variant_connect_tests; +#[cfg(test)] mod region_fill_rows_tests; #[cfg(test)] mod resources_tests; diff --git a/crates/ui-egui/src/proto_variant_connect_tests.rs b/crates/ui-egui/src/proto_variant_connect_tests.rs new file mode 100644 index 000000000..b9f6ba812 --- /dev/null +++ b/crates/ui-egui/src/proto_variant_connect_tests.rs @@ -0,0 +1,126 @@ +//! A connection dragged out of a variant (or a layer in it) onto a sibling variant makes a Change +//! to it (On click, Instant), as in Figma (#2158); onto the set's background or its own variant it +//! makes nothing, and onto a frame outside the set it still navigates. + +use egui::{Pos2, pos2}; +use figcraft_doc::NodeId; +use figcraft_doc::proto::{Action, Transition, Trigger}; +use figcraft_engine::Session; +use serde_json::json; + +use crate::FigApp; +use crate::RightTab; +use crate::canvas::proto_canvas::handles; +use crate::present_tests::{Ui, id}; + +fn screen_centre(app: &FigApp, n: NodeId) -> Pos2 { + let b = app.session.doc().unwrap().world_bounds(n).unwrap(); + app.to_screen((b.x0 + b.x1) / 2.0, (b.y0 + b.y1) / 2.0) +} + +struct Setup { + u: Ui, + set: NodeId, + default: NodeId, + hover: NodeId, + layer: NodeId, + outside: NodeId, +} + +fn setup() -> Setup { + let mut s = Session::new(); + let mut variant = |name: &str, x: f64| { + let f = id(&s.execute("frame.create", &json!({"x": x, "y": 0, "width": 100, "height": 80, "name": name})).unwrap()); + id(&s.execute("component.create", &json!({"ids": [f]})).unwrap()) + }; + let default = variant("Property 1=Default", 0.0); + let hover = variant("Property 1=Hover", 300.0); + let layer = id(&s.execute("shape.rectangle", &json!({"x": 10, "y": 10, "width": 30, "height": 20, "parent": default})).unwrap()); + let outside = id(&s.execute("frame.create", &json!({"x": 0, "y": 500, "width": 200, "height": 150, "name": "Outside"})).unwrap()); + let set = id(&s.execute("component.combineVariants", &json!({"ids": [default, hover]})).unwrap()); + let mut u = Ui::new(s); + u.app.ui.right_tab = RightTab::Prototype; + Setup { u, set, default, hover, layer, outside } +} + +/// Select `source`, then drag its connection handle to the centre of `to` (or `at`) and release. +fn drag(t: &mut Setup, source: NodeId, to: Pos2) { + t.u.run("select.set", json!({"ids": [source]})); + t.u.run("view.zoomSelection", json!({})); + t.u.run("view.zoomFit", json!({})); + t.u.frames(2, Vec::new); + let doc = t.u.app.session.doc().unwrap().clone(); + let (_, at) = *handles(&t.u.app, &doc, &[source]).first().unwrap(); + t.u.button(at, true); + t.u.button(pos2((at.x + to.x) / 2.0, (at.y + to.y) / 2.0), true); + t.u.button(to, true); + t.u.button(to, false); + t.u.frames(2, Vec::new); +} + +fn interactions(t: &Setup, n: NodeId) -> Vec { + t.u.app.session.doc().unwrap().node(n).unwrap().interactions.clone() +} + +fn assert_change_to(t: &Setup, source: NodeId, dest: NodeId) { + let its = interactions(t, source); + assert_eq!(its.len(), 1, "{its:?}"); + assert_eq!(its[0].trigger, Trigger::OnClick); + assert_eq!(its[0].transition, Transition::Instant); + assert!(matches!(its[0].actions.as_slice(), [Action::ChangeTo { dest: d }] if *d == dest), "{:?}", its[0].actions); + assert_eq!(crate::proto_panel::editor(&t.u.ctx), Some((source, 0))); +} + +#[test] +fn a_variants_connection_dropped_on_a_sibling_variant_changes_to_it() { + let mut t = setup(); + let to = screen_centre(&t.u.app, t.hover); + let src = t.default; + drag(&mut t, src, to); + assert_change_to(&t, t.default, t.hover); +} + +#[test] +fn the_reverse_connection_changes_back() { + let mut t = setup(); + let to = screen_centre(&t.u.app, t.default); + let src = t.hover; + drag(&mut t, src, to); + assert_change_to(&t, t.hover, t.default); +} + +#[test] +fn a_layer_inside_a_variant_changes_its_set_to_the_sibling() { + let mut t = setup(); + let to = screen_centre(&t.u.app, t.hover); + let src = t.layer; + drag(&mut t, src, to); + assert_change_to(&t, t.layer, t.hover); +} + +#[test] +fn dropped_on_the_sets_background_or_its_own_variant_it_adds_nothing() { + let mut t = setup(); + // Between the two variants (x 100..300) and inside the set's padding. + let (a, b) = (screen_centre(&t.u.app, t.default), screen_centre(&t.u.app, t.hover)); + let gap = pos2((a.x + b.x) / 2.0, a.y); + let src = t.default; + drag(&mut t, src, gap); + assert!(interactions(&t, t.default).is_empty()); + let own = screen_centre(&t.u.app, t.default); + let src = t.default; + drag(&mut t, src, own); + assert!(interactions(&t, t.default).is_empty()); + let _ = t.set; +} + +#[test] +fn a_variant_dropped_on_a_frame_outside_the_set_still_navigates() { + let mut t = setup(); + let to = screen_centre(&t.u.app, t.outside); + let src = t.default; + drag(&mut t, src, to); + let its = interactions(&t, t.default); + assert_eq!(its.len(), 1, "{its:?}"); + assert!(matches!(its[0].actions.as_slice(), [Action::Navigate { dest, .. }] if *dest == t.outside), "{:?}", its[0].actions); +} diff --git a/docs/prototyping-parity.md b/docs/prototyping-parity.md index 7c216bcae..07e3c691d 100644 --- a/docs/prototyping-parity.md +++ b/docs/prototyping-parity.md @@ -1,6 +1,6 @@ # Prototyping parity -> **Last reviewed:** 2026-10-11 · **Last updated:** 2026-11-06 · **Change:** patch (`proto.settings` refuses an unknown device with the list of devices instead of saving it, takes a known one in any case, and answers the page's settings, so `proto.settings {}` reads them (#2027); Hide UI in the presenter's Options menu, and Cmd/Ctrl+\ as in the editor: the bar above the prototype and the navigation bar under it go away, a toast names the key that brings them back, `proto.presentOptions {hideUi}` (#1820); the Controller menu names each button as PlayStation and Switch controllers do; "Open in new tab" on Open link: off, the web build's own tab goes to the link; a manual overlay's position can be dragged on the canvas (#405); Open link notices now cover mail links, and skipping them covers only links the viewer fired (#1096); overlay positions relative to the layer that opens them; the Triggers row no longer lists delays on mouse triggers as missing; top-level frames bigger than the device's screen scroll in the player; Change to, set variable and set variable mode lay out what they change in the player, as the canvas does; presentation tabs, one per page of a file; a Present tab with device and scale controls (#537); core editor leftovers: delays on mouse triggers and manual overlay offsets; controller buttons on key/gamepad triggers, widgets that react in prototypes, `proto.evaluate` and the mode lookup rules pinned) · **Target:** Figma Design (desktop app 126.10.7) +> **Last reviewed:** 2026-10-11 · **Last updated:** 2026-11-09 · **Change:** patch (a connection dragged from a variant, or a layer in it, onto a sibling variant makes Change to, On click, Instant, with the sibling outlined (#2158); `proto.settings` refuses an unknown device with the list of devices instead of saving it, takes a known one in any case, and answers the page's settings, so `proto.settings {}` reads them (#2027); Hide UI in the presenter's Options menu, and Cmd/Ctrl+\ as in the editor: the bar above the prototype and the navigation bar under it go away, a toast names the key that brings them back, `proto.presentOptions {hideUi}` (#1820); the Controller menu names each button as PlayStation and Switch controllers do; "Open in new tab" on Open link: off, the web build's own tab goes to the link; a manual overlay's position can be dragged on the canvas (#405); Open link notices now cover mail links, and skipping them covers only links the viewer fired (#1096); overlay positions relative to the layer that opens them; the Triggers row no longer lists delays on mouse triggers as missing; top-level frames bigger than the device's screen scroll in the player; Change to, set variable and set variable mode lay out what they change in the player, as the canvas does; presentation tabs, one per page of a file; a Present tab with device and scale controls (#537); core editor leftovers: delays on mouse triggers and manual overlay offsets; controller buttons on key/gamepad triggers, widgets that react in prototypes, `proto.evaluate` and the mode lookup rules pinned) · **Target:** Figma Design (desktop app 126.10.7) **Breadth ~92%, ready ~74% (estimated).** Every Figma trigger except media, every action except media control, every transition and easing exist; key/gamepad triggers take controller buttons, @@ -57,6 +57,7 @@ tool; opt-in), **silent** (the documentation doesn't say; the case pins the curr | Open link | pass | a new tab or browser window by default; with "Open in new tab" off, the web build's own tab goes to the link (the desktop app has no tab of its own to replace, so it opens the browser either way) | | Change to: another variant of the instance, in place, with the interaction's animation | pass | `interactive_components_change_in_place` | | Interactive components: every instance plays the interactions of the variant it shows; an interaction on the instance with the same trigger wins | **fixed** | instances played only interactions copied onto them when they were placed: an instance placed before its main got interactions did nothing, and one placed after kept the first variant's interactions after changing (a toggle went on but never off). New instances no longer copy them, and copies in older files give way to the variant shown; `instances_play_their_variants_interactions` | +| Drag a variant's (or a layer in it) connection onto a sibling variant: Change to, On click, Instant; the sibling is outlined | **fixed** | the drop only found top-level frames, and a variant's top-level frame is its set, so nothing happened. Dropped on the set's background or on its own variant it still adds nothing; on a frame outside the set it still navigates. Measured in Figma's web app, 2026-11-09; `a_variants_connection_dropped_on_a_sibling_variant_changes_to_it`, `the_reverse_connection_changes_back`, `a_layer_inside_a_variant_changes_its_set_to_the_sibling`, `dropped_on_the_sets_background_or_its_own_variant_it_adds_nothing`, `a_variant_dropped_on_a_frame_outside_the_set_still_navigates` | | Presentation tabs: one per page of a file, named "file - page" (renames follow). Play on a page that has a tab shows it as it was (from another start frame it starts again). Tabs keep their own copy of the prototype and play on after their file closes; a saved file opened again gets its tabs back. A tab never changes a file that isn't in front. Its X or Escape ends it and goes back to its file, or Home | **fixed** | one "Present" tab: a second presentation replaced the first, Play restarted it, and closing the file ended it; `present_tab_tests` | | Change to on a layer inside a nested instance changes the instance whose variant set holds the destination | **fixed** | the innermost instance (an icon inside a button) was changed instead | | Set variable, set variable mode, conditional | pass | `proto_run_tests`, `proto_conditional_tests`, `present_variables_tests` | @@ -107,6 +108,7 @@ tool; opt-in), **silent** (the documentation doesn't say; the case pins the curr | Date | Change | Summary | |---|---|---| +| 2026-11-09 | patch | M7, #2158: a connection dragged from a variant (or a layer in it) onto a sibling variant of its set did nothing, because the drop looked only for top-level frames and a variant's top-level frame is its set. It now creates Change to the sibling (On click, Instant, as measured in Figma's web app) and outlines the sibling while dragging; the set's background and the variant itself still add nothing, and a frame outside the set still gets Navigate to | | 2026-11-06 | patch | M5, #2027: `proto.settings` took any string as the device (`"Pixel Nonexistent"`, `"iphone 16"`) and saved it in the file; the presenter then drew no device while its picker showed the name as if it were one, and the settings couldn't be read back over MCP (`proto.settings {}` answered `{ok: true}`). An unknown name (or a non-string) is now refused with every name the picker offers (`None`, `Custom size` and the devices), as an unknown colour is refused with the device's colours, and nothing changes; a known name is taken in any case and stored as the picker spells it. Every call answers the page's settings after it: device, background, rotation, the colour shown, the screen as presented, the custom size and responsive. Test: `proto_present_tests::unknown_devices_are_refused_and_settings_read_back` | | 2026-10-31 | minor | Gap 15: the Controller menu names buttons as PlayStation and Switch controllers do; that item leaves the missing list. Estimate unchanged. Test: `present::tail_tests`. | | 2026-10-30 | minor | Opening a link in place: Open link has "Open in new tab", on by default; off, the web build's own tab goes to the link after the notice (or at once with it skipped); the desktop app has no tab of its own and opens the browser either way. Saved in files only when off (`openInNewTab`) and read from REST files. | From 36cd59dada3ca260a5e54e588078d3dbd745cff0 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Mon, 9 Nov 2026 09:38:54 -0500 Subject: [PATCH 11/19] M7: a grouped component set's background takes no connection either (#2161 review) A set in a group has no top-level frame, so a drop on its background fell through to frame_at and made a Navigate to the section around it. target_at now returns nothing for any point inside the source's set that misses a sibling variant, as Figma does; red-first UI test with the set in a group in a section. Co-Authored-By: Claude Opus 5.5 Model-Effort: Opus 5.5 checked the finding and wrote --- crates/ui-egui/src/canvas/proto_canvas.rs | 5 ++++ .../src/proto_variant_connect_tests.rs | 26 +++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/crates/ui-egui/src/canvas/proto_canvas.rs b/crates/ui-egui/src/canvas/proto_canvas.rs index b6955e956..3d7727f2c 100644 --- a/crates/ui-egui/src/canvas/proto_canvas.rs +++ b/crates/ui-egui/src/canvas/proto_canvas.rs @@ -171,6 +171,11 @@ fn target_at(app: &FigApp, doc: &Document, page: NodeId, source: NodeId, p: Pos2 if let Some(w) = siblings.into_iter().rev().find(|w| doc.world_bounds(*w).is_some_and(|b| b.contains(pt))) { return (w != v).then_some(Target::ChangeTo(w)); } + // The set's own background: nothing, as in Figma, whatever holds the set. (A set in a + // group has no top-level frame, so the fallback below would offer a section around it.) + if doc.world_bounds(set).is_some_and(|b| b.contains(pt)) { + return None; + } } frame_at(app, doc, page, p).filter(|f| doc.top_level_frame(source) != Some(*f)).map(Target::Navigate) } diff --git a/crates/ui-egui/src/proto_variant_connect_tests.rs b/crates/ui-egui/src/proto_variant_connect_tests.rs index b9f6ba812..db5f55a9d 100644 --- a/crates/ui-egui/src/proto_variant_connect_tests.rs +++ b/crates/ui-egui/src/proto_variant_connect_tests.rs @@ -28,6 +28,11 @@ struct Setup { } fn setup() -> Setup { + setup_in(false) +} + +/// `grouped`: the set is put in a group, inside a section around everything. +fn setup_in(grouped: bool) -> Setup { let mut s = Session::new(); let mut variant = |name: &str, x: f64| { let f = id(&s.execute("frame.create", &json!({"x": x, "y": 0, "width": 100, "height": 80, "name": name})).unwrap()); @@ -38,6 +43,12 @@ fn setup() -> Setup { let layer = id(&s.execute("shape.rectangle", &json!({"x": 10, "y": 10, "width": 30, "height": 20, "parent": default})).unwrap()); let outside = id(&s.execute("frame.create", &json!({"x": 0, "y": 500, "width": 200, "height": 150, "name": "Outside"})).unwrap()); let set = id(&s.execute("component.combineVariants", &json!({"ids": [default, hover]})).unwrap()); + if grouped { + let group = id(&s.execute("object.group", &json!({"ids": [set]})).unwrap()); + let section = id(&s.execute("node.create", &json!({"type": "section", "x": -200, "y": -200, "width": 1000, "height": 1000})).unwrap()); + s.execute("node.reparent", &json!({"ids": [group], "parent": section})).unwrap(); + assert_eq!(s.doc().unwrap().top_level_frame(default), None, "a set in a group has no top-level frame"); + } let mut u = Ui::new(s); u.app.ui.right_tab = RightTab::Prototype; Setup { u, set, default, hover, layer, outside } @@ -114,6 +125,21 @@ fn dropped_on_the_sets_background_or_its_own_variant_it_adds_nothing() { let _ = t.set; } +/// A set in a group in a section (CodeRabbit, #2161): its background still gives nothing, not a +/// Navigate to the section, and a sibling still gives Change to. +#[test] +fn in_a_grouped_set_the_background_adds_nothing_and_a_sibling_changes_to() { + let mut t = setup_in(true); + let (a, b) = (screen_centre(&t.u.app, t.default), screen_centre(&t.u.app, t.hover)); + let gap = pos2((a.x + b.x) / 2.0, a.y); + let src = t.default; + drag(&mut t, src, gap); + assert!(interactions(&t, t.default).is_empty(), "{:?}", interactions(&t, t.default)); + let to = screen_centre(&t.u.app, t.hover); + drag(&mut t, src, to); + assert_change_to(&t, t.default, t.hover); +} + #[test] fn a_variant_dropped_on_a_frame_outside_the_set_still_navigates() { let mut t = setup(); From 499717d6a0ff284d86c02aa48151b466a158ae2f Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Mon, 9 Nov 2026 14:32:49 -0500 Subject: [PATCH 12/19] M7: the variant connection docs name the grouped-set case and target_at's None cases (#2161 review) Co-Authored-By: Claude Opus 5.5 Model-Effort: Opus 5.5 checked and wrote --- crates/ui-egui/src/canvas/proto_canvas.rs | 3 ++- crates/ui-egui/src/proto_variant_connect_tests.rs | 2 +- docs/prototyping-parity.md | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/ui-egui/src/canvas/proto_canvas.rs b/crates/ui-egui/src/canvas/proto_canvas.rs index 3d7727f2c..b30fc604b 100644 --- a/crates/ui-egui/src/canvas/proto_canvas.rs +++ b/crates/ui-egui/src/canvas/proto_canvas.rs @@ -160,7 +160,8 @@ fn variant_of(doc: &Document, source: NodeId) -> Option { /// What a connection dragged from `source` and released at screen point `p` targets: a sibling /// variant of the source's own variant (Change to), else a frame other than the source's own -/// (Navigate to). +/// (Navigate to). `None` over the source's own variant, over the rest of its set (its background), +/// and where no frame or section is under the pointer. fn target_at(app: &FigApp, doc: &Document, page: NodeId, source: NodeId, p: Pos2) -> Option { if let Some(v) = variant_of(doc, source) && let Some(set) = doc.node(v).and_then(|n| n.parent) diff --git a/crates/ui-egui/src/proto_variant_connect_tests.rs b/crates/ui-egui/src/proto_variant_connect_tests.rs index db5f55a9d..0ab64ac81 100644 --- a/crates/ui-egui/src/proto_variant_connect_tests.rs +++ b/crates/ui-egui/src/proto_variant_connect_tests.rs @@ -54,7 +54,7 @@ fn setup_in(grouped: bool) -> Setup { Setup { u, set, default, hover, layer, outside } } -/// Select `source`, then drag its connection handle to the centre of `to` (or `at`) and release. +/// Select `source`, then drag its connection handle (found inside) to the screen point `to` and release. fn drag(t: &mut Setup, source: NodeId, to: Pos2) { t.u.run("select.set", json!({"ids": [source]})); t.u.run("view.zoomSelection", json!({})); diff --git a/docs/prototyping-parity.md b/docs/prototyping-parity.md index 07e3c691d..6ca217eec 100644 --- a/docs/prototyping-parity.md +++ b/docs/prototyping-parity.md @@ -57,7 +57,7 @@ tool; opt-in), **silent** (the documentation doesn't say; the case pins the curr | Open link | pass | a new tab or browser window by default; with "Open in new tab" off, the web build's own tab goes to the link (the desktop app has no tab of its own to replace, so it opens the browser either way) | | Change to: another variant of the instance, in place, with the interaction's animation | pass | `interactive_components_change_in_place` | | Interactive components: every instance plays the interactions of the variant it shows; an interaction on the instance with the same trigger wins | **fixed** | instances played only interactions copied onto them when they were placed: an instance placed before its main got interactions did nothing, and one placed after kept the first variant's interactions after changing (a toggle went on but never off). New instances no longer copy them, and copies in older files give way to the variant shown; `instances_play_their_variants_interactions` | -| Drag a variant's (or a layer in it) connection onto a sibling variant: Change to, On click, Instant; the sibling is outlined | **fixed** | the drop only found top-level frames, and a variant's top-level frame is its set, so nothing happened. Dropped on the set's background or on its own variant it still adds nothing; on a frame outside the set it still navigates. Measured in Figma's web app, 2026-11-09; `a_variants_connection_dropped_on_a_sibling_variant_changes_to_it`, `the_reverse_connection_changes_back`, `a_layer_inside_a_variant_changes_its_set_to_the_sibling`, `dropped_on_the_sets_background_or_its_own_variant_it_adds_nothing`, `a_variant_dropped_on_a_frame_outside_the_set_still_navigates` | +| Drag a variant's (or a layer in it) connection onto a sibling variant: Change to, On click, Instant; the sibling is outlined | **fixed** | the drop only found top-level frames, and a variant's top-level frame is its set, so nothing happened. Dropped on the set's background or on its own variant it still adds nothing, also when the set sits in a group inside a section (the background used to give a Navigate to that section); on a frame outside the set it still navigates. Measured in Figma's web app, 2026-11-09; `a_variants_connection_dropped_on_a_sibling_variant_changes_to_it`, `the_reverse_connection_changes_back`, `a_layer_inside_a_variant_changes_its_set_to_the_sibling`, `dropped_on_the_sets_background_or_its_own_variant_it_adds_nothing`, `a_variant_dropped_on_a_frame_outside_the_set_still_navigates`, `in_a_grouped_set_the_background_adds_nothing_and_a_sibling_changes_to` | | Presentation tabs: one per page of a file, named "file - page" (renames follow). Play on a page that has a tab shows it as it was (from another start frame it starts again). Tabs keep their own copy of the prototype and play on after their file closes; a saved file opened again gets its tabs back. A tab never changes a file that isn't in front. Its X or Escape ends it and goes back to its file, or Home | **fixed** | one "Present" tab: a second presentation replaced the first, Play restarted it, and closing the file ended it; `present_tab_tests` | | Change to on a layer inside a nested instance changes the instance whose variant set holds the destination | **fixed** | the innermost instance (an icon inside a button) was changed instead | | Set variable, set variable mode, conditional | pass | `proto_run_tests`, `proto_conditional_tests`, `present_variables_tests` | From 97ceeca35e1cfdb4f4183485e435a503c4d500a7 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Tue, 10 Nov 2026 20:55:23 -0500 Subject: [PATCH 13/19] M10: Windows: the window no longer draws below a hidden caption (#1343) FigCraft draws its own title bar on Windows and opens undecorated windows, but winit 0.30 still gives them WS_CAPTION | WS_BORDER. On some systems the desktop compositor reserves that caption, so the content is drawn about 30 px low (a black band above it) while clicks keep the client coordinates and land above what is drawn. Fixes #1343; the same report as #1422 and #2233. A per-frame step (apps/figcraft/src/window_frame.rs, run from raw_input_hook) clears WS_CAPTION and WS_BORDER from every winit window of the process (the main window and the other windows alike), keeps WS_THICKFRAME and the window buttons so edge resizing and snap work, and calls SetWindowPos(SWP_FRAMECHANGED) only when a style changed. It uses safe winsafe calls (no unsafe), Windows only; other platforms and the browser are unchanged. The maximize-to-work-area trim of DesignCraft's fix is left for a later change. Ports the fix of DesignCraft #2139 and PhotoCraft #2401. Tests: the style arithmetic (caption and border cleared, thick frame and buttons kept, a clean style unchanged) and the per-frame hook (runs every frame, a no-op when unset). Co-Authored-By: Claude Sonnet 5.5 Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium --- Cargo.lock | 1 + apps/figcraft/Cargo.toml | 3 + apps/figcraft/src/main.rs | 10 ++ apps/figcraft/src/window_frame.rs | 177 ++++++++++++++++++++++++++++++ docs/hardware-parity.md | 3 +- 5 files changed, 193 insertions(+), 1 deletion(-) create mode 100644 apps/figcraft/src/window_frame.rs diff --git a/Cargo.lock b/Cargo.lock index 8ca91ac04..6bab85d73 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1810,6 +1810,7 @@ dependencies = [ "windows", "winit", "winresource", + "winsafe", "zbus", ] diff --git a/apps/figcraft/Cargo.toml b/apps/figcraft/Cargo.toml index f2ea73ba8..12fe93b5a 100644 --- a/apps/figcraft/Cargo.toml +++ b/apps/figcraft/Cargo.toml @@ -37,6 +37,9 @@ env_logger = { version = "0.11", default-features = false, features = ["auto-col [target.'cfg(windows)'.dependencies] craft-update = { workspace = true } windows = { version = "0.62", default-features = false, features = ["UI_ViewManagement", "System_UserProfile", "Foundation_Collections", "Gaming_Input"] } +# The custom title bar's window styles (src/window_frame.rs): safe Win32 wrappers (MIT); the `user` +# feature is User32.dll only. Same version as DesignCraft and PhotoCraft. +winsafe = { version = "0.0.29", default-features = false, features = ["user"] } # The system colour scheme (org.freedesktop.portal.Settings): winit reports no theme on Linux and # the BSDs, so the interface's "system" mode follows the portal's instead. zbus comes in through diff --git a/apps/figcraft/src/main.rs b/apps/figcraft/src/main.rs index 66b5f73ee..1d24e511b 100644 --- a/apps/figcraft/src/main.rs +++ b/apps/figcraft/src/main.rs @@ -29,6 +29,7 @@ mod graphics; mod recovery; mod services; mod startup; +mod window_frame; #[cfg(all(test, target_os = "macos"))] mod apple_events_tests; @@ -63,6 +64,8 @@ struct App { title: String, /// Shared with the services, which write the copies after a panic. recovery: recovery::Shared, + /// Keeps the custom title bar's undecorated windows borderless (Windows, #1343). + window_frame: window_frame::WindowFrame, /// Documents and quit requests from Finder, the Dock and Open With. #[cfg(target_os = "macos")] apple_events: fmv_macos_events::Inbox, @@ -111,6 +114,9 @@ impl eframe::App for App { } fn raw_input_hook(&mut self, _ctx: &egui::Context, raw_input: &mut egui::RawInput) { + // winit gives an undecorated window its caption back when it changes the window's flags + // (maximize, restore, ...): take it off again before the frame is laid out (#1343). + self.window_frame.run(); // Pointer and key events sent over the control channel (`ui.input`), for the window // about to draw. if let Some(events) = with_app(|fig| figcraft_ui_egui::windows::take_input(fig, raw_input.viewport_id)) { @@ -268,6 +274,7 @@ fn main() -> eframe::Result { // the old bespoke xdg-decoration probe that always drew FigCraft's custom title bar on KDE. fig.ui.title_bar = desktop_title_bar(); viewport = window_chrome(viewport, fig.ui.title_bar); + let custom_titlebar = fig.ui.title_bar == figcraft_ui_egui::TitleBar::Custom; if let Some(icon) = icon { viewport = viewport.with_icon(icon); } @@ -304,6 +311,9 @@ fn main() -> eframe::Result { ctx_slot, title: String::new(), recovery, + // The custom title bar's undecorated window must stay borderless, or its caption + // and border offset the content and the pointer on some Windows systems (#1343). + window_frame: window_frame::WindowFrame::new(custom_titlebar), #[cfg(target_os = "macos")] apple_events: apple_events.connect(&cc.egui_ctx), })) diff --git a/apps/figcraft/src/window_frame.rs b/apps/figcraft/src/window_frame.rs new file mode 100644 index 000000000..0033444ec --- /dev/null +++ b/apps/figcraft/src/window_frame.rs @@ -0,0 +1,177 @@ +//! Keeps the custom (undecorated) title bar windows truly borderless on Windows (#1343). +//! +//! winit 0.30 gives an undecorated window the `WS_CAPTION | WS_BORDER` styles and hides the +//! non-client area by spreading the client rect over it (`WM_NCCALCSIZE`). On some systems the +//! desktop compositor still reserves that frame for the window surface: the content is drawn about +//! 30 px low (a black band above it) while the pointer keeps the un-offset client coordinates, so +//! clicks land on something other than what is drawn under them. +//! +//! winit 0.27 omitted those styles for undecorated windows and had no offset. [`WindowFrame`] +//! restores that: it strips `WS_CAPTION` and `WS_BORDER` from every window of this process that +//! draws its own title bar, and has Windows recalculate the frame. winit puts the styles back +//! whenever it changes the window flags (maximize, restore, ...), so the step runs every frame; it +//! reads each style and writes only when it differs, so it costs next to nothing. +//! +//! The same fix is in DesignCraft (#2139) and PhotoCraft (#2401). The long-term fix is in winit +//! (storytold/winit#17); this module goes when the pinned winit has it. +//! +//! The Windows calls go through safe `winsafe` wrappers (the workspace forbids `unsafe`). Which +//! windows are ours is found by enumerating this process's top-level windows of winit's window +//! class, so the main window and every other window opened later are covered alike, and a file +//! dialog or message box of the same process is left alone. + +/// `WS_BORDER`. +#[cfg(any(windows, test))] +const WS_BORDER: u32 = 0x0080_0000; +/// `WS_CAPTION`, which already includes `WS_BORDER`. +#[cfg(any(windows, test))] +const WS_CAPTION: u32 = 0x00C0_0000; + +/// `style` without the OS title bar and frame (`WS_CAPTION`, `WS_BORDER`). The sizing border +/// (`WS_THICKFRAME`) and the window buttons stay, so edge resizing, Aero snap and the system menu +/// keep working, as they did with winit 0.27's undecorated windows. +#[cfg(any(windows, test))] +pub fn borderless_style(style: u32) -> u32 { + style & !(WS_CAPTION | WS_BORDER) +} + +/// The per-frame step that keeps the windows borderless; a no-op where the OS draws the frame +/// (macOS, Linux, the BSDs), where the app uses the system title bar, and in the browser. +pub struct WindowFrame { + step: Option>, +} + +impl WindowFrame { + /// The step for an app whose windows draw their own title bar when `custom_titlebar`. + pub fn new(custom_titlebar: bool) -> Self { + Self { step: platform::step(custom_titlebar) } + } + + /// Run the step; call it once per frame, before the frame is laid out. + pub fn run(&mut self) { + if let Some(step) = self.step.as_mut() { + step(); + } + } + + #[cfg(test)] + fn with_step(step: Box) -> Self { + Self { step: Some(step) } + } +} + +#[cfg(windows)] +mod platform { + use winsafe::{HWND, HwndPlace, POINT, SIZE, co}; + + /// winit's window class (`WindowAttributes`' default `class_name`). + const WINIT_CLASS: &str = "Window Class"; + + /// A step that strips the frame styles from this process's windows each call, or `None` when + /// the app uses the system title bar (the windows are decorated). + pub fn step(custom_titlebar: bool) -> Option> { + if !custom_titlebar { + return None; + } + let pid = std::process::id(); + Some(Box::new(move || { + // The windows are handed over as real `HWND`s; nothing is wrapped from a raw handle. + let _ = winsafe::EnumWindows(|hwnd| { + strip_if_ours(&hwnd, pid); + true + }); + })) + } + + /// Strip `hwnd` when it is one of this process's winit windows. + fn strip_if_ours(hwnd: &HWND, pid: u32) { + if hwnd.GetWindowThreadProcessId().1 != pid || !matches!(hwnd.GetClassName().as_deref(), Ok(WINIT_CLASS)) { + return; + } + strip(hwnd); + } + + /// Removes `WS_CAPTION`/`WS_BORDER` and has Windows recalculate the frame; a no-op once they + /// are gone. + fn strip(hwnd: &HWND) { + let style = hwnd.style(); + // The decision is the tested arithmetic; the write uses the same bits as winsafe's flags. + if super::borderless_style(style.raw()) == style.raw() { + return; + } + hwnd.set_style(style & !(co::WS::CAPTION | co::WS::BORDER)); + let _ = hwnd.SetWindowPos( + HwndPlace::None, + POINT::new(), + SIZE::new(), + co::SWP::FRAMECHANGED | co::SWP::NOMOVE | co::SWP::NOSIZE | co::SWP::NOZORDER | co::SWP::NOACTIVATE, + ); + } +} + +#[cfg(not(windows))] +mod platform { + pub fn step(_custom_titlebar: bool) -> Option> { + None + } +} + +#[cfg(test)] +mod window_frame_tests { + use std::sync::Arc; + use std::sync::atomic::{AtomicUsize, Ordering}; + + use super::{WS_BORDER, WS_CAPTION, WindowFrame, borderless_style}; + + #[cfg(windows)] + #[test] + fn the_style_bits_match_winsafes() { + use winsafe::co; + assert_eq!(co::WS::CAPTION.raw(), WS_CAPTION); + assert_eq!(co::WS::BORDER.raw(), WS_BORDER); + } + + const WS_SYSMENU: u32 = 0x0008_0000; + const WS_THICKFRAME: u32 = 0x0004_0000; + const WS_MINIMIZEBOX: u32 = 0x0002_0000; + const WS_MAXIMIZEBOX: u32 = 0x0001_0000; + const WS_VISIBLE: u32 = 0x1000_0000; + + #[test] + fn the_borderless_style_drops_the_caption_and_border_only() { + let decorated = WS_CAPTION | WS_BORDER | WS_SYSMENU | WS_THICKFRAME | WS_MAXIMIZEBOX | WS_MINIMIZEBOX | WS_VISIBLE; + let bare = borderless_style(decorated); + assert_eq!(bare & WS_CAPTION, 0, "caption gone"); + assert_eq!(bare & WS_BORDER, 0, "border gone"); + assert_eq!(bare & WS_THICKFRAME, WS_THICKFRAME, "edge resizing kept"); + assert_eq!(bare & (WS_MAXIMIZEBOX | WS_MINIMIZEBOX | WS_SYSMENU), WS_MAXIMIZEBOX | WS_MINIMIZEBOX | WS_SYSMENU, "window buttons kept"); + assert_eq!(bare & WS_VISIBLE, WS_VISIBLE, "unrelated bits kept"); + } + + #[test] + fn an_already_borderless_style_is_unchanged_so_no_frame_change_is_made() { + let bare = WS_THICKFRAME | WS_SYSMENU | WS_MAXIMIZEBOX | WS_MINIMIZEBOX | WS_VISIBLE; + assert_eq!(borderless_style(bare), bare); + assert_eq!(borderless_style(borderless_style(bare | WS_CAPTION)), bare); + } + + #[test] + fn the_step_runs_each_time_the_frame_runs_it() { + let calls = Arc::new(AtomicUsize::new(0)); + let n = calls.clone(); + let mut frame = WindowFrame::with_step(Box::new(move || { + n.fetch_add(1, Ordering::SeqCst); + })); + for _ in 0..3 { + frame.run(); + } + assert_eq!(calls.load(Ordering::SeqCst), 3); + } + + #[test] + fn no_step_is_fine() { + // Decorated windows and other platforms have no step; running must do nothing. + let mut frame = WindowFrame::new(false); + frame.run(); + } +} diff --git a/docs/hardware-parity.md b/docs/hardware-parity.md index 1d64bc411..846c8a199 100644 --- a/docs/hardware-parity.md +++ b/docs/hardware-parity.md @@ -1,6 +1,6 @@ # Hardware and platform parity -> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-11-06 · **Change:** patch (under Wayland a minimised window answers control and MCP requests in about half a second instead of timing out after 60 s (#1906); images copied in other apps paste in the browser (#492); text reads only the fallback fonts it draws with; `doc.list` gives AI agents and plugins the open files' names, not their paths (#1117); a batch keeps one undo snapshot, not one per step (#1099); one depth cap bounds a whole render, pattern sources included, and render threads get 8 MiB stacks (#1082); in the browser an internal error that stops the page keeps its unsaved files, which open again on reload (#1123); the portable Windows zip keeps its settings, recovery copies and plugins in `config\` beside the executable, starting with an installed copy's preferences; the window starts on other graphics when its first ones fail before the first frame: Direct3D 12 compiles with FXC and no device compiles wgpu's indirect-validation shaders, then Vulkan, OpenGL and lower requirements on the power-saving GPU (#965, #1438); large images on the canvas draw from a smaller copy, so two 16k images no longer lag (#1483); macOS: the Quit menu and ⌘Q ask about unsaved changes (#857); egui/eframe 0.37 dependency migration; hidden-window screenshot deadlines; zoom previews; hidden windows answer control requests; macOS file opening, the Windows start-up message, Linux packaging; copy and paste in the browser; Windows QA pass; Display P3: gamut warning and soft-proof (true P3 blocked upstream); several windows; pen pressure for the Pencil and brushes on Windows and from browser styluses; macOS: quitting ends the process once everything is kept, avoiding the Touch Bar teardown crash (#781); Linux and BSD clipboard: images under Wayland, reads time out; minimised windows under Wayland; window controls on Wayland without server decorations; canvas textures on device pixels) · **Target:** Figma Design (desktop app 126.10.7) +> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-11-10 · **Change:** patch (Windows: the custom title bar's windows stay borderless, so the content is no longer drawn about 30 px low with clicks landing above it (#1343); under Wayland a minimised window answers control and MCP requests in about half a second instead of timing out after 60 s (#1906); images copied in other apps paste in the browser (#492); text reads only the fallback fonts it draws with; `doc.list` gives AI agents and plugins the open files' names, not their paths (#1117); a batch keeps one undo snapshot, not one per step (#1099); one depth cap bounds a whole render, pattern sources included, and render threads get 8 MiB stacks (#1082); in the browser an internal error that stops the page keeps its unsaved files, which open again on reload (#1123); the portable Windows zip keeps its settings, recovery copies and plugins in `config\` beside the executable, starting with an installed copy's preferences; the window starts on other graphics when its first ones fail before the first frame: Direct3D 12 compiles with FXC and no device compiles wgpu's indirect-validation shaders, then Vulkan, OpenGL and lower requirements on the power-saving GPU (#965, #1438); large images on the canvas draw from a smaller copy, so two 16k images no longer lag (#1483); macOS: the Quit menu and ⌘Q ask about unsaved changes (#857); egui/eframe 0.37 dependency migration; hidden-window screenshot deadlines; zoom previews; hidden windows answer control requests; macOS file opening, the Windows start-up message, Linux packaging; copy and paste in the browser; Windows QA pass; Display P3: gamut warning and soft-proof (true P3 blocked upstream); several windows; pen pressure for the Pencil and brushes on Windows and from browser styluses; macOS: quitting ends the process once everything is kept, avoiding the Touch Bar teardown crash (#781); Linux and BSD clipboard: images under Wayland, reads time out; minimised windows under Wayland; window controls on Wayland without server decorations; canvas textures on device pixels) · **Target:** Figma Design (desktop app 126.10.7) How FigCraft uses hardware and which platforms it runs on, against Figma. Figma's desktop app is Electron with a GPU helper process; its canvas renders on the GPU (WebGL, with WebGPU rolling out @@ -50,6 +50,7 @@ Nothing has been timed against Figma on the same document (needs `.fig` import). | Date | Change | Summary | |---|---|---| +| 2026-11-10 | patch | M10, #1343 (also #1422, #2233): Windows: the window no longer draws below a hidden caption. FigCraft draws its own title bar on Windows and opens undecorated windows, but winit 0.30 still gives them `WS_CAPTION | WS_BORDER`; on some systems the desktop compositor reserves that caption, so the content was drawn about 30 px low (a black band above it) while clicks kept the client coordinates and landed above what was drawn. A per-frame step (`apps/figcraft/src/window_frame.rs`, safe `winsafe` calls, Windows only) clears `WS_CAPTION` and `WS_BORDER` from every FigCraft window, the main one and the others, keeping the sizing border and window buttons so edge resizing and snap work, and writes only when a style changed (winit puts them back on maximize and restore). The same fix as DesignCraft #2139 and PhotoCraft #2401; the maximize-to-work-area trim from DesignCraft is left for a later change. Not run on a Windows machine that shows the offset: the style math and the per-frame hook are tested, the window itself needs a live check. Tests: `window_frame_tests`. Numbers unchanged | | 2026-11-06 | patch | M8, #1906: under Wayland (seen on GNOME and KDE Plasma) a minimised FigCraft window still reports itself visible and the compositor stops asking it to draw, so every control or attached-MCP request waited for a frame and timed out after 60 s ("it was not applied"), though eframe kept running the app's logic. `control::background` now treats a window that drew no frame for `NOT_DRAWING_AFTER` (0.2 s) while a request waited for it as hidden: state-only requests are answered from the logic passes (0.54 s each, measured on GNOME Wayland; they took 13.7 s or timed out before), the wait starts again when the window draws, and screenshots and `ui.input` still wait for a frame. Test: `idle_tests::a_window_that_stopped_drawing_answers_from_its_logic_passes` | | 2026-10-31 | minor | M1, #492: Web row: the browser pastes images copied in other apps, read from the paste event under the same limits as the desktop. Numbers unchanged. | | 2026-10-30 | minor | M8: text reads only the fallback fonts it draws with. Each fallback family reads the face nearest a run's style, not all of them (Noto Sans CJK is seven files of 16–20 MB); families naming the faces of one file share its bytes; and the faces are worked out once per style until fonts change, not for every text laid out. First text laid out on a Linux machine with Noto Sans CJK, DejaVu Sans and Inter: 41 files (265 MiB, kept in memory) and 41 faces parsed → 3 files (20 MiB) and 4 faces; fallback lookups per text laid out ~45 µs → 0.2 µs. Tests: `fontdb_fallback_tests`. Numbers unchanged | From 8e1a2ff26223e25bbf452bebb606564241eca7a0 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Wed, 11 Nov 2026 00:35:51 -0500 Subject: [PATCH 14/19] M10: Docs: the hardware-parity row keeps its three cells (#1343) A bare pipe inside the code span `WS_CAPTION | WS_BORDER` split the table row; the two style names are separate code spans now. Co-Authored-By: Claude Opus 5.5 Model-Effort: Opus 5.5 drove and wrote --- docs/hardware-parity.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hardware-parity.md b/docs/hardware-parity.md index 846c8a199..b827a887c 100644 --- a/docs/hardware-parity.md +++ b/docs/hardware-parity.md @@ -50,7 +50,7 @@ Nothing has been timed against Figma on the same document (needs `.fig` import). | Date | Change | Summary | |---|---|---| -| 2026-11-10 | patch | M10, #1343 (also #1422, #2233): Windows: the window no longer draws below a hidden caption. FigCraft draws its own title bar on Windows and opens undecorated windows, but winit 0.30 still gives them `WS_CAPTION | WS_BORDER`; on some systems the desktop compositor reserves that caption, so the content was drawn about 30 px low (a black band above it) while clicks kept the client coordinates and landed above what was drawn. A per-frame step (`apps/figcraft/src/window_frame.rs`, safe `winsafe` calls, Windows only) clears `WS_CAPTION` and `WS_BORDER` from every FigCraft window, the main one and the others, keeping the sizing border and window buttons so edge resizing and snap work, and writes only when a style changed (winit puts them back on maximize and restore). The same fix as DesignCraft #2139 and PhotoCraft #2401; the maximize-to-work-area trim from DesignCraft is left for a later change. Not run on a Windows machine that shows the offset: the style math and the per-frame hook are tested, the window itself needs a live check. Tests: `window_frame_tests`. Numbers unchanged | +| 2026-11-10 | patch | M10, #1343 (also #1422, #2233): Windows: the window no longer draws below a hidden caption. FigCraft draws its own title bar on Windows and opens undecorated windows, but winit 0.30 still gives them `WS_CAPTION` and `WS_BORDER`; on some systems the desktop compositor reserves that caption, so the content was drawn about 30 px low (a black band above it) while clicks kept the client coordinates and landed above what was drawn. A per-frame step (`apps/figcraft/src/window_frame.rs`, safe `winsafe` calls, Windows only) clears `WS_CAPTION` and `WS_BORDER` from every FigCraft window, the main one and the others, keeping the sizing border and window buttons so edge resizing and snap work, and writes only when a style changed (winit puts them back on maximize and restore). The same fix as DesignCraft #2139 and PhotoCraft #2401; the maximize-to-work-area trim from DesignCraft is left for a later change. Not run on a Windows machine that shows the offset: the style math and the per-frame hook are tested, the window itself needs a live check. Tests: `window_frame_tests`. Numbers unchanged | | 2026-11-06 | patch | M8, #1906: under Wayland (seen on GNOME and KDE Plasma) a minimised FigCraft window still reports itself visible and the compositor stops asking it to draw, so every control or attached-MCP request waited for a frame and timed out after 60 s ("it was not applied"), though eframe kept running the app's logic. `control::background` now treats a window that drew no frame for `NOT_DRAWING_AFTER` (0.2 s) while a request waited for it as hidden: state-only requests are answered from the logic passes (0.54 s each, measured on GNOME Wayland; they took 13.7 s or timed out before), the wait starts again when the window draws, and screenshots and `ui.input` still wait for a frame. Test: `idle_tests::a_window_that_stopped_drawing_answers_from_its_logic_passes` | | 2026-10-31 | minor | M1, #492: Web row: the browser pastes images copied in other apps, read from the paste event under the same limits as the desktop. Numbers unchanged. | | 2026-10-30 | minor | M8: text reads only the fallback fonts it draws with. Each fallback family reads the face nearest a run's style, not all of them (Noto Sans CJK is seven files of 16–20 MB); families naming the faces of one file share its bytes; and the faces are worked out once per style until fonts change, not for every text laid out. First text laid out on a Linux machine with Noto Sans CJK, DejaVu Sans and Inter: 41 files (265 MiB, kept in memory) and 41 faces parsed → 3 files (20 MiB) and 4 faces; fallback lookups per text laid out ~45 µs → 0.2 µs. Tests: `fontdb_fallback_tests`. Numbers unchanged | From 016dba8c34d697419c7db87ebfd5aa13b925511e Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Tue, 10 Nov 2026 23:49:43 -0800 Subject: [PATCH 15/19] Export: the color profile note says Display P3 tagging applies to exports that use the file's profile An export setting set to sRGB still writes sRGB files in a Display P3 document, so the note no longer says every exported PNG, JPG and WebP is tagged Display P3. Follows #1759. --- crates/ui-egui/locales/ar.toml | 2 +- crates/ui-egui/locales/bn.toml | 2 +- crates/ui-egui/locales/bs.toml | 2 +- crates/ui-egui/locales/cs.toml | 2 +- crates/ui-egui/locales/de.toml | 2 +- crates/ui-egui/locales/en.toml | 2 +- crates/ui-egui/locales/es.toml | 2 +- crates/ui-egui/locales/fi.toml | 2 +- crates/ui-egui/locales/fr.toml | 2 +- crates/ui-egui/locales/id.toml | 2 +- crates/ui-egui/locales/it.toml | 2 +- crates/ui-egui/locales/ja.toml | 2 +- crates/ui-egui/locales/ka.toml | 2 +- crates/ui-egui/locales/ko.toml | 2 +- crates/ui-egui/locales/nl.toml | 2 +- crates/ui-egui/locales/pl.toml | 2 +- crates/ui-egui/locales/pt-BR.toml | 2 +- crates/ui-egui/locales/ru.toml | 2 +- crates/ui-egui/locales/sv.toml | 2 +- crates/ui-egui/locales/th.toml | 2 +- crates/ui-egui/locales/tr.toml | 2 +- crates/ui-egui/locales/vi.toml | 2 +- crates/ui-egui/locales/zh-Hans.toml | 2 +- crates/ui-egui/locales/zh-Hant.toml | 2 +- crates/ui-egui/src/dialogs/color_profile.rs | 2 +- 25 files changed, 25 insertions(+), 25 deletions(-) diff --git a/crates/ui-egui/locales/ar.toml b/crates/ui-egui/locales/ar.toml index e50a9b9c4..cc55d730a 100644 --- a/crates/ui-egui/locales/ar.toml +++ b/crates/ui-egui/locales/ar.toml @@ -1496,7 +1496,7 @@ status = "draft — needs native review" "Text styles" = "أنماط النص" "Texts" = "النصوص" "Texture" = "النسيج" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "تُعاين الألوان على لوحة الرسم بفضاء sRGB؛ وتُوسم ملفات PNG وJPG وWebP المصدّرة بملف Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "تُعاين الألوان على لوحة الرسم بفضاء sRGB؛ وملفات PNG وJPG وWebP المصدّرة بملف تعريف الألوان الخاص بالملف تُوسم بملف Display P3." "The destination document is unavailable. Nothing was imported." = "المستند الوجهة غير متاح. لم يُستورد شيء." "The destination document was closed. Nothing was imported." = "أُغلق المستند الوجهة. لم يُستورد شيء." "The destination page was removed. Nothing was imported." = "أُزيلت الصفحة الوجهة. لم يُستورد شيء." diff --git a/crates/ui-egui/locales/bn.toml b/crates/ui-egui/locales/bn.toml index b79877271..03927be6b 100644 --- a/crates/ui-egui/locales/bn.toml +++ b/crates/ui-egui/locales/bn.toml @@ -1453,7 +1453,7 @@ status = "draft — needs native review" "Text styles" = "টেক্সট স্টাইলসমূহ" "Texts" = "টেক্সটসমূহ" "Texture" = "টেক্সচার" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "ক্যানভাস sRGB-তে রঙ প্রিভিউ করে; এক্সপোর্ট করা PNG, JPG এবং WebP ফাইলে Display P3 ট্যাগ করা থাকে।" +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "ক্যানভাস sRGB-তে রঙ প্রিভিউ করে; ফাইলের প্রোফাইল দিয়ে এক্সপোর্ট করা PNG, JPG এবং WebP ফাইলে Display P3 ট্যাগ করা থাকে।" "The destination document is unavailable. Nothing was imported." = "গন্তব্য ডকুমেন্ট অনুপলব্ধ। কিছু ইম্পোর্ট করা হয়নি।" "The destination document was closed. Nothing was imported." = "গন্তব্য ডকুমেন্ট বন্ধ করা হয়েছিল। কিছু ইম্পোর্ট করা হয়নি।" "The destination page was removed. Nothing was imported." = "গন্তব্য পেজ সরানো হয়েছে। কিছু ইম্পোর্ট করা হয়নি।" diff --git a/crates/ui-egui/locales/bs.toml b/crates/ui-egui/locales/bs.toml index 919bc0381..bbb268933 100644 --- a/crates/ui-egui/locales/bs.toml +++ b/crates/ui-egui/locales/bs.toml @@ -1508,7 +1508,7 @@ status = "draft — needs native review" "Text styles" = "Stilovi teksta" "Texts" = "Tekstovi" "Texture" = "Tekstura" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Platno prikazuje boje u sRGB-u; izvezene PNG, JPG i WebP datoteke su označene kao Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Platno prikazuje boje u sRGB-u; PNG, JPG i WebP datoteke izvezene s profilom datoteke su označene kao Display P3." "The destination document is unavailable. Nothing was imported." = "Odredišni dokument nije dostupan. Ništa nije uvezeno." "The destination document was closed. Nothing was imported." = "Odredišni dokument je zatvoren. Ništa nije uvezeno." "The destination page was removed. Nothing was imported." = "Odredišna stranica je uklonjena. Ništa nije uvezeno." diff --git a/crates/ui-egui/locales/cs.toml b/crates/ui-egui/locales/cs.toml index 7ecc6779a..6f6399811 100644 --- a/crates/ui-egui/locales/cs.toml +++ b/crates/ui-egui/locales/cs.toml @@ -1428,7 +1428,7 @@ status = "draft — needs native review" "Text styles" = "Textové styly" "Texts" = "Texty" "Texture" = "Textura" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Plátno zobrazuje barvy v sRGB; exportované soubory PNG, JPG a WebP mají profil Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Plátno zobrazuje barvy v sRGB; soubory PNG, JPG a WebP exportované s profilem souboru mají profil Display P3." "The file is deleted from the server: nobody can open or join it from there again, and this can't be undone. Copies that are open stay with whoever has them." = "Soubor se smaže ze serveru: nikdo ho odtud již neotevře ani se k němu nepřipojí a tuto akci nelze vrátit zpět. Otevřené kopie zůstanou těm, kteří je mají." "The file now holds another library" = "Soubor nyní obsahuje jinou knihovnu" "The file now holds another library (\"{name}\")" = "Soubor nyní obsahuje jinou knihovnu („{name}“)" diff --git a/crates/ui-egui/locales/de.toml b/crates/ui-egui/locales/de.toml index f57fcc5d3..d0e1536fe 100644 --- a/crates/ui-egui/locales/de.toml +++ b/crates/ui-egui/locales/de.toml @@ -1398,7 +1398,7 @@ status = "draft — needs native review" "Text styles" = "Textstile" "Texts" = "Texte" "Texture" = "Textur" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Die Arbeitsfläche zeigt Farben in sRGB an; exportierte PNG-, JPG- und WebP-Dateien werden als Display P3 gekennzeichnet." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Die Arbeitsfläche zeigt Farben in sRGB an; PNG-, JPG- und WebP-Exporte mit dem Profil der Datei werden als Display P3 gekennzeichnet." "The destination document is unavailable. Nothing was imported." = "Das Zieldokument ist nicht verfügbar. Es wurde nichts importiert." "The destination document was closed. Nothing was imported." = "Das Zieldokument wurde geschlossen. Es wurde nichts importiert." "The destination page was removed. Nothing was imported." = "Die Zielseite wurde entfernt. Es wurde nichts importiert." diff --git a/crates/ui-egui/locales/en.toml b/crates/ui-egui/locales/en.toml index 625ee3bd8..3d3fb7fc4 100644 --- a/crates/ui-egui/locales/en.toml +++ b/crates/ui-egui/locales/en.toml @@ -1577,7 +1577,7 @@ name = "English" "Text styles" = "Text styles" "Texts" = "Texts" "Texture" = "Texture" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." "The destination document is unavailable. Nothing was imported." = "The destination document is unavailable. Nothing was imported." "The destination document was closed. Nothing was imported." = "The destination document was closed. Nothing was imported." "The destination page was removed. Nothing was imported." = "The destination page was removed. Nothing was imported." diff --git a/crates/ui-egui/locales/es.toml b/crates/ui-egui/locales/es.toml index 258a1527d..f6f437925 100644 --- a/crates/ui-egui/locales/es.toml +++ b/crates/ui-egui/locales/es.toml @@ -1491,7 +1491,7 @@ status = "draft — needs native review" "Text styles" = "Estilos de texto" "Texts" = "Textos" "Texture" = "Textura" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "El lienzo muestra los colores en sRGB; los archivos PNG, JPG y WebP exportados se etiquetan como Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "El lienzo muestra los colores en sRGB; los archivos PNG, JPG y WebP exportados con el perfil del archivo se etiquetan como Display P3." "The destination document is unavailable. Nothing was imported." = "El documento de destino no está disponible. No se importó nada." "The destination document was closed. Nothing was imported." = "Se cerró el documento de destino. No se importó nada." "The destination page was removed. Nothing was imported." = "Se eliminó la página de destino. No se importó nada." diff --git a/crates/ui-egui/locales/fi.toml b/crates/ui-egui/locales/fi.toml index 88fb21e06..d9544ec94 100644 --- a/crates/ui-egui/locales/fi.toml +++ b/crates/ui-egui/locales/fi.toml @@ -1522,7 +1522,7 @@ status = "draft — needs native review" "Text styles" = "Tekstityylit" "Texts" = "Tekstit" "Texture" = "Tekstuuri" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Piirtoalue esikatselee värit sRGB-muodossa. Vietäviin PNG-, JPG- ja WebP-tiedostoihin merkitään Display P3 -profiili." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Piirtoalue esikatselee värit sRGB-muodossa. Tiedoston profiililla vietäviin PNG-, JPG- ja WebP-tiedostoihin merkitään Display P3 -profiili." "The destination document is unavailable. Nothing was imported." = "Kohdeasiakirja ei ole käytettävissä. Mitään ei tuotu." "The destination document was closed. Nothing was imported." = "Kohdeasiakirja suljettiin. Mitään ei tuotu." "The destination page was removed. Nothing was imported." = "Kohdesivu poistettiin. Mitään ei tuotu." diff --git a/crates/ui-egui/locales/fr.toml b/crates/ui-egui/locales/fr.toml index e40b3a060..33c7d1ad4 100644 --- a/crates/ui-egui/locales/fr.toml +++ b/crates/ui-egui/locales/fr.toml @@ -1457,7 +1457,7 @@ status = "draft — needs native review" "Text styles" = "Styles de texte" "Texts" = "Textes" "Texture" = "Texture" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Le canevas affiche les couleurs en sRGB ; les fichiers PNG, JPG et WebP exportés sont balisés Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Le canevas affiche les couleurs en sRGB ; les fichiers PNG, JPG et WebP exportés avec le profil du fichier sont balisés Display P3." "The destination document is unavailable. Nothing was imported." = "Le document de destination est indisponible. Rien n’a été importé." "The destination document was closed. Nothing was imported." = "Le document de destination a été fermé. Rien n’a été importé." "The destination page was removed. Nothing was imported." = "La page de destination a été supprimée. Rien n’a été importé." diff --git a/crates/ui-egui/locales/id.toml b/crates/ui-egui/locales/id.toml index 59dbd492c..2945719fd 100644 --- a/crates/ui-egui/locales/id.toml +++ b/crates/ui-egui/locales/id.toml @@ -1434,7 +1434,7 @@ status = "draft — needs native review" "Text styles" = "Gaya teks" "Texts" = "Teks" "Texture" = "Tekstur" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Kanvas mempratinjau warna dalam sRGB; file PNG, JPG, dan WebP yang diekspor ditandai Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Kanvas mempratinjau warna dalam sRGB; file PNG, JPG, dan WebP yang diekspor dengan profil file ditandai Display P3." "The file is deleted from the server: nobody can open or join it from there again, and this can't be undone. Copies that are open stay with whoever has them." = "File dihapus dari server: tidak ada yang dapat membuka atau bergabung ke file itu dari sana lagi, dan tindakan ini tidak dapat diurungkan. Salinan yang sedang terbuka tetap ada pada pemiliknya." "The file now holds another library" = "File kini berisi pustaka lain" "The file now holds another library (\"{name}\")" = "File kini berisi pustaka lain (\"{name}\")" diff --git a/crates/ui-egui/locales/it.toml b/crates/ui-egui/locales/it.toml index f61ee86fe..16001e8cb 100644 --- a/crates/ui-egui/locales/it.toml +++ b/crates/ui-egui/locales/it.toml @@ -1389,7 +1389,7 @@ status = "draft — needs native review" "Text styles" = "Stili di testo" "Texts" = "Testi" "Texture" = "Texture" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Il canvas mostra i colori in sRGB; i file PNG, JPG e WebP esportati sono contrassegnati come Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Il canvas mostra i colori in sRGB; i file PNG, JPG e WebP esportati con il profilo del file sono contrassegnati come Display P3." "The destination document is unavailable. Nothing was imported." = "Il documento di destinazione non è disponibile. Non è stato importato nulla." "The destination document was closed. Nothing was imported." = "Il documento di destinazione è stato chiuso. Non è stato importato nulla." "The destination page was removed. Nothing was imported." = "La pagina di destinazione è stata rimossa. Non è stato importato nulla." diff --git a/crates/ui-egui/locales/ja.toml b/crates/ui-egui/locales/ja.toml index d440e910f..94a7e9574 100644 --- a/crates/ui-egui/locales/ja.toml +++ b/crates/ui-egui/locales/ja.toml @@ -1444,7 +1444,7 @@ status = "draft — needs native review" "Text styles" = "テキストスタイル" "Texts" = "テキスト" "Texture" = "テクスチャ" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "キャンバスは sRGB で色をプレビュー。書き出した PNG、JPG、WebP ファイルには Display P3 のタグが付く。" +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "キャンバスは sRGB で色をプレビュー。ファイルのプロファイルで書き出した PNG、JPG、WebP ファイルには Display P3 のタグが付く。" "The file is deleted from the server: nobody can open or join it from there again, and this can't be undone. Copies that are open stay with whoever has them." = "ファイルはサーバーから削除される：サーバーから開いたり参加したりすることは誰にもできなくなり、元に戻せない。開いているコピーは各自の手元に残る。" "The file now holds another library" = "このファイルは別のライブラリになっている" "The file now holds another library (\"{name}\")" = "このファイルは別のライブラリ（「{name}」）になっている" diff --git a/crates/ui-egui/locales/ka.toml b/crates/ui-egui/locales/ka.toml index 4c6764afa..816381c24 100644 --- a/crates/ui-egui/locales/ka.toml +++ b/crates/ui-egui/locales/ka.toml @@ -1477,7 +1477,7 @@ status = "draft — reviewed by a native speaker, awaiting a maintainer's approv "Text styles" = "ტექსტის სტილები" "Texts" = "ტექსტები" "Texture" = "ტექსტურა" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "ტილო ფერებს sRGB-ში აჩვენებს; ექსპორტირებულ PNG, JPG და WebP ფაილებს Display P3 ჭდე აქვს." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "ტილო ფერებს sRGB-ში აჩვენებს; ფაილის პროფილით ექსპორტირებულ PNG, JPG და WebP ფაილებს Display P3 ჭდე აქვს." "The destination document is unavailable. Nothing was imported." = "დანიშნულების დოკუმენტი მიუწვდომელია. იმპორტი არ შესრულდა." "The destination document was closed. Nothing was imported." = "დანიშნულების დოკუმენტი დაიხურა. იმპორტი არ შესრულდა." "The destination page was removed. Nothing was imported." = "დანიშნულების გვერდი წაიშალა. იმპორტი არ შესრულდა." diff --git a/crates/ui-egui/locales/ko.toml b/crates/ui-egui/locales/ko.toml index b4c960fbc..666fd02c8 100644 --- a/crates/ui-egui/locales/ko.toml +++ b/crates/ui-egui/locales/ko.toml @@ -1379,7 +1379,7 @@ status = "draft — needs native review" "Text styles" = "텍스트 스타일" "Texts" = "텍스트" "Texture" = "텍스처" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "캔버스는 sRGB로 색상을 미리 보여 줌. 내보낸 PNG, JPG, WebP 파일에는 Display P3 태그가 붙음." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "캔버스는 sRGB로 색상을 미리 보여 줌. 파일의 프로필로 내보낸 PNG, JPG, WebP 파일에는 Display P3 태그가 붙음." "The file is deleted from the server: nobody can open or join it from there again, and this can't be undone. Copies that are open stay with whoever has them." = "파일이 서버에서 삭제됨: 누구도 서버에서 다시 열거나 참여할 수 없으며 되돌릴 수 없음. 열려 있는 사본은 각자에게 남음." "The file now holds another library" = "이 파일은 이제 다른 라이브러리를 담고 있음" "The file now holds another library (\"{name}\")" = "이 파일은 이제 다른 라이브러리(\"{name}\")를 담고 있음" diff --git a/crates/ui-egui/locales/nl.toml b/crates/ui-egui/locales/nl.toml index 2d6816ab6..9e289ef1f 100644 --- a/crates/ui-egui/locales/nl.toml +++ b/crates/ui-egui/locales/nl.toml @@ -1458,7 +1458,7 @@ status = "draft — needs native review" "Text styles" = "Tekststijlen" "Texts" = "Teksten" "Texture" = "Texture" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Het canvas toont de kleuren als voorvertoning in sRGB; geëxporteerde PNG-, JPG- en WebP-bestanden worden gelabeld als Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Het canvas toont de kleuren als voorvertoning in sRGB; PNG-, JPG- en WebP-bestanden die met het profiel van het bestand worden geëxporteerd, worden gelabeld als Display P3." "The destination document is unavailable. Nothing was imported." = "Het doeldocument is niet beschikbaar. Er is niets geïmporteerd." "The destination document was closed. Nothing was imported." = "Het doeldocument is gesloten. Er is niets geïmporteerd." "The destination page was removed. Nothing was imported." = "De doelpagina is verwijderd. Er is niets geïmporteerd." diff --git a/crates/ui-egui/locales/pl.toml b/crates/ui-egui/locales/pl.toml index bcc9f0051..fb93dcaf0 100644 --- a/crates/ui-egui/locales/pl.toml +++ b/crates/ui-egui/locales/pl.toml @@ -1465,7 +1465,7 @@ name = "Polski" "Text styles" = "Style tekstu" "Texts" = "Teksty" "Texture" = "Tekstura" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Płótno wyświetla podgląd kolorów w sRGB; wyeksportowane pliki PNG, JPG i WebP są oznaczane profilem Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Płótno wyświetla podgląd kolorów w sRGB; pliki PNG, JPG i WebP wyeksportowane z profilem pliku są oznaczane profilem Display P3." "The destination document is unavailable. Nothing was imported." = "Dokument docelowy jest niedostępny. Nic nie zostało zaimportowane." "The destination document was closed. Nothing was imported." = "Dokument docelowy został zamknięty. Nic nie zostało zaimportowane." "The destination page was removed. Nothing was imported." = "Strona docelowa została usunięta. Nic nie zostało zaimportowane." diff --git a/crates/ui-egui/locales/pt-BR.toml b/crates/ui-egui/locales/pt-BR.toml index 9108dea4d..7e7500145 100644 --- a/crates/ui-egui/locales/pt-BR.toml +++ b/crates/ui-egui/locales/pt-BR.toml @@ -1377,7 +1377,7 @@ status = "draft — needs native review" "Text styles" = "Estilos de texto" "Texts" = "Textos" "Texture" = "Textura" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "A tela exibe as cores em sRGB; os arquivos PNG, JPG e WebP exportados são marcados como Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "A tela exibe as cores em sRGB; os arquivos PNG, JPG e WebP exportados com o perfil do arquivo são marcados como Display P3." "The file is deleted from the server: nobody can open or join it from there again, and this can't be undone. Copies that are open stay with whoever has them." = "O arquivo é excluído do servidor: ninguém poderá abri-lo nem entrar nele a partir de lá de novo, e isso não pode ser desfeito. As cópias abertas ficam com quem as tem." "The file now holds another library" = "O arquivo agora contém outra biblioteca" "The file now holds another library (\"{name}\")" = "O arquivo agora contém outra biblioteca (\"{name}\")" diff --git a/crates/ui-egui/locales/ru.toml b/crates/ui-egui/locales/ru.toml index 36e9abeaa..92670011a 100644 --- a/crates/ui-egui/locales/ru.toml +++ b/crates/ui-egui/locales/ru.toml @@ -1465,7 +1465,7 @@ name = "Русский" "Text styles" = "Текстовые стили" "Texts" = "Тексты" "Texture" = "Текстура" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "На холсте цвета отображаются в sRGB; экспортированные PNG, JPG и WebP помечены профилем Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "На холсте цвета отображаются в sRGB; PNG, JPG и WebP, экспортированные с профилем файла, помечены профилем Display P3." "The destination document is unavailable. Nothing was imported." = "Документ назначения недоступен. Ничего не импортировано." "The destination document was closed. Nothing was imported." = "Документ назначения закрыт. Ничего не импортировано." "The destination page was removed. Nothing was imported." = "Страница назначения удалена. Ничего не импортировано." diff --git a/crates/ui-egui/locales/sv.toml b/crates/ui-egui/locales/sv.toml index ce02b3f7f..93353be22 100644 --- a/crates/ui-egui/locales/sv.toml +++ b/crates/ui-egui/locales/sv.toml @@ -1537,7 +1537,7 @@ name = "Svenska" "Text styles" = "Textstilar" "Texts" = "Texter" "Texture" = "Textur" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Arbetsytan förhandsgranskar färger i sRGB; exporterade PNG-, JPG- och WebP-filer märks med Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Arbetsytan förhandsgranskar färger i sRGB; PNG-, JPG- och WebP-filer som exporteras med filens profil märks med Display P3." "The destination document is unavailable. Nothing was imported." = "Måldokumentet är inte tillgängligt. Ingenting importerades." "The destination document was closed. Nothing was imported." = "Måldokumentet stängdes. Ingenting importerades." "The destination page was removed. Nothing was imported." = "Målsidan togs bort. Ingenting importerades." diff --git a/crates/ui-egui/locales/th.toml b/crates/ui-egui/locales/th.toml index f4662a2b8..629abaa56 100644 --- a/crates/ui-egui/locales/th.toml +++ b/crates/ui-egui/locales/th.toml @@ -1446,7 +1446,7 @@ status = "draft — needs native review" "Text styles" = "สไตล์ข้อความ" "Texts" = "ข้อความ" "Texture" = "เท็กซ์เจอร์" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "แคนวาสแสดงตัวอย่างสีใน sRGB ส่วนไฟล์ PNG, JPG และ WebP ที่ส่งออกจะติดแท็ก Display P3" +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "แคนวาสแสดงตัวอย่างสีใน sRGB ส่วนไฟล์ PNG, JPG และ WebP ที่ส่งออกด้วยโปรไฟล์ของไฟล์จะติดแท็ก Display P3" "The destination document is unavailable. Nothing was imported." = "เอกสารปลายทางใช้ไม่ได้ ไม่มีอะไรถูกนำเข้า" "The destination document was closed. Nothing was imported." = "เอกสารปลายทางถูกปิดแล้ว ไม่มีอะไรถูกนำเข้า" "The destination page was removed. Nothing was imported." = "หน้าปลายทางถูกลบแล้ว ไม่มีอะไรถูกนำเข้า" diff --git a/crates/ui-egui/locales/tr.toml b/crates/ui-egui/locales/tr.toml index b98f8389b..f27ccf52f 100644 --- a/crates/ui-egui/locales/tr.toml +++ b/crates/ui-egui/locales/tr.toml @@ -1433,7 +1433,7 @@ name = "Türkçe" "Text styles" = "Metin stilleri" "Texts" = "Metinler" "Texture" = "Doku" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Tuval renkleri sRGB olarak önizler; dışa aktarılan PNG, JPG ve WebP dosyaları Display P3 olarak etiketlenir." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Tuval renkleri sRGB olarak önizler; dosyanın profiliyle dışa aktarılan PNG, JPG ve WebP dosyaları Display P3 olarak etiketlenir." "The file is deleted from the server: nobody can open or join it from there again, and this can't be undone. Copies that are open stay with whoever has them." = "Dosya sunucudan silinir: artık kimse onu oradan açamaz veya ona katılamaz ve bu işlem geri alınamaz. Açık olan kopyalar, kimdeyse onda kalır." "The file now holds another library" = "Dosya artık başka bir kitaplık içeriyor" "The file now holds another library (\"{name}\")" = "Dosya artık başka bir kitaplık içeriyor (“{name}”)" diff --git a/crates/ui-egui/locales/vi.toml b/crates/ui-egui/locales/vi.toml index 5bd9cf7ff..83142691c 100644 --- a/crates/ui-egui/locales/vi.toml +++ b/crates/ui-egui/locales/vi.toml @@ -1390,7 +1390,7 @@ status = "draft — needs native review" "Text styles" = "Kiểu văn bản" "Texts" = "Văn bản" "Texture" = "Kết cấu" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "Vùng vẽ xem trước màu theo sRGB; các tệp PNG, JPG và WebP xuất ra được gắn thẻ Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Vùng vẽ xem trước màu theo sRGB; các tệp PNG, JPG và WebP xuất ra theo cấu hình của tệp được gắn thẻ Display P3." "The destination document is unavailable. Nothing was imported." = "Tài liệu đích không khả dụng. Không có nội dung nào được nhập." "The destination document was closed. Nothing was imported." = "Tài liệu đích đã đóng. Không có nội dung nào được nhập." "The destination page was removed. Nothing was imported." = "Trang đích đã bị xóa. Không có nội dung nào được nhập." diff --git a/crates/ui-egui/locales/zh-Hans.toml b/crates/ui-egui/locales/zh-Hans.toml index f78f0d938..9c593ccd5 100644 --- a/crates/ui-egui/locales/zh-Hans.toml +++ b/crates/ui-egui/locales/zh-Hans.toml @@ -1387,7 +1387,7 @@ status = "draft — needs native review" "Text styles" = "文本样式" "Texts" = "文本" "Texture" = "纹理" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "画布以 sRGB 预览颜色；导出的 PNG、JPG 和 WebP 文件标记为 Display P3。" +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "画布以 sRGB 预览颜色；使用文件配置文件导出的 PNG、JPG 和 WebP 文件标记为 Display P3。" "The file is deleted from the server: nobody can open or join it from there again, and this can't be undone. Copies that are open stay with whoever has them." = "文件将从服务器删除：任何人都无法再从服务器打开或加入它，且无法撤销。已打开的副本仍归各自持有者所有。" "The file now holds another library" = "该文件现在包含另一个库" "The file now holds another library (\"{name}\")" = "该文件现在包含另一个库（“{name}”）" diff --git a/crates/ui-egui/locales/zh-Hant.toml b/crates/ui-egui/locales/zh-Hant.toml index a1179aa0c..fb941ceec 100644 --- a/crates/ui-egui/locales/zh-Hant.toml +++ b/crates/ui-egui/locales/zh-Hant.toml @@ -1542,7 +1542,7 @@ status = "draft — needs native review" "Texts" = "文字" "Texture" = "材質" "The bars are hidden. {shortcut} shows them again" = "工具列已隱藏。按 {shortcut} 可再次顯示" -"The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3." = "畫布以 sRGB 預覽顏色；匯出的 PNG、JPG 與 WebP 檔案會標記為 Display P3。" +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "畫布以 sRGB 預覽顏色；使用檔案描述檔匯出的 PNG、JPG 與 WebP 檔案會標記為 Display P3。" "The destination document is unavailable. Nothing was imported." = "目的地文件無法使用。未匯入任何內容。" "The destination document was closed. Nothing was imported." = "目的地文件已關閉。未匯入任何內容。" "The destination page was removed. Nothing was imported." = "目的地頁面已移除。未匯入任何內容。" diff --git a/crates/ui-egui/src/dialogs/color_profile.rs b/crates/ui-egui/src/dialogs/color_profile.rs index 3cf941dc0..1a5cb3587 100644 --- a/crates/ui-egui/src/dialogs/color_profile.rs +++ b/crates/ui-egui/src/dialogs/color_profile.rs @@ -36,7 +36,7 @@ pub(super) fn color_profile_dialog(app: &mut FigApp, ctx: &Context) { if !chosen.is_srgb() { ui.add_space(4.0); ui.label( - RichText::new(tr("The canvas previews colors in sRGB; exported PNG, JPG and WebP files are tagged Display P3.")) + RichText::new(tr("The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3.")) .color(t.text_secondary) .font(regular(11.0)), ); From 3d4c798ff23a04a953118439f2a52b4c2d671d0c Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Tue, 10 Nov 2026 23:58:47 -0800 Subject: [PATCH 16/19] Export: the Vietnamese color profile note names the file's color profile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Vietnamese row said "cấu hình của tệp" (the file's configuration) for the file's profile. It now says "hồ sơ màu của tệp", the term the Color profile label uses. --- crates/ui-egui/locales/vi.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/ui-egui/locales/vi.toml b/crates/ui-egui/locales/vi.toml index 83142691c..578619809 100644 --- a/crates/ui-egui/locales/vi.toml +++ b/crates/ui-egui/locales/vi.toml @@ -1390,7 +1390,7 @@ status = "draft — needs native review" "Text styles" = "Kiểu văn bản" "Texts" = "Văn bản" "Texture" = "Kết cấu" -"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Vùng vẽ xem trước màu theo sRGB; các tệp PNG, JPG và WebP xuất ra theo cấu hình của tệp được gắn thẻ Display P3." +"The canvas previews colors in sRGB; PNG, JPG and WebP exports that use the file's profile are tagged Display P3." = "Vùng vẽ xem trước màu theo sRGB; các tệp PNG, JPG và WebP xuất ra theo hồ sơ màu của tệp được gắn thẻ Display P3." "The destination document is unavailable. Nothing was imported." = "Tài liệu đích không khả dụng. Không có nội dung nào được nhập." "The destination document was closed. Nothing was imported." = "Tài liệu đích đã đóng. Không có nội dung nào được nhập." "The destination page was removed. Nothing was imported." = "Trang đích đã bị xóa. Không có nội dung nào được nhập." From cb52621414be379d0bebc2f2ae233895c300fcd4 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Wed, 11 Nov 2026 17:13:26 -0500 Subject: [PATCH 17/19] M5: marquee selection follows Figma's measured rules (gap 4) A plain marquee now selects each top-level layer it touches: a partly covered frame or section gives the layers in it the marquee touches, an enclosed one is selected itself, an empty frame on touch, a rotated shape by its outline. A drag from inside a frame never selects that frame and also takes the top-level layers it touches outside it. Once the marquee selects a frame whole, no frame opens and a partly covered frame comes whole. Measured in Figma's web app, 2026-11-11. Flipped existing assertions: marquee_selects_what_it_touches, cmd_marquee_selects_nested_layers, a_box_selects_like_a_marquee. Tests: marquee_behaviour_tests. Co-Authored-By: Claude Sonnet 5.5 Model-Effort: Opus 5.5 drove; Fable 5.1 briefed; Sonnet 5.5 wrote at medium --- crates/doc/src/geometry.rs | 143 +++++++++++-- crates/engine/src/canvas/tools/pointer.rs | 21 +- crates/engine/src/lib.rs | 2 + crates/engine/src/marquee_behaviour_tests.rs | 200 ++++++++++++++++++ crates/engine/src/select_area_tests.rs | 8 +- .../engine/src/selection_behaviour_tests.rs | 4 +- crates/engine/src/selection_depth_tests.rs | 8 +- docs/mcp.md | 6 +- docs/ui-parity.md | 5 +- 9 files changed, 357 insertions(+), 40 deletions(-) create mode 100644 crates/engine/src/marquee_behaviour_tests.rs diff --git a/crates/doc/src/geometry.rs b/crates/doc/src/geometry.rs index 189e06192..c9cc9958b 100644 --- a/crates/doc/src/geometry.rs +++ b/crates/doc/src/geometry.rs @@ -355,14 +355,15 @@ pub fn enter_target(doc: &Document, leaf: NodeId, selection: &[NodeId]) -> NodeI inner.unwrap_or_else(|| select_target(doc, leaf, selection, false)) } -/// Nodes on `page` whose world bounds intersect `rect` (marquee): top-level children, or the -/// children of top-level frames when the marquee starts inside a frame (`within`). +/// Nodes a marquee over `rect` touches, one level only: the children of `within` (a focus view's +/// frame), or the top-level layers of `page`. Frames are not opened or enclosed here; see +/// [`marquee_select`] for a plain marquee. pub fn marquee(doc: &Document, page: NodeId, rect: Rect, within: Option) -> Vec { let parent = within.unwrap_or(page); doc.node(parent).map(|p| marquee_children(doc, p, rect)).unwrap_or_default() } -/// Nodes on `page` a Cmd/Ctrl marquee selects: the innermost layers whose bounds touch `rect` +/// Nodes on `page` a Cmd/Ctrl marquee selects: the innermost layers the marquee touches /// (frames, groups and instances are looked into; a container none of whose children are touched /// counts itself; boolean groups count as one shape). pub fn marquee_deep(doc: &Document, page: NodeId, rect: Rect) -> Vec { @@ -384,25 +385,131 @@ pub fn marquee_deep(doc: &Document, page: NodeId, rect: Rect) -> Vec { out } -/// The visible, unlocked children of `p` whose world bounds touch `rect` (on both axes: lines and -/// other flat layers too). +/// The visible, unlocked children of `p` the marquee touches (see [`marquee_touches`]). fn marquee_children(doc: &Document, p: &Node, rect: Rect) -> Vec { - p.children - .iter() - .copied() - .filter(|c| doc.node(*c).is_some_and(|n| n.visible && !n.locked)) - .filter(|c| doc.world_bounds(*c).is_some_and(|b| b.x0 <= rect.x1 && b.x1 >= rect.x0 && b.y0 <= rect.y1 && b.y1 >= rect.y0)) - .collect() + p.children.iter().copied().filter(|c| doc.node(*c).is_some_and(|n| n.visible && !n.locked && marquee_touches(doc, *c, n, rect))).collect() } -/// Figma marquee rule: a marquee that fully contains a top-level frame selects the frame; one -/// starting on empty canvas selects top-level objects it touches. -pub fn marquee_select(doc: &Document, page: NodeId, rect: Rect, start_inside: Option) -> Vec { - if let Some(frame) = start_inside { - let inside = marquee(doc, page, rect, Some(frame)); - return inside; +/// The outline a rotated shape is touched by. One line: return the turned box instead +/// (`figcraft_geom::rounded_rect(n.width, n.height, [0.0; 4], 0.0)`) if Figma proves to test that. +fn marquee_outline(n: &Node) -> Option { + shape_path(n) +} + +/// Whether the marquee touches layer `id`: its world box overlaps `rect` (inclusive, so lines and +/// zero-size marquees count) and, for a rotated shape, its outline in page space does too. +fn marquee_touches(doc: &Document, id: NodeId, n: &Node, rect: Rect) -> bool { + let box_hit = doc.world_bounds(id).is_some_and(|b| b.x0 <= rect.x1 && b.x1 >= rect.x0 && b.y0 <= rect.y1 && b.y1 >= rect.y0); + if !box_hit + || !matches!( + n.kind, + NodeKind::Rectangle + | NodeKind::Ellipse { .. } + | NodeKind::Polygon { .. } + | NodeKind::Star { .. } + | NodeKind::Line + | NodeKind::Vector { .. } + ) + { + return box_hit; } - marquee(doc, page, rect, None) + let xf = doc.world_transform(id); + let [a, b, c, d, e, f] = xf.as_coeffs(); + const EPS: f64 = 1e-9; + let rotated = !((b.abs() < EPS && c.abs() < EPS) || (a.abs() < EPS && d.abs() < EPS)); + if !rotated { + return true; + } + let det = a * d - b * c; + if ![a, b, c, d, e, f, det].iter().all(|v| v.is_finite()) || det.abs() < EPS { + return true; + } + marquee_outline(n).is_none_or(|path| path_touches_rect(n, &path, xf, rect)) +} + +/// Whether the marquee and the shape drawn as local `path` under `xf` share a point: a path end +/// inside the marquee, a path segment crossing a marquee edge, or the marquee inside the filled shape. +fn path_touches_rect(n: &Node, path: &BezPath, xf: figcraft_geom::Affine, rect: Rect) -> bool { + use figcraft_geom::kurbo::{Line, ParamCurve, PathSeg}; + let inside = |p: Point| p.x >= rect.x0 && p.x <= rect.x1 && p.y >= rect.y0 && p.y <= rect.y1; + let mut world = path.clone(); + world.apply_affine(xf); + if world.segments().any(|s| inside(s.start()) || inside(s.end())) { + return true; + } + let (tl, tr, br, bl) = (Point::new(rect.x0, rect.y0), Point::new(rect.x1, rect.y0), Point::new(rect.x1, rect.y1), Point::new(rect.x0, rect.y1)); + let edges = [(tl, tr), (tr, br), (br, bl), (bl, tl)]; + for (p, q) in edges { + if (q - p).hypot() < 1e-9 { + continue; + } + let line = Line::new(p, q); + if world.segments().any(|s: PathSeg| s.intersect_line(line).iter().any(|h| (0.0..=1.0).contains(&h.line_t))) { + return true; + } + } + is_closed(n) && fills_point(n, path, xf.inverse() * tl) +} + +/// Whether a marquee takes a touched top-level layer whole, opens it for the layers in it, or skips it. +enum Touch { + Whole, + /// The frame the drag started in: only the layers in it the marquee touches. + Open, + /// A partly covered frame or section: the layers in it, or the frame itself once the marquee is at the top level. + Partial, + Skip, +} + +/// Figma's marquee rule (measured in the web app, 2026-11-11): each top-level layer the marquee +/// touches is selected whole, except a frame with children or a section with its contents shown: +/// enclosed by the marquee it is selected itself, otherwise the marquee takes the layers in it that +/// it touches. The frame the drag started in (`start_inside`) is never selected itself, only the +/// layers in it the marquee touches. Selecting a frame or section whole keeps the marquee at the +/// top level: no frame opens then, and a partly covered one is selected whole. Components, instances, board items and sections with hidden +/// contents are selected only when enclosed. +pub fn marquee_select(doc: &Document, page: NodeId, rect: Rect, start_inside: Option) -> Vec { + let Some(page_node) = doc.node(page) else { return Vec::new() }; + let touched = marquee_children(doc, page_node, rect); + let classified: Vec<(NodeId, Touch, bool)> = touched + .iter() + .filter_map(|t| { + let n = doc.node(*t)?; + let enclosed = doc.world_bounds(*t).is_some_and(|b| rect.contains(b.origin()) && rect.contains(Point::new(b.x1, b.y1))); + let container = n.kind.is_frame_like() || matches!(n.kind, NodeKind::Section { .. }); + let opens = match &n.kind { + NodeKind::Frame | NodeKind::Section { .. } => !n.is_board_atom() && !n.hides_contents() && !n.children.is_empty(), + _ => false, + }; + let plain_empty_frame = matches!(n.kind, NodeKind::Frame) && n.children.is_empty() && !n.is_board_atom(); + let act = if start_inside == Some(*t) { + Touch::Open + } else if opens { + if enclosed { Touch::Whole } else { Touch::Partial } + } else if plain_empty_frame || !(container || n.is_board_atom()) || enclosed { + Touch::Whole + } else { + Touch::Skip + }; + let whole_container = container && matches!(act, Touch::Whole); + Some((*t, act, whole_container)) + }) + .collect(); + let top_level_mode = classified.iter().any(|(_, _, whole_container)| *whole_container); + let mut out = Vec::new(); + for (t, act, _) in &classified { + match act { + Touch::Whole => out.push(*t), + Touch::Partial if top_level_mode => out.push(*t), + Touch::Open | Touch::Partial if !top_level_mode => { + if let Some(n) = doc.node(*t) { + out.extend(marquee_children(doc, n, rect)); + } + } + Touch::Open | Touch::Partial | Touch::Skip => {} + } + } + out } /// Bounds of a node's outline in page coordinates for snapping (the box corners and centre). diff --git a/crates/engine/src/canvas/tools/pointer.rs b/crates/engine/src/canvas/tools/pointer.rs index fb802353e..1e9c645e3 100644 --- a/crates/engine/src/canvas/tools/pointer.rs +++ b/crates/engine/src/canvas/tools/pointer.rs @@ -47,16 +47,23 @@ impl Session { /// the layers it touches (`deep`: nested ones too); `additive` (Shift) toggles them. pub(crate) fn marquee_selection(&self, r: Rect, within: Option, deep: bool, base: &[NodeId], additive: bool) -> Result> { let (doc, page) = (self.doc()?, self.page()?); - let mut hits = - if deep { figcraft_doc::geometry::marquee_deep(doc, page, r) } else { figcraft_doc::geometry::marquee_select(doc, page, r, within) }; - if let Some(f) = self.ds()?.focused() { + let focused = self.ds()?.focused(); + let mut hits = match (deep, focused) { + (true, _) => figcraft_doc::geometry::marquee_deep(doc, page, r), + (false, Some(f)) => figcraft_doc::geometry::marquee(doc, page, r, Some(f)), + (false, None) => figcraft_doc::geometry::marquee_select(doc, page, r, within), + }; + if let Some(f) = focused { hits.retain(|h| *h != f && doc.is_ancestor(f, *h)); } - // A marquee over a frame from outside selects the frame only when it covers it fully. - if within.is_none() && !deep { + // A widget's layers are part of the widget: a marquee from outside never opens one. + if !deep { hits.retain(|h| { - let full = doc.world_bounds(*h).is_some_and(|b| r.contains(b.origin()) && r.contains(Point::new(b.x1, b.y1))); - full || !doc.node(*h).is_some_and(|n| n.kind.is_frame_like() || matches!(n.kind, NodeKind::Section { .. })) + doc.node(*h) + .and_then(|n| n.parent) + .filter(|p| Some(*p) != within) + .and_then(|p| doc.node(p)) + .is_none_or(|p| !crate::widgets::is_widget(p)) }); } // Shift toggles: what was selected and is touched again comes out. diff --git a/crates/engine/src/lib.rs b/crates/engine/src/lib.rs index 89de7f22f..1ec7c3d7d 100644 --- a/crates/engine/src/lib.rs +++ b/crates/engine/src/lib.rs @@ -421,6 +421,8 @@ mod live_tests; #[cfg(test)] mod lock_behaviour_tests; #[cfg(test)] +mod marquee_behaviour_tests; +#[cfg(test)] mod mask_tests; #[cfg(test)] mod masks_behaviour_tests; diff --git a/crates/engine/src/marquee_behaviour_tests.rs b/crates/engine/src/marquee_behaviour_tests.rs new file mode 100644 index 000000000..90c37ccd1 --- /dev/null +++ b/crates/engine/src/marquee_behaviour_tests.rs @@ -0,0 +1,200 @@ +//! Marquee selection, as measured in Figma's web app (2026-11-11, the "marquee rules" and "confirming +//! pass" readings) and described in the help-center article "Select layers and objects": a drag +//! selects each top-level layer it touches; a partly covered frame or section gives the layers in it +//! the marquee touches, an enclosed one is selected itself; a drag started inside a frame never selects +//! that frame; selecting a frame whole keeps the marquee at the top level; a rotated shape is touched by +//! its outline, an unrotated one by its box. + +use serde_json::{Value, json}; + +use crate::Session; +use crate::params::id_of; +use crate::tools::{PointerEvent, PointerKind}; +use figcraft_doc::NodeId; +use figcraft_geom::Point; + +fn ex(s: &mut Session, cmd: &str, p: Value) -> Value { + s.execute(cmd, &p).unwrap_or_else(|e| panic!("{cmd}: {e}")) +} + +fn id(v: &Value) -> NodeId { + id_of(&v["id"]).unwrap() +} + +fn rect(s: &mut Session, x: f64, y: f64, w: f64, h: f64, parent: Option) -> NodeId { + let mut p = json!({"x": x, "y": y, "width": w, "height": h}); + if let Some(parent) = parent { + p["parent"] = json!(parent); + } + id(&ex(s, "shape.rectangle", p)) +} + +fn ev(kind: PointerKind, x: f64, y: f64) -> PointerEvent { + PointerEvent::at(kind, x, y, 1.0) +} + +fn drag(s: &mut Session, a: (f64, f64), b: (f64, f64)) { + s.pointer(&ev(PointerKind::Down, a.0, a.1)).unwrap(); + s.pointer(&ev(PointerKind::Move, b.0, b.1)).unwrap(); + s.pointer(&ev(PointerKind::Up, b.0, b.1)).unwrap(); +} + +fn sorted(mut v: Vec) -> Vec { + v.sort(); + v +} + +#[allow(dead_code)] +struct Scene { + f1: NodeId, + r1: NodeId, + r2: NodeId, + e: NodeId, + u: NodeId, + rr: NodeId, + re: NodeId, + f2: NodeId, + g: NodeId, + s: NodeId, + r5: NodeId, +} + +/// The confirming pass's layout: `f1` (0,0 300x200) holding `r1` (20,20) and `r2` (220,120), both 60x60; +/// ellipse `e` (500,0 200x200); rectangle `u` (900,0 100x100); `rr` rectangle (0,400 200x100) and ellipse +/// `re` (500,400 200x100) turned 45 degrees about their centres; the empty frame `f2` (0,700 200x150); +/// the group `g` of two rectangles (300,700) and (360,760); the section `s` (600,700 300x200) holding `r5`. +fn scene(s: &mut Session) -> Scene { + let f1 = id(&ex(s, "frame.create", json!({"x": 0, "y": 0, "width": 300, "height": 200}))); + let r1 = rect(s, 20.0, 20.0, 60.0, 60.0, Some(f1)); + let r2 = rect(s, 220.0, 120.0, 60.0, 60.0, Some(f1)); + let e = id(&ex(s, "shape.ellipse", json!({"x": 500, "y": 0, "width": 200, "height": 200}))); + let u = rect(s, 900.0, 0.0, 100.0, 100.0, None); + let rr = rect(s, 0.0, 400.0, 200.0, 100.0, None); + ex(s, "node.set", json!({"id": rr, "props": {"rotation": 45}})); + let re = id(&ex(s, "shape.ellipse", json!({"x": 500, "y": 400, "width": 200, "height": 100}))); + ex(s, "node.set", json!({"id": re, "props": {"rotation": 45}})); + let f2 = id(&ex(s, "frame.create", json!({"x": 0, "y": 700, "width": 200, "height": 150}))); + let g1 = rect(s, 300.0, 700.0, 80.0, 80.0, None); + let g2 = rect(s, 360.0, 760.0, 80.0, 80.0, None); + let g = id(&ex(s, "object.group", json!({"ids": [g1, g2]}))); + let sec = id(&ex(s, "node.create", json!({"type": "section", "x": 600, "y": 700, "width": 300, "height": 200}))); + let r5 = rect(s, 20.0, 20.0, 60.0, 60.0, Some(sec)); + ex(s, "select.none", json!({})); + Scene { f1, r1, r2, e, u, rr, re, f2, g, s: sec, r5 } +} + +fn selected(s: &mut Session, a: (f64, f64), b: (f64, f64)) -> Vec { + ex(s, "select.none", json!({})); + drag(s, a, b); + let sel = sorted(s.selection()); + ex(s, "select.none", json!({})); + sel +} + +#[test] +fn a_partly_covered_frame_gives_the_layers_it_touches() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (-50.0, -50.0), (60.0, 60.0)), vec![k.r1], "measured case 2: Rectangle 1, not F1"); +} + +#[test] +fn an_enclosed_frame_is_selected_itself() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (-20.0, -20.0), (320.0, 220.0)), vec![k.f1], "measured b"); +} + +#[test] +fn an_empty_frame_is_selected_on_touch() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (-20.0, 680.0), (50.0, 720.0)), vec![k.f2], "measured c: Frame 2"); +} + +#[test] +fn a_group_is_selected_whole_on_touch() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (290.0, 690.0), (310.0, 710.0)), vec![k.g], "measured c: Group 1, not the rectangle"); +} + +#[test] +fn a_partly_covered_section_gives_the_layers_it_touches() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (590.0, 690.0), (650.0, 750.0)), vec![k.r5], "measured c: Rectangle 5, not the section"); +} + +#[test] +fn an_unrotated_shape_is_touched_by_its_box() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (490.0, -10.0), (505.0, 5.0)), vec![k.e], "measured case 3: the ellipse's box corner selects it"); + assert_eq!(selected(&mut s, (890.0, -10.0), (905.0, 5.0)), vec![k.u], "control"); +} + +#[test] +fn a_rotated_rectangle_is_touched_by_its_outline() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (-30.0, 320.0), (4.0, 354.0)), Vec::::new(), "measured case 3: the box corner selects nothing"); + assert_eq!(selected(&mut s, (-30.0, 320.0), (100.0, 450.0)), vec![k.rr]); +} + +#[test] +fn a_rotated_ellipse_is_not_touched_by_its_axis_aligned_box() { + let mut s = Session::new(); + let k = scene(&mut s); + assert_eq!(selected(&mut s, (470.0, 320.0), (504.0, 354.0)), Vec::::new(), "measured case 3: the box corner selects nothing"); + assert_eq!(selected(&mut s, (470.0, 320.0), (600.0, 450.0)), vec![k.re]); +} + +#[test] +fn a_rotated_ellipse_is_not_touched_through_the_corner_of_its_turned_box() { + let mut s = Session::new(); + let k = scene(&mut s); + // Not the measurement's literal numbers (see the brief, section 5): a point inside the turned box + // but outside the ellipse. + let p = Point::new(690.0, 420.0); + let doc = s.doc().unwrap(); + let n = doc.node(k.re).unwrap(); + assert!(n.local_rect().contains(doc.world_transform(k.re).inverse() * p), "the probe is inside the turned box"); + assert_eq!(selected(&mut s, (727.0, 407.0), (690.0, 420.0)), Vec::::new()); +} + +#[test] +fn a_drag_from_inside_a_frame_never_selects_it() { + let mut s = Session::new(); + let k = scene(&mut s); + let start_x = |s: &Session| s.doc().unwrap().world_bounds(k.f1).map(|b| (b.x0, b.y0)); + assert_eq!(selected(&mut s, (150.0, 100.0), (180.0, 150.0)), Vec::::new(), "measured e1"); + assert_eq!(start_x(&s), Some((0.0, 0.0))); + assert_eq!(selected(&mut s, (150.0, 100.0), (180.0, 250.0)), Vec::::new(), "measured e2"); + assert_eq!(start_x(&s), Some((0.0, 0.0))); + assert_eq!(selected(&mut s, (150.0, 100.0), (600.0, 100.0)), vec![k.e], "measured e3: the ellipse only"); + assert_eq!(start_x(&s), Some((0.0, 0.0))); + assert_eq!(selected(&mut s, (150.0, 100.0), (250.0, 150.0)), vec![k.r2], "today's rule, not measured"); + assert_eq!(start_x(&s), Some((0.0, 0.0))); +} + +#[test] +fn selecting_a_frame_whole_keeps_the_marquee_at_the_top_level() { + let mut s = Session::new(); + let k = scene(&mut s); + // Encloses the empty f2, covers rr, and partly covers f1 over r1: no frame opens, f1 comes whole. + assert_eq!( + selected(&mut s, (-20.0, 50.0), (210.0, 860.0)), + sorted(vec![k.f2, k.f1, k.rr]), + "the article: selecting a top-level frame selects only top-level layers; measured: a partly covered frame comes whole" + ); +} + +#[test] +fn a_marquee_enclosing_an_empty_frame_takes_a_partly_covered_frame_whole() { + let mut s = Session::new(); + let f1 = id(&ex(&mut s, "frame.create", json!({"x": 0, "y": 0, "width": 300, "height": 200}))); + let _r1 = rect(&mut s, 20.0, 20.0, 60.0, 60.0, Some(f1)); + let f2 = id(&ex(&mut s, "frame.create", json!({"x": 400, "y": 0, "width": 200, "height": 150}))); + assert_eq!(selected(&mut s, (650.0, 170.0), (40.0, -10.0)), sorted(vec![f1, f2]), "measured re-measure: F2 and F1, not R1"); +} diff --git a/crates/engine/src/select_area_tests.rs b/crates/engine/src/select_area_tests.rs index 8f1d4cf75..30de60d4c 100644 --- a/crates/engine/src/select_area_tests.rs +++ b/crates/engine/src/select_area_tests.rs @@ -1,6 +1,6 @@ //! `select.area`: what a marquee over a box selects, without a pointer (keyboard box selection in -//! the app, agents over MCP): top-level layers, a frame only when fully covered, the children of -//! the frame the box starts in, Shift-like toggling, Cmd/Ctrl-like nested layers; no box asks the +//! the app, agents over MCP): top-level layers, a frame only when fully covered (otherwise the +//! layers in it the box touches), the children of the frame the box starts in, Shift-like toggling, Cmd/Ctrl-like nested layers; no box asks the //! app to draw one. use serde_json::{Value, json}; @@ -40,8 +40,8 @@ fn a_box_selects_like_a_marquee() { let inner = rect(&mut s, 20.0, 20.0, Some(frame)); let a = rect(&mut s, 0.0, 0.0, None); let b = rect(&mut s, 100.0, 0.0, None); - // Top-level layers it touches; a frame only touched from outside isn't selected. - assert_eq!(area(&mut s, -10.0, -10.0, 340.0, 40.0, json!({})), sorted(vec![a, b])); + // Top-level layers it touches; a frame only touched from outside gives the layers in it the box touches. + assert_eq!(area(&mut s, -10.0, -10.0, 340.0, 40.0, json!({})), sorted(vec![a, b, inner])); // A negative size draws the box the other way. assert_eq!(area(&mut s, 130.0, 30.0, -140.0, -40.0, json!({})), sorted(vec![a, b])); // Covering the frame selects it. diff --git a/crates/engine/src/selection_behaviour_tests.rs b/crates/engine/src/selection_behaviour_tests.rs index c58527286..6422f4b93 100644 --- a/crates/engine/src/selection_behaviour_tests.rs +++ b/crates/engine/src/selection_behaviour_tests.rs @@ -214,8 +214,8 @@ fn marquee_selects_what_it_touches() { (450.0, 40.0), NONE, vec![], - vec![], - "from the canvas, a top-level frame is selected only when the marquee covers all of it", + vec![k.g, k.n], + "from the canvas, a partly covered top-level frame gives the layers in it the marquee touches (measured); the nested frame comes whole", ), ((-10.0, -10.0), (450.0, 310.0), NONE, vec![], vec![k.f], "a marquee covering a top-level frame selects the frame"), ( diff --git a/crates/engine/src/selection_depth_tests.rs b/crates/engine/src/selection_depth_tests.rs index 5897ac6fd..a754e7343 100644 --- a/crates/engine/src/selection_depth_tests.rs +++ b/crates/engine/src/selection_depth_tests.rs @@ -66,10 +66,10 @@ fn cmd_click_selects_the_nested_layer() { #[test] fn cmd_marquee_selects_nested_layers() { let mut s = Session::new(); - let (f, _, [a, b, c], out) = scene(&mut s); - // From empty canvas, a plain marquee across the frame only touches top-level layers (and the - // frame isn't fully covered). - assert_eq!(marquee(&mut s, (-10.0, 10.0), (500.0, 70.0), false, false), vec![out]); + let (f, g, [a, b, c], out) = scene(&mut s); + // From empty canvas, a plain marquee across the frame (not fully covered) gives the layers in it + // it touches (the group whole), plus the top-level layer. + assert_eq!(sorted(marquee(&mut s, (-10.0, 10.0), (500.0, 70.0), false, false)), sorted(vec![g, out])); // Cmd/Ctrl: the innermost layers it touches, through the frame and the group. assert_eq!(sorted(marquee(&mut s, (-10.0, 10.0), (500.0, 70.0), false, true)), sorted(vec![a, b, out])); assert_eq!(sorted(marquee(&mut s, (-10.0, 10.0), (100.0, 190.0), false, true)), sorted(vec![a, b, c])); diff --git a/docs/mcp.md b/docs/mcp.md index 04b37e1f0..1c582b0f3 100644 --- a/docs/mcp.md +++ b/docs/mcp.md @@ -675,8 +675,8 @@ on; `key` resolves keys the way the canvas does. Commands behind keys: panel has the keyboard (after F6 or a click on a row), else on the canvas below the selection; the menu takes the keyboard and gives it back when it closes (no-op headless). - `select.area {x, y, width, height, add?, deep?}`: select what a marquee from `x, y` over that box - (page units) would: top-level layers, a frame only when the box covers it, the children of the - top-level frame the box starts in; `add` toggles like a Shift marquee, `deep` takes nested layers + (page units) would: the top-level layers it touches (a rotated shape by its outline), a frame or section + only when the box covers it and otherwise the layers in it the box touches, never the frame the box starts in; `add` toggles like a Shift marquee, `deep` takes nested layers like Cmd/Ctrl. Returns `{selection}`. Without a box (`F8` in the app) it draws one for the keyboard around the selection (or in the middle of the view): the arrows move it, Shift+arrows move its far corner (10 screen pixels a press), Enter selects (Shift+Enter adds, Cmd/Ctrl+Enter @@ -2059,7 +2059,7 @@ turned off 0°. / Shift+Enter), `select.next` / `select.previous` (Tab / Shift+Tab). With `pointer`, `cmd: true` clicks select the nested layer, `cmd` drags from empty canvas select the nested layers they touch, and `shift` drags toggle what they touch. A press on the background of a top-level frame with - layers in it (the frame not selected) starts a marquee inside it, as on the canvas; an empty frame + layers in it (the frame not selected) starts a marquee, as on the canvas; an empty frame is picked and dragged. Locked layers (selectable with `select.set`) get no handles and stay put when the rest of the selection is dragged. `select.all` / `select.inverse` skip hidden and locked layers. diff --git a/docs/ui-parity.md b/docs/ui-parity.md index 224286838..59583fd13 100644 --- a/docs/ui-parity.md +++ b/docs/ui-parity.md @@ -1,6 +1,6 @@ # UI and interaction parity -> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-11-10 · **Change:** minor (the main menu and its submenus stay inside the window, moving up to fit and scrolling when taller (#2217); locked layers ignore the arrow keys and a locked parent's children can't be locked on their own (#1560); the left rail's and tab strip's icons are larger, 20 pt (#553); pick select: Tab while the keyboard selection box shows (or the chord again) puts a pink outline on a layer and the keys walk the layer tree from it, as Accessibility at Figma says (#1836); scrubbing a field faster or slower by the pointer's height, with a notice of the speed, as the help center's Scrub fields says (#1837); component rows in the Layers panel at AA contrast in the theme's component tint, with the rows inside a selected component in a tone of its row (#1903); Cmd/Ctrl-click on a padding field sets all four sides with the value typed, a documented auto layout shortcut; a fill per region of a vector: with regions selected in edit mode, the Fill section and the fill commands edit those regions' own fills, as Edit vector layers says (#1875); the Fill section of a text whose characters were coloured differently while editing shows mixed content, characters that all share fills the layer doesn't have show those, and a layer-level fill edit reaches every character (#1856); a number field scrubs when dragged with Alt held, as the help center's scrub section says, not only by its label; reuse visible layer selection roots (M8); ; with a shape or frame tool chosen and nothing selected, the arrows show a placement crosshair in the middle of the view and move it, and Enter places there, as Accessibility at Figma says (#1839); text direction per paragraph: Text ▸ Text direction forces a paragraph left to right or right to left, as Add right-to-left text says (#1830), with `text.direction`, `node.set textDirection`, the Type settings control once a right-to-left script is in the text, inspect, the CSS `direction` and the `.fig` lines' `sourceDirectionality`; the boolean operation menu in the Design panel leads each entry with an original icon drawn in code, a filled preview of the result (#2003); a press on the open gradient's handles or stops on the canvas keeps the colour picker open through the drag, as its own control (#1852); a click with the Bend tool on a sharp point curves it, its handles along the line between its neighbours, as Edit vector layers says (#1875); wrap style: Auto, Balance and Pretty on a text layer decide where its lines break, as Explore text properties says (#1827), with the Type settings control, `text.wrapStyle`, `node.set wrapStyle`, inspect and the CSS `text-wrap`; Backspace or Delete at the start of a list item keeps the item's indentation level, as the lists article says; max lines on auto-width text keep it auto width, hugging that many lines, as the text properties article says; superscript and subscript are synthesised where the font has no glyphs for them, from the standard glyphs shrunk and shifted by the font's OS/2 metrics, and a run mixing available and unavailable glyphs is synthesised whole, as Explore text properties says (#1828); Alt+Enter while editing text opens the link at the caret, as the accessibility page documents; Minimize, by its shortcut or the button by the file name, collapses the navigation bar and both sidebars as the help center says, with the right sidebar back while something is selected (#1835); the interface size keys of the help center's accessibility page: Cmd/Ctrl+Shift+Alt with =, - and 0 step the interface through the Preferences sizes and back to the system's size; Cmd/Ctrl+Alt+arrows rotate the selection a degree at a time, 15 with Shift, as the help center's accessibility page says; they resized before; the Layers panel answers Ctrl+1 as well as Alt+1 on Windows and Linux, the two keys the help center gives it; the colour picker's Image tab shows a placeholder and Upload from computer, an asset preview, and a file dropped on it replaces the image, keeping the fill mode, crop and position (#1682); the keyboard's Menu key opens the context menu, as Shift+F10 does; the eyedropper with Cmd/Ctrl+Shift makes a colour style or variable of what it picks; sidebar number and text fields keep their text vertically centered when focused, including typography spacing; with the pen out, Enter or a double-click ends the path and edits the vector with the Move tool instead of drawing on (#1430); the Actions palette offers only commands that run from it, and no second row reading like a menu item: Place image opens the file dialog (#1574); Preferences ▸ Scroll wheel zoom: a mouse wheel zooms the canvas about the pointer and Cmd/Ctrl+wheel scrolls (#1390); boolean operations refuse input past their caps, and a boolean group past them draws without its result (#1104); the selection and hover outlines of rounded rectangles and frames follow their corners (#1506); colour picker review fixes for text undo, fitted sidebars, moving controls and gradient variables; Corner smoothing: an original icon and the shared number-field drag gesture, preserving fractional baselines; guides snap to layers when dragged; Crop image: Object ▸ Crop image, the right-click menu and the image fill row enter crop mode (`image.crop`, #1464); the Design panel's sections on one grid — 16 / 8 margins, 88 + 8 + 88 + 8 + 24 columns, 24 pt rows, 4 pt between a row's buttons (#858); the toolbar on one 32 pt grid, without its Resources button (#1210); colour picker LCH and OKLCH models; an XML (Android Vector Drawable) export format; Context menus: the Menu key reaches egui 0.37 but is unbound (row done → partial); the Text on a path tool; board tool keys pinned; community fixes: the text box by dragging, the font picker keys, the pen path on leaving Design, a still canvas in vector edit mode, a scrolling pages list, colour emoji, readable new text in frames, system theme on first run; the Small caps sample in Type settings drawn from capitals; recent files as cards; vector edit mode: hovering, hatching, selecting and dragging filled regions; home screen: Templates tab, first-run templates and Getting started tips; number fields: scrub rates, arrow steps, arithmetic with brackets, relative edits of mixed values; outline mode's hidden layers and object bounds; Hide when publishing; cursors per tool and modifier; panel widths; dark pages for files made in the dark theme; drag threshold and double-clicks into text in groups; rotation origin on Alt+R and placing with Enter: no documented shortcut missing; keyboard shortcut parity suite and bindings; cursor chat and spotlight in live sessions; layers and assets panels behaviour suite and fixes; vector multi-edit and the vector edit tail; canvas navigation, guides and grids behaviour suite and fixes; shapes and vector behaviour suite and fixes; paint and effects behaviour suite and fixes; frames, groups, sections and masks behaviour suite and fixes; layers panel keyboard: F2 rename, Shift+F10 context menu, F8 box selection; selection and transform behaviour suite and fixes; Display P3: gamut warning and soft-proof (true P3 blocked upstream); several windows; boolean hit testing on the result, group drags, frame outlines and slices; outlines for the selection, mask outlines; arc fields, live boolean editing, shape builder on strokes, one-sided widths; fields select their text on focus; Typography spacing icons support scrubbing (#373); CSS colour names in hex fields; a rename selects the whole name, so typing replaces it; Escape or Enter after a pen path stays on the same vector (#760); IME composition kept on through idle frames of a text edit, candidates at the caret (#747); Selection colors for mixed selections and smart-selection spacing (#753); submenus with a hover delay and a safe triangle; the Actions palette's tabs, ranked search, highlight and recents; menu items that ask for a value; editor fixes from the community batches) · **Target:** Figma Design UI3 (desktop app 126.10.7) +> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-11-11 · **Change:** minor (the marquee follows Figma's measured rules: a partly covered frame or section gives the layers in it the marquee touches, a rotated shape is touched by its outline, a drag from inside a frame never selects that frame (`marquee_behaviour_tests`); the main menu and its submenus stay inside the window, moving up to fit and scrolling when taller (#2217); locked layers ignore the arrow keys and a locked parent's children can't be locked on their own (#1560); the left rail's and tab strip's icons are larger, 20 pt (#553); pick select: Tab while the keyboard selection box shows (or the chord again) puts a pink outline on a layer and the keys walk the layer tree from it, as Accessibility at Figma says (#1836); scrubbing a field faster or slower by the pointer's height, with a notice of the speed, as the help center's Scrub fields says (#1837); component rows in the Layers panel at AA contrast in the theme's component tint, with the rows inside a selected component in a tone of its row (#1903); Cmd/Ctrl-click on a padding field sets all four sides with the value typed, a documented auto layout shortcut; a fill per region of a vector: with regions selected in edit mode, the Fill section and the fill commands edit those regions' own fills, as Edit vector layers says (#1875); the Fill section of a text whose characters were coloured differently while editing shows mixed content, characters that all share fills the layer doesn't have show those, and a layer-level fill edit reaches every character (#1856); a number field scrubs when dragged with Alt held, as the help center's scrub section says, not only by its label; reuse visible layer selection roots (M8); ; with a shape or frame tool chosen and nothing selected, the arrows show a placement crosshair in the middle of the view and move it, and Enter places there, as Accessibility at Figma says (#1839); text direction per paragraph: Text ▸ Text direction forces a paragraph left to right or right to left, as Add right-to-left text says (#1830), with `text.direction`, `node.set textDirection`, the Type settings control once a right-to-left script is in the text, inspect, the CSS `direction` and the `.fig` lines' `sourceDirectionality`; the boolean operation menu in the Design panel leads each entry with an original icon drawn in code, a filled preview of the result (#2003); a press on the open gradient's handles or stops on the canvas keeps the colour picker open through the drag, as its own control (#1852); a click with the Bend tool on a sharp point curves it, its handles along the line between its neighbours, as Edit vector layers says (#1875); wrap style: Auto, Balance and Pretty on a text layer decide where its lines break, as Explore text properties says (#1827), with the Type settings control, `text.wrapStyle`, `node.set wrapStyle`, inspect and the CSS `text-wrap`; Backspace or Delete at the start of a list item keeps the item's indentation level, as the lists article says; max lines on auto-width text keep it auto width, hugging that many lines, as the text properties article says; superscript and subscript are synthesised where the font has no glyphs for them, from the standard glyphs shrunk and shifted by the font's OS/2 metrics, and a run mixing available and unavailable glyphs is synthesised whole, as Explore text properties says (#1828); Alt+Enter while editing text opens the link at the caret, as the accessibility page documents; Minimize, by its shortcut or the button by the file name, collapses the navigation bar and both sidebars as the help center says, with the right sidebar back while something is selected (#1835); the interface size keys of the help center's accessibility page: Cmd/Ctrl+Shift+Alt with =, - and 0 step the interface through the Preferences sizes and back to the system's size; Cmd/Ctrl+Alt+arrows rotate the selection a degree at a time, 15 with Shift, as the help center's accessibility page says; they resized before; the Layers panel answers Ctrl+1 as well as Alt+1 on Windows and Linux, the two keys the help center gives it; the colour picker's Image tab shows a placeholder and Upload from computer, an asset preview, and a file dropped on it replaces the image, keeping the fill mode, crop and position (#1682); the keyboard's Menu key opens the context menu, as Shift+F10 does; the eyedropper with Cmd/Ctrl+Shift makes a colour style or variable of what it picks; sidebar number and text fields keep their text vertically centered when focused, including typography spacing; with the pen out, Enter or a double-click ends the path and edits the vector with the Move tool instead of drawing on (#1430); the Actions palette offers only commands that run from it, and no second row reading like a menu item: Place image opens the file dialog (#1574); Preferences ▸ Scroll wheel zoom: a mouse wheel zooms the canvas about the pointer and Cmd/Ctrl+wheel scrolls (#1390); boolean operations refuse input past their caps, and a boolean group past them draws without its result (#1104); the selection and hover outlines of rounded rectangles and frames follow their corners (#1506); colour picker review fixes for text undo, fitted sidebars, moving controls and gradient variables; Corner smoothing: an original icon and the shared number-field drag gesture, preserving fractional baselines; guides snap to layers when dragged; Crop image: Object ▸ Crop image, the right-click menu and the image fill row enter crop mode (`image.crop`, #1464); the Design panel's sections on one grid — 16 / 8 margins, 88 + 8 + 88 + 8 + 24 columns, 24 pt rows, 4 pt between a row's buttons (#858); the toolbar on one 32 pt grid, without its Resources button (#1210); colour picker LCH and OKLCH models; an XML (Android Vector Drawable) export format; Context menus: the Menu key reaches egui 0.37 but is unbound (row done → partial); the Text on a path tool; board tool keys pinned; community fixes: the text box by dragging, the font picker keys, the pen path on leaving Design, a still canvas in vector edit mode, a scrolling pages list, colour emoji, readable new text in frames, system theme on first run; the Small caps sample in Type settings drawn from capitals; recent files as cards; vector edit mode: hovering, hatching, selecting and dragging filled regions; home screen: Templates tab, first-run templates and Getting started tips; number fields: scrub rates, arrow steps, arithmetic with brackets, relative edits of mixed values; outline mode's hidden layers and object bounds; Hide when publishing; cursors per tool and modifier; panel widths; dark pages for files made in the dark theme; drag threshold and double-clicks into text in groups; rotation origin on Alt+R and placing with Enter: no documented shortcut missing; keyboard shortcut parity suite and bindings; cursor chat and spotlight in live sessions; layers and assets panels behaviour suite and fixes; vector multi-edit and the vector edit tail; canvas navigation, guides and grids behaviour suite and fixes; shapes and vector behaviour suite and fixes; paint and effects behaviour suite and fixes; frames, groups, sections and masks behaviour suite and fixes; layers panel keyboard: F2 rename, Shift+F10 context menu, F8 box selection; selection and transform behaviour suite and fixes; Display P3: gamut warning and soft-proof (true P3 blocked upstream); several windows; boolean hit testing on the result, group drags, frame outlines and slices; outlines for the selection, mask outlines; arc fields, live boolean editing, shape builder on strokes, one-sided widths; fields select their text on focus; Typography spacing icons support scrubbing (#373); CSS colour names in hex fields; a rename selects the whole name, so typing replaces it; Escape or Enter after a pen path stays on the same vector (#760); IME composition kept on through idle frames of a text edit, candidates at the caret (#747); Selection colors for mixed selections and smart-selection spacing (#753); submenus with a hover delay and a safe triangle; the Actions palette's tabs, ranked search, highlight and recents; menu items that ask for a value; editor fixes from the community batches) · **Target:** Figma Design UI3 (desktop app 126.10.7) Fine canvas control is what Figma users feel first: handles, snapping, nudging, modifier keys, drag behaviour, numeric precision. This checklist covers the tools, gestures and panels. Status: @@ -56,7 +56,7 @@ interaction feel not yet compared. | Item | Status | Notes | |---|---|---| -| Click, Shift-click, marquee, Shift-marquee toggle | done | Shift-drag on a selected layer moves the selection, kept to one axis (#498); a marquee selects what it touches; from a top-level frame's background, the layers inside it; locked and hidden layers are skipped (`selection_behaviour_tests`) (a locked layer selected from the panel ignores the arrow keys and the nudge commands; its properties still edit; measured in Figma's web app, 2026-11-10) | +| Click, Shift-click, marquee, Shift-marquee toggle | done | Shift-drag on a selected layer moves the selection, kept to one axis (#498); a marquee selects the top-level layers it touches, by the box and a rotated shape by its outline (rectangle and ellipse measured, the other shapes by the same code); a partly covered top-level frame or section gives the layers in it the marquee touches, an enclosed one is selected itself, an empty frame on touch; a drag from a frame's background never selects that frame and also takes what it touches outside it; selecting a frame whole keeps the marquee at the top level (a partly covered frame then comes whole too); locked and hidden layers are skipped (`marquee_behaviour_tests`, `selection_behaviour_tests`; measured in Figma's web app, 2026-11-11; Shift and Cmd/Ctrl marquees not measured) (a locked layer selected from the panel ignores the arrow keys and the nudge commands; its properties still edit; measured in Figma's web app, 2026-11-10) | | Deep select (Cmd/Ctrl-click, Cmd/Ctrl-marquee) | done | | | Select layer menu (every layer under the click) | done | | | Enter / Shift+Enter (children / parent), Tab / Shift+Tab (siblings) | done | Tab renames the next layer while renaming | @@ -187,6 +187,7 @@ in the table. `crates/ui-egui/src/shortcut_keys_tests.rs` drives the keys a look | Date | Change | Summary | |---|---|---| +| 2026-11-11 | patch | M5, gap 4: marquee selection as measured in Figma's web app (Select layers and objects, Selection marquee): a partly covered top-level frame or section gives the layers in it the marquee touches (it was selected only when enclosed, so nothing came), an empty frame is selected on touch, a rotated shape is touched by its outline and not its box, a drag from inside a frame never selects that frame and also takes the top-level layers it touches outside it, and selecting a frame whole keeps the marquee at the top level (a partly covered frame then comes whole, not its layers). Flipped: `marquee_selects_what_it_touches`, `cmd_marquee_selects_nested_layers`, `a_box_selects_like_a_marquee`. Tests: `marquee_behaviour_tests`. Counts unchanged | | 2026-11-10 | patch | M5, #1560: locked layers follow Figma's rules (Lock and unlock layers; measured in Figma's web app): a locked layer selected in the Layers panel ignores the arrow keys and the nudge commands while its properties still edit, and a child of a locked layer keeps its padlock inert (the Layers panel padlock, Lock/Unlock and `object.toggleLock` without a value no longer lock the child on its own) | | 2026-11-10 | patch | #2217: the main menu's submenus (Object, say) ran past the window's bottom, behind the taskbar, with the lowest commands out of reach, because submenus were not constrained to the window (to keep them beside their row). Every menu panel now scrolls when taller than the window less 8 pt margins, and a submenu is held within the window's height (moved up, never above the top) while keeping its place beside its row, so menu-aim is unchanged. Tests: `menu_overflow_tests.rs`. Numbers unchanged. | | 2026-11-02 | patch | Shortcuts: a Cmd/Ctrl-click on a padding field (the horizontal or vertical pair, or a side with Individual padding open) makes the value typed go to all four sides, in one undo step (Guide to auto layout, Keyboard shortcut guide); a plain click still edits that axis or side alone. A documented gesture row: 134 documented, 133 bound. Test: `padding_individual_tests` | From 604c78466cc0aef37b8b7a814e05e492381cab56 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Wed, 11 Nov 2026 17:40:52 -0500 Subject: [PATCH 18/19] M5: marquee: a drag from inside a frame takes it whole when it takes another top-level frame, as re-measured In top-level mode the frame the drag started in is now selected whole (re-measure 2: [F1, F2], R1 not selected); with no other frame taken only the touched shapes are. Test 9 uses the re-measure's literal marquees; docs reworded and docs/mcp.md rewrapped. Co-Authored-By: Claude Sonnet 5.5 Model-Effort: Opus 5.5 drove; Fable 5.1 briefed; Sonnet 5.5 wrote at medium --- crates/doc/src/geometry.rs | 16 +++++---- crates/engine/src/marquee_behaviour_tests.rs | 34 +++++++++++++++----- docs/mcp.md | 7 ++-- docs/ui-parity.md | 6 ++-- 4 files changed, 43 insertions(+), 20 deletions(-) diff --git a/crates/doc/src/geometry.rs b/crates/doc/src/geometry.rs index c9cc9958b..479ca439b 100644 --- a/crates/doc/src/geometry.rs +++ b/crates/doc/src/geometry.rs @@ -454,7 +454,8 @@ fn path_touches_rect(n: &Node, path: &BezPath, xf: figcraft_geom::Affine, rect: /// Whether a marquee takes a touched top-level layer whole, opens it for the layers in it, or skips it. enum Touch { Whole, - /// The frame the drag started in: only the layers in it the marquee touches. + /// The frame the drag started in: the layers in it the marquee touches, or the frame itself + /// (whole) once the marquee is at the top level. Open, /// A partly covered frame or section: the layers in it, or the frame itself once the marquee is at the top level. Partial, @@ -464,9 +465,10 @@ enum Touch { /// Figma's marquee rule (measured in the web app, 2026-11-11): each top-level layer the marquee /// touches is selected whole, except a frame with children or a section with its contents shown: /// enclosed by the marquee it is selected itself, otherwise the marquee takes the layers in it that -/// it touches. The frame the drag started in (`start_inside`) is never selected itself, only the -/// layers in it the marquee touches. Selecting a frame or section whole keeps the marquee at the -/// top level: no frame opens then, and a partly covered one is selected whole. Components, instances, board items and sections with hidden +/// it touches. The frame the drag started in (`start_inside`) is selected only when the marquee also +/// takes another top-level frame (then whole); otherwise only the layers in it the marquee touches. +/// Selecting a frame or section whole keeps the marquee at the top level: no frame opens then, and a +/// partly covered one is selected whole. Components, instances, board items and sections with hidden /// contents are selected only when enclosed. pub fn marquee_select(doc: &Document, page: NodeId, rect: Rect, start_inside: Option) -> Vec { let Some(page_node) = doc.node(page) else { return Vec::new() }; @@ -500,13 +502,13 @@ pub fn marquee_select(doc: &Document, page: NodeId, rect: Rect, start_inside: Op for (t, act, _) in &classified { match act { Touch::Whole => out.push(*t), - Touch::Partial if top_level_mode => out.push(*t), - Touch::Open | Touch::Partial if !top_level_mode => { + Touch::Open | Touch::Partial if top_level_mode => out.push(*t), + Touch::Open | Touch::Partial => { if let Some(n) = doc.node(*t) { out.extend(marquee_children(doc, n, rect)); } } - Touch::Open | Touch::Partial | Touch::Skip => {} + Touch::Skip => {} } } out diff --git a/crates/engine/src/marquee_behaviour_tests.rs b/crates/engine/src/marquee_behaviour_tests.rs index 90c37ccd1..cede8c253 100644 --- a/crates/engine/src/marquee_behaviour_tests.rs +++ b/crates/engine/src/marquee_behaviour_tests.rs @@ -1,8 +1,8 @@ //! Marquee selection, as measured in Figma's web app (2026-11-11, the "marquee rules" and "confirming -//! pass" readings) and described in the help-center article "Select layers and objects": a drag +//! pass" readings, and the two evening re-measures) and described in the help-center article "Select layers and objects": a drag //! selects each top-level layer it touches; a partly covered frame or section gives the layers in it -//! the marquee touches, an enclosed one is selected itself; a drag started inside a frame never selects -//! that frame; selecting a frame whole keeps the marquee at the top level; a rotated shape is touched by +//! the marquee touches, an enclosed one is selected itself; a drag started inside a frame selects that frame +//! only when the marquee also takes another top-level frame (then whole); selecting a frame whole keeps the marquee at the top level; a rotated shape is touched by //! its outline, an unrotated one by its box. use serde_json::{Value, json}; @@ -154,17 +154,18 @@ fn a_rotated_ellipse_is_not_touched_by_its_axis_aligned_box() { fn a_rotated_ellipse_is_not_touched_through_the_corner_of_its_turned_box() { let mut s = Session::new(); let k = scene(&mut s); - // Not the measurement's literal numbers (see the brief, section 5): a point inside the turned box - // but outside the ellipse. - let p = Point::new(690.0, 420.0); + // The re-measure's literal marquees (evening, section 1): corner A, the deeper B, and the control. + let p = Point::new(692.0, 419.0); let doc = s.doc().unwrap(); let n = doc.node(k.re).unwrap(); assert!(n.local_rect().contains(doc.world_transform(k.re).inverse() * p), "the probe is inside the turned box"); - assert_eq!(selected(&mut s, (727.0, 407.0), (690.0, 420.0)), Vec::::new()); + assert_eq!(selected(&mut s, (715.0, 411.0), (692.0, 419.0)), Vec::::new(), "measured marquee A"); + assert_eq!(selected(&mut s, (715.0, 411.0), (683.0, 419.0)), Vec::::new(), "measured marquee B"); + assert_eq!(selected(&mut s, (715.0, 411.0), (667.0, 419.0)), vec![k.re], "measured control"); } #[test] -fn a_drag_from_inside_a_frame_never_selects_it() { +fn a_drag_from_inside_a_frame_selects_only_what_it_touches() { let mut s = Session::new(); let k = scene(&mut s); let start_x = |s: &Session| s.doc().unwrap().world_bounds(k.f1).map(|b| (b.x0, b.y0)); @@ -198,3 +199,20 @@ fn a_marquee_enclosing_an_empty_frame_takes_a_partly_covered_frame_whole() { let f2 = id(&ex(&mut s, "frame.create", json!({"x": 400, "y": 0, "width": 200, "height": 150}))); assert_eq!(selected(&mut s, (650.0, 170.0), (40.0, -10.0)), sorted(vec![f1, f2]), "measured re-measure: F2 and F1, not R1"); } + +#[test] +fn a_drag_from_inside_a_frame_takes_it_whole_when_it_takes_another_top_level_frame() { + let mut s = Session::new(); + let f1 = id(&ex(&mut s, "frame.create", json!({"x": 0, "y": 0, "width": 300, "height": 200}))); + let r1 = rect(&mut s, 20.0, 20.0, 60.0, 60.0, Some(f1)); + let _r2 = rect(&mut s, 220.0, 120.0, 60.0, 60.0, Some(f1)); + let f2 = id(&ex(&mut s, "frame.create", json!({"x": 0, "y": 400, "width": 200, "height": 150}))); + let rr = rect(&mut s, 400.0, 400.0, 200.0, 100.0, None); + ex(&mut s, "select.none", json!({})); + assert_eq!(selected(&mut s, (150.0, 100.0), (90.0, 720.0)), sorted(vec![f1, f2]), "re-measure 2, case 1"); + let sel = selected(&mut s, (150.0, 50.0), (50.0, 720.0)); + assert_eq!(sel, sorted(vec![f1, f2]), "re-measure 2, case 2b: R1 is covered in part and still not selected"); + assert!(!sel.contains(&r1)); + assert_eq!(selected(&mut s, (150.0, 100.0), (450.0, 450.0)), sorted(vec![f1, f2, rr]), "re-measure 2, case 3"); + assert_eq!(selected(&mut s, (290.0, 100.0), (450.0, 450.0)), vec![rr], "re-measure 2, case 3b: the frame only when another is taken"); +} diff --git a/docs/mcp.md b/docs/mcp.md index 1c582b0f3..5ff485795 100644 --- a/docs/mcp.md +++ b/docs/mcp.md @@ -675,8 +675,11 @@ on; `key` resolves keys the way the canvas does. Commands behind keys: panel has the keyboard (after F6 or a click on a row), else on the canvas below the selection; the menu takes the keyboard and gives it back when it closes (no-op headless). - `select.area {x, y, width, height, add?, deep?}`: select what a marquee from `x, y` over that box - (page units) would: the top-level layers it touches (a rotated shape by its outline), a frame or section - only when the box covers it and otherwise the layers in it the box touches, never the frame the box starts in; `add` toggles like a Shift marquee, `deep` takes nested layers + (page units) would: the top-level layers it touches (a rotated shape by its outline); an empty + frame on touch; any other frame or section only when the box covers it, otherwise the layers in it + the box touches, except that once the box takes a frame whole, a partly covered frame comes whole + too, and the frame the box starts in is selected only then (when the box also takes another + top-level frame); `add` toggles like a Shift marquee, `deep` takes nested layers like Cmd/Ctrl. Returns `{selection}`. Without a box (`F8` in the app) it draws one for the keyboard around the selection (or in the middle of the view): the arrows move it, Shift+arrows move its far corner (10 screen pixels a press), Enter selects (Shift+Enter adds, Cmd/Ctrl+Enter diff --git a/docs/ui-parity.md b/docs/ui-parity.md index 59583fd13..3c9abe701 100644 --- a/docs/ui-parity.md +++ b/docs/ui-parity.md @@ -1,6 +1,6 @@ # UI and interaction parity -> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-11-11 · **Change:** minor (the marquee follows Figma's measured rules: a partly covered frame or section gives the layers in it the marquee touches, a rotated shape is touched by its outline, a drag from inside a frame never selects that frame (`marquee_behaviour_tests`); the main menu and its submenus stay inside the window, moving up to fit and scrolling when taller (#2217); locked layers ignore the arrow keys and a locked parent's children can't be locked on their own (#1560); the left rail's and tab strip's icons are larger, 20 pt (#553); pick select: Tab while the keyboard selection box shows (or the chord again) puts a pink outline on a layer and the keys walk the layer tree from it, as Accessibility at Figma says (#1836); scrubbing a field faster or slower by the pointer's height, with a notice of the speed, as the help center's Scrub fields says (#1837); component rows in the Layers panel at AA contrast in the theme's component tint, with the rows inside a selected component in a tone of its row (#1903); Cmd/Ctrl-click on a padding field sets all four sides with the value typed, a documented auto layout shortcut; a fill per region of a vector: with regions selected in edit mode, the Fill section and the fill commands edit those regions' own fills, as Edit vector layers says (#1875); the Fill section of a text whose characters were coloured differently while editing shows mixed content, characters that all share fills the layer doesn't have show those, and a layer-level fill edit reaches every character (#1856); a number field scrubs when dragged with Alt held, as the help center's scrub section says, not only by its label; reuse visible layer selection roots (M8); ; with a shape or frame tool chosen and nothing selected, the arrows show a placement crosshair in the middle of the view and move it, and Enter places there, as Accessibility at Figma says (#1839); text direction per paragraph: Text ▸ Text direction forces a paragraph left to right or right to left, as Add right-to-left text says (#1830), with `text.direction`, `node.set textDirection`, the Type settings control once a right-to-left script is in the text, inspect, the CSS `direction` and the `.fig` lines' `sourceDirectionality`; the boolean operation menu in the Design panel leads each entry with an original icon drawn in code, a filled preview of the result (#2003); a press on the open gradient's handles or stops on the canvas keeps the colour picker open through the drag, as its own control (#1852); a click with the Bend tool on a sharp point curves it, its handles along the line between its neighbours, as Edit vector layers says (#1875); wrap style: Auto, Balance and Pretty on a text layer decide where its lines break, as Explore text properties says (#1827), with the Type settings control, `text.wrapStyle`, `node.set wrapStyle`, inspect and the CSS `text-wrap`; Backspace or Delete at the start of a list item keeps the item's indentation level, as the lists article says; max lines on auto-width text keep it auto width, hugging that many lines, as the text properties article says; superscript and subscript are synthesised where the font has no glyphs for them, from the standard glyphs shrunk and shifted by the font's OS/2 metrics, and a run mixing available and unavailable glyphs is synthesised whole, as Explore text properties says (#1828); Alt+Enter while editing text opens the link at the caret, as the accessibility page documents; Minimize, by its shortcut or the button by the file name, collapses the navigation bar and both sidebars as the help center says, with the right sidebar back while something is selected (#1835); the interface size keys of the help center's accessibility page: Cmd/Ctrl+Shift+Alt with =, - and 0 step the interface through the Preferences sizes and back to the system's size; Cmd/Ctrl+Alt+arrows rotate the selection a degree at a time, 15 with Shift, as the help center's accessibility page says; they resized before; the Layers panel answers Ctrl+1 as well as Alt+1 on Windows and Linux, the two keys the help center gives it; the colour picker's Image tab shows a placeholder and Upload from computer, an asset preview, and a file dropped on it replaces the image, keeping the fill mode, crop and position (#1682); the keyboard's Menu key opens the context menu, as Shift+F10 does; the eyedropper with Cmd/Ctrl+Shift makes a colour style or variable of what it picks; sidebar number and text fields keep their text vertically centered when focused, including typography spacing; with the pen out, Enter or a double-click ends the path and edits the vector with the Move tool instead of drawing on (#1430); the Actions palette offers only commands that run from it, and no second row reading like a menu item: Place image opens the file dialog (#1574); Preferences ▸ Scroll wheel zoom: a mouse wheel zooms the canvas about the pointer and Cmd/Ctrl+wheel scrolls (#1390); boolean operations refuse input past their caps, and a boolean group past them draws without its result (#1104); the selection and hover outlines of rounded rectangles and frames follow their corners (#1506); colour picker review fixes for text undo, fitted sidebars, moving controls and gradient variables; Corner smoothing: an original icon and the shared number-field drag gesture, preserving fractional baselines; guides snap to layers when dragged; Crop image: Object ▸ Crop image, the right-click menu and the image fill row enter crop mode (`image.crop`, #1464); the Design panel's sections on one grid — 16 / 8 margins, 88 + 8 + 88 + 8 + 24 columns, 24 pt rows, 4 pt between a row's buttons (#858); the toolbar on one 32 pt grid, without its Resources button (#1210); colour picker LCH and OKLCH models; an XML (Android Vector Drawable) export format; Context menus: the Menu key reaches egui 0.37 but is unbound (row done → partial); the Text on a path tool; board tool keys pinned; community fixes: the text box by dragging, the font picker keys, the pen path on leaving Design, a still canvas in vector edit mode, a scrolling pages list, colour emoji, readable new text in frames, system theme on first run; the Small caps sample in Type settings drawn from capitals; recent files as cards; vector edit mode: hovering, hatching, selecting and dragging filled regions; home screen: Templates tab, first-run templates and Getting started tips; number fields: scrub rates, arrow steps, arithmetic with brackets, relative edits of mixed values; outline mode's hidden layers and object bounds; Hide when publishing; cursors per tool and modifier; panel widths; dark pages for files made in the dark theme; drag threshold and double-clicks into text in groups; rotation origin on Alt+R and placing with Enter: no documented shortcut missing; keyboard shortcut parity suite and bindings; cursor chat and spotlight in live sessions; layers and assets panels behaviour suite and fixes; vector multi-edit and the vector edit tail; canvas navigation, guides and grids behaviour suite and fixes; shapes and vector behaviour suite and fixes; paint and effects behaviour suite and fixes; frames, groups, sections and masks behaviour suite and fixes; layers panel keyboard: F2 rename, Shift+F10 context menu, F8 box selection; selection and transform behaviour suite and fixes; Display P3: gamut warning and soft-proof (true P3 blocked upstream); several windows; boolean hit testing on the result, group drags, frame outlines and slices; outlines for the selection, mask outlines; arc fields, live boolean editing, shape builder on strokes, one-sided widths; fields select their text on focus; Typography spacing icons support scrubbing (#373); CSS colour names in hex fields; a rename selects the whole name, so typing replaces it; Escape or Enter after a pen path stays on the same vector (#760); IME composition kept on through idle frames of a text edit, candidates at the caret (#747); Selection colors for mixed selections and smart-selection spacing (#753); submenus with a hover delay and a safe triangle; the Actions palette's tabs, ranked search, highlight and recents; menu items that ask for a value; editor fixes from the community batches) · **Target:** Figma Design UI3 (desktop app 126.10.7) +> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-11-11 · **Change:** minor (the marquee follows Figma's measured rules: a partly covered frame or section gives the layers in it the marquee touches, a rotated shape is touched by its outline, a drag from inside a frame selects that frame only when the marquee also takes another top-level frame (then whole) (`marquee_behaviour_tests`); the main menu and its submenus stay inside the window, moving up to fit and scrolling when taller (#2217); locked layers ignore the arrow keys and a locked parent's children can't be locked on their own (#1560); the left rail's and tab strip's icons are larger, 20 pt (#553); pick select: Tab while the keyboard selection box shows (or the chord again) puts a pink outline on a layer and the keys walk the layer tree from it, as Accessibility at Figma says (#1836); scrubbing a field faster or slower by the pointer's height, with a notice of the speed, as the help center's Scrub fields says (#1837); component rows in the Layers panel at AA contrast in the theme's component tint, with the rows inside a selected component in a tone of its row (#1903); Cmd/Ctrl-click on a padding field sets all four sides with the value typed, a documented auto layout shortcut; a fill per region of a vector: with regions selected in edit mode, the Fill section and the fill commands edit those regions' own fills, as Edit vector layers says (#1875); the Fill section of a text whose characters were coloured differently while editing shows mixed content, characters that all share fills the layer doesn't have show those, and a layer-level fill edit reaches every character (#1856); a number field scrubs when dragged with Alt held, as the help center's scrub section says, not only by its label; reuse visible layer selection roots (M8); ; with a shape or frame tool chosen and nothing selected, the arrows show a placement crosshair in the middle of the view and move it, and Enter places there, as Accessibility at Figma says (#1839); text direction per paragraph: Text ▸ Text direction forces a paragraph left to right or right to left, as Add right-to-left text says (#1830), with `text.direction`, `node.set textDirection`, the Type settings control once a right-to-left script is in the text, inspect, the CSS `direction` and the `.fig` lines' `sourceDirectionality`; the boolean operation menu in the Design panel leads each entry with an original icon drawn in code, a filled preview of the result (#2003); a press on the open gradient's handles or stops on the canvas keeps the colour picker open through the drag, as its own control (#1852); a click with the Bend tool on a sharp point curves it, its handles along the line between its neighbours, as Edit vector layers says (#1875); wrap style: Auto, Balance and Pretty on a text layer decide where its lines break, as Explore text properties says (#1827), with the Type settings control, `text.wrapStyle`, `node.set wrapStyle`, inspect and the CSS `text-wrap`; Backspace or Delete at the start of a list item keeps the item's indentation level, as the lists article says; max lines on auto-width text keep it auto width, hugging that many lines, as the text properties article says; superscript and subscript are synthesised where the font has no glyphs for them, from the standard glyphs shrunk and shifted by the font's OS/2 metrics, and a run mixing available and unavailable glyphs is synthesised whole, as Explore text properties says (#1828); Alt+Enter while editing text opens the link at the caret, as the accessibility page documents; Minimize, by its shortcut or the button by the file name, collapses the navigation bar and both sidebars as the help center says, with the right sidebar back while something is selected (#1835); the interface size keys of the help center's accessibility page: Cmd/Ctrl+Shift+Alt with =, - and 0 step the interface through the Preferences sizes and back to the system's size; Cmd/Ctrl+Alt+arrows rotate the selection a degree at a time, 15 with Shift, as the help center's accessibility page says; they resized before; the Layers panel answers Ctrl+1 as well as Alt+1 on Windows and Linux, the two keys the help center gives it; the colour picker's Image tab shows a placeholder and Upload from computer, an asset preview, and a file dropped on it replaces the image, keeping the fill mode, crop and position (#1682); the keyboard's Menu key opens the context menu, as Shift+F10 does; the eyedropper with Cmd/Ctrl+Shift makes a colour style or variable of what it picks; sidebar number and text fields keep their text vertically centered when focused, including typography spacing; with the pen out, Enter or a double-click ends the path and edits the vector with the Move tool instead of drawing on (#1430); the Actions palette offers only commands that run from it, and no second row reading like a menu item: Place image opens the file dialog (#1574); Preferences ▸ Scroll wheel zoom: a mouse wheel zooms the canvas about the pointer and Cmd/Ctrl+wheel scrolls (#1390); boolean operations refuse input past their caps, and a boolean group past them draws without its result (#1104); the selection and hover outlines of rounded rectangles and frames follow their corners (#1506); colour picker review fixes for text undo, fitted sidebars, moving controls and gradient variables; Corner smoothing: an original icon and the shared number-field drag gesture, preserving fractional baselines; guides snap to layers when dragged; Crop image: Object ▸ Crop image, the right-click menu and the image fill row enter crop mode (`image.crop`, #1464); the Design panel's sections on one grid — 16 / 8 margins, 88 + 8 + 88 + 8 + 24 columns, 24 pt rows, 4 pt between a row's buttons (#858); the toolbar on one 32 pt grid, without its Resources button (#1210); colour picker LCH and OKLCH models; an XML (Android Vector Drawable) export format; Context menus: the Menu key reaches egui 0.37 but is unbound (row done → partial); the Text on a path tool; board tool keys pinned; community fixes: the text box by dragging, the font picker keys, the pen path on leaving Design, a still canvas in vector edit mode, a scrolling pages list, colour emoji, readable new text in frames, system theme on first run; the Small caps sample in Type settings drawn from capitals; recent files as cards; vector edit mode: hovering, hatching, selecting and dragging filled regions; home screen: Templates tab, first-run templates and Getting started tips; number fields: scrub rates, arrow steps, arithmetic with brackets, relative edits of mixed values; outline mode's hidden layers and object bounds; Hide when publishing; cursors per tool and modifier; panel widths; dark pages for files made in the dark theme; drag threshold and double-clicks into text in groups; rotation origin on Alt+R and placing with Enter: no documented shortcut missing; keyboard shortcut parity suite and bindings; cursor chat and spotlight in live sessions; layers and assets panels behaviour suite and fixes; vector multi-edit and the vector edit tail; canvas navigation, guides and grids behaviour suite and fixes; shapes and vector behaviour suite and fixes; paint and effects behaviour suite and fixes; frames, groups, sections and masks behaviour suite and fixes; layers panel keyboard: F2 rename, Shift+F10 context menu, F8 box selection; selection and transform behaviour suite and fixes; Display P3: gamut warning and soft-proof (true P3 blocked upstream); several windows; boolean hit testing on the result, group drags, frame outlines and slices; outlines for the selection, mask outlines; arc fields, live boolean editing, shape builder on strokes, one-sided widths; fields select their text on focus; Typography spacing icons support scrubbing (#373); CSS colour names in hex fields; a rename selects the whole name, so typing replaces it; Escape or Enter after a pen path stays on the same vector (#760); IME composition kept on through idle frames of a text edit, candidates at the caret (#747); Selection colors for mixed selections and smart-selection spacing (#753); submenus with a hover delay and a safe triangle; the Actions palette's tabs, ranked search, highlight and recents; menu items that ask for a value; editor fixes from the community batches) · **Target:** Figma Design UI3 (desktop app 126.10.7) Fine canvas control is what Figma users feel first: handles, snapping, nudging, modifier keys, drag behaviour, numeric precision. This checklist covers the tools, gestures and panels. Status: @@ -56,7 +56,7 @@ interaction feel not yet compared. | Item | Status | Notes | |---|---|---| -| Click, Shift-click, marquee, Shift-marquee toggle | done | Shift-drag on a selected layer moves the selection, kept to one axis (#498); a marquee selects the top-level layers it touches, by the box and a rotated shape by its outline (rectangle and ellipse measured, the other shapes by the same code); a partly covered top-level frame or section gives the layers in it the marquee touches, an enclosed one is selected itself, an empty frame on touch; a drag from a frame's background never selects that frame and also takes what it touches outside it; selecting a frame whole keeps the marquee at the top level (a partly covered frame then comes whole too); locked and hidden layers are skipped (`marquee_behaviour_tests`, `selection_behaviour_tests`; measured in Figma's web app, 2026-11-11; Shift and Cmd/Ctrl marquees not measured) (a locked layer selected from the panel ignores the arrow keys and the nudge commands; its properties still edit; measured in Figma's web app, 2026-11-10) | +| Click, Shift-click, marquee, Shift-marquee toggle | done | Shift-drag on a selected layer moves the selection, kept to one axis (#498); a marquee selects the top-level layers it touches, by the box and a rotated shape by its outline (rectangle and ellipse measured, the other shapes by the same code); a partly covered top-level frame or section gives the layers in it the marquee touches, an enclosed one is selected itself, an empty frame on touch; a drag from a frame's background selects that frame only when the marquee also takes another top-level frame (then whole), and also takes what it touches outside it; selecting a frame whole keeps the marquee at the top level (a partly covered frame then comes whole too); locked and hidden layers are skipped (`marquee_behaviour_tests`, `selection_behaviour_tests`; measured in Figma's web app, 2026-11-11; Shift and Cmd/Ctrl marquees not measured) (a locked layer selected from the panel ignores the arrow keys and the nudge commands; its properties still edit; measured in Figma's web app, 2026-11-10) | | Deep select (Cmd/Ctrl-click, Cmd/Ctrl-marquee) | done | | | Select layer menu (every layer under the click) | done | | | Enter / Shift+Enter (children / parent), Tab / Shift+Tab (siblings) | done | Tab renames the next layer while renaming | @@ -187,7 +187,7 @@ in the table. `crates/ui-egui/src/shortcut_keys_tests.rs` drives the keys a look | Date | Change | Summary | |---|---|---| -| 2026-11-11 | patch | M5, gap 4: marquee selection as measured in Figma's web app (Select layers and objects, Selection marquee): a partly covered top-level frame or section gives the layers in it the marquee touches (it was selected only when enclosed, so nothing came), an empty frame is selected on touch, a rotated shape is touched by its outline and not its box, a drag from inside a frame never selects that frame and also takes the top-level layers it touches outside it, and selecting a frame whole keeps the marquee at the top level (a partly covered frame then comes whole, not its layers). Flipped: `marquee_selects_what_it_touches`, `cmd_marquee_selects_nested_layers`, `a_box_selects_like_a_marquee`. Tests: `marquee_behaviour_tests`. Counts unchanged | +| 2026-11-11 | patch | M5, gap 4: marquee selection as measured in Figma's web app (Select layers and objects, Selection marquee): a partly covered top-level frame or section gives the layers in it the marquee touches (it was selected only when enclosed, so nothing came), an empty frame is selected on touch, a rotated shape is touched by its outline and not its box, a drag from inside a frame selects that frame only when the marquee also takes another top-level frame (then whole), and also takes the top-level layers it touches outside it, and selecting a frame whole keeps the marquee at the top level (a partly covered frame then comes whole, not its layers). Flipped: `marquee_selects_what_it_touches`, `cmd_marquee_selects_nested_layers`, `a_box_selects_like_a_marquee`. Tests: `marquee_behaviour_tests`. Counts unchanged | | 2026-11-10 | patch | M5, #1560: locked layers follow Figma's rules (Lock and unlock layers; measured in Figma's web app): a locked layer selected in the Layers panel ignores the arrow keys and the nudge commands while its properties still edit, and a child of a locked layer keeps its padlock inert (the Layers panel padlock, Lock/Unlock and `object.toggleLock` without a value no longer lock the child on its own) | | 2026-11-10 | patch | #2217: the main menu's submenus (Object, say) ran past the window's bottom, behind the taskbar, with the lowest commands out of reach, because submenus were not constrained to the window (to keep them beside their row). Every menu panel now scrolls when taller than the window less 8 pt margins, and a submenu is held within the window's height (moved up, never above the top) while keeping its place beside its row, so menu-aim is unchanged. Tests: `menu_overflow_tests.rs`. Numbers unchanged. | | 2026-11-02 | patch | Shortcuts: a Cmd/Ctrl-click on a padding field (the horizontal or vertical pair, or a side with Individual padding open) makes the value typed go to all four sides, in one undo step (Guide to auto layout, Keyboard shortcut guide); a plain click still edits that axis or side alone. A documented gesture row: 134 documented, 133 bound. Test: `padding_individual_tests` | From b1ee6535c9aada73b0d6d6f92438864d4cc0c47a Mon Sep 17 00:00:00 2001 From: bflatastic Date: Thu, 12 Nov 2026 09:23:03 +0700 Subject: [PATCH 19/19] Ellipse tests: drop an unused binding and a comment about an allowance main never had --- crates/geom/src/tests.rs | 3 +-- crates/render/src/band_tests.rs | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/crates/geom/src/tests.rs b/crates/geom/src/tests.rs index 909a3c475..059dd6098 100644 --- a/crates/geom/src/tests.rs +++ b/crates/geom/src/tests.rs @@ -341,8 +341,7 @@ fn a_whole_ellipse_is_four_cubics_through_the_extremes() { assert!((s.p3 - want[i]).hypot() < 1e-9, "{w}x{h}: anchor {i} is {:?}", s.p3); // Handle length is 0.5523 of the radius along the tangent. let k = 0.552_284_749_830_793_4; - let (r_along, r_across) = if i % 2 == 0 { (ry, rx) } else { (rx, ry) }; - let _ = r_across; + let r_along = if i % 2 == 0 { ry } else { rx }; assert!(((s.p1 - s.p0).hypot() - k * r_along).abs() < 1e-9, "{w}x{h}: handle {i}"); } } diff --git a/crates/render/src/band_tests.rs b/crates/render/src/band_tests.rs index 9fcf29f20..6cdf2cd88 100644 --- a/crates/render/src/band_tests.rs +++ b/crates/render/src/band_tests.rs @@ -96,9 +96,8 @@ fn a_real_band_artifact_fails_but_edge_noise_passes() { let width = 880; // scale 2 let flat = vec![100u8; width * 4]; // 44 pixels whose colour channels differ by 60 (alpha unchanged): the mean is - // 44 * 3 * 60 / (880 * 4) = 2.25, which the earlier `0.25 + 0.05 * off` allowance (2.45 here) - // let through; the count, 44, is within a twentieth of the row. A real artifact, so it fails - // on the mean now. + // 44 * 3 * 60 / (880 * 4) = 2.25, and the count, 44, is within a twentieth of the row. A real + // artifact, so it fails on the mean. let mut artifact = flat.clone(); for px in artifact.chunks_mut(4).take(44) { px.iter_mut().take(3).for_each(|c| *c += 60);