mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-11-11 00:41:21 +00:00
* build(i18n): embed the craft-i18n catalogs from a pinned checkout
- `craft-i18n.rev` pins storytold/craft-i18n at e45ddf7 (the PdfCraft cutover sync of
pdfcraft@ecdd1e6); `.gitattributes` keeps it LF.
- The `craft-i18n` crate (craft-libs 787a7a0, PdfCraft's existing pin) is a direct dependency
of the UI crate; it was already in the tree through craft-ui.
- `crates/ui-egui/build.rs` writes `CRAFT_I18N` from `CRAFT_I18N_DIR`: one (locale, common.tsv,
pdfcraft.tsv) entry per locale with a `pdfcraft.tsv`, paths written with `{:?}` and never
canonicalized. Unset it is empty (English only); `CRAFT_I18N_REQUIRED=1` makes a missing or
invalid checkout an error.
- Both flatpak manifests name the craft-i18n commit and `CRAFT_I18N_DIR`; a test keeps both
commits equal to the trimmed pin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(i18n): look strings up through craft-i18n behind a thin Lang wrapper
`i18n.rs` keeps PdfCraft's API (tr, tr_ctx, tr_id, trn, key_name, fmt,
Lang, LANGUAGES, detection) and hands lookups to the craft-i18n crate:
`get` for key names, `trn_plain` for plurals (no isolates, no digit
grouping), PdfCraft's own `fmt` (no FSI isolates). `@id` rows and the
"Undo {action}" template are read only where PdfCraft had them, so menus
and history labels read exactly as before.
Detection is unchanged (LC_ALL/LC_MESSAGES/LANG, macOS defaults,
sys_locale); the crate's match_tag would drop nb for no/nn, so PdfCraft's
own tag mapping stays, with one parity test per path.
Completeness tests become reports; tests that need catalogs skip with a
note when the build has none. Font coverage tests read the embedded
catalogs (shared and PdfCraft rows).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore(i18n): remove the in-repo catalogs; craft-i18n holds them
The 34 `crates/ui-egui/src/i18n/*.tsv` catalogs were migrated into
craft-i18n at pdfcraft@ecdd1e6 and are now embedded from the pinned
checkout. ATTRIBUTION.toml drops their 34 entries for one craft-i18n
`[[build_input]]` (craft-i18n's ATTRIBUTION.md credits the translators);
AGENTS.md and docs/localization.md describe the new system and how to
add a language.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(i18n): skip catalog tests without craft-i18n; drop the catalog hash exemption
Tests that switch to a non-English language skip with a note when the
build embeds no catalogs (CRAFT_I18N_DIR unset), so the English-only
build tests green. `skip_without_catalogs` moves to the integration
test support module.
With no catalogs left in the repository, `cargo xtask assets` no longer
exempts `crates/ui-egui/src/i18n/*.tsv` from hashing: every `[[asset]]`
carries a sha256 again, and a `.tsv` added back would need one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* build(i18n): watch the locales directory before reading it
A CRAFT_I18N_DIR that doesn't exist yet now reruns the build script once it appears (review).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* build(i18n): pin craft-i18n dfbe955, the merge of storytold/craft-i18n#129
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(i18n): skip an @id row that changes the label's placeholders or ellipsis
craft-i18n checks placeholders and the trailing ellipsis on every row whose
source is English text, but not on @id rows, whose source is the command id.
The in-repo catalog test used to fail on such a row; since the cutover it only
prints it, while tr_id and menu_label still showed it. Both now use PdfCraft's
own @id row only when it keeps the label's shape (same_shape, the rule
craft-i18n applies elsewhere), and otherwise show the label's translation, as
bundled_catalogs_are_consistent says.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(i18n): reject an @id row with an open brace; list unused @id rows in the gaps report
same_shape skipped a `{` with no `}`, so an @id row such as "Öffnen {name…"
for "Open…" was still shown. It now counts as a changed shape.
bundled_catalogs_are_consistent printed the @id rows PdfCraft doesn't use, but
CI captures test output, so nobody saw them. translation_gaps_report, which
`cargo xtask i18n-report` runs with --nocapture, now lists them
(unused_id_rows).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(i18n): reject an @id row with a `}` that closes no placeholder
same_shape counted only the `}` that close a `{`, so "Öffnen name}…" for
"Open…" or "{name}} öffnen" for "Open {name}" still passed. A row whose `}`
count differs from its placeholders now counts as a changed shape.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(i18n): no braces in the assert messages of the brace test
assert! reads its message as a format string, so "a `}` without its `{`"
did not compile.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
467 lines
24 KiB
Rust
467 lines
24 KiB
Rust
//! The interface fonts with and without the optional craft-fonts build input (`CRAFT_FONTS_DIR`).
|
|
|
|
use egui::epaint::text::{Fonts, TextOptions};
|
|
use egui::{Color32, FontFamily, FontId};
|
|
use pdfcraft_ui_egui::theme;
|
|
|
|
const JAPANESE: &str = "日本語の文字";
|
|
const CHINESE: &str = "简体中文欢迎";
|
|
const ARABIC: &str = "واحد اثنين";
|
|
const TELUGU: &str = "తెలుగు ఫైల్";
|
|
const HEBREW: &str = "ייפוי כח.pdf";
|
|
const DEVANAGARI: &str = "हिंदी पाठ सम्पादन";
|
|
|
|
/// The embedded craft-i18n catalogs `code` reads (the shared one and PdfCraft's), one text; empty
|
|
/// in a build without them.
|
|
fn catalog(code: &str) -> String {
|
|
pdfcraft_ui_egui::i18n::Lang::from_code(code).map(|l| l.catalog_texts().collect::<Vec<_>>().join("\n")).unwrap_or_default()
|
|
}
|
|
|
|
fn families() -> Vec<FontId> {
|
|
vec![FontId::proportional(13.0), FontId::monospace(13.0), theme::medium(13.0), theme::semibold(17.0)]
|
|
}
|
|
|
|
/// The bundled faces, with no craft-fonts and no installed system face: 0.37 gates its emoji
|
|
/// fonts behind `monochrome_emoji_fonts`, which the app and this test crate explicitly enable.
|
|
/// Text symbols must keep working with `PDFCRAFT_SYSTEM_FONTS=0`.
|
|
#[test]
|
|
fn bundled_monochrome_symbols_have_glyphs() {
|
|
let mut fonts = Fonts::new(TextOptions::default(), theme::font_definitions());
|
|
for id in families() {
|
|
for text in ["✔", "▲", "▼"] {
|
|
assert!(fonts.has_glyphs(&id, text), "{id:?} lacks {text} with default_fonts + monochrome_emoji_fonts");
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Lays `text` out in every interface family and returns each galley's width.
|
|
fn layout_widths(fonts: &mut Fonts, text: &str) -> Vec<f32> {
|
|
let mut view = fonts.with_pixels_per_point(2.0);
|
|
families().into_iter().map(|id| view.layout_no_wrap(text.to_owned(), id, Color32::BLACK).size().x).collect()
|
|
}
|
|
|
|
/// Built with craft-fonts, Japanese text renders with real glyphs (no tofu) in every family,
|
|
/// from a craft-fonts face placed after the app's own fonts.
|
|
#[test]
|
|
fn japanese_ui_text_uses_craft_fonts() {
|
|
if pdfcraft_fonts::ui_japanese_fonts().is_empty() {
|
|
eprintln!("skipping japanese_ui_text_uses_craft_fonts: built without craft-fonts (set CRAFT_FONTS_DIR to run it)");
|
|
return;
|
|
}
|
|
let defs = theme::font_definitions();
|
|
for family in [FontFamily::Proportional, FontFamily::Monospace] {
|
|
let stack = &defs.families[&family];
|
|
let first_jp = stack.iter().position(|n| n.starts_with("BIZ UDPGothic")).expect("BIZ UDPGothic is a fallback");
|
|
let own = stack.iter().position(|n| n == "Inter" || n == "JetBrainsMono").expect("the app's own font");
|
|
assert!(own < first_jp, "{family:?}: {stack:?}");
|
|
assert!(stack[first_jp..].iter().all(|n| pdfcraft_fonts::CRAFT_FONTS.iter().any(|f| f.name() == *n)), "{stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, JAPANESE), "{id:?} lacks {JAPANESE}");
|
|
}
|
|
// Real glyphs are about a full em wide each; tofu boxes and missing glyphs are not.
|
|
for w in layout_widths(&mut fonts, JAPANESE) {
|
|
assert!(w > 13.0 * 0.8 * JAPANESE.chars().count() as f32, "{w}");
|
|
}
|
|
}
|
|
|
|
/// Chinese mode orders the CJK fallback with the `Hans` group first, so one line never
|
|
/// mixes faces with different vertical metrics. Without a `Hans` face in the build input the
|
|
/// order part still holds; glyph coverage follows the craft-fonts checkout.
|
|
#[test]
|
|
fn chinese_ui_text_prefers_the_chinese_face() {
|
|
if pdfcraft_fonts::ui_chinese_fonts().is_empty() {
|
|
eprintln!("skipping chinese_ui_text_prefers_the_chinese_face: no Hans face bundled (set CRAFT_FONTS_DIR with a Chinese face to run it)");
|
|
return;
|
|
}
|
|
let defs = theme::font_definitions_for(true);
|
|
let hans: Vec<String> = pdfcraft_fonts::ui_chinese_fonts().iter().map(|f| f.name()).collect();
|
|
for family in [FontFamily::Proportional, FontFamily::Monospace] {
|
|
let stack = &defs.families[&family];
|
|
let first_zh = stack.iter().position(|n| hans.iter().any(|h| h == n)).expect("a Hans face is a fallback");
|
|
let first_ja = stack.iter().position(|n| n.starts_with("BIZ UDPGothic")).expect("BIZ UDPGothic is a fallback");
|
|
let own = stack.iter().position(|n| n == "Inter" || n == "JetBrainsMono").expect("the app's own font");
|
|
assert!(own < first_zh && first_zh < first_ja, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, CHINESE), "{id:?} lacks {CHINESE}");
|
|
}
|
|
for w in layout_widths(&mut fonts, CHINESE) {
|
|
assert!(w > 13.0 * 0.8 * CHINESE.chars().count() as f32, "{w}");
|
|
}
|
|
}
|
|
|
|
/// Built with a craft-fonts Arabic face, Arabic text has real glyphs in every family, from a
|
|
/// face placed after the app's own fonts.
|
|
#[test]
|
|
fn arabic_ui_text_uses_craft_fonts() {
|
|
let arabic: Vec<String> = pdfcraft_fonts::ui_arabic_fonts().iter().map(|f| f.name()).collect();
|
|
if arabic.is_empty() {
|
|
eprintln!("skipping arabic_ui_text_uses_craft_fonts: no Arab face bundled (set CRAFT_FONTS_DIR with an Arabic face to run it)");
|
|
return;
|
|
}
|
|
let defs = theme::font_definitions();
|
|
for family in [FontFamily::Proportional, FontFamily::Monospace] {
|
|
let stack = &defs.families[&family];
|
|
let first_ar = stack.iter().position(|n| arabic.contains(n)).expect("an Arab face is a fallback");
|
|
let own = stack.iter().position(|n| n == "Inter" || n == "JetBrainsMono").expect("the app's own font");
|
|
assert!(own < first_ar, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, ARABIC), "{id:?} lacks {ARABIC}");
|
|
}
|
|
}
|
|
|
|
/// Built with a craft-fonts Telugu face, Telugu text has real glyphs in every family, from a
|
|
/// face placed after the app's own fonts, and is shaped: the conjunct క్ష is narrower than క్
|
|
/// and ష held apart by a zero-width non-joiner.
|
|
#[test]
|
|
fn telugu_ui_text_uses_craft_fonts() {
|
|
let telugu: Vec<String> = pdfcraft_fonts::CRAFT_FONTS.iter().filter(|f| f.covers("Telu")).map(|f| f.name()).collect();
|
|
if telugu.is_empty() {
|
|
eprintln!("skipping telugu_ui_text_uses_craft_fonts: no Telu face bundled (set CRAFT_FONTS_DIR with a Telugu face to run it)");
|
|
return;
|
|
}
|
|
let defs = theme::font_definitions();
|
|
for family in [FontFamily::Proportional, FontFamily::Monospace] {
|
|
let stack = &defs.families[&family];
|
|
let first_te = stack.iter().position(|n| telugu.contains(n)).expect("a Telu face is a fallback");
|
|
let own = stack.iter().position(|n| n == "Inter" || n == "JetBrainsMono").expect("the app's own font");
|
|
assert!(own < first_te, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, TELUGU), "{id:?} lacks {TELUGU}");
|
|
}
|
|
let joined = layout_widths(&mut fonts, "క్ష");
|
|
let apart = layout_widths(&mut fonts, "క్\u{200c}ష");
|
|
for (j, a) in joined.iter().zip(&apart) {
|
|
assert!(j < a, "క్ష is one conjunct, narrower than క్ష: {j} vs {a}");
|
|
}
|
|
}
|
|
|
|
/// On a machine with a suitable installed font, the installed definitions end every family
|
|
/// with it and Arabic text has glyphs; the embedded-only definitions never name it.
|
|
#[test]
|
|
fn system_fallback_fills_missing_scripts() {
|
|
assert!(!theme::font_definitions().font_data.contains_key(theme::SYSTEM_FALLBACK));
|
|
let defs = theme::installed_font_definitions(theme::CjkPreference::Default);
|
|
if !defs.font_data.contains_key(theme::SYSTEM_FALLBACK) {
|
|
eprintln!("skipping system_fallback_fills_missing_scripts: no installed fallback font (or PDFCRAFT_SYSTEM_FONTS=0)");
|
|
assert!(defs.families.values().all(|stack| !stack.iter().any(|n| n == theme::SYSTEM_FALLBACK)));
|
|
return;
|
|
}
|
|
for (family, stack) in &defs.families {
|
|
assert_eq!(stack.last().map(String::as_str), Some(theme::SYSTEM_FALLBACK), "{family:?}: {stack:?}");
|
|
assert_eq!(stack.iter().filter(|n| *n == theme::SYSTEM_FALLBACK).count(), 1, "{family:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, ARABIC), "{id:?} lacks {ARABIC}");
|
|
assert!(fonts.has_glyphs(&id, "PdfCraft"), "{id:?}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, ARABIC).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
}
|
|
|
|
/// On a machine with a suitable installed Devanagari font, the installed definitions include
|
|
/// it and Hindi text has glyphs; the embedded-only definitions never name it.
|
|
#[test]
|
|
fn system_fallback_covers_devanagari() {
|
|
assert!(!theme::font_definitions().font_data.contains_key(theme::SYSTEM_DEVANAGARI_FALLBACK));
|
|
let defs = theme::installed_font_definitions(theme::CjkPreference::Default);
|
|
if !defs.font_data.contains_key(theme::SYSTEM_DEVANAGARI_FALLBACK) {
|
|
eprintln!("skipping system_fallback_covers_devanagari: no installed Devanagari fallback font (or PDFCRAFT_SYSTEM_FONTS=0)");
|
|
assert!(defs.families.values().all(|stack| !stack.iter().any(|n| n == theme::SYSTEM_DEVANAGARI_FALLBACK)));
|
|
return;
|
|
}
|
|
for (family, stack) in &defs.families {
|
|
assert!(stack.iter().any(|n| n == theme::SYSTEM_DEVANAGARI_FALLBACK), "{family:?}: {stack:?}");
|
|
assert_eq!(stack.iter().filter(|n| *n == theme::SYSTEM_DEVANAGARI_FALLBACK).count(), 1, "{family:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, DEVANAGARI), "{id:?} lacks {DEVANAGARI}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, DEVANAGARI).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
}
|
|
|
|
/// Built with craft-fonts, Hindi text renders with real glyphs (no tofu) in every family: a
|
|
/// `Deva` face is a fallback after the app's own fonts. Without craft-fonts it is the installed
|
|
/// Devanagari fallback's job (see `system_fallback_covers_devanagari`), and the web build has
|
|
/// neither.
|
|
#[test]
|
|
fn devanagari_ui_text_uses_craft_fonts() {
|
|
if pdfcraft_fonts::ui_devanagari_fonts().is_empty() {
|
|
eprintln!("skipping devanagari_ui_text_uses_craft_fonts: built without craft-fonts (set CRAFT_FONTS_DIR to run it)");
|
|
return;
|
|
}
|
|
let defs = theme::font_definitions();
|
|
for family in [FontFamily::Proportional, FontFamily::Monospace] {
|
|
let stack = &defs.families[&family];
|
|
let first =
|
|
stack.iter().position(|n| pdfcraft_fonts::ui_devanagari_fonts().iter().any(|f| f.name() == *n)).expect("a Deva face is a fallback");
|
|
let own = stack.iter().position(|n| n == "Inter" || n == "JetBrainsMono").expect("the app's own font");
|
|
assert!(own < first, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, DEVANAGARI), "{id:?} lacks {DEVANAGARI}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, DEVANAGARI).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
}
|
|
|
|
/// On a machine with an installed Telugu font, the installed definitions include it and Telugu
|
|
/// text has glyphs, so the language's own name in Preferences is not boxes (#1531). macOS always
|
|
/// ships Kohinoor Telugu, so there the test never skips.
|
|
#[test]
|
|
fn system_fallback_covers_telugu() {
|
|
assert!(!theme::font_definitions().font_data.contains_key(theme::SYSTEM_TELUGU_FALLBACK));
|
|
let defs = theme::installed_font_definitions(theme::CjkPreference::Default);
|
|
let off = std::env::var_os("PDFCRAFT_SYSTEM_FONTS").is_some_and(|v| v == "0");
|
|
if !defs.font_data.contains_key(theme::SYSTEM_TELUGU_FALLBACK) && (off || !cfg!(target_os = "macos")) {
|
|
eprintln!("skipping system_fallback_covers_telugu: no installed Telugu fallback font (or PDFCRAFT_SYSTEM_FONTS=0)");
|
|
assert!(defs.families.values().all(|stack| !stack.iter().any(|n| n == theme::SYSTEM_TELUGU_FALLBACK)));
|
|
return;
|
|
}
|
|
for (family, stack) in &defs.families {
|
|
assert_eq!(stack.iter().filter(|n| *n == theme::SYSTEM_TELUGU_FALLBACK).count(), 1, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, TELUGU), "{id:?} lacks {TELUGU}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, TELUGU).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
}
|
|
|
|
/// On a machine with installed Sinhala and Tamil fonts, the installed definitions include them
|
|
/// and Sinhala and Tamil text, such as a file name, has glyphs instead of boxes (#1688). macOS
|
|
/// always ships Sinhala Sangam MN and Tamil Sangam MN, so there the test never skips.
|
|
#[test]
|
|
fn system_fallback_covers_sinhala_and_tamil() {
|
|
for (name, text) in [(theme::SYSTEM_SINHALA_FALLBACK, "ශ්රී ලංකා ගොනුව"), (theme::SYSTEM_TAMIL_FALLBACK, "தமிழ் கோப்பு")]
|
|
{
|
|
assert!(!theme::font_definitions().font_data.contains_key(name));
|
|
let defs = theme::installed_font_definitions(theme::CjkPreference::Default);
|
|
let off = std::env::var_os("PDFCRAFT_SYSTEM_FONTS").is_some_and(|v| v == "0");
|
|
if !defs.font_data.contains_key(name) && (off || !cfg!(target_os = "macos")) {
|
|
eprintln!("skipping {name}: no installed fallback font (or PDFCRAFT_SYSTEM_FONTS=0)");
|
|
assert!(defs.families.values().all(|stack| !stack.iter().any(|n| n == name)));
|
|
continue;
|
|
}
|
|
for (family, stack) in &defs.families {
|
|
assert_eq!(stack.iter().filter(|n| *n == name).count(), 1, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, text), "{id:?} lacks {text}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, text).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
}
|
|
}
|
|
|
|
/// On a machine with an installed Hebrew font, the installed definitions include it and a
|
|
/// Hebrew file name has glyphs in the document tab and the recent files (#586). macOS always
|
|
/// ships Arial Hebrew and SF Hebrew, so there the test never skips.
|
|
#[test]
|
|
fn system_fallback_covers_hebrew() {
|
|
assert!(!theme::font_definitions().font_data.contains_key(theme::SYSTEM_HEBREW_FALLBACK));
|
|
let defs = theme::installed_font_definitions(theme::CjkPreference::Default);
|
|
let off = std::env::var_os("PDFCRAFT_SYSTEM_FONTS").is_some_and(|v| v == "0");
|
|
if !defs.font_data.contains_key(theme::SYSTEM_HEBREW_FALLBACK) && (off || !cfg!(target_os = "macos")) {
|
|
eprintln!("skipping system_fallback_covers_hebrew: no installed Hebrew fallback font (or PDFCRAFT_SYSTEM_FONTS=0)");
|
|
assert!(defs.families.values().all(|stack| !stack.iter().any(|n| n == theme::SYSTEM_HEBREW_FALLBACK)));
|
|
return;
|
|
}
|
|
for (family, stack) in &defs.families {
|
|
assert_eq!(stack.iter().filter(|n| *n == theme::SYSTEM_HEBREW_FALLBACK).count(), 1, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, HEBREW), "{id:?} lacks {HEBREW}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, HEBREW).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
}
|
|
|
|
/// The Han characters of a catalog's translations.
|
|
fn catalog_han(catalog: &str) -> String {
|
|
let mut han: Vec<char> = catalog
|
|
.lines()
|
|
.filter(|l| !l.starts_with('#'))
|
|
.filter_map(|l| l.split('\t').nth(2))
|
|
.flat_map(str::chars)
|
|
.filter(|c| matches!(*c, '\u{3400}'..='\u{9fff}' | '\u{f900}'..='\u{faff}'))
|
|
.collect();
|
|
han.sort_unstable();
|
|
han.dedup();
|
|
han.into_iter().collect()
|
|
}
|
|
|
|
/// One Chinese preference against its catalog: the installed face must be in every family,
|
|
/// before the Japanese faces, and cover every Han character the catalog uses.
|
|
///
|
|
/// Returns false when this machine has no installed face for the preference (or system fonts
|
|
/// are off); the caller reports that as a skip. A bundled `Hans` face is never allowed to
|
|
/// stand in for Traditional Chinese.
|
|
fn installed_chinese_face_covers(cjk: theme::CjkPreference, catalog: &str, name: &str) -> bool {
|
|
let defs = theme::installed_font_definitions(cjk);
|
|
if !defs.font_data.contains_key(theme::SYSTEM_FALLBACK) {
|
|
eprintln!("skipping {name}: no installed Chinese face for {cjk:?} (or PDFCRAFT_SYSTEM_FONTS=0)");
|
|
return false;
|
|
}
|
|
for (family, stack) in &defs.families {
|
|
let system = stack.iter().position(|n| n == theme::SYSTEM_FALLBACK).expect("in every family");
|
|
assert_eq!(stack.iter().filter(|n| *n == theme::SYSTEM_FALLBACK).count(), 1, "{family:?}");
|
|
let own = stack.iter().position(|n| n.starts_with("Inter") || n == "JetBrainsMono").expect("the app's own font");
|
|
assert!(own < system, "{family:?}: {stack:?}");
|
|
if let Some(first_ja) = stack.iter().position(|n| n.starts_with("BIZ UDPGothic")) {
|
|
assert!(system < first_ja, "{family:?}: {stack:?}");
|
|
}
|
|
}
|
|
let han = catalog_han(catalog);
|
|
assert!(han.contains('欢') || han.contains('說'), "{cjk:?}");
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
let missing: String = han.chars().filter(|c| !fonts.has_glyphs(&id, &c.to_string())).collect();
|
|
assert!(missing.is_empty(), "{cjk:?} {id:?} lacks {missing}");
|
|
}
|
|
true
|
|
}
|
|
|
|
/// In a Simplified Chinese interface built without a `Hans` face, a Simplified Chinese face
|
|
/// installed on this machine goes before the Japanese faces, which lack hundreds of the
|
|
/// catalog's characters.
|
|
#[test]
|
|
fn simplified_chinese_ui_uses_an_installed_hans_face_without_an_embedded_one() {
|
|
if crate::support::skip_without_catalogs("simplified_chinese_ui_uses_an_installed_hans_face_without_an_embedded_one") {
|
|
return;
|
|
}
|
|
if !pdfcraft_fonts::ui_chinese_fonts().is_empty() {
|
|
eprintln!("skipping simplified_chinese_ui_uses_an_installed_hans_face_without_an_embedded_one: a Hans face is bundled");
|
|
return;
|
|
}
|
|
installed_chinese_face_covers(theme::CjkPreference::SimplifiedChinese, &catalog("zh-hans"), "Simplified");
|
|
}
|
|
|
|
/// A Traditional Chinese interface keeps its installed Traditional face before the Japanese
|
|
/// faces even when the build embeds a Simplified-only `Hans` face: that face cannot supply
|
|
/// Traditional-only characters, and Japanese-first fallback would otherwise win.
|
|
#[test]
|
|
fn traditional_chinese_ui_keeps_an_installed_hant_face_before_japanese() {
|
|
if crate::support::skip_without_catalogs("traditional_chinese_ui_keeps_an_installed_hant_face_before_japanese") {
|
|
return;
|
|
}
|
|
installed_chinese_face_covers(theme::CjkPreference::TraditionalChinese, &catalog("zh-hant"), "Traditional");
|
|
}
|
|
|
|
/// Other languages keep the installed face last.
|
|
#[test]
|
|
fn non_chinese_ui_keeps_the_installed_face_last() {
|
|
let defs = theme::installed_font_definitions(theme::CjkPreference::Default);
|
|
for stack in defs.families.values() {
|
|
assert!(stack.iter().position(|n| n == theme::SYSTEM_FALLBACK).is_none_or(|i| i + 1 == stack.len()), "{stack:?}");
|
|
}
|
|
}
|
|
|
|
/// Without craft-fonts the interface fonts still install and lay out any text (Japanese falls
|
|
/// back to egui's replacement glyph) without panicking; Latin text is unaffected.
|
|
#[test]
|
|
fn ui_fonts_work_without_craft_fonts() {
|
|
let mut fonts = Fonts::new(TextOptions::default(), theme::font_definitions());
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, "PdfCraft"), "{id:?}");
|
|
assert_eq!(fonts.has_glyphs(&id, JAPANESE), !pdfcraft_fonts::ui_japanese_fonts().is_empty(), "{id:?}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, JAPANESE).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
assert!(layout_widths(&mut fonts, "PdfCraft").iter().all(|w| *w > 20.0));
|
|
let ctx = egui::Context::default();
|
|
theme::install_fonts(&ctx);
|
|
}
|
|
|
|
/// Latin- and Cyrillic-script catalogs (Czech, Brazilian Portuguese, German, Spanish, French, Russian, Bulgarian, Kazakh, Hungarian, Ukrainian, Italian, Slovene, Lithuanian, Greek, Turkish, Indonesian, Vietnamese, Albanian, Catalan) are drawn entirely by the app's own faces
|
|
/// (Inter, JetBrains Mono with Inter fallback): no letter falls through to egui's defaults or a CJK fallback. (egui's
|
|
/// `has_glyphs` can't answer this: with only the primary face it is also the replacement face.)
|
|
#[test]
|
|
fn primary_ui_fonts_cover_latin_and_cyrillic_catalogs() {
|
|
if crate::support::skip_without_catalogs("primary_ui_fonts_cover_latin_and_cyrillic_catalogs") {
|
|
return;
|
|
}
|
|
use skrifa::MetadataProvider as _;
|
|
let defs = theme::font_definitions();
|
|
assert_eq!(&defs.families[&FontFamily::Monospace][..2], ["JetBrainsMono", "Inter"]);
|
|
let fallback = &defs.font_data["Inter"];
|
|
let fallback_font = skrifa::FontRef::from_index(fallback.font.as_ref().as_ref(), fallback.index).unwrap();
|
|
let fallback_charmap = fallback_font.charmap();
|
|
for (code, catalog) in [
|
|
("cs", &catalog("cs")),
|
|
("el", &catalog("el")),
|
|
("pt-br", &catalog("pt-br")),
|
|
("de", &catalog("de")),
|
|
("es", &catalog("es")),
|
|
("fr", &catalog("fr")),
|
|
("ru", &catalog("ru")),
|
|
("kk", &catalog("kk")),
|
|
("bg", &catalog("bg")),
|
|
("hu", &catalog("hu")),
|
|
("uk", &catalog("uk")),
|
|
("it", &catalog("it")),
|
|
("tr", &catalog("tr")),
|
|
("sl", &catalog("sl")),
|
|
("lt", &catalog("lt")),
|
|
("id", &catalog("id")),
|
|
("vi", &catalog("vi")),
|
|
("fi", &catalog("fi")),
|
|
("sq", &catalog("sq")),
|
|
("ca", &catalog("ca")),
|
|
("ro", &catalog("ro")),
|
|
("nb", &catalog("nb")),
|
|
] {
|
|
// Vietnamese stacks its diacritics: the precomposed letters and the base letters they
|
|
// combine with, including `đ` and the tone marks `ạ ả ấ ầ ẩ ẫ ậ ắ ằ ẳ ẵ ặ ế ề ể ễ ệ`.
|
|
let mut text = String::from(
|
|
"áčďéěíňóřšťúůýžÁČĎÉĚÍŇÓŘŠŤÚŮÝŽãõçâêôàÃÕÇÂÊÔÀñÑüÜäÄöÖőűßæøåÆØÅ„“¿¡«»…ґҐєЄіІїЇәғқңөұүһӘҒҚҢӨҰҮҺđĐạảấầẩẫậắằẳẵặếềểễệọỏốồổỗộớờởỡợụủứừửữựỳỵỷỹ",
|
|
);
|
|
for line in catalog.lines().filter(|l| !l.starts_with('#')) {
|
|
if let Some(translation) = line.split('\t').nth(2) {
|
|
text.extend(translation.chars().filter(|c| !c.is_whitespace()));
|
|
}
|
|
}
|
|
for name in ["Inter", "Inter-Medium", "Inter-SemiBold", "JetBrainsMono"] {
|
|
let data = &defs.font_data[name];
|
|
let font = skrifa::FontRef::from_index(data.font.as_ref().as_ref(), data.index).unwrap();
|
|
let charmap = font.charmap();
|
|
let mut missing: Vec<char> =
|
|
text.chars().filter(|c| charmap.map(*c).is_none() && (name != "JetBrainsMono" || fallback_charmap.map(*c).is_none())).collect();
|
|
missing.sort_unstable();
|
|
missing.dedup();
|
|
assert!(missing.is_empty(), "{code}: {name} lacks {missing:?}");
|
|
}
|
|
}
|
|
}
|
|
|
|
/// On a machine with an installed Korean font, the installed definitions include it and Hangul has
|
|
/// glyphs, so a Korean file name in a tab title is not boxes. macOS always ships Apple SD Gothic
|
|
/// Neo and Windows Malgun Gothic, so there the test never skips.
|
|
#[test]
|
|
fn system_fallback_covers_hangul() {
|
|
const HANGUL: &str = "성가대 찬양곡 목록";
|
|
assert!(!theme::font_definitions().font_data.contains_key(theme::SYSTEM_HANGUL_FALLBACK));
|
|
let defs = theme::installed_font_definitions(theme::CjkPreference::Default);
|
|
let off = std::env::var_os("PDFCRAFT_SYSTEM_FONTS").is_some_and(|v| v == "0");
|
|
if !defs.font_data.contains_key(theme::SYSTEM_HANGUL_FALLBACK) && (off || cfg!(all(unix, not(target_os = "macos")))) {
|
|
eprintln!("skipping system_fallback_covers_hangul: no installed Korean fallback font (or PDFCRAFT_SYSTEM_FONTS=0)");
|
|
assert!(defs.families.values().all(|stack| !stack.iter().any(|n| n == theme::SYSTEM_HANGUL_FALLBACK)));
|
|
return;
|
|
}
|
|
for (family, stack) in &defs.families {
|
|
assert_eq!(stack.iter().filter(|n| *n == theme::SYSTEM_HANGUL_FALLBACK).count(), 1, "{family:?}: {stack:?}");
|
|
}
|
|
let mut fonts = Fonts::new(TextOptions::default(), defs);
|
|
for id in families() {
|
|
assert!(fonts.has_glyphs(&id, HANGUL), "{id:?} lacks {HANGUL}");
|
|
}
|
|
assert!(layout_widths(&mut fonts, HANGUL).iter().all(|w| w.is_finite() && *w > 0.0));
|
|
}
|