mirror of
https://github.com/valentderah/totk-pc-recomp.git
synced 2026-11-22 13:05:57 +00:00
Write GPU-rendered textures back when the CPU invalidates a pool range or waits for a fence
nvn_pool_invalidate was a weak no-op, so nvnMemoryPoolInvalidateMappedRange never wrote anything back. TotK invalidates its 260x260 R16 grass maps and 1x1 targets before reading them; they now go through guest_read. The grass system also renders a 128x128 RGBA8 cut map into a CPU-cached pool every frame and reads it with no invalidate. Without its texels the CPU saw no cut: swings left the grass standing, with no blades and no insects. After nvnSyncWait or nvnQueueFinish, dirty mirrored targets up to 64 KiB rendered in a submission up to the waited fence go back to storage (cpu_synced, vk_texture_write_back_small), unless the CPU rewrote it since. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3505258a06
commit
0beafeb066
10 files changed
+87
-6
No files matched your search
@@ -80,6 +80,11 @@ Check these classes before you re-investigate a symptom that looks like one of t
|
||||
writes them back first. Other CPU reads of GPU output are not covered yet. A write-back skips a texture whose
|
||||
storage the CPU rewrote after the GPU render (`vk_texture.c` `write_back`); writing it anyway put stale grass maps
|
||||
into the far terrain for a second (texture flicker on a hit).
|
||||
- The CPU reads GPU-rendered textures in CPU-cached pools: `nvnMemoryPoolInvalidateMappedRange` writes them back
|
||||
(`nvn_ext.c` `nvn_pool_invalidate`; TotK invalidates its 260x260 R16 grass maps and 1x1 targets), and once the CPU
|
||||
waits for a fence, targets up to 64 KiB rendered before it go back too (`vk_texture.c`
|
||||
`vk_texture_write_back_small`): the 128x128 cut map is read with no invalidate. Without it a cut left the grass
|
||||
standing, with no blades and no insects.
|
||||
- A one-shot draw (a target not rendered in the previous frame) waits for its shader and pipeline instead of being
|
||||
skipped: `vk_exec_draw.c` `prepare_draw`. Skipping left the cloud and fog volumes empty for the session.
|
||||
- Storage buffers bound by Ryujinx first-use order instead of the NVN c0 slot: `vk_exec_draw.c` `ssbo_slot`. It showed
|
||||
|
||||
Reference in new issue
Block a user