mirror of
https://github.com/valentderah/totk-pc-recomp.git
synced 2026-11-22 13:05:57 +00:00
Keep the virtual core gate on when totk.ini sets free_cores
Earlier settings menus wrote free_cores = 1 under the label "Virtual core gate", which promised the gate. Without it a thread that holds no virtual core reports its ideal core to GetCurrentProcessorNumber, so the game's job workers all report core 0 and run its per-core code at once. On 1.2.1 two of them add the same per-core NVN control memory, which retires the command handle the other just recorded, and its CallCommands fails at start (#212); on 1.4.3 the game corrupts a heap in main+0x82e00 or hangs at the title menu. A player with such a totk.ini crashed at every start and the menu no longer shows the row. free_cores is no longer a setting: only TOTK_FREE_CORES in the environment lifts the gate, and a free_cores value in totk.ini is logged as ignored. The kernel probe asks the kernel whether the gate is on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
b5286ef054
commit
dafc35fb35
7 files changed
+23
-16
No files matched your search
+1
-7
@@ -354,7 +354,6 @@ int probe_cfg(void) {
|
||||
cfg_load("cfg-probe-missing.ini");
|
||||
plat_setenv("TOTK_FPS60", NULL);
|
||||
plat_setenv("TOTK_MOUSE_SENS", NULL);
|
||||
plat_setenv("TOTK_FREE_CORES", NULL);
|
||||
CHECK(cfg_bool("TOTK_FPS60") == 1, "default: unset FPS60 is on");
|
||||
CHECK(EQ(cfg_value("TOTK_VK_PRESENT"), "mailbox") && cfg_int("TOTK_SPLIT_DRAWS") == 64, "default: text and integer");
|
||||
plat_setenv("TOTK_MOUSE_SENS", "2.5");
|
||||
@@ -364,12 +363,7 @@ int probe_cfg(void) {
|
||||
plat_setenv("TOTK_MOUSE_SENS", NULL);
|
||||
cfg_set("TOTK_MOUSE_SENS", "3");
|
||||
CHECK(cfg_double("TOTK_MOUSE_SENS") == 3.0 && cfg_int("TOTK_MOUSE_SENS") == 3, "a cfg_set value beats the default");
|
||||
CHECK(cfg_bool("TOTK_FREE_CORES") == 0, "free_cores unset: off");
|
||||
plat_setenv("TOTK_FREE_CORES", "0");
|
||||
CHECK(cfg_bool("TOTK_FREE_CORES") == 0, "free_cores 0 gives the same as unset");
|
||||
plat_setenv("TOTK_FREE_CORES", "1");
|
||||
CHECK(cfg_bool("TOTK_FREE_CORES") == 1, "free_cores 1: on");
|
||||
plat_setenv("TOTK_FREE_CORES", NULL);
|
||||
CHECK(cfg_meta("FREE_CORES") == NULL, "free_cores is no setting: only the environment lifts the core gate");
|
||||
cfg_load("cfg-probe-missing.ini");
|
||||
int listed = 0;
|
||||
for (int i = 0; cfg_meta_at(i); i++) {
|
||||
|
||||
Reference in new issue
Block a user