diff --git a/docs/agents/symptoms.md b/docs/agents/symptoms.md index 5c9fb005..5a96e8a8 100644 --- a/docs/agents/symptoms.md +++ b/docs/agents/symptoms.md @@ -26,6 +26,7 @@ GPU semantics behind the graphics rows: [maxwell.md](../maxwell.md). The method | no sun shadows, wrong lighting | unwritten vertex outputs read as zero instead of (0,0,0,1) | the shader's output map | | one flat ambient colour | a 1-layer 2D array sampled as 2D | the view type the shader expects | | upside-down text | lower-left window origin | origin mode in the log | +| with DLAA/DLSS on, large distant blocks behind the fog (the Depths) turn darker or lighter for a frame while the camera moves | DLSS created with AutoExposure estimated the exposure of the dark scene itself, and the estimate moved from frame to frame (fixed: `vk_dlaa.c` evaluate creates the feature without it) | a flat fogged patch in `capture.py` frames: one value without DLAA, jumps with it | | flicker or a texture swapped with a similar one | the newest texture picked at shared storage instead of the one with the matching view | texture lookup by id in the dump | | with DLAA on, dust and small particles in fog (shrines) vanish, smear or behave oddly; the fog looks processed | DLSS ran at the bloom, after the fog and the particles, which have no motion vectors or jitter of their own (fixed: `vk_dlaa.c` effects_point runs DLSS at the first pass into the light target after the lighting, and the effects go over its picture) | `dlaa_effects_after = 0` (Screen tab) brings the old point back; the count "before the effects" in the `dlaa:` log line against the frames anti-aliased | | with DLAA on, the picture flickers from frame to frame: a little outdoors; the whole scene in a fogged shrine with an ability's targeting view (Ultrahand) open, where the fog also goes back under DLSS | DLSS ran before some effects in one frame and after them in the next: their order changes from frame to frame (the yard's half-size effects pass is in some frames only; the ability highlight, drawn into the light target with a D16 depth of its own, comes before or after the fog layer), and a rule that waited for one of them or took any D16 pass for the lighting followed it (fixed: `vk_dlaa.c` effects_point knows the lighting by its depth and runs DLSS right after it) | the `dlaa:` log line: "before the effects" must equal the frames anti-aliased in the world; a log of the passes into the light target per frame | diff --git a/runtime/vk_dlaa.c b/runtime/vk_dlaa.c index 83e716bb..160c0322 100644 --- a/runtime/vk_dlaa.c +++ b/runtime/vk_dlaa.c @@ -1007,8 +1007,12 @@ static void evaluate(VkExec *ex, const VkExecTarget *dst) { p_setu(p, "OutWidth", ow); p_setu(p, "OutHeight", oh); p_seti(p, "PerfQualityValue", perf_quality(w, ow)); - // IsHDR | MVLowRes | AutoExposure: linear scene light, motion vectors at the render size, no exposure texture - p_seti(p, "DLSS.Feature.Create.Flags", (1 << 0) | (1 << 1) | (1 << 6)); + // IsHDR | MVLowRes: linear scene light, motion vectors at the render size, no exposure texture. Not AutoExposure + // (1 << 6): DLSS then estimated the exposure from each frame itself, and in the Depths, where the whole scene is + // dark, the estimate moved with the camera; distant blocks under uniform fog came out up to 0.7 levels (of 255) + // darker or brighter for a frame, where the game's own picture held one value (a 64x64 patch at 30.79 without + // DLAA read 30.09-30.79 frame to frame with AutoExposure and 30.4-30.7, steady, without it). + p_seti(p, "DLSS.Feature.Create.Flags", (1 << 0) | (1 << 1)); p_seti(p, "DLSS.Enable.Output.Subrects", 0); // The model per mode (NVSDK_NGX_DLSS_Hint_Render_Preset: 1 A ... 11 K, 12 L, 13 M), as NVIDIA recommends for // DLSS 4.5 (310.x): K (transformer) for DLAA, Quality and Balanced, M for Performance, L for Ultra Performance.