With mouse_mode = direct the mouse reached only the cameras the direct hooks cover. Autobuild's placement camera runs
none of them on games 1.4.3 and 1.2.1 and turns by the right stick, so the mouse moved nothing there. mouse_direct.c
now notes each camera step that runs a hook; after two steps without one the mouse acts as the right stick
(input.c mouse_camera), as with mouse_mode = stick, until a hook runs again. A script's MOUSE lines move that stick
too, also under TOTK_INPUT=none, so the path can be tested with scripted input.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A call adds no command memory since the previous commit. Control memory grew only at EndRecording, so a buffer queried
after calls and before its first EndRecording reported 0 command and 0 control bytes, which the game treats as an empty
buffer. The game's inline copy of the driver's call (1.4.3 main+0x2d33a4) writes one 24-byte control entry per segment
of the called handle; each called handle now adds that much. The NVN probe checks that a call-only buffer reports 0
command and some control memory.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The real driver puts a call in control memory, so a call adds no command memory; a copy adds what the copied commands
take on hardware. We added our record bytes of the inlined recording for both. On 1.4.3 the game queries recordings
that hold calls every frame (field save, 20 s: 15,700 such queries from six call sites, up to 14,604 bytes reported
where the driver rule gives 3,204); copies were not seen. Each recording now keeps its hardware size from EndRecording
(copy_prefix.hw), and memory added while recording keeps that size whole. Same accounting as MacNativeGames 6909dbb7,
which measured 40 bytes on the original driver where their port reported 88 and traced a renderer heap crash near
Zora's Domain to the larger sizes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
input_rumble used to call SDL_RumbleGamepad under the input lock; on a Bluetooth pad the write can take tens of milliseconds and stalled SendVibrationValue and every other user of the lock. It now stores the newest request and wakes a rumble worker, which sends only the latest one. The worker takes its own handle on the open pad (SDL_OpenGamepad of its id) under the lock and writes without it, so closing the pad meanwhile cannot free it under the write. A pad going away drops the pending request, and exit sends a zero request. TOTK_TEST_PAD_RUMBLE_MS makes the test gamepad rumble with a slow write. Idea from Savage Wind Recomp commit a8ad674 (issue #730).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The default output_res keeps the display's shape only while that shape has the
prompts' folder (cfg.c shape_keeps_prompts). After a switch to PlayStation
prompts on a 21:9 display the default was 1920x1080, so the start and the menu
asked only for the 16:9 folder and the game stayed 16:9. cfg_screen_size gives
the display's size while the player set no output_res.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the game resolution, the HUD width, the button prompts or the pad layout need a folder the install lacks (an
older setup, a failed setup step, a new display), totk.exe starts the setup's generator for it in the background
with the tools build-cache/rebuild.txt names, once per folder and process: at start for the settings in effect
(the resolution output_res asks for, also when the missing layout made this start 16:9), and from the settings
menu once a changed choice has stayed for 1.5 seconds or the menu closes. A missing 16:9 prompts folder is made too,
the PC prompts from totk.ini's bindings. The notes under Game resolution and Button prompts say the files are being
made and are used at the next start; when the tools did not start they say so and Try again starts them again.
The Prepare button is gone. Source builds without rebuild.txt and TOTK_ROMFS_PATCHES keep the old behaviour.
romfs_shape_missing and romfs_shape_prepare become romfs_folders_missing (a mask of the missing folders) and
romfs_folders_prepare; --probe-cfg and tests/romfs_shapes_check.py check the new decisions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prepare_draw sets ex->volume_bias where the draw's dynamic state changes, so record_fixed reads a flag instead of
checking the pipeline state on every draw. A census of the matching draws in the field, the town and rain found two more
states with the same blend and depth signature, both tested GREATER: the volume's back faces into the same channel and
another shader's front faces into red. GREATER's equal case fails, and the bias toward passing turned the game's tie
the other way for them; they are now left as the game sets them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prompts = playstation shows the face buttons as circle, cross, triangle and square, L1 R1 L2 R2, Options and Share.
The setup writes romfs-patches-playstation (pad_layout = nintendo) and romfs-patches-playstation-xbox (xbox, auto) on
every install, next to the Xbox folders, and the Shapes step and the settings menu make their shaped folders like the
other styles. playstation-xbox lays the action prompt's diamond out as xbox-label does, cross at the bottom.
Rebased onto dev from pull request #741 by fabiomode2: the shaped folders, hud_width, the Xbox diamond and the
keyboard prompts' text glyphs of dev are kept, and cfg.c's shape default uses input_prompts_folder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1. scan_pads took a controller Steam hid when the virtual pad was not up yet and kept it for the session, so Steam's
remapping was lost. While the open pad is a hidden one, pad_physical looks again every RESCAN_MS and scan_pads
moves the buttons to the virtual pad; the hidden controller stays open as motion_extra, so motion goes on with
the same bias and orientation.
2. pad_identity marked " (under Steam)" only on motion_extra; a hidden controller that became the pad lost the mark
and could take the bias calibrated with Steam closed. The mark now follows steam_hidden_id.
3. After pull request #1024: sensors_ready logs SDL_GetError when the pad has both sensors but enabling them failed,
instead of "has no gyro and accelerometer".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A game Steam starts gets SDL_GAMECONTROLLER_IGNORE_DEVICES with the controllers Steam reads itself and sees Steam's
virtual gamepad, which has no motion sensors. input.c steam_reveal keeps that list and clears the hint before
SDL_Init (only with motion on); scan_pads still takes the virtual pad for buttons and sticks, so Steam's remapping
holds, and motion_source opens the hidden controller for its gyro and accelerometer only. A bias belongs to the pad
as Steam presents it: " (Steam Input)" or " (under Steam)" in gyro_bias_pad. docs/controls.md, "Steam Input and
motion", says the Steam layout must bind the gyro to something or Steam zeroes it on the Steam Controller.
The patch as posted against 6151ac4, with sensors_ready merged with #1274's restart. Tested by the author on Linux
(Steam Controller) and the Steam Deck; not on Windows.
Co-authored-by: St5sz2Jk <St5sz2Jk@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The calibration removes the bias measured once; a bias that moves as the controller warms up, or a controller never
calibrated, still turns the aim slowly. motion_fusion.c drift_track learns it from 256 ms windows in which the gyro
stays within 0.04 rad/s and the acceleration within 0.03 G peak to peak, after half a second of rest, with a time
constant of 0.25 s until the estimate settles and 30 s after. The estimate sits on top of the calibrated bias and is
cleared with a new controller, a new or loaded calibration and a change of gyro_calibration. New setting
gyro_auto_bias (live, default 1).
Taken from #380: the rest window by peak to peak, the two time constants, the per-axis limit. Left out: the
0.006 rad/s dead zone, which ate slow aiming; the one global state shared by every fusion instance; the reset at
every StartSixAxisSensor; the 0.5 G acceleration gate, which let a controller in motion count as still. The first
estimate is limited to 0.1 rad/s from zero instead of 0.15; a larger bias is the calibration's job.
Also: a sample without a reading at a restart (#1274) no longer returns before the calibration's log and save.
--probe-services checks the drift with the switch off and on, after a calibration whose bias then moved, a slow
aim in the hand, and the levelling of #1274 with a bias on every axis.
Co-authored-by: airquark <97342227+airquark@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It acts only with sync_ahead in effect and is on by default there, so a player who turns on sync_ahead gets it; 0 and check stay for comparing. docs/settings.md keeps the row.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new line is written for wb_eager 0, 1 and check alike, so the stall wb_eager removes can be compared between the settings. It costs a clock read only on the blocking path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>