mirror of
https://github.com/valentderah/totk-pc-recomp.git
synced 2026-11-22 13:05:57 +00:00
- BFE / BFI (patch 0012): a field past bit 31 is cut there, one that starts past it extracts 0 (signed: bit 31 repeated) and inserts nothing, as PTX bfe / bfi. Clamped only where the field is not a constant inside the word. 1.4.3's Depths terrain vertex shaders (42 variants, 134 extracts) compute the position as ((2y + x) * 8) & 0xff, up to 248; AMD's bitfield instructions take it modulo 32. UltraTears saw the Depths walls and ground missing on RADV (Steam Deck, RX 570). - SHF by 0 (patch 0013) gives the unshifted word instead of shifting the other one by 32. Every register SHF of 1.4.3 pairs its word with 0, so 1.4.3 results do not change. - Function-local variables start at 0 (patch 0014): a register read on a path that never wrote it is no longer an undefined value Mesa may fold. All 12,454 1.4.3 shaders translate and pass spirv-val. RX 9070, Depths save: the same picture before and after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
19 lines
1.2 KiB
Diff
19 lines
1.2 KiB
Diff
--- a/src/Ryujinx.Graphics.Shader/CodeGen/Spirv/Declarations.cs
|
|
+++ b/src/Ryujinx.Graphics.Shader/CodeGen/Spirv/Declarations.cs
|
|
@@ -33,8 +33,13 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Spirv
|
|
{
|
|
foreach (AstOperand local in function.Locals)
|
|
{
|
|
- SpvInstruction localPointerType = context.TypePointer(StorageClass.Function, context.GetType(local.VarType));
|
|
- SpvInstruction spvLocal = context.Variable(localPointerType, StorageClass.Function);
|
|
+ SpvInstruction localType = context.GetType(local.VarType);
|
|
+ SpvInstruction localPointerType = context.TypePointer(StorageClass.Function, localType);
|
|
+
|
|
+ // TOTK: a register read on a path that did not write it reads 0. Without an initializer the load is
|
|
+ // undefined, and a compiler that folds undefined values (Mesa's, on the Steam Deck) may compute anything
|
|
+ // from it.
|
|
+ SpvInstruction spvLocal = context.Variable(localPointerType, StorageClass.Function, context.ConstantNull(localType));
|
|
|
|
context.AddLocalVariable(spvLocal);
|
|
context.DeclareLocal(local, spvLocal);
|