mirror of
https://github.com/storytold/wordcraft.git
synced 2026-11-11 16:51:21 +00:00
8548b33be1
* #5124: the window moves by its title bar behind a modal dialog On macOS WordCraft draws its own title bar, and since modal dialogs (#3859, #4076) the dialog's backdrop covers it, so the window couldn't be dragged while a dialog was open. Word for Mac lets you drag the document window by its title bar behind its Font dialog (and beeps on the click). - The title bar (and the Backstage's top band on macOS) notes the part that drags the window each frame. When the modal backdrop's drag starts there, it moves the window; the press still shakes the dialog, as Word beeps. - Only the backdrop's own drag counts, so a drag on the dialog, its tabs or its popups, where it reaches over the title bar, moves only the dialog. Tested by the developer on a Mac. Fixes #5124. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * #5124: only the macOS title bar moves the window behind a dialog Review (CodeRabbit): - Elsewhere the system's title bar already moves the window; WordCraft's own bar under it now doesn't, behind a modal dialog either, so nothing changes on Linux and Windows. - A drag from just inside the dialog's edge, where it reaches over the title bar, moves only the dialog, as the nudge already tells it apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * #5124: the window moves by its title bar behind Colors too; modal_open tests Colors is an egui Modal, not a window with the backdrop of block_behind, so a drag on the macOS title bar did nothing behind it. It now shares the check with the other modal windows. The new tests pin modal_open with nothing open, a modeless dialog, a modal dialog, the file browser and Colors, and that the title bar moves the window in each of those while the dialog stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * #5124: the modal drag test covers the top of File's side menu On macOS File's side menu covers the title bar, and its top band moves the window. The test now drags there too, so losing the band's note_title_drag call fails it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>