Compare commits

..
11 changed files with 30 additions and 124 deletions

No files matched your search

@@ -1,7 +0,0 @@
---
area: manager
type: fixed
audience: admins
title: Graceful server shutdowns no longer trigger crash recovery
---
Automatic crash recovery requires a confirmed abnormal exit. Normal shutdowns and scheduled restarts are not counted as crashes.
-7
View File
@@ -1,7 +0,0 @@
---
area: manager
type: added
audience: admins
title: Configure the visual day and night cycle from Modules
---
Modules now offers TimeIsTime clock settings when supported by the installed server.
-7
View File
@@ -1,7 +0,0 @@
---
area: manager
type: added
audience: admins
title: Select parallel or global scaling and remove item class requirements
---
The scaling settings now offer the parallel and global progression modes and a switch for class-restricted equipment, including tier sets.
+7
View File
@@ -0,0 +1,7 @@
---
area: bots
type: fixed
audience: admins
title: Disabling custom races for SQUID bots now excludes all nonstandard races
---
The standard-races preset keeps only the ten original playable races. High elves, worgen and other custom race IDs are excluded, and the displayed setting reads complete race IDs rather than matching number substrings.
+20 -2
View File
@@ -55,7 +55,7 @@ pub const RACE_MPQS: &[&str] = &[
];
pub const EXCLUDED_BOT_RACES_RECOMMENDED: &str =
"19,27,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128";
"9,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128";
pub const EXCLUDED_BOT_RACES_EXPERIMENTAL: &str =
"16,19,27,32,50,52,53,65,66,67,68,69,70,71,72,74,77,80,81";
@@ -99,7 +99,8 @@ pub fn is_bot_custom_races_allowed(root: &Path) -> Option<bool> {
if let Ok(conf) = crate::config::parser::ConfFile::parse_bytes(&bytes) {
if let Some(val) = conf.get("AiPlayerbot.ExcludedBotRaces") {
let clean = val.trim().trim_matches(['"', '\'']);
return Some(!clean.contains("33") && !clean.contains("128"));
let excluded: std::collections::BTreeSet<u32> = clean.split(',').filter_map(|race| race.trim().parse().ok()).collect();
return Some((1..=128).filter(|race| ![1, 2, 3, 4, 5, 6, 7, 8, 10, 11].contains(race)).any(|race| !excluded.contains(&race)));
}
}
}
@@ -617,4 +618,21 @@ mod tests {
assert!(client_path.join("dinput8.dll").is_file());
assert!(!client_path.join("dinput8.dll.disabled").is_file());
}
#[test]
fn disabling_bot_custom_races_excludes_every_nonstandard_race() {
let temp = tempfile::tempdir().unwrap();
let conf = temp.path().join("Core/configs/modules/playerbots.conf");
fs::create_dir_all(conf.parent().unwrap()).unwrap();
fs::write(&conf, "AiPlayerbot.ExcludedBotRaces = \"\"\n").unwrap();
sync_bot_races_config(temp.path(), false).unwrap();
assert_eq!(is_bot_custom_races_allowed(temp.path()), Some(false));
let parsed = crate::config::parser::ConfFile::parse_bytes(&fs::read(conf).unwrap()).unwrap();
let value = parsed.get("AiPlayerbot.ExcludedBotRaces").unwrap().trim_matches('"');
let excluded: Vec<u32> = value.split(',').map(|race| race.parse().unwrap()).collect();
for race in 1..=128 {
assert_eq!(excluded.contains(&race), ![1, 2, 3, 4, 5, 6, 7, 8, 10, 11].contains(&race), "race {race}");
}
}
}
-32
View File
@@ -341,20 +341,6 @@ fn save_settings_in(cat: &[Entry], root: &Path, meta: &Path, id: &str, changes:
for (key, value) in changes {
let value = value.trim();
if let Some(field) = fields.get(key) { crate::squid::validate(field, value)?; }
if id == "time-is-time" {
let bounds = match key.as_str() {
"TimeIsTime.SpeedRate" => Some((0.01, 60.0)),
"TimeIsTime.HourOffset" => Some((-24.0, 24.0)),
"TimeIsTime.TimeStart" => Some((0.0, 2147483647.0)),
_ => None,
};
if let Some((min, max)) = bounds {
let number = value.parse::<f64>().map_err(|_| Error::Invalid(format!("{key} must be a number.")))?;
if !number.is_finite() || number < min || number > max || (key == "TimeIsTime.TimeStart" && number.fract() != 0.0) {
return Err(Error::Invalid(format!("{key} must be between {min} and {max}.")));
}
}
}
if e.switchable && key == &e.enable_key {
return Err(Error::Invalid("Use the module switch to turn this module on or off.".into()));
}
@@ -411,24 +397,6 @@ fn save_settings_in(cat: &[Entry], root: &Path, meta: &Path, id: &str, changes:
mod tests {
use super::*;
#[test]
fn time_settings_are_validated_before_writing() {
let d = tempfile::tempdir().unwrap();
let root = d.path();
fs::create_dir_all(dir(root)).unwrap();
fs::write(dir(root).join("mod-time_is_time.conf.dist"), "TimeIsTime.Enable = 0\nTimeIsTime.SpeedRate = 1\nTimeIsTime.HourOffset = 0\nTimeIsTime.TimeStart = 0\n").unwrap();
let cat = catalog();
for (key, value) in [("TimeIsTime.SpeedRate", "NaN"), ("TimeIsTime.SpeedRate", "0"),
("TimeIsTime.HourOffset", "25"), ("TimeIsTime.TimeStart", "1.5")] {
assert!(save_settings_in(&cat, root, root, "time-is-time", &BTreeMap::from([
(key.into(), value.into())
])).is_err());
}
assert!(save_settings_in(&cat, root, root, "time-is-time", &BTreeMap::from([
("TimeIsTime.SpeedRate".into(), "60".into())
])).is_ok());
}
fn test_catalog() -> Vec<Entry> {
let one = |id: &str, name: &str, conf: &str, key: &str| Entry {
id: id.into(),
+1 -40
View File
@@ -68,24 +68,6 @@ pub fn read_state_record(root: &Path, name: &str) -> Option<ProcessIdentity> {
fsx::read_json(&root.join(".state").join(format!("{name}.json"))).ok()
}
#[derive(Deserialize)]
struct ProcessExit {
process: ProcessIdentity,
exit_code: i64,
}
fn exited_state(root: &Path, name: &str, expected: &[String]) -> ServiceState {
let exit: Option<ProcessExit> = fsx::read_json(&root.join(".state").join(format!("{name}-exit.json"))).ok();
let record = read_state_record(root, name);
match (exit, record) {
(Some(exit), Some(record))
if exit.process.same_as(&record)
&& expected.iter().any(|exe| record.exe.eq_ignore_ascii_case(exe))
&& exit.exit_code != 0 && exit.exit_code != 2 => ServiceState::Crashed,
_ => ServiceState::Stopped,
}
}
#[cfg(windows)]
mod sys {
use super::ProcessIdentity;
@@ -322,7 +304,7 @@ fn service_with(root: &Path, name: &'static str, exe: PathBuf, alternatives: &[P
(None, Some(o)) => {
(ServiceState::Stopped, false, Some(PortConflict { port, pid: o, exe: identity(o).map(|i| i.exe) }))
}
(None, None) => (exited_state(root, name, &expected), false, None),
(None, None) => (ServiceState::Stopped, false, None),
};
ServiceStatus {
name,
@@ -418,25 +400,4 @@ mod tests {
assert_eq!(o.world.state, ServiceState::Stopped);
assert!(o.world.pid.is_none());
}
#[test]
fn only_matching_abnormal_exits_are_crashes() {
let dir = tempfile::tempdir().unwrap();
let state = dir.path().join(".state");
std::fs::create_dir_all(&state).unwrap();
let record = ProcessIdentity { pid: 42, created: 123, exe: "C:\\server\\worldserver.exe".into() };
let expected = vec![record.exe.clone()];
std::fs::write(state.join("world.json"), serde_json::to_vec(&record).unwrap()).unwrap();
for (code, want) in [(0i64, ServiceState::Stopped), (2, ServiceState::Stopped), (1, ServiceState::Crashed),
(3221225477, ServiceState::Crashed)] {
std::fs::write(state.join("world-exit.json"), serde_json::to_vec(&serde_json::json!({
"process": record, "exit_code": code
})).unwrap()).unwrap();
assert_eq!(exited_state(dir.path(), "world", &expected), want);
}
let newer = ProcessIdentity { created: 124, ..record };
std::fs::write(state.join("world.json"), serde_json::to_vec(&newer).unwrap()).unwrap();
assert_eq!(exited_state(dir.path(), "world", &expected), ServiceState::Stopped);
assert_eq!(exited_state(dir.path(), "world", &["C:\\other.exe".into()]), ServiceState::Stopped);
}
}
-18
View File
@@ -1,24 +1,6 @@
{
"schema": 1,
"modules": [
{
"id": "time-is-time",
"name": "TimeIsTime",
"description": {
"en": "Adjust the visual day and night cycle without changing server timers.",
"ru": "Настройка визуального цикла дня и ночи без изменения серверных таймеров.",
"de": "Passt den sichtbaren Tag-Nacht-Zyklus an, ohne Serverzeiten zu ändern.",
"fr": "Ajuste le cycle visuel jour-nuit sans modifier les minuteries du serveur.",
"es": "Ajusta el ciclo visual día-noche sin cambiar los temporizadores del servidor."
},
"repo": "https://github.com/dunjeon/mod-TimeIsTime",
"conf": "mod-time_is_time.conf",
"enable_key": "TimeIsTime.Enable",
"switchable": true,
"default_on": false,
"status": "beta",
"icon": "clock"
},
{
"id": "companions",
"name": "CoA Companions",
+1 -8
View File
@@ -14,10 +14,6 @@ const text = (values: string[], locale: Locale) => values[locales.indexOf(locale
type Entry = { key: string; type: string; title: string[]; description: string[]; min?: number; max?: number; advanced?: boolean; options?: { value: string; label: string[] }[] };
export const moduleSettingDefinitions: Entry[] = [];
const fields = moduleSettingDefinitions;
add("TimeIsTime.Announce", "bool", ["Announce on login", "Сообщение при входе"], ["Show a module notice when a character logs in.", "Показывать сообщение о модуле при входе персонажа."]);
add("TimeIsTime.SpeedRate", "float", ["Day/night speed", "Скорость смены дня и ночи"], ["1 follows real time; 60 gives one game day every 24 minutes. Changes only the client visual clock.", "1 — реальное время; 60 — игровые сутки за 24 минуты. Меняет только визуальное время клиента."], { min: 0.01, max: 60 });
add("TimeIsTime.HourOffset", "float", ["Hour offset", "Смещение часов"], ["Offset applied to the visual client clock, in hours.", "Смещение визуальных часов клиента в часах."], { min: -24, max: 24 });
add("TimeIsTime.TimeStart", "int", ["Starting time", "Начальное время"], ["Unix timestamp used at every login; 0 uses the server clock.", "Unix-время при каждом входе; 0 использует часы сервера."], { min: 0, max: 2147483647 });
function add(key: string, type: string, title: string[], description: string[], extra: Partial<Entry> = {}) {
fields.push({ key, type, title, description, ...extra });
}
@@ -73,11 +69,8 @@ add(scaling + "LFG.DefaultChallengeSize", "int", ["Challenge group size", "Ра
add(scaling + "GroupScaling.LockOnEncounterStart", "bool", ["Lock scaling during combat", "Фиксировать скейлинг на время боя", "Skalierung im Kampf sperren", "Figer l’adaptation en combat", "Fijar ajuste durante combate", "战斗期间锁定缩放"], ["Joining or leaving during a boss fight does not change its scaling.", "Вход и выход игроков во время боя с боссом не меняют скейлинг.", "Beitreten oder Verlassen während eines Bosskampfs ändert die Skalierung nicht.", "Les arrivées et départs pendant un boss ne changent pas l’adaptation.", "Entrar o salir durante un jefe no cambia el ajuste.", "首领战期间玩家进出不会改变缩放。"], { advanced: true });
add(scaling + "Progression.Mode", "enum", ["Progression boundaries", "Границы прогрессии", "Fortschrittsgrenzen", "Limites de progression", "Límites de progresión", "进度边界"], ["Automatic boundaries follow the level cap and enabled expansions. Custom uses the levels below.", "Автоматические границы зависят от максимального уровня и включённых дополнений. Ручные используют уровни ниже.", "Automatisch folgt der Maximalstufe und Erweiterungen. Benutzerdefiniert nutzt die folgenden Stufen.", "Automatique suit le niveau maximal et les extensions. Manuel utilise les niveaux ci-dessous.", "Automático sigue el nivel máximo y las expansiones. Manual usa los niveles siguientes.", "自动边界按等级上限和启用的资料片计算,自定义使用以下等级。"], { advanced: true, options: [
{ value: "Auto", label: ["Automatic", "Автоматически", "Automatisch", "Automatique", "Automático", "自动"] },
{ value: "Parallel", label: ["Parallel: Classic 1–60, TBC/WotLK 45–60", "Параллельно: классика 1–60, БК/ЛК 45–60", "Parallel: Classic 1–60, TBC/WotLK 45–60", "Parallèle : Classic 1–60, TBC/WotLK 45–60", "Paralelo: Classic 1–60, TBC/WotLK 45–60", "并行:经典1–60,TBC/WotLK45–60"] },
{ value: "Global", label: ["Global: all eras 1–60", "Всё содержимое 1–60", "Alle Erweiterungen 1–60", "Toutes les extensions 1–60", "Todas las expansiones 1–60", "全部资料片1–60"] },
{ value: "Custom", label: ["Custom", "Вручную", "Benutzerdefiniert", "Manuel", "Manual", "自定义"] },
] });
add(scaling + "Items.RemoveClassRestrictions", "bool", ["Remove item class requirements", "Убрать классовые ограничения предметов"], ["Allow all classes to equip class-restricted items, including tier sets. Requires a world server restart.", "Разрешает всем классам надевать предметы с классовыми ограничениями, включая комплекты T10. Требуется перезапуск игрового сервера."]);
for (const era of ["Classic", "Tbc"]) add(scaling + `Progression.${era}End`, "int", [`${era} last level`, `Последний уровень ${era}`, `${era}-Endstufe`, `Dernier niveau ${era}`, `Último nivel ${era}`, `${era} 最高等级`], ["Used in custom progression. 0 chooses automatically.", "Для ручной прогрессии. 0 — автоматически.", "Für benutzerdefinierten Fortschritt. 0 wählt automatisch.", "Pour la progression manuelle. 0 choisit automatiquement.", "Para progresión manual. 0 elige automáticamente.", "用于自定义进度,0为自动。"], { min: 0, max: 80, advanced: true });
add(scaling + "Debug", "bool", ["Detailed scaling logs", "Подробные логи скейлинга", "Ausführliche Skalierungsprotokolle", "Journaux détaillés", "Registros detallados", "详细缩放日志"], ["Log scaling calculations for troubleshooting.", "Записывает расчёты скейлинга для диагностики.", "Protokolliert Berechnungen zur Fehleranalyse.", "Enregistre les calculs pour le diagnostic.", "Registra cálculos para diagnóstico.", "记录缩放计算以排查问题。"], { advanced: true });
@@ -210,6 +203,6 @@ export function canonicalModuleValue(key: string, value: string): string {
const v = value.trim().replace(/^"|"$/g, "");
if (key === scaling + "SoloAssist.Mode") return ({ "0": "None", "1": "Light", "2": "Full", none: "None", light: "Light", full: "Full" } as Record<string, string>)[v.toLowerCase()] ?? v;
if (key === scaling + "LFG.DefaultMode") return ({ "0": "Matchmaking", "1": "BotFill", "2": "CurrentParty", matchmaking: "Matchmaking", botfill: "BotFill", currentparty: "CurrentParty" } as Record<string, string>)[v.toLowerCase()] ?? v;
if (key === scaling + "Progression.Mode") return ({ auto: "Auto", custom: "Custom", parallel: "Parallel", global: "Global" } as Record<string, string>)[v.toLowerCase()] ?? v;
if (key === scaling + "Progression.Mode") return v.toLowerCase() === "auto" ? "Auto" : v.toLowerCase() === "custom" ? "Custom" : v;
return v;
}
+1 -2
View File
@@ -1,6 +1,6 @@
import { Fragment, useCallback, useEffect, useRef, useState, type ComponentType, type ReactNode } from "react";
import { listen } from "@tauri-apps/api/event";
import { Bot, Clock, Flame, Gavel, Loader2, Plug, Puzzle, Scaling, Settings2, Snowflake, Sparkles, Swords, Users, type LucideProps } from "lucide-react";
import { Bot, Flame, Gavel, Loader2, Plug, Puzzle, Scaling, Settings2, Snowflake, Sparkles, Swords, Users, type LucideProps } from "lucide-react";
import { api, asUiError, type CustomRacesClientStatus, type CustomRacesProgress, type ModuleSetting, type ModuleView, type UiError } from "@/lib/api";
import { cn } from "@/lib/utils";
import { Button } from "@/components/ui/button";
@@ -21,7 +21,6 @@ function GithubMark(props: { className?: string }) {
/** Icon and colours of a module's square tile, by the name the catalog gives it. */
const TILES: Record<string, { icon: ComponentType<LucideProps>; from: string; to: string }> = {
clock: { icon: Clock, from: "from-amber-500", to: "to-indigo-700" },
bot: { icon: Bot, from: "from-emerald-500", to: "to-teal-700" },
scaling: { icon: Scaling, from: "from-violet-500", to: "to-indigo-700" },
plug: { icon: Plug, from: "from-amber-500", to: "to-orange-700" },
-1
View File
@@ -196,7 +196,6 @@ export function Overview({ server, companions = true, onForget, onOpenUpdates, o
if (alive.current) setPop(null);
if (
wasWorldRunningRef.current &&
s.observed.world.state === "crashed" &&
!userStoppedRef.current &&
actionRef.current === null
) {