mirror of
https://github.com/valentderah/totk-pc-recomp.git
synced 2026-11-19 20:25:57 +00:00
Merge pull request #246: Cache the thread id per thread on Linux (SchulzCode)
dev already caches the id; this keeps that and takes the PR's noinline, so a fiber resumed on another thread reads its own thread's slot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
commit
6e95e441e3
1 file changed
+4
-2
@@ -1181,8 +1181,10 @@ size_t plat_getenv(const char *name, char *out, size_t cap) {
|
||||
|
||||
// Cached per thread: plat_rmutex_lock asks on every acquire, hundreds of thousands of times a second in play, and
|
||||
// gettid is a full syscall on Linux (Windows reads GetCurrentThreadId from the TEB). A thread's id never changes, and
|
||||
// the runtime starts child processes with posix_spawn only, so no forked copy inherits a stale id.
|
||||
uint32_t plat_thread_id(void) {
|
||||
// the runtime starts child processes with posix_spawn only, so no forked copy inherits a stale id. noinline: a fiber
|
||||
// may resume on another thread (platform.h), and a caller that inlined this could keep the address of tid it computed
|
||||
// before a plat_fiber_switch; as a call it reads the slot of the thread it runs on.
|
||||
__attribute__((noinline)) uint32_t plat_thread_id(void) {
|
||||
static __thread uint32_t tid;
|
||||
if (!tid) tid = (uint32_t)syscall(SYS_gettid);
|
||||
return tid;
|
||||
|
||||
Reference in new issue
Block a user